You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Kevin Klues <kl...@gmail.com> on 2017/02/28 05:09:44 UTC

Review Request 57121: Renamed 'ContainerLogger::SubprocessInfo' to 'ContainerIO'.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57121/
-----------------------------------------------------------

Review request for mesos, Jie Yu and Joseph Wu.


Bugs: MESOS-7050
    https://issues.apache.org/jira/browse/MESOS-7050


Repository: mesos


Description
-------

Renamed 'ContainerLogger::SubprocessInfo' to 'ContainerIO'.


Diffs
-----

  include/mesos/slave/container_logger.hpp a3f619b79ca0188df9e231c600dfa396f39ab29a 
  src/slave/container_loggers/lib_logrotate.hpp e37d99cb268bb3286e312d2ebdbaf84d3fd4bf91 
  src/slave/container_loggers/lib_logrotate.cpp b257f48f819985e339a5a7fd8066ffa9f39df7a6 
  src/slave/container_loggers/sandbox.hpp 4ec090cbfc5834ead45ec39c3a646f491fe892cb 
  src/slave/container_loggers/sandbox.cpp b55e089877f205bab482ae4ebe5a2010aeebeb47 
  src/slave/containerizer/docker.cpp 7d801fb17565a5298e8e3c5b430e070e12473680 
  src/slave/containerizer/mesos/io/switchboard.hpp 5b1fa25d5f577ce3c232fdf5324c7f9c837a64ce 
  src/slave/containerizer/mesos/io/switchboard.cpp 820d53bc12b1bf6018132660e4b7c5eae8c1e2ee 
  src/tests/container_logger_tests.cpp 589d6a9df7ce964052355be41597ef11677ca03d 

Diff: https://reviews.apache.org/r/57121/diff/


Testing
-------


Thanks,

Kevin Klues

Re: Review Request 57121: Renamed 'ContainerLogger::SubprocessInfo' to 'ContainerIO'.

Posted by Kevin Klues <kl...@gmail.com>.

> On Feb. 28, 2017, 10:19 p.m., Jie Yu wrote:
> > include/mesos/slave/container_logger.hpp, line 58
> > <https://reviews.apache.org/r/57121/diff/1/?file=1650926#file1650926line58>
> >
> >     I would pull this to top level, rather than nested inside container logger as it'll be used by io switchboard as well.
> >     
> >     Probably put that in `include/mesos/slave/containerizer.hpp`

I think I'd rather do this as a follow-on patch to https://reviews.apache.org/r/56195. Otherwise we will have to compress all of these patches into 1 because the nee 'ContainerIO' class will conflict with the 'ContainerIO' protobuf definition (which we remove in 56195).

Sound good?


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57121/#review167143
-----------------------------------------------------------


On Feb. 28, 2017, 5:09 a.m., Kevin Klues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57121/
> -----------------------------------------------------------
> 
> (Updated Feb. 28, 2017, 5:09 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Joseph Wu.
> 
> 
> Bugs: MESOS-7050
>     https://issues.apache.org/jira/browse/MESOS-7050
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Renamed 'ContainerLogger::SubprocessInfo' to 'ContainerIO'.
> 
> 
> Diffs
> -----
> 
>   include/mesos/slave/container_logger.hpp a3f619b79ca0188df9e231c600dfa396f39ab29a 
>   src/slave/container_loggers/lib_logrotate.hpp e37d99cb268bb3286e312d2ebdbaf84d3fd4bf91 
>   src/slave/container_loggers/lib_logrotate.cpp b257f48f819985e339a5a7fd8066ffa9f39df7a6 
>   src/slave/container_loggers/sandbox.hpp 4ec090cbfc5834ead45ec39c3a646f491fe892cb 
>   src/slave/container_loggers/sandbox.cpp b55e089877f205bab482ae4ebe5a2010aeebeb47 
>   src/slave/containerizer/docker.cpp 7d801fb17565a5298e8e3c5b430e070e12473680 
>   src/slave/containerizer/mesos/io/switchboard.hpp 5b1fa25d5f577ce3c232fdf5324c7f9c837a64ce 
>   src/slave/containerizer/mesos/io/switchboard.cpp 820d53bc12b1bf6018132660e4b7c5eae8c1e2ee 
>   src/tests/container_logger_tests.cpp 589d6a9df7ce964052355be41597ef11677ca03d 
> 
> Diff: https://reviews.apache.org/r/57121/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Re: Review Request 57121: Renamed 'SubprocessInfo' to 'ContainerIO' in 'ContainerLogger'.

Posted by Jie Yu <yu...@gmail.com>.

> On Feb. 28, 2017, 10:19 p.m., Jie Yu wrote:
> > include/mesos/slave/container_logger.hpp, line 58
> > <https://reviews.apache.org/r/57121/diff/1/?file=1650926#file1650926line58>
> >
> >     I would pull this to top level, rather than nested inside container logger as it'll be used by io switchboard as well.
> >     
> >     Probably put that in `include/mesos/slave/containerizer.hpp`
> 
> Kevin Klues wrote:
>     I think I'd rather do this as a follow-on patch to https://reviews.apache.org/r/56195. Otherwise we will have to compress all of these patches into 1 because the nee 'ContainerIO' class will conflict with the 'ContainerIO' protobuf definition (which we remove in 56195).
>     
>     Sound good?

Sounds good!


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57121/#review167143
-----------------------------------------------------------


On March 1, 2017, 1:41 a.m., Kevin Klues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57121/
> -----------------------------------------------------------
> 
> (Updated March 1, 2017, 1:41 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Joseph Wu.
> 
> 
> Bugs: MESOS-7050
>     https://issues.apache.org/jira/browse/MESOS-7050
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Renamed 'SubprocessInfo' to 'ContainerIO' in 'ContainerLogger'.
> 
> 
> Diffs
> -----
> 
>   include/mesos/slave/container_logger.hpp a3f619b79ca0188df9e231c600dfa396f39ab29a 
>   src/slave/container_loggers/lib_logrotate.hpp e37d99cb268bb3286e312d2ebdbaf84d3fd4bf91 
>   src/slave/container_loggers/lib_logrotate.cpp b257f48f819985e339a5a7fd8066ffa9f39df7a6 
>   src/slave/container_loggers/sandbox.hpp 4ec090cbfc5834ead45ec39c3a646f491fe892cb 
>   src/slave/container_loggers/sandbox.cpp b55e089877f205bab482ae4ebe5a2010aeebeb47 
>   src/slave/containerizer/docker.cpp 7d801fb17565a5298e8e3c5b430e070e12473680 
>   src/slave/containerizer/mesos/io/switchboard.hpp 5b1fa25d5f577ce3c232fdf5324c7f9c837a64ce 
>   src/slave/containerizer/mesos/io/switchboard.cpp 820d53bc12b1bf6018132660e4b7c5eae8c1e2ee 
>   src/tests/container_logger_tests.cpp 589d6a9df7ce964052355be41597ef11677ca03d 
> 
> Diff: https://reviews.apache.org/r/57121/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Re: Review Request 57121: Renamed 'ContainerLogger::SubprocessInfo' to 'ContainerIO'.

Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57121/#review167143
-----------------------------------------------------------




include/mesos/slave/container_logger.hpp (line 58)
<https://reviews.apache.org/r/57121/#comment239331>

    I would pull this to top level, rather than nested inside container logger as it'll be used by io switchboard as well.
    
    Probably put that in `include/mesos/slave/containerizer.hpp`



include/mesos/slave/container_logger.hpp (line 130)
<https://reviews.apache.org/r/57121/#comment239306>

    No need for `ContainerIO` here?



include/mesos/slave/container_logger.hpp (line 135)
<https://reviews.apache.org/r/57121/#comment239307>

    Ditto.



include/mesos/slave/container_logger.hpp (line 166)
<https://reviews.apache.org/r/57121/#comment239308>

    the container


- Jie Yu


On Feb. 28, 2017, 5:09 a.m., Kevin Klues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57121/
> -----------------------------------------------------------
> 
> (Updated Feb. 28, 2017, 5:09 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Joseph Wu.
> 
> 
> Bugs: MESOS-7050
>     https://issues.apache.org/jira/browse/MESOS-7050
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Renamed 'ContainerLogger::SubprocessInfo' to 'ContainerIO'.
> 
> 
> Diffs
> -----
> 
>   include/mesos/slave/container_logger.hpp a3f619b79ca0188df9e231c600dfa396f39ab29a 
>   src/slave/container_loggers/lib_logrotate.hpp e37d99cb268bb3286e312d2ebdbaf84d3fd4bf91 
>   src/slave/container_loggers/lib_logrotate.cpp b257f48f819985e339a5a7fd8066ffa9f39df7a6 
>   src/slave/container_loggers/sandbox.hpp 4ec090cbfc5834ead45ec39c3a646f491fe892cb 
>   src/slave/container_loggers/sandbox.cpp b55e089877f205bab482ae4ebe5a2010aeebeb47 
>   src/slave/containerizer/docker.cpp 7d801fb17565a5298e8e3c5b430e070e12473680 
>   src/slave/containerizer/mesos/io/switchboard.hpp 5b1fa25d5f577ce3c232fdf5324c7f9c837a64ce 
>   src/slave/containerizer/mesos/io/switchboard.cpp 820d53bc12b1bf6018132660e4b7c5eae8c1e2ee 
>   src/tests/container_logger_tests.cpp 589d6a9df7ce964052355be41597ef11677ca03d 
> 
> Diff: https://reviews.apache.org/r/57121/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Re: Review Request 57121: Renamed 'SubprocessInfo' to 'ContainerIO' in 'ContainerLogger'.

Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57121/#review167197
-----------------------------------------------------------


Ship it!




Ship It!

- Jie Yu


On March 1, 2017, 1:41 a.m., Kevin Klues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57121/
> -----------------------------------------------------------
> 
> (Updated March 1, 2017, 1:41 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Joseph Wu.
> 
> 
> Bugs: MESOS-7050
>     https://issues.apache.org/jira/browse/MESOS-7050
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Renamed 'SubprocessInfo' to 'ContainerIO' in 'ContainerLogger'.
> 
> 
> Diffs
> -----
> 
>   include/mesos/slave/container_logger.hpp a3f619b79ca0188df9e231c600dfa396f39ab29a 
>   src/slave/container_loggers/lib_logrotate.hpp e37d99cb268bb3286e312d2ebdbaf84d3fd4bf91 
>   src/slave/container_loggers/lib_logrotate.cpp b257f48f819985e339a5a7fd8066ffa9f39df7a6 
>   src/slave/container_loggers/sandbox.hpp 4ec090cbfc5834ead45ec39c3a646f491fe892cb 
>   src/slave/container_loggers/sandbox.cpp b55e089877f205bab482ae4ebe5a2010aeebeb47 
>   src/slave/containerizer/docker.cpp 7d801fb17565a5298e8e3c5b430e070e12473680 
>   src/slave/containerizer/mesos/io/switchboard.hpp 5b1fa25d5f577ce3c232fdf5324c7f9c837a64ce 
>   src/slave/containerizer/mesos/io/switchboard.cpp 820d53bc12b1bf6018132660e4b7c5eae8c1e2ee 
>   src/tests/container_logger_tests.cpp 589d6a9df7ce964052355be41597ef11677ca03d 
> 
> Diff: https://reviews.apache.org/r/57121/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Re: Review Request 57121: Renamed 'SubprocessInfo' to 'ContainerIO' in 'ContainerLogger'.

Posted by Kevin Klues <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57121/
-----------------------------------------------------------

(Updated March 1, 2017, 1:41 a.m.)


Review request for mesos, Jie Yu and Joseph Wu.


Changes
-------

Updated based on @jie's comments.


Summary (updated)
-----------------

Renamed 'SubprocessInfo' to 'ContainerIO' in 'ContainerLogger'.


Bugs: MESOS-7050
    https://issues.apache.org/jira/browse/MESOS-7050


Repository: mesos


Description (updated)
-------

Renamed 'SubprocessInfo' to 'ContainerIO' in 'ContainerLogger'.


Diffs (updated)
-----

  include/mesos/slave/container_logger.hpp a3f619b79ca0188df9e231c600dfa396f39ab29a 
  src/slave/container_loggers/lib_logrotate.hpp e37d99cb268bb3286e312d2ebdbaf84d3fd4bf91 
  src/slave/container_loggers/lib_logrotate.cpp b257f48f819985e339a5a7fd8066ffa9f39df7a6 
  src/slave/container_loggers/sandbox.hpp 4ec090cbfc5834ead45ec39c3a646f491fe892cb 
  src/slave/container_loggers/sandbox.cpp b55e089877f205bab482ae4ebe5a2010aeebeb47 
  src/slave/containerizer/docker.cpp 7d801fb17565a5298e8e3c5b430e070e12473680 
  src/slave/containerizer/mesos/io/switchboard.hpp 5b1fa25d5f577ce3c232fdf5324c7f9c837a64ce 
  src/slave/containerizer/mesos/io/switchboard.cpp 820d53bc12b1bf6018132660e4b7c5eae8c1e2ee 
  src/tests/container_logger_tests.cpp 589d6a9df7ce964052355be41597ef11677ca03d 

Diff: https://reviews.apache.org/r/57121/diff/


Testing
-------


Thanks,

Kevin Klues