You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rukletsov <ru...@gmail.com> on 2017/02/02 09:57:11 UTC
Review Request 56211: Renamed health checker in command executor for
clarity.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56211/
-----------------------------------------------------------
Review request for mesos, Gast�n Kleiman and Vinod Kone.
Bugs: MESOS-6906
https://issues.apache.org/jira/browse/MESOS-6906
Repository: mesos
Description
-------
See summary.
Diffs
-----
src/launcher/executor.cpp 0c770bb18ae8bd8df85589b5262f457ab50574a9
Diff: https://reviews.apache.org/r/56211/diff/
Testing
-------
See https://reviews.apache.org/r/56218/
Thanks,
Alexander Rukletsov
Re: Review Request 56211: Renamed health checker in command executor
for clarity.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56211/#review167772
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Feb. 28, 2017, 3:54 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56211/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2017, 3:54 p.m.)
>
>
> Review request for mesos, Gast�n Kleiman and Vinod Kone.
>
>
> Bugs: MESOS-6906
> https://issues.apache.org/jira/browse/MESOS-6906
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Also validate internal invariants when health is updated.
>
>
> Diffs
> -----
>
> src/launcher/executor.cpp adcc50fb7df91b9f8dff0f583b61e0efcd6da378
>
>
> Diff: https://reviews.apache.org/r/56211/diff/4/
>
>
> Testing
> -------
>
> See https://reviews.apache.org/r/56213/
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 56211: Renamed health checker in command executor
for clarity.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56211/
-----------------------------------------------------------
(Updated March 15, 2017, 12:47 p.m.)
Review request for mesos, Gast�n Kleiman and Vinod Kone.
Changes
-------
Rebased. NNTR.
Bugs: MESOS-6906
https://issues.apache.org/jira/browse/MESOS-6906
Repository: mesos
Description
-------
Also validate internal invariants when health is updated.
Diffs (updated)
-----
src/launcher/executor.cpp adcc50fb7df91b9f8dff0f583b61e0efcd6da378
Diff: https://reviews.apache.org/r/56211/diff/7/
Changes: https://reviews.apache.org/r/56211/diff/6-7/
Testing
-------
See https://reviews.apache.org/r/56213/
Thanks,
Alexander Rukletsov
Re: Review Request 56211: Renamed health checker in command executor
for clarity.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56211/
-----------------------------------------------------------
(Updated March 14, 2017, 2:07 p.m.)
Review request for mesos, Gast�n Kleiman and Vinod Kone.
Bugs: MESOS-6906
https://issues.apache.org/jira/browse/MESOS-6906
Repository: mesos
Description
-------
Also validate internal invariants when health is updated.
Diffs (updated)
-----
src/launcher/executor.cpp adcc50fb7df91b9f8dff0f583b61e0efcd6da378
Diff: https://reviews.apache.org/r/56211/diff/6/
Changes: https://reviews.apache.org/r/56211/diff/5-6/
Testing
-------
See https://reviews.apache.org/r/56213/
Thanks,
Alexander Rukletsov
Re: Review Request 56211: Renamed health checker in command executor
for clarity.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56211/
-----------------------------------------------------------
(Updated March 7, 2017, 8:39 p.m.)
Review request for mesos, Gast�n Kleiman and Vinod Kone.
Bugs: MESOS-6906
https://issues.apache.org/jira/browse/MESOS-6906
Repository: mesos
Description
-------
Also validate internal invariants when health is updated.
Diffs (updated)
-----
src/launcher/executor.cpp adcc50fb7df91b9f8dff0f583b61e0efcd6da378
Diff: https://reviews.apache.org/r/56211/diff/5/
Changes: https://reviews.apache.org/r/56211/diff/4-5/
Testing
-------
See https://reviews.apache.org/r/56213/
Thanks,
Alexander Rukletsov
Re: Review Request 56211: Renamed health checker in command executor
for clarity.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56211/
-----------------------------------------------------------
(Updated Feb. 28, 2017, 3:54 p.m.)
Review request for mesos, Gast�n Kleiman and Vinod Kone.
Bugs: MESOS-6906
https://issues.apache.org/jira/browse/MESOS-6906
Repository: mesos
Description
-------
Also validate internal invariants when health is updated.
Diffs
-----
src/launcher/executor.cpp adcc50fb7df91b9f8dff0f583b61e0efcd6da378
Diff: https://reviews.apache.org/r/56211/diff/
Testing (updated)
-------
See https://reviews.apache.org/r/56213/
Thanks,
Alexander Rukletsov
Re: Review Request 56211: Renamed health checker in command executor
for clarity.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56211/
-----------------------------------------------------------
(Updated Feb. 28, 2017, 3:54 p.m.)
Review request for mesos, Gast�n Kleiman and Vinod Kone.
Bugs: MESOS-6906
https://issues.apache.org/jira/browse/MESOS-6906
Repository: mesos
Description (updated)
-------
Also validate internal invariants when health is updated.
Diffs (updated)
-----
src/launcher/executor.cpp adcc50fb7df91b9f8dff0f583b61e0efcd6da378
Diff: https://reviews.apache.org/r/56211/diff/
Testing
-------
See https://reviews.apache.org/r/56218/
Thanks,
Alexander Rukletsov
Re: Review Request 56211: Renamed health checker in command executor
for clarity.
Posted by Gastón Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56211/#review165018
-----------------------------------------------------------
Ship it!
Ship It!
- Gast�n Kleiman
On Feb. 8, 2017, 4:56 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56211/
> -----------------------------------------------------------
>
> (Updated Feb. 8, 2017, 4:56 p.m.)
>
>
> Review request for mesos, Gast�n Kleiman and Vinod Kone.
>
>
> Bugs: MESOS-6906
> https://issues.apache.org/jira/browse/MESOS-6906
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/launcher/executor.cpp d9417ce1d5b108f5292a66010eab80f11552a969
>
> Diff: https://reviews.apache.org/r/56211/diff/
>
>
> Testing
> -------
>
> See https://reviews.apache.org/r/56218/
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 56211: Renamed health checker in command executor
for clarity.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56211/
-----------------------------------------------------------
(Updated Feb. 8, 2017, 4:56 p.m.)
Review request for mesos, Gast�n Kleiman and Vinod Kone.
Bugs: MESOS-6906
https://issues.apache.org/jira/browse/MESOS-6906
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
src/launcher/executor.cpp d9417ce1d5b108f5292a66010eab80f11552a969
Diff: https://reviews.apache.org/r/56211/diff/
Testing
-------
See https://reviews.apache.org/r/56218/
Thanks,
Alexander Rukletsov
Re: Review Request 56211: Renamed health checker in command executor
for clarity.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56211/
-----------------------------------------------------------
(Updated Feb. 8, 2017, 3:16 p.m.)
Review request for mesos, Gast�n Kleiman and Vinod Kone.
Bugs: MESOS-6906
https://issues.apache.org/jira/browse/MESOS-6906
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
src/launcher/executor.cpp d9417ce1d5b108f5292a66010eab80f11552a969
Diff: https://reviews.apache.org/r/56211/diff/
Testing
-------
See https://reviews.apache.org/r/56218/
Thanks,
Alexander Rukletsov
Re: Review Request 56211: Renamed health checker in command executor
for clarity.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56211/#review164606
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Feb. 2, 2017, 9:57 a.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56211/
> -----------------------------------------------------------
>
> (Updated Feb. 2, 2017, 9:57 a.m.)
>
>
> Review request for mesos, Gast�n Kleiman and Vinod Kone.
>
>
> Bugs: MESOS-6906
> https://issues.apache.org/jira/browse/MESOS-6906
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/launcher/executor.cpp 0c770bb18ae8bd8df85589b5262f457ab50574a9
>
> Diff: https://reviews.apache.org/r/56211/diff/
>
>
> Testing
> -------
>
> See https://reviews.apache.org/r/56218/
>
>
> Thanks,
>
> Alexander Rukletsov
>
>