You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rojas <al...@mesosphere.io> on 2017/02/27 14:28:13 UTC
Review Request 57093: Clears timedout timers before marking the clock
as settle.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57093/
-----------------------------------------------------------
Review request for mesos, Benjamin Bannier, Benjamin Hindman, Benjamin Mahler, and Joris Van Remoortere.
Bugs: MESOS-6907
https://issues.apache.org/jira/browse/MESOS-6907
Repository: mesos
Description
-------
When using timers in tests, there was the possibility that
`clock::settle()` would return before the list containing
the timedout timers was destroyed. That behavior resulted
in race conditions in tests which expected objects stored
in timers to be destroyed after such timers timed out and
the clock had settled.
The issue described above was addressed by explicitly
clearing the list after the timer's callbacks were executed
but before `clock::settle` is set to `false`.
Diffs
-----
3rdparty/libprocess/src/clock.cpp 6116c82377b1c2f33c5f4bc14890d35f34cc973d
Diff: https://reviews.apache.org/r/57093/diff/
Testing
-------
`make check`
Full test tried in next patch.
Thanks,
Alexander Rojas
Re: Review Request 57093: Clears timedout timers before marking the
clock as settle.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57093/#review166995
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Mahler
On Feb. 27, 2017, 2:28 p.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57093/
> -----------------------------------------------------------
>
> (Updated Feb. 27, 2017, 2:28 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Benjamin Hindman, Benjamin Mahler, and Joris Van Remoortere.
>
>
> Bugs: MESOS-6907
> https://issues.apache.org/jira/browse/MESOS-6907
>
>
> Repository: mesos
>
>
> Description
> -------
>
> When using timers in tests, there was the possibility that
> `clock::settle()` would return before the list containing
> the timedout timers was destroyed. That behavior resulted
> in race conditions in tests which expected objects stored
> in timers to be destroyed after such timers timed out and
> the clock had settled.
>
> The issue described above was addressed by explicitly
> clearing the list after the timer's callbacks were executed
> but before `clock::settle` is set to `false`.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/clock.cpp 6116c82377b1c2f33c5f4bc14890d35f34cc973d
>
> Diff: https://reviews.apache.org/r/57093/diff/
>
>
> Testing
> -------
>
> `make check`
>
> Full test tried in next patch.
>
>
> Thanks,
>
> Alexander Rojas
>
>