You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jay Guo <gu...@gmail.com> on 2017/02/23 04:31:12 UTC
Re: Review Request 56837: Added agent capabilities to
HierarchicalAllocatorProcess.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56837/
-----------------------------------------------------------
(Updated Feb. 23, 2017, 12:31 p.m.)
Review request for mesos, Benjamin Bannier, Benjamin Mahler, Guangya Liu, and Michael Park.
Changes
-------
address bmahler's comments.
Summary (updated)
-----------------
Added agent capabilities to HierarchicalAllocatorProcess.
Bugs: MESOS-6940
https://issues.apache.org/jira/browse/MESOS-6940
Repository: mesos
Description (updated)
-------
Allocator should be aware of agent capabilities in order to make
correct/smarter decisions on resource allocations. The interface
`addSlave` is augmented to pass in agent capabilities and we store
them in HierarchicalAllocatorProcess. Tests are updated accordingly.
Diffs (updated)
-----
include/mesos/allocator/allocator.hpp 23413d1f9d76009c999b35d2bc98afc52c136404
src/master/allocator/mesos/allocator.hpp 38fbf16a0500fc9f6ce7a498a6af3d81d63fc215
src/master/allocator/mesos/hierarchical.hpp d33306745a7287b750cb4a5242c7527369d58d65
src/master/allocator/mesos/hierarchical.cpp eeb44fe89d4bfd26900b11833c1182157e5c7e5c
src/master/master.cpp 2ef836536784d5fda23c80dc2304239b176a8942
src/tests/allocator.hpp c741a985660e1540ad8e3a9c387d513247e56714
src/tests/api_tests.cpp 378612dd4d038fb4d65fba60a4be00d4950d0c02
src/tests/hierarchical_allocator_tests.cpp 5441fa9d1fad1ca7819038db49c6d88e40571e4a
src/tests/master_allocator_tests.cpp 25c67d32eec5fede78eb9fcbc1009eeff7da0dad
src/tests/master_quota_tests.cpp d15c7aacb85596cdee7cf59c0c179247ba624fe5
src/tests/persistent_volume_endpoints_tests.cpp ec8df33a3f0d4ad790d5cc753e1691c5517c39c0
src/tests/reservation_endpoints_tests.cpp 7432d752120b43560aa96cad8bf3981ee8102e67
src/tests/reservation_tests.cpp 309ce8b9acc9131110198c14c655427d7fe9d603
src/tests/slave_recovery_tests.cpp 0e295915fea0a7314e173857249bd8726eeccd76
Diff: https://reviews.apache.org/r/56837/diff/
Testing
-------
make check
Thanks,
Jay Guo
Re: Review Request 56837: Added agent capabilities to
HierarchicalAllocatorProcess.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56837/#review166944
-----------------------------------------------------------
Ship it!
include/mesos/allocator/allocator.hpp (line 179)
<https://reviews.apache.org/r/56837/#comment239035>
I believe it has to be written like so, no?
```
* @param capabilities Capabilities of the agent.
```
- Benjamin Mahler
On Feb. 24, 2017, 8:43 a.m., Jay Guo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56837/
> -----------------------------------------------------------
>
> (Updated Feb. 24, 2017, 8:43 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, Guangya Liu, and Michael Park.
>
>
> Bugs: MESOS-6940
> https://issues.apache.org/jira/browse/MESOS-6940
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Allocator should be aware of agent capabilities in order to make
> correct/smarter decisions on resource allocations. The interface
> `addSlave` is augmented to pass in agent capabilities and we store
> them in HierarchicalAllocatorProcess. Tests are updated accordingly.
>
>
> Diffs
> -----
>
> include/mesos/allocator/allocator.hpp 23413d1f9d76009c999b35d2bc98afc52c136404
> src/master/allocator/mesos/allocator.hpp 38fbf16a0500fc9f6ce7a498a6af3d81d63fc215
> src/master/allocator/mesos/hierarchical.hpp d33306745a7287b750cb4a5242c7527369d58d65
> src/master/allocator/mesos/hierarchical.cpp eeb44fe89d4bfd26900b11833c1182157e5c7e5c
> src/master/master.cpp 2ef836536784d5fda23c80dc2304239b176a8942
> src/tests/allocator.hpp c741a985660e1540ad8e3a9c387d513247e56714
> src/tests/api_tests.cpp 24f31ff133185a3224f9edaf8b8532d5630b34c2
> src/tests/hierarchical_allocator_tests.cpp 5441fa9d1fad1ca7819038db49c6d88e40571e4a
> src/tests/master_allocator_tests.cpp 25c67d32eec5fede78eb9fcbc1009eeff7da0dad
> src/tests/master_quota_tests.cpp d15c7aacb85596cdee7cf59c0c179247ba624fe5
> src/tests/persistent_volume_endpoints_tests.cpp ec8df33a3f0d4ad790d5cc753e1691c5517c39c0
> src/tests/reservation_endpoints_tests.cpp 7432d752120b43560aa96cad8bf3981ee8102e67
> src/tests/reservation_tests.cpp 309ce8b9acc9131110198c14c655427d7fe9d603
> src/tests/slave_recovery_tests.cpp 0e295915fea0a7314e173857249bd8726eeccd76
>
> Diff: https://reviews.apache.org/r/56837/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jay Guo
>
>
Re: Review Request 56837: Added agent capabilities to
HierarchicalAllocatorProcess.
Posted by Jay Guo <gu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56837/
-----------------------------------------------------------
(Updated Feb. 24, 2017, 4:43 p.m.)
Review request for mesos, Benjamin Bannier, Benjamin Mahler, Guangya Liu, and Michael Park.
Bugs: MESOS-6940
https://issues.apache.org/jira/browse/MESOS-6940
Repository: mesos
Description
-------
Allocator should be aware of agent capabilities in order to make
correct/smarter decisions on resource allocations. The interface
`addSlave` is augmented to pass in agent capabilities and we store
them in HierarchicalAllocatorProcess. Tests are updated accordingly.
Diffs (updated)
-----
include/mesos/allocator/allocator.hpp 23413d1f9d76009c999b35d2bc98afc52c136404
src/master/allocator/mesos/allocator.hpp 38fbf16a0500fc9f6ce7a498a6af3d81d63fc215
src/master/allocator/mesos/hierarchical.hpp d33306745a7287b750cb4a5242c7527369d58d65
src/master/allocator/mesos/hierarchical.cpp eeb44fe89d4bfd26900b11833c1182157e5c7e5c
src/master/master.cpp 2ef836536784d5fda23c80dc2304239b176a8942
src/tests/allocator.hpp c741a985660e1540ad8e3a9c387d513247e56714
src/tests/api_tests.cpp 24f31ff133185a3224f9edaf8b8532d5630b34c2
src/tests/hierarchical_allocator_tests.cpp 5441fa9d1fad1ca7819038db49c6d88e40571e4a
src/tests/master_allocator_tests.cpp 25c67d32eec5fede78eb9fcbc1009eeff7da0dad
src/tests/master_quota_tests.cpp d15c7aacb85596cdee7cf59c0c179247ba624fe5
src/tests/persistent_volume_endpoints_tests.cpp ec8df33a3f0d4ad790d5cc753e1691c5517c39c0
src/tests/reservation_endpoints_tests.cpp 7432d752120b43560aa96cad8bf3981ee8102e67
src/tests/reservation_tests.cpp 309ce8b9acc9131110198c14c655427d7fe9d603
src/tests/slave_recovery_tests.cpp 0e295915fea0a7314e173857249bd8726eeccd76
Diff: https://reviews.apache.org/r/56837/diff/
Testing
-------
make check
Thanks,
Jay Guo