You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Anand Mazumdar <an...@apache.org> on 2017/02/20 05:00:42 UTC
Review Request 56831: Minor fix to a comment.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56831/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Repository: mesos
Description
-------
Modified a comment now that the default executor can launch
multiple task groups.
Diffs
-----
include/mesos/mesos.proto 030e79c003f6560e9c0627db12fb1baba411151d
include/mesos/v1/mesos.proto 7f6f858a7d9387d202510730d400e490298e6574
Diff: https://reviews.apache.org/r/56831/diff/
Testing
-------
make check
Thanks,
Anand Mazumdar
Re: Review Request 56831: Minor fix to a comment + docs.
Posted by Anand Mazumdar <an...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56831/
-----------------------------------------------------------
(Updated Feb. 22, 2017, 6:16 p.m.)
Review request for mesos and Vinod Kone.
Changes
-------
Review comments
Summary (updated)
-----------------
Minor fix to a comment + docs.
Repository: mesos
Description (updated)
-------
Modified a comment now that the default executor can launch
multiple task groups. Also, updated the nested task groups
docs to reflect this.
Diffs (updated)
-----
docs/nested-container-and-task-group.md debf9f82622557aff915dd04ef06a50793f496b6
include/mesos/mesos.proto 030e79c003f6560e9c0627db12fb1baba411151d
include/mesos/v1/mesos.proto 7f6f858a7d9387d202510730d400e490298e6574
Diff: https://reviews.apache.org/r/56831/diff/
Testing
-------
make check
Thanks,
Anand Mazumdar
Re: Review Request 56831: Minor fix to a comment + docs.
Posted by Anand Mazumdar <an...@apache.org>.
> On Feb. 21, 2017, 8:42 p.m., Vinod Kone wrote:
> > include/mesos/mesos.proto, line 655
> > <https://reviews.apache.org/r/56831/diff/1/?file=1640430#file1640430line655>
> >
> > Can you also update the docs that say it only accepts a single executor? Also, worth calling out in 1.3 CHANGELOG (WIP).
Updated the nested task groups doc. Would update the CHANGELOG in a separate patch.
- Anand
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56831/#review166219
-----------------------------------------------------------
On Feb. 22, 2017, 6:16 p.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56831/
> -----------------------------------------------------------
>
> (Updated Feb. 22, 2017, 6:16 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Modified a comment now that the default executor can launch
> multiple task groups. Also, updated the nested task groups
> docs to reflect this.
>
>
> Diffs
> -----
>
> docs/nested-container-and-task-group.md debf9f82622557aff915dd04ef06a50793f496b6
> include/mesos/mesos.proto 030e79c003f6560e9c0627db12fb1baba411151d
> include/mesos/v1/mesos.proto 7f6f858a7d9387d202510730d400e490298e6574
>
> Diff: https://reviews.apache.org/r/56831/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 56831: Minor fix to a comment.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56831/#review166219
-----------------------------------------------------------
include/mesos/mesos.proto (line 655)
<https://reviews.apache.org/r/56831/#comment238114>
Can you also update the docs that say it only accepts a single executor? Also, worth calling out in 1.3 CHANGELOG (WIP).
- Vinod Kone
On Feb. 20, 2017, 5 a.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56831/
> -----------------------------------------------------------
>
> (Updated Feb. 20, 2017, 5 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Modified a comment now that the default executor can launch
> multiple task groups.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 030e79c003f6560e9c0627db12fb1baba411151d
> include/mesos/v1/mesos.proto 7f6f858a7d9387d202510730d400e490298e6574
>
> Diff: https://reviews.apache.org/r/56831/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>