You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Neil Conway <ne...@gmail.com> on 2017/02/08 03:40:16 UTC
Review Request 56427: Added another sorter test case.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56427/
-----------------------------------------------------------
Review request for mesos and Michael Park.
Repository: mesos
Description
-------
When two clients have the same share, the sorter uses the total number
of allocations made to each client as a tiebreaker.
Diffs
-----
src/tests/sorter_tests.cpp a57a4fa4dbf7a9184e29b5dca4f636fe65a77773
Diff: https://reviews.apache.org/r/56427/diff/
Testing
-------
`make check`
Thanks,
Neil Conway
Re: Review Request 56427: Added another sorter test case.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56427/#review164675
-----------------------------------------------------------
Patch looks great!
Reviews applied: [56245, 56246, 56247, 56248, 56249, 56250, 56251, 56349, 56350, 56351, 56352, 56427]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Feb. 8, 2017, 3:40 a.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56427/
> -----------------------------------------------------------
>
> (Updated Feb. 8, 2017, 3:40 a.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> When two clients have the same share, the sorter uses the total number
> of allocations made to each client as a tiebreaker.
>
>
> Diffs
> -----
>
> src/tests/sorter_tests.cpp a57a4fa4dbf7a9184e29b5dca4f636fe65a77773
>
> Diff: https://reviews.apache.org/r/56427/diff/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 56427: Added another sorter test case.
Posted by Neil Conway <ne...@gmail.com>.
> On Feb. 9, 2017, 12:46 a.m., Michael Park wrote:
> > What's the subsequent tie-breaker if the # of allocations is the same?
It's the client name (see `DRFComparator::operator()`). This test also covers that case (not super explicitly though).
- Neil
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56427/#review164819
-----------------------------------------------------------
On Feb. 8, 2017, 3:40 a.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56427/
> -----------------------------------------------------------
>
> (Updated Feb. 8, 2017, 3:40 a.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> When two clients have the same share, the sorter uses the total number
> of allocations made to each client as a tiebreaker.
>
>
> Diffs
> -----
>
> src/tests/sorter_tests.cpp a57a4fa4dbf7a9184e29b5dca4f636fe65a77773
>
> Diff: https://reviews.apache.org/r/56427/diff/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 56427: Added another sorter test case.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56427/#review164819
-----------------------------------------------------------
Ship it!
What's the subsequent tie-breaker if the # of allocations is the same?
- Michael Park
On Feb. 7, 2017, 7:40 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56427/
> -----------------------------------------------------------
>
> (Updated Feb. 7, 2017, 7:40 p.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> When two clients have the same share, the sorter uses the total number
> of allocations made to each client as a tiebreaker.
>
>
> Diffs
> -----
>
> src/tests/sorter_tests.cpp a57a4fa4dbf7a9184e29b5dca4f636fe65a77773
>
> Diff: https://reviews.apache.org/r/56427/diff/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 56427: Added another sorter test case.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56427/
-----------------------------------------------------------
(Updated Feb. 19, 2017, 1 a.m.)
Review request for mesos and Michael Park.
Repository: mesos
Description
-------
When two clients have the same share, the sorter uses the total number
of allocations made to each client as a tiebreaker.
Diffs
-----
src/tests/sorter_tests.cpp a57a4fa4dbf7a9184e29b5dca4f636fe65a77773
Diff: https://reviews.apache.org/r/56427/diff/
Testing
-------
`make check`
Thanks,
Neil Conway