You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by James Peach <jp...@apache.org> on 2017/02/08 23:51:39 UTC
Review Request 56472: Revert "Revert "Use the stout ELF parser to
collect rootfs files."".
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56472/
-----------------------------------------------------------
Review request for mesos, Jie Yu, Kevin Klues, and Jiang Yan Xu.
Bugs: MESOS-7060
https://issues.apache.org/jira/browse/MESOS-7060
Repository: mesos
Description
-------
This reverts commit 273aca1d2df1553df5fbf27c3e7479d5dc0f5dbb.
Diffs
-----
src/tests/containerizer/rootfs.hpp 9648638c1d4b1f1c49708e058e9b930c5ae32138
src/tests/containerizer/rootfs.cpp f11f126fa4f3130b6778bfe7e7d0f025a638f06e
Diff: https://reviews.apache.org/r/56472/diff/
Testing
-------
make check (Fedora, Ubuntu)
```
vagrant@vagrant-ubuntu-trusty-64:~/mesos/build/src$ sudo ./mesos-tests --gtest_filter=*IsolatorTest.ROOT_*
...
[==========] 64 tests from 10 test cases ran. (85512 ms total)
[ PASSED ] 64 tests.
```
Thanks,
James Peach
Re: Review Request 56472: Revert "Revert "Use the stout ELF parser to
collect rootfs files."".
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56472/
-----------------------------------------------------------
(Updated Feb. 9, 2017, 8:03 p.m.)
Review request for mesos, Jie Yu, Kevin Klues, and Jiang Yan Xu.
Bugs: MESOS-7060
https://issues.apache.org/jira/browse/MESOS-7060
Repository: mesos
Description
-------
This reverts commit 273aca1d2df1553df5fbf27c3e7479d5dc0f5dbb.
Diffs (updated)
-----
src/tests/containerizer/rootfs.hpp 9648638c1d4b1f1c49708e058e9b930c5ae32138
src/tests/containerizer/rootfs.cpp f11f126fa4f3130b6778bfe7e7d0f025a638f06e
Diff: https://reviews.apache.org/r/56472/diff/
Testing
-------
make check (Fedora, Ubuntu)
```
vagrant@vagrant-ubuntu-trusty-64:~/mesos/build/src$ sudo ./mesos-tests --gtest_filter=*IsolatorTest.ROOT_*
...
[==========] 64 tests from 10 test cases ran. (85512 ms total)
[ PASSED ] 64 tests.
```
Thanks,
James Peach
Re: Review Request 56472: Revert "Revert "Use the stout ELF parser to
collect rootfs files."".
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56472/
-----------------------------------------------------------
(Updated Feb. 9, 2017, 5:21 p.m.)
Review request for mesos, Jie Yu, Kevin Klues, and Jiang Yan Xu.
Bugs: MESOS-7060
https://issues.apache.org/jira/browse/MESOS-7060
Repository: mesos
Description
-------
This reverts commit 273aca1d2df1553df5fbf27c3e7479d5dc0f5dbb.
Diffs (updated)
-----
src/tests/containerizer/rootfs.hpp 9648638c1d4b1f1c49708e058e9b930c5ae32138
src/tests/containerizer/rootfs.cpp f11f126fa4f3130b6778bfe7e7d0f025a638f06e
Diff: https://reviews.apache.org/r/56472/diff/
Testing
-------
make check (Fedora, Ubuntu)
```
vagrant@vagrant-ubuntu-trusty-64:~/mesos/build/src$ sudo ./mesos-tests --gtest_filter=*IsolatorTest.ROOT_*
...
[==========] 64 tests from 10 test cases ran. (85512 ms total)
[ PASSED ] 64 tests.
```
Thanks,
James Peach
Re: Review Request 56472: Revert "Revert "Use the stout ELF parser to
collect rootfs files."".
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56472/#review164835
-----------------------------------------------------------
Patch looks great!
Reviews applied: [56465, 56466, 56472]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Feb. 8, 2017, 11:51 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56472/
> -----------------------------------------------------------
>
> (Updated Feb. 8, 2017, 11:51 p.m.)
>
>
> Review request for mesos, Jie Yu, Kevin Klues, and Jiang Yan Xu.
>
>
> Bugs: MESOS-7060
> https://issues.apache.org/jira/browse/MESOS-7060
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This reverts commit 273aca1d2df1553df5fbf27c3e7479d5dc0f5dbb.
>
>
> Diffs
> -----
>
> src/tests/containerizer/rootfs.hpp 9648638c1d4b1f1c49708e058e9b930c5ae32138
> src/tests/containerizer/rootfs.cpp f11f126fa4f3130b6778bfe7e7d0f025a638f06e
>
> Diff: https://reviews.apache.org/r/56472/diff/
>
>
> Testing
> -------
>
> make check (Fedora, Ubuntu)
>
> ```
> vagrant@vagrant-ubuntu-trusty-64:~/mesos/build/src$ sudo ./mesos-tests --gtest_filter=*IsolatorTest.ROOT_*
> ...
> [==========] 64 tests from 10 test cases ran. (85512 ms total)
> [ PASSED ] 64 tests.
> ```
>
>
> Thanks,
>
> James Peach
>
>