You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2017/02/07 16:43:34 UTC
Review Request 56391: Set AllocationInfo in some reservation-related
tests.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56391/
-----------------------------------------------------------
Review request for mesos, Benjamin Mahler, Jay Guo, and Guangya Liu.
Repository: mesos
Description
-------
In a later change we will take a 'Resource''s 'AllocationInfo' into
account. Update a number of tests related to resource validation to
set 'AllocationInfo' so continue to trigger the originally expected
errors.
Diffs
-----
src/tests/master_validation_tests.cpp 1f833aa8d6cacbd7bf502fb66c556e4e3d4f79e2
Diff: https://reviews.apache.org/r/56391/diff/
Testing
-------
make check (OS X)
Thanks,
Benjamin Bannier
Re: Review Request 56391: Set AllocationInfo in some
reservation-related tests.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56391/#review165054
-----------------------------------------------------------
src/tests/master_validation_tests.cpp (lines 252 - 256)
<https://reviews.apache.org/r/56391/#comment236896>
Can this just be:
```
reserve.mutable_resources()->CopyFrom(
allocatedResources(resource, resource.role()));
```
Ditto below.
- Benjamin Mahler
On Feb. 8, 2017, 11:41 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56391/
> -----------------------------------------------------------
>
> (Updated Feb. 8, 2017, 11:41 a.m.)
>
>
> Review request for mesos, Benjamin Mahler, Jay Guo, and Guangya Liu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> In a later change we will take a 'Resource''s 'AllocationInfo' into
> account. Update a number of tests related to resource validation to
> set 'AllocationInfo' so continue to trigger the originally expected
> errors.
>
>
> Diffs
> -----
>
> src/tests/master_validation_tests.cpp 51185031cb67e64cd69ec6ce1c8f722a0c349970
>
> Diff: https://reviews.apache.org/r/56391/diff/
>
>
> Testing
> -------
>
> make check (OS X)
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 56391: Set AllocationInfo in some
reservation-related tests.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56391/#review165202
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Mahler
On Feb. 10, 2017, 2:57 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56391/
> -----------------------------------------------------------
>
> (Updated Feb. 10, 2017, 2:57 p.m.)
>
>
> Review request for mesos, Benjamin Mahler, Jay Guo, and Guangya Liu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> In a later change we will take a 'Resource''s 'AllocationInfo' into
> account. Update a number of tests related to resource validation to
> set 'AllocationInfo' so continue to trigger the originally expected
> errors.
>
>
> Diffs
> -----
>
> src/tests/master_validation_tests.cpp 0c2649089d7fd29eb021ac75c71e6a74368577dc
>
> Diff: https://reviews.apache.org/r/56391/diff/
>
>
> Testing
> -------
>
> make check (OS X)
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 56391: Set AllocationInfo in some
reservation-related tests.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56391/
-----------------------------------------------------------
(Updated Feb. 10, 2017, 3:57 p.m.)
Review request for mesos, Benjamin Mahler, Jay Guo, and Guangya Liu.
Changes
-------
Implemented suggestion from bmahler.
Repository: mesos
Description
-------
In a later change we will take a 'Resource''s 'AllocationInfo' into
account. Update a number of tests related to resource validation to
set 'AllocationInfo' so continue to trigger the originally expected
errors.
Diffs (updated)
-----
src/tests/master_validation_tests.cpp 0c2649089d7fd29eb021ac75c71e6a74368577dc
Diff: https://reviews.apache.org/r/56391/diff/
Testing
-------
make check (OS X)
Thanks,
Benjamin Bannier
Re: Review Request 56391: Set AllocationInfo in some
reservation-related tests.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56391/
-----------------------------------------------------------
(Updated Feb. 8, 2017, 12:41 p.m.)
Review request for mesos, Benjamin Mahler, Jay Guo, and Guangya Liu.
Repository: mesos
Description
-------
In a later change we will take a 'Resource''s 'AllocationInfo' into
account. Update a number of tests related to resource validation to
set 'AllocationInfo' so continue to trigger the originally expected
errors.
Diffs (updated)
-----
src/tests/master_validation_tests.cpp 51185031cb67e64cd69ec6ce1c8f722a0c349970
Diff: https://reviews.apache.org/r/56391/diff/
Testing
-------
make check (OS X)
Thanks,
Benjamin Bannier