You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Ilya Pronin <ip...@twopensource.com> on 2017/02/21 15:42:06 UTC
Review Request 56889: Added setting volume mode and ownership in
LinuxFilesystemIsolator.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56889/
-----------------------------------------------------------
Review request for mesos.
Bugs: MESOS-6563
https://issues.apache.org/jira/browse/MESOS-6563
Repository: mesos
Description
-------
`LinuxFilesystemIsolator` now sets ownership and permissions of the newly created relative host path to match the absolute container path.
Diffs
-----
src/slave/containerizer/mesos/isolators/filesystem/linux.cpp ae0031d8d8d6dfe0334b605fbb85e83de88ab436
src/tests/containerizer/linux_filesystem_isolator_tests.cpp c27335731924509632ec96cc01a4b4415f108a30
Diff: https://reviews.apache.org/r/56889/diff/
Testing
-------
Added permissions and ownerchip check to `LinuxFilesystemIsolatorTest.ROOT_VolumeFromSandbox`. Ran `make check`.
Thanks,
Ilya Pronin
Re: Review Request 56889: Added setting volume mode and ownership in
LinuxFilesystemIsolator.
Posted by Stephan Erb <se...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56889/#review166337
-----------------------------------------------------------
Ship it!
Using this patch, I was able to adopt the `filesystem/linux` isolator as a drop-in replacement for `filesystem/shared`.
- Stephan Erb
On Feb. 22, 2017, 8:54 a.m., Ilya Pronin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56889/
> -----------------------------------------------------------
>
> (Updated Feb. 22, 2017, 8:54 a.m.)
>
>
> Review request for mesos and Gilbert Song.
>
>
> Bugs: MESOS-6563 and MESOS-7069
> https://issues.apache.org/jira/browse/MESOS-6563
> https://issues.apache.org/jira/browse/MESOS-7069
>
>
> Repository: mesos
>
>
> Description
> -------
>
> `LinuxFilesystemIsolator` now sets ownership and permissions of the newly created relative host path to match the absolute container path.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/filesystem/linux.cpp ae0031d8d8d6dfe0334b605fbb85e83de88ab436
> src/tests/containerizer/linux_filesystem_isolator_tests.cpp c27335731924509632ec96cc01a4b4415f108a30
>
> Diff: https://reviews.apache.org/r/56889/diff/
>
>
> Testing
> -------
>
> Added permissions and ownerchip check to `LinuxFilesystemIsolatorTest.ROOT_VolumeFromSandbox`. Ran `make check`.
>
>
> Thanks,
>
> Ilya Pronin
>
>
Re: Review Request 56889: Added setting volume mode and ownership in
LinuxFilesystemIsolator.
Posted by Ilya Pronin <ip...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56889/
-----------------------------------------------------------
(Updated Feb. 22, 2017, 8:54 a.m.)
Review request for mesos and Gilbert Song.
Bugs: MESOS-6563 and MESOS-7069
https://issues.apache.org/jira/browse/MESOS-6563
https://issues.apache.org/jira/browse/MESOS-7069
Repository: mesos
Description
-------
`LinuxFilesystemIsolator` now sets ownership and permissions of the newly created relative host path to match the absolute container path.
Diffs
-----
src/slave/containerizer/mesos/isolators/filesystem/linux.cpp ae0031d8d8d6dfe0334b605fbb85e83de88ab436
src/tests/containerizer/linux_filesystem_isolator_tests.cpp c27335731924509632ec96cc01a4b4415f108a30
Diff: https://reviews.apache.org/r/56889/diff/
Testing
-------
Added permissions and ownerchip check to `LinuxFilesystemIsolatorTest.ROOT_VolumeFromSandbox`. Ran `make check`.
Thanks,
Ilya Pronin
Re: Review Request 56889: Added setting volume mode and ownership in
LinuxFilesystemIsolator.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56889/#review166183
-----------------------------------------------------------
Bad review!
Reviews applied: []
Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.
- Mesos Reviewbot
On Feb. 21, 2017, 3:42 p.m., Ilya Pronin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56889/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2017, 3:42 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-6563
> https://issues.apache.org/jira/browse/MESOS-6563
>
>
> Repository: mesos
>
>
> Description
> -------
>
> `LinuxFilesystemIsolator` now sets ownership and permissions of the newly created relative host path to match the absolute container path.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/filesystem/linux.cpp ae0031d8d8d6dfe0334b605fbb85e83de88ab436
> src/tests/containerizer/linux_filesystem_isolator_tests.cpp c27335731924509632ec96cc01a4b4415f108a30
>
> Diff: https://reviews.apache.org/r/56889/diff/
>
>
> Testing
> -------
>
> Added permissions and ownerchip check to `LinuxFilesystemIsolatorTest.ROOT_VolumeFromSandbox`. Ran `make check`.
>
>
> Thanks,
>
> Ilya Pronin
>
>