You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Till Toenshoff <to...@me.com> on 2017/02/21 15:56:20 UTC
Review Request 56771: Added regression test against fetcher SSL
spillover.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56771/
-----------------------------------------------------------
Review request for mesos, Adam B, Benjamin Bannier, and Greg Mann.
Repository: mesos
Description
-------
Added regression test against fetcher SSL spillover.
Diffs
-----
src/tests/fetcher_tests.cpp 9c7e8b94071501c435e26850d66a8f3e8950c6cd
Diff: https://reviews.apache.org/r/56771/diff/
Testing
-------
Before applying RR56711:
```
[ RUN ] FetcherTest.EnvironmentSpillover
W0216 23:31:25.794740 124055552 fetcher.cpp:899] Begin fetcher log (stderr in sandbox) for container b0fd3f0f-ae72-4d88-b8c2-b4c1af1edee9 from running command: /Users/till/Development/mesos-private/build/src/mesos-fetcher
I0216 23:31:25.746598 3022980032 fetcher.cpp:531] Fetcher Info: {"cache_directory":"\/var\/folders\/_t\/rdp354gx7j5fjww270kbk6_r0000gn\/T\/mesos\/fetch\/slaves\/","items":[{"action":"BYPASS_CACHE","uri":{"extract":true,"value":"\/private\/var\/folders\/_t\/rdp354gx7j5fjww270kbk6_r0000gn\/T\/KBvUlM\/Fo2V66\/zpbEP1.gz"}}],"sandbox_directory":"\/private\/var\/folders\/_t\/rdp354gx7j5fjww270kbk6_r0000gn\/T\/KBvUlM"}
I0216 23:31:25.752025 3022980032 fetcher.cpp:442] Fetching URI '/private/var/folders/_t/rdp354gx7j5fjww270kbk6_r0000gn/T/KBvUlM/Fo2V66/zpbEP1.gz'
I0216 23:31:25.752058 3022980032 fetcher.cpp:283] Fetching directly into the sandbox directory
I0216 23:31:25.752096 3022980032 fetcher.cpp:220] Fetching URI '/private/var/folders/_t/rdp354gx7j5fjww270kbk6_r0000gn/T/KBvUlM/Fo2V66/zpbEP1.gz'
I0216 23:31:25.756001 3022980032 fetcher.cpp:205] Copied resource '/private/var/folders/_t/rdp354gx7j5fjww270kbk6_r0000gn/T/KBvUlM/Fo2V66/zpbEP1.gz' to '/private/var/folders/_t/rdp354gx7j5fjww270kbk6_r0000gn/T/KBvUlM/zpbEP1.gz'
SSL requires key! NOTE: Set path with LIBPROCESS_SSL_KEY_FILE
End fetcher log for container b0fd3f0f-ae72-4d88-b8c2-b4c1af1edee9
E0216 23:31:25.795078 124055552 fetcher.cpp:555] Failed to run mesos-fetcher: Failed to fetch all URIs for container 'b0fd3f0f-ae72-4d88-b8c2-b4c1af1edee9' with exit status: 256
../../src/tests/fetcher_tests.cpp:1134: Failure
(fetch).failure(): Failed to fetch all URIs for container 'b0fd3f0f-ae72-4d88-b8c2-b4c1af1edee9' with exit status: 256
[ FAILED ] FetcherTest.EnvironmentSpillover (115 ms)
```
After applying RR56711:
```
[ RUN ] FetcherTest.EnvironmentSpillover
[ OK ] FetcherTest.EnvironmentSpillover (300 ms)
```
Thanks,
Till Toenshoff
Re: Review Request 56771: Added regression test against fetcher SSL
spillover.
Posted by Adam B <ad...@mesosphere.io>.
> On Feb. 21, 2017, 5:16 p.m., Adam B wrote:
> > Looks good to me. Just a cuminor comments.
s/cuminor/few minor/
- Adam
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56771/#review166187
-----------------------------------------------------------
On Feb. 21, 2017, 7:56 a.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56771/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2017, 7:56 a.m.)
>
>
> Review request for mesos, Adam B, Benjamin Bannier, and Greg Mann.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added regression test against fetcher SSL spillover.
>
>
> Diffs
> -----
>
> src/tests/fetcher_tests.cpp 9c7e8b94071501c435e26850d66a8f3e8950c6cd
>
> Diff: https://reviews.apache.org/r/56771/diff/
>
>
> Testing
> -------
>
> Before applying RR56711:
> ```
> [ RUN ] FetcherTest.EnvironmentSpillover
> W0216 23:31:25.794740 124055552 fetcher.cpp:899] Begin fetcher log (stderr in sandbox) for container b0fd3f0f-ae72-4d88-b8c2-b4c1af1edee9 from running command: /Users/till/Development/mesos-private/build/src/mesos-fetcher
> I0216 23:31:25.746598 3022980032 fetcher.cpp:531] Fetcher Info: {"cache_directory":"\/var\/folders\/_t\/rdp354gx7j5fjww270kbk6_r0000gn\/T\/mesos\/fetch\/slaves\/","items":[{"action":"BYPASS_CACHE","uri":{"extract":true,"value":"\/private\/var\/folders\/_t\/rdp354gx7j5fjww270kbk6_r0000gn\/T\/KBvUlM\/Fo2V66\/zpbEP1.gz"}}],"sandbox_directory":"\/private\/var\/folders\/_t\/rdp354gx7j5fjww270kbk6_r0000gn\/T\/KBvUlM"}
> I0216 23:31:25.752025 3022980032 fetcher.cpp:442] Fetching URI '/private/var/folders/_t/rdp354gx7j5fjww270kbk6_r0000gn/T/KBvUlM/Fo2V66/zpbEP1.gz'
> I0216 23:31:25.752058 3022980032 fetcher.cpp:283] Fetching directly into the sandbox directory
> I0216 23:31:25.752096 3022980032 fetcher.cpp:220] Fetching URI '/private/var/folders/_t/rdp354gx7j5fjww270kbk6_r0000gn/T/KBvUlM/Fo2V66/zpbEP1.gz'
> I0216 23:31:25.756001 3022980032 fetcher.cpp:205] Copied resource '/private/var/folders/_t/rdp354gx7j5fjww270kbk6_r0000gn/T/KBvUlM/Fo2V66/zpbEP1.gz' to '/private/var/folders/_t/rdp354gx7j5fjww270kbk6_r0000gn/T/KBvUlM/zpbEP1.gz'
> SSL requires key! NOTE: Set path with LIBPROCESS_SSL_KEY_FILE
>
> End fetcher log for container b0fd3f0f-ae72-4d88-b8c2-b4c1af1edee9
> E0216 23:31:25.795078 124055552 fetcher.cpp:555] Failed to run mesos-fetcher: Failed to fetch all URIs for container 'b0fd3f0f-ae72-4d88-b8c2-b4c1af1edee9' with exit status: 256
> ../../src/tests/fetcher_tests.cpp:1134: Failure
> (fetch).failure(): Failed to fetch all URIs for container 'b0fd3f0f-ae72-4d88-b8c2-b4c1af1edee9' with exit status: 256
> [ FAILED ] FetcherTest.EnvironmentSpillover (115 ms)
> ```
>
> After applying RR56711:
> ```
> [ RUN ] FetcherTest.EnvironmentSpillover
> [ OK ] FetcherTest.EnvironmentSpillover (300 ms)
> ```
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 56771: Added regression test against fetcher SSL
spillover.
Posted by Till Toenshoff <to...@me.com>.
> On Feb. 22, 2017, 1:16 a.m., Adam B wrote:
> > src/tests/fetcher_tests.cpp, line 1112
> > <https://reviews.apache.org/r/56771/diff/1/?file=1638049#file1638049line1112>
> >
> > Maybe at least choose different strings for dirname and path?
Not sure I understand. Both names are very different in that they are indiviually randomized. Note that those "X"s are replaced with a unique alphanumeric combination by those `mktemp` `mkdtemp` functions.
- Till
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56771/#review166187
-----------------------------------------------------------
On Feb. 23, 2017, 12:43 a.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56771/
> -----------------------------------------------------------
>
> (Updated Feb. 23, 2017, 12:43 a.m.)
>
>
> Review request for mesos, Adam B, Benjamin Bannier, and Greg Mann.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added regression test against fetcher SSL spillover.
>
>
> Diffs
> -----
>
> src/tests/fetcher_tests.cpp 9c7e8b94071501c435e26850d66a8f3e8950c6cd
>
> Diff: https://reviews.apache.org/r/56771/diff/
>
>
> Testing
> -------
>
> Before applying RR56711:
> ```
> [ RUN ] FetcherTest.EnvironmentSpillover
> W0216 23:31:25.794740 124055552 fetcher.cpp:899] Begin fetcher log (stderr in sandbox) for container b0fd3f0f-ae72-4d88-b8c2-b4c1af1edee9 from running command: /Users/till/Development/mesos-private/build/src/mesos-fetcher
> I0216 23:31:25.746598 3022980032 fetcher.cpp:531] Fetcher Info: {"cache_directory":"\/var\/folders\/_t\/rdp354gx7j5fjww270kbk6_r0000gn\/T\/mesos\/fetch\/slaves\/","items":[{"action":"BYPASS_CACHE","uri":{"extract":true,"value":"\/private\/var\/folders\/_t\/rdp354gx7j5fjww270kbk6_r0000gn\/T\/KBvUlM\/Fo2V66\/zpbEP1.gz"}}],"sandbox_directory":"\/private\/var\/folders\/_t\/rdp354gx7j5fjww270kbk6_r0000gn\/T\/KBvUlM"}
> I0216 23:31:25.752025 3022980032 fetcher.cpp:442] Fetching URI '/private/var/folders/_t/rdp354gx7j5fjww270kbk6_r0000gn/T/KBvUlM/Fo2V66/zpbEP1.gz'
> I0216 23:31:25.752058 3022980032 fetcher.cpp:283] Fetching directly into the sandbox directory
> I0216 23:31:25.752096 3022980032 fetcher.cpp:220] Fetching URI '/private/var/folders/_t/rdp354gx7j5fjww270kbk6_r0000gn/T/KBvUlM/Fo2V66/zpbEP1.gz'
> I0216 23:31:25.756001 3022980032 fetcher.cpp:205] Copied resource '/private/var/folders/_t/rdp354gx7j5fjww270kbk6_r0000gn/T/KBvUlM/Fo2V66/zpbEP1.gz' to '/private/var/folders/_t/rdp354gx7j5fjww270kbk6_r0000gn/T/KBvUlM/zpbEP1.gz'
> SSL requires key! NOTE: Set path with LIBPROCESS_SSL_KEY_FILE
>
> End fetcher log for container b0fd3f0f-ae72-4d88-b8c2-b4c1af1edee9
> E0216 23:31:25.795078 124055552 fetcher.cpp:555] Failed to run mesos-fetcher: Failed to fetch all URIs for container 'b0fd3f0f-ae72-4d88-b8c2-b4c1af1edee9' with exit status: 256
> ../../src/tests/fetcher_tests.cpp:1134: Failure
> (fetch).failure(): Failed to fetch all URIs for container 'b0fd3f0f-ae72-4d88-b8c2-b4c1af1edee9' with exit status: 256
> [ FAILED ] FetcherTest.EnvironmentSpillover (115 ms)
> ```
>
> After applying RR56711:
> ```
> [ RUN ] FetcherTest.EnvironmentSpillover
> [ OK ] FetcherTest.EnvironmentSpillover (300 ms)
> ```
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 56771: Added regression test against fetcher SSL
spillover.
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56771/#review166187
-----------------------------------------------------------
Fix it, then Ship it!
Looks good to me. Just a cuminor comments.
src/tests/fetcher_tests.cpp (line 1112)
<https://reviews.apache.org/r/56771/#comment238063>
Maybe at least choose different strings for dirname and path?
src/tests/fetcher_tests.cpp (line 1135)
<https://reviews.apache.org/r/56771/#comment238203>
Seems like this AWAIT is the final check. Please add a comment explaining how a successful fetch means a successful test run.
- Adam B
On Feb. 21, 2017, 7:56 a.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56771/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2017, 7:56 a.m.)
>
>
> Review request for mesos, Adam B, Benjamin Bannier, and Greg Mann.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added regression test against fetcher SSL spillover.
>
>
> Diffs
> -----
>
> src/tests/fetcher_tests.cpp 9c7e8b94071501c435e26850d66a8f3e8950c6cd
>
> Diff: https://reviews.apache.org/r/56771/diff/
>
>
> Testing
> -------
>
> Before applying RR56711:
> ```
> [ RUN ] FetcherTest.EnvironmentSpillover
> W0216 23:31:25.794740 124055552 fetcher.cpp:899] Begin fetcher log (stderr in sandbox) for container b0fd3f0f-ae72-4d88-b8c2-b4c1af1edee9 from running command: /Users/till/Development/mesos-private/build/src/mesos-fetcher
> I0216 23:31:25.746598 3022980032 fetcher.cpp:531] Fetcher Info: {"cache_directory":"\/var\/folders\/_t\/rdp354gx7j5fjww270kbk6_r0000gn\/T\/mesos\/fetch\/slaves\/","items":[{"action":"BYPASS_CACHE","uri":{"extract":true,"value":"\/private\/var\/folders\/_t\/rdp354gx7j5fjww270kbk6_r0000gn\/T\/KBvUlM\/Fo2V66\/zpbEP1.gz"}}],"sandbox_directory":"\/private\/var\/folders\/_t\/rdp354gx7j5fjww270kbk6_r0000gn\/T\/KBvUlM"}
> I0216 23:31:25.752025 3022980032 fetcher.cpp:442] Fetching URI '/private/var/folders/_t/rdp354gx7j5fjww270kbk6_r0000gn/T/KBvUlM/Fo2V66/zpbEP1.gz'
> I0216 23:31:25.752058 3022980032 fetcher.cpp:283] Fetching directly into the sandbox directory
> I0216 23:31:25.752096 3022980032 fetcher.cpp:220] Fetching URI '/private/var/folders/_t/rdp354gx7j5fjww270kbk6_r0000gn/T/KBvUlM/Fo2V66/zpbEP1.gz'
> I0216 23:31:25.756001 3022980032 fetcher.cpp:205] Copied resource '/private/var/folders/_t/rdp354gx7j5fjww270kbk6_r0000gn/T/KBvUlM/Fo2V66/zpbEP1.gz' to '/private/var/folders/_t/rdp354gx7j5fjww270kbk6_r0000gn/T/KBvUlM/zpbEP1.gz'
> SSL requires key! NOTE: Set path with LIBPROCESS_SSL_KEY_FILE
>
> End fetcher log for container b0fd3f0f-ae72-4d88-b8c2-b4c1af1edee9
> E0216 23:31:25.795078 124055552 fetcher.cpp:555] Failed to run mesos-fetcher: Failed to fetch all URIs for container 'b0fd3f0f-ae72-4d88-b8c2-b4c1af1edee9' with exit status: 256
> ../../src/tests/fetcher_tests.cpp:1134: Failure
> (fetch).failure(): Failed to fetch all URIs for container 'b0fd3f0f-ae72-4d88-b8c2-b4c1af1edee9' with exit status: 256
> [ FAILED ] FetcherTest.EnvironmentSpillover (115 ms)
> ```
>
> After applying RR56711:
> ```
> [ RUN ] FetcherTest.EnvironmentSpillover
> [ OK ] FetcherTest.EnvironmentSpillover (300 ms)
> ```
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 56771: Added regression test against fetcher SSL
spillover.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56771/#review166473
-----------------------------------------------------------
Bad patch!
Reviews applied: [56771, 56711]
Failed command: python support/apply-reviews.py -n -r 56711
Error:
2017-02-23 03:43:19 URL:https://reviews.apache.org/r/56711/diff/raw/ [2000/2000] -> "56711.patch" [1]
error: patch failed: src/slave/containerizer/fetcher.cpp:22
error: src/slave/containerizer/fetcher.cpp: patch does not apply
Full log: https://builds.apache.org/job/Mesos-Reviewbot/17197/console
- Mesos Reviewbot
On Feb. 23, 2017, 12:43 a.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56771/
> -----------------------------------------------------------
>
> (Updated Feb. 23, 2017, 12:43 a.m.)
>
>
> Review request for mesos, Adam B, Benjamin Bannier, and Greg Mann.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added regression test against fetcher SSL spillover.
>
>
> Diffs
> -----
>
> src/tests/fetcher_tests.cpp 9c7e8b94071501c435e26850d66a8f3e8950c6cd
>
> Diff: https://reviews.apache.org/r/56771/diff/
>
>
> Testing
> -------
>
> Before applying RR56711:
> ```
> [ RUN ] FetcherTest.EnvironmentSpillover
> W0216 23:31:25.794740 124055552 fetcher.cpp:899] Begin fetcher log (stderr in sandbox) for container b0fd3f0f-ae72-4d88-b8c2-b4c1af1edee9 from running command: /Users/till/Development/mesos-private/build/src/mesos-fetcher
> I0216 23:31:25.746598 3022980032 fetcher.cpp:531] Fetcher Info: {"cache_directory":"\/var\/folders\/_t\/rdp354gx7j5fjww270kbk6_r0000gn\/T\/mesos\/fetch\/slaves\/","items":[{"action":"BYPASS_CACHE","uri":{"extract":true,"value":"\/private\/var\/folders\/_t\/rdp354gx7j5fjww270kbk6_r0000gn\/T\/KBvUlM\/Fo2V66\/zpbEP1.gz"}}],"sandbox_directory":"\/private\/var\/folders\/_t\/rdp354gx7j5fjww270kbk6_r0000gn\/T\/KBvUlM"}
> I0216 23:31:25.752025 3022980032 fetcher.cpp:442] Fetching URI '/private/var/folders/_t/rdp354gx7j5fjww270kbk6_r0000gn/T/KBvUlM/Fo2V66/zpbEP1.gz'
> I0216 23:31:25.752058 3022980032 fetcher.cpp:283] Fetching directly into the sandbox directory
> I0216 23:31:25.752096 3022980032 fetcher.cpp:220] Fetching URI '/private/var/folders/_t/rdp354gx7j5fjww270kbk6_r0000gn/T/KBvUlM/Fo2V66/zpbEP1.gz'
> I0216 23:31:25.756001 3022980032 fetcher.cpp:205] Copied resource '/private/var/folders/_t/rdp354gx7j5fjww270kbk6_r0000gn/T/KBvUlM/Fo2V66/zpbEP1.gz' to '/private/var/folders/_t/rdp354gx7j5fjww270kbk6_r0000gn/T/KBvUlM/zpbEP1.gz'
> SSL requires key! NOTE: Set path with LIBPROCESS_SSL_KEY_FILE
>
> End fetcher log for container b0fd3f0f-ae72-4d88-b8c2-b4c1af1edee9
> E0216 23:31:25.795078 124055552 fetcher.cpp:555] Failed to run mesos-fetcher: Failed to fetch all URIs for container 'b0fd3f0f-ae72-4d88-b8c2-b4c1af1edee9' with exit status: 256
> ../../src/tests/fetcher_tests.cpp:1134: Failure
> (fetch).failure(): Failed to fetch all URIs for container 'b0fd3f0f-ae72-4d88-b8c2-b4c1af1edee9' with exit status: 256
> [ FAILED ] FetcherTest.EnvironmentSpillover (115 ms)
> ```
>
> After applying RR56711:
> ```
> [ RUN ] FetcherTest.EnvironmentSpillover
> [ OK ] FetcherTest.EnvironmentSpillover (300 ms)
> ```
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 56771: Added regression test against fetcher SSL
spillover.
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56771/
-----------------------------------------------------------
(Updated Feb. 23, 2017, 12:43 a.m.)
Review request for mesos, Adam B, Benjamin Bannier, and Greg Mann.
Repository: mesos
Description
-------
Added regression test against fetcher SSL spillover.
Diffs (updated)
-----
src/tests/fetcher_tests.cpp 9c7e8b94071501c435e26850d66a8f3e8950c6cd
Diff: https://reviews.apache.org/r/56771/diff/
Testing
-------
Before applying RR56711:
```
[ RUN ] FetcherTest.EnvironmentSpillover
W0216 23:31:25.794740 124055552 fetcher.cpp:899] Begin fetcher log (stderr in sandbox) for container b0fd3f0f-ae72-4d88-b8c2-b4c1af1edee9 from running command: /Users/till/Development/mesos-private/build/src/mesos-fetcher
I0216 23:31:25.746598 3022980032 fetcher.cpp:531] Fetcher Info: {"cache_directory":"\/var\/folders\/_t\/rdp354gx7j5fjww270kbk6_r0000gn\/T\/mesos\/fetch\/slaves\/","items":[{"action":"BYPASS_CACHE","uri":{"extract":true,"value":"\/private\/var\/folders\/_t\/rdp354gx7j5fjww270kbk6_r0000gn\/T\/KBvUlM\/Fo2V66\/zpbEP1.gz"}}],"sandbox_directory":"\/private\/var\/folders\/_t\/rdp354gx7j5fjww270kbk6_r0000gn\/T\/KBvUlM"}
I0216 23:31:25.752025 3022980032 fetcher.cpp:442] Fetching URI '/private/var/folders/_t/rdp354gx7j5fjww270kbk6_r0000gn/T/KBvUlM/Fo2V66/zpbEP1.gz'
I0216 23:31:25.752058 3022980032 fetcher.cpp:283] Fetching directly into the sandbox directory
I0216 23:31:25.752096 3022980032 fetcher.cpp:220] Fetching URI '/private/var/folders/_t/rdp354gx7j5fjww270kbk6_r0000gn/T/KBvUlM/Fo2V66/zpbEP1.gz'
I0216 23:31:25.756001 3022980032 fetcher.cpp:205] Copied resource '/private/var/folders/_t/rdp354gx7j5fjww270kbk6_r0000gn/T/KBvUlM/Fo2V66/zpbEP1.gz' to '/private/var/folders/_t/rdp354gx7j5fjww270kbk6_r0000gn/T/KBvUlM/zpbEP1.gz'
SSL requires key! NOTE: Set path with LIBPROCESS_SSL_KEY_FILE
End fetcher log for container b0fd3f0f-ae72-4d88-b8c2-b4c1af1edee9
E0216 23:31:25.795078 124055552 fetcher.cpp:555] Failed to run mesos-fetcher: Failed to fetch all URIs for container 'b0fd3f0f-ae72-4d88-b8c2-b4c1af1edee9' with exit status: 256
../../src/tests/fetcher_tests.cpp:1134: Failure
(fetch).failure(): Failed to fetch all URIs for container 'b0fd3f0f-ae72-4d88-b8c2-b4c1af1edee9' with exit status: 256
[ FAILED ] FetcherTest.EnvironmentSpillover (115 ms)
```
After applying RR56711:
```
[ RUN ] FetcherTest.EnvironmentSpillover
[ OK ] FetcherTest.EnvironmentSpillover (300 ms)
```
Thanks,
Till Toenshoff
Re: Review Request 56771: Added regression test against fetcher SSL
spillover.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56771/#review166299
-----------------------------------------------------------
Patch looks great!
Reviews applied: [56711, 56771]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Feb. 21, 2017, 3:56 p.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56771/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2017, 3:56 p.m.)
>
>
> Review request for mesos, Adam B, Benjamin Bannier, and Greg Mann.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added regression test against fetcher SSL spillover.
>
>
> Diffs
> -----
>
> src/tests/fetcher_tests.cpp 9c7e8b94071501c435e26850d66a8f3e8950c6cd
>
> Diff: https://reviews.apache.org/r/56771/diff/
>
>
> Testing
> -------
>
> Before applying RR56711:
> ```
> [ RUN ] FetcherTest.EnvironmentSpillover
> W0216 23:31:25.794740 124055552 fetcher.cpp:899] Begin fetcher log (stderr in sandbox) for container b0fd3f0f-ae72-4d88-b8c2-b4c1af1edee9 from running command: /Users/till/Development/mesos-private/build/src/mesos-fetcher
> I0216 23:31:25.746598 3022980032 fetcher.cpp:531] Fetcher Info: {"cache_directory":"\/var\/folders\/_t\/rdp354gx7j5fjww270kbk6_r0000gn\/T\/mesos\/fetch\/slaves\/","items":[{"action":"BYPASS_CACHE","uri":{"extract":true,"value":"\/private\/var\/folders\/_t\/rdp354gx7j5fjww270kbk6_r0000gn\/T\/KBvUlM\/Fo2V66\/zpbEP1.gz"}}],"sandbox_directory":"\/private\/var\/folders\/_t\/rdp354gx7j5fjww270kbk6_r0000gn\/T\/KBvUlM"}
> I0216 23:31:25.752025 3022980032 fetcher.cpp:442] Fetching URI '/private/var/folders/_t/rdp354gx7j5fjww270kbk6_r0000gn/T/KBvUlM/Fo2V66/zpbEP1.gz'
> I0216 23:31:25.752058 3022980032 fetcher.cpp:283] Fetching directly into the sandbox directory
> I0216 23:31:25.752096 3022980032 fetcher.cpp:220] Fetching URI '/private/var/folders/_t/rdp354gx7j5fjww270kbk6_r0000gn/T/KBvUlM/Fo2V66/zpbEP1.gz'
> I0216 23:31:25.756001 3022980032 fetcher.cpp:205] Copied resource '/private/var/folders/_t/rdp354gx7j5fjww270kbk6_r0000gn/T/KBvUlM/Fo2V66/zpbEP1.gz' to '/private/var/folders/_t/rdp354gx7j5fjww270kbk6_r0000gn/T/KBvUlM/zpbEP1.gz'
> SSL requires key! NOTE: Set path with LIBPROCESS_SSL_KEY_FILE
>
> End fetcher log for container b0fd3f0f-ae72-4d88-b8c2-b4c1af1edee9
> E0216 23:31:25.795078 124055552 fetcher.cpp:555] Failed to run mesos-fetcher: Failed to fetch all URIs for container 'b0fd3f0f-ae72-4d88-b8c2-b4c1af1edee9' with exit status: 256
> ../../src/tests/fetcher_tests.cpp:1134: Failure
> (fetch).failure(): Failed to fetch all URIs for container 'b0fd3f0f-ae72-4d88-b8c2-b4c1af1edee9' with exit status: 256
> [ FAILED ] FetcherTest.EnvironmentSpillover (115 ms)
> ```
>
> After applying RR56711:
> ```
> [ RUN ] FetcherTest.EnvironmentSpillover
> [ OK ] FetcherTest.EnvironmentSpillover (300 ms)
> ```
>
>
> Thanks,
>
> Till Toenshoff
>
>