You are viewing a plain text version of this content. The canonical link for it is here.
- Re: Review Request 64384: Added new 'any' setting for reconfiguration_policy flag. - posted by Benno Evers <be...@mesosphere.com> on 2018/10/01 13:53:57 UTC, 0 replies.
- Re: Review Request 63654: Added a `net::socketpair` helper to stout. - posted by James Peach <jp...@apache.org> on 2018/10/01 17:36:43 UTC, 4 replies.
- Re: Review Request 63655: Switched to `net::socketpair` in `ns::clone`. - posted by James Peach <jp...@apache.org> on 2018/10/01 17:37:03 UTC, 5 replies.
- Re: Review Request 68810: Removed call to 'setsid()' in command executor if TTY attached. - posted by Jie Yu <yu...@gmail.com> on 2018/10/01 17:38:58 UTC, 0 replies.
- [GitHub] jpeach commented on issue #312: BugFix backporting 1.5.x - posted by GitBox <gi...@apache.org> on 2018/10/01 18:08:56 UTC, 1 replies.
- Re: Review Request 68887: Added MESOS-9231 in CHANGELOG and updated upgrades.md. - posted by Gilbert Song <so...@gmail.com> on 2018/10/01 18:40:53 UTC, 0 replies.
- Re: Review Request 68644: Closed all file descriptors except `whitelist_fds` in posix/subprocess. - posted by James Peach <jp...@apache.org> on 2018/10/01 21:28:49 UTC, 10 replies.
- Re: Review Request 68734: Refactored new CLI. - posted by Kevin Klues <kl...@gmail.com> on 2018/10/02 14:37:42 UTC, 0 replies.
- Review Request 68899: Updated the MesosCon 2018 location. - posted by Gastón Kleiman <ga...@mesosphere.io> on 2018/10/02 18:59:33 UTC, 3 replies.
- Re: Review Request 68866: Waited for TEARDOWN response in v1 Java scheduler shim. - posted by Greg Mann <gr...@mesosphere.io> on 2018/10/02 23:58:46 UTC, 9 replies.
- Review Request 68903: Avoid deadlock-prone blocking in master's parallel endpoint serving. - posted by Benjamin Mahler <bm...@apache.org> on 2018/10/03 00:07:53 UTC, 2 replies.
- Review Request 68904: Removed version check from libevent dependency tracking. - posted by Till Toenshoff via Review Board <no...@reviews.apache.org> on 2018/10/03 01:30:41 UTC, 2 replies.
- Review Request 68905: Removed version check from libevent dependency tracking from libprocess. - posted by Till Toenshoff via Review Board <no...@reviews.apache.org> on 2018/10/03 01:31:04 UTC, 2 replies.
- Review Request 68906: Fixed ssl build specific incompatiblity with libevent later than 2.1.5. - posted by Till Toenshoff via Review Board <no...@reviews.apache.org> on 2018/10/03 01:31:39 UTC, 5 replies.
- Review Request 68912: Added a log line to `MesosContainerizer::kill()`. - posted by Vinod Kone <vi...@apache.org> on 2018/10/03 15:05:29 UTC, 3 replies.
- Re: Review Request 68865: Put `TerminateEvent` at the end of the queue in the Mesos library. - posted by Greg Mann <gr...@mesosphere.io> on 2018/10/03 15:12:01 UTC, 3 replies.
- Re: Review Request 67748: Added monitoring paragraph to high-availability.md. - posted by Till Toenshoff via Review Board <no...@reviews.apache.org> on 2018/10/03 16:28:39 UTC, 0 replies.
- Review Request 68913: Updated libevent linkage to adhere to best practices. - posted by Till Toenshoff via Review Board <no...@reviews.apache.org> on 2018/10/03 16:50:49 UTC, 3 replies.
- Review Request 68914: Updated libevent linkage to adhere to best practices. - posted by Till Toenshoff via Review Board <no...@reviews.apache.org> on 2018/10/03 16:51:03 UTC, 2 replies.
- Review Request 68916: Moved libevent_openssl validation into libevent.m4. - posted by Till Toenshoff via Review Board <no...@reviews.apache.org> on 2018/10/03 16:51:16 UTC, 4 replies.
- Review Request 68915: Moved libevent_openssl validation into libevent.m4. - posted by Till Toenshoff via Review Board <no...@reviews.apache.org> on 2018/10/03 16:51:27 UTC, 3 replies.
- Review Request 68919: Removed unbundling by default for libevent on macOS when using CMake. - posted by Till Toenshoff via Review Board <no...@reviews.apache.org> on 2018/10/03 20:55:02 UTC, 2 replies.
- Re: Review Request 68508: Added tracking of framework allocations in the allocator Slave class. - posted by Benjamin Mahler <bm...@apache.org> on 2018/10/03 22:20:35 UTC, 0 replies.
- Re: Review Request 68507: Pulled out nested `Framework` and `Slave` classes in the allocator. - posted by Benjamin Mahler <bm...@apache.org> on 2018/10/03 22:20:46 UTC, 1 replies.
- Review Request 68921: Bring up the loopback interface using `iproute2`. - posted by Sergey Urbanovich <se...@gmail.com> on 2018/10/03 22:36:27 UTC, 5 replies.
- Review Request 68923: Updated 'Docker::inspect()' to avoid 'os::killtree()'. - posted by Greg Mann <gr...@mesosphere.io> on 2018/10/04 05:22:02 UTC, 1 replies.
- Review Request 68924: Updated the Docker library to avoid 'os::killtree()'. - posted by Greg Mann <gr...@mesosphere.io> on 2018/10/04 05:26:41 UTC, 4 replies.
- Re: Review Request 68813: Added support for `Option` / `Option`. - posted by Michael Park <mp...@apache.org> on 2018/10/04 15:25:58 UTC, 0 replies.
- Re: Review Request 68923: Updated Docker library to avoid 'os::killtree()' when discarding. - posted by Greg Mann <gr...@mesosphere.io> on 2018/10/04 22:14:17 UTC, 4 replies.
- Review Request 68929: Fixed the nested container launch failure on the agent upgrade case. - posted by Gilbert Song <so...@gmail.com> on 2018/10/05 00:37:36 UTC, 8 replies.
- Review Request 68936: Fixed libevent dependency. - posted by Jan Schlicht <ja...@mesosphere.io> on 2018/10/05 09:10:46 UTC, 2 replies.
- Re: Review Request 66657: Updated Config initialization for new CLI if file does not exist. - posted by Armand Grillet <ag...@mesosphere.io> on 2018/10/05 09:40:02 UTC, 1 replies.
- Re: Review Request 66683: Updated address field of new CLI config to accept URLs. - posted by Armand Grillet <ag...@mesosphere.io> on 2018/10/05 09:59:09 UTC, 1 replies.
- Review Request 68937: Removed output in mesos-style.py when linting goes well. - posted by Armand Grillet <ag...@mesosphere.io> on 2018/10/05 10:29:00 UTC, 5 replies.
- Re: Review Request 67414: Added default message bodies to libprocess HTTP error responses. - posted by Alexander Rukletsov <ru...@gmail.com> on 2018/10/05 13:54:40 UTC, 4 replies.
- Review Request 68939: Updated cpplint.py to be less verbose when there is no linting issue. - posted by Armand Grillet <ag...@mesosphere.io> on 2018/10/05 15:28:22 UTC, 2 replies.
- Review Request 68940: Added a 1.7.0 performance improvements blog post. - posted by Benjamin Mahler <bm...@apache.org> on 2018/10/05 23:01:11 UTC, 3 replies.
- Review Request 68941: Added an unit test for agent recovery with new cgroup subsystems. - posted by Gilbert Song <so...@gmail.com> on 2018/10/05 23:32:26 UTC, 9 replies.
- Review Request 68944: Used delegating constructors in `Response` types. - posted by Alexander Rukletsov <ru...@gmail.com> on 2018/10/07 15:16:06 UTC, 1 replies.
- Review Request 68945: Fused constructors of `MethodNotAllowed` into one. - posted by Alexander Rukletsov <ru...@gmail.com> on 2018/10/07 15:16:40 UTC, 6 replies.
- Review Request 68949: Removed unused `lib/cli/tasks.py` for new CLI. - posted by Armand Grillet <ag...@mesosphere.io> on 2018/10/08 13:07:52 UTC, 0 replies.
- Review Request 68950: Moved `get_agent_address` from `util.py` to `mesos.py` in new CLI. - posted by Armand Grillet <ag...@mesosphere.io> on 2018/10/08 13:08:22 UTC, 1 replies.
- Re: Review Request 68711: Added `task ls` command to new CLI. - posted by Armand Grillet <ag...@mesosphere.io> on 2018/10/08 13:09:18 UTC, 0 replies.
- Review Request 68951: Updated verify-reviews.py to use current interpreter in subprocesses. - posted by Armand Grillet <ag...@mesosphere.io> on 2018/10/08 18:06:42 UTC, 6 replies.
- Review Request 68957: Add documentation for per-framework metrics flag. - posted by Jacob Janco <jj...@gmail.com> on 2018/10/08 21:58:34 UTC, 33 replies.
- Review Request 68956: Add flag to toggle per framework metrics. - posted by Jacob Janco <jj...@gmail.com> on 2018/10/08 21:58:44 UTC, 4 replies.
- Review Request 68955: Add per framework metrics in member function. - posted by Jacob Janco <jj...@gmail.com> on 2018/10/08 21:58:48 UTC, 2 replies.
- Review Request 68954: Fix tests related to allocator options refactor. - posted by Jacob Janco <jj...@gmail.com> on 2018/10/08 21:58:55 UTC, 3 replies.
- Review Request 68953: Refactor allocator configuration into class. - posted by Jacob Janco <jj...@gmail.com> on 2018/10/08 21:59:00 UTC, 4 replies.
- Re: Review Request 66683: Updated address sanitization in new CLI to accept DNS names. - posted by Armand Grillet <ag...@mesosphere.io> on 2018/10/09 09:37:18 UTC, 5 replies.
- Review Request 68965: Added try/catch statements when using Mesos util functions in new CLI. - posted by Armand Grillet <ag...@mesosphere.io> on 2018/10/09 14:01:30 UTC, 4 replies.
- Re: Review Request 61818: Adjusted a comment and a log message around container termination. - posted by Alexander Rukletsov <ru...@gmail.com> on 2018/10/09 15:50:11 UTC, 2 replies.
- Re: Review Request 68706: Added master failover reregistration progress metrics. - posted by Xudong Ni via Review Board <no...@reviews.apache.org> on 2018/10/09 20:45:24 UTC, 20 replies.
- [GitHub] mengzhugithub opened a new pull request #314: Fixed failed test `CGROUPS_ROOT_PidNamespace*`. - posted by GitBox <gi...@apache.org> on 2018/10/09 23:49:52 UTC, 0 replies.
- [GitHub] mengzhugithub commented on issue #307: Generated a new bundle of Boost headers. - posted by GitBox <gi...@apache.org> on 2018/10/09 23:51:31 UTC, 0 replies.
- [GitHub] mengzhugithub closed pull request #307: Generated a new bundle of Boost headers. - posted by GitBox <gi...@apache.org> on 2018/10/09 23:51:32 UTC, 0 replies.
- [GitHub] bmahler closed pull request #314: Fixed failed test `CGROUPS_ROOT_PidNamespace*`. - posted by GitBox <gi...@apache.org> on 2018/10/09 23:58:19 UTC, 0 replies.
- Review Request 68970: Fixed JSON object type error when using `support/apply-reviews.py`. - posted by Armand Grillet <ag...@mesosphere.io> on 2018/10/10 05:21:22 UTC, 2 replies.
- Review Request 68971: Added pylint init-hook to add Mesos library to `PYTHONPATH`. - posted by Armand Grillet <ag...@mesosphere.io> on 2018/10/10 11:11:23 UTC, 1 replies.
- Review Request 68976: Added `post()` function to new CLI for interacting with the HTTP API. - posted by Armand Grillet <ag...@mesosphere.io> on 2018/10/10 14:44:31 UTC, 0 replies.
- Review Request 68977: Added Record-IO encoder and decoder to new CLI. - posted by Armand Grillet <ag...@mesosphere.io> on 2018/10/10 14:45:02 UTC, 2 replies.
- Review Request 68978: Added TaskIO object to new CLI for `task exec` and `task attach`. - posted by Armand Grillet <ag...@mesosphere.io> on 2018/10/10 14:45:30 UTC, 4 replies.
- Review Request 68984: Changed a benign warning log message in slave.cpp to info. - posted by Meng Zhu <mz...@mesosphere.io> on 2018/10/10 23:02:06 UTC, 3 replies.
- [GitHub] asfgit closed pull request #313: BugFix backporting 1.6.x - posted by GitBox <gi...@apache.org> on 2018/10/10 23:53:36 UTC, 0 replies.
- [GitHub] asfgit closed pull request #312: BugFix backporting 1.5.x - posted by GitBox <gi...@apache.org> on 2018/10/10 23:53:56 UTC, 0 replies.
- [GitHub] asfgit closed pull request #311: BugFix backporting 1.4.x - posted by GitBox <gi...@apache.org> on 2018/10/10 23:54:16 UTC, 0 replies.
- Review Request 68986: Created cgroup recursively when calling prepare on containers. - posted by fei long <ca...@gmail.com> on 2018/10/11 05:12:30 UTC, 5 replies.
- Review Request 68987: Fixed protobuf map equality check in the URI disk profile adaptor. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/10/11 05:18:02 UTC, 5 replies.
- Review Request 68991: Added a test `FsTest.Lsof`. - posted by Qian Zhang <zh...@gmail.com> on 2018/10/11 13:56:43 UTC, 9 replies.
- Re: Review Request 68642: Added `lsof()` into stout. - posted by Qian Zhang <zh...@gmail.com> on 2018/10/11 13:56:55 UTC, 8 replies.
- Re: Review Request 68643: Updated `MesosContainerizerLaunch` to call `os::lsof()`. - posted by Qian Zhang <zh...@gmail.com> on 2018/10/11 14:00:44 UTC, 2 replies.
- Review Request 68995: Removed the child hook `UNSET_CLOEXEC`. - posted by Qian Zhang <zh...@gmail.com> on 2018/10/11 14:12:41 UTC, 4 replies.
- Review Request 68992: Added 'received' timestamp into `process::Request`. - posted by Alexander Rukletsov <ru...@gmail.com> on 2018/10/11 14:16:36 UTC, 4 replies.
- Review Request 68993: Introduced `logResponse` for http handlers. - posted by Alexander Rukletsov <ru...@gmail.com> on 2018/10/11 14:16:38 UTC, 4 replies.
- Review Request 68994: Logged request processing time for some endpoints. - posted by Alexander Rukletsov <ru...@gmail.com> on 2018/10/11 14:16:40 UTC, 7 replies.
- Review Request 68999: Fixed the XFS project ID labeling to not cross mount points. - posted by James Peach <jp...@apache.org> on 2018/10/11 22:23:41 UTC, 6 replies.
- Re: Review Request 68956: Add a flag to toggle per-framework metrics. - posted by Jacob Janco <jj...@gmail.com> on 2018/10/11 23:12:51 UTC, 21 replies.
- Re: Review Request 68953: Refactor allocator configuration into a struct. - posted by Jacob Janco <jj...@gmail.com> on 2018/10/11 23:13:51 UTC, 12 replies.
- Re: Review Request 68954: Fix tests broken by allocator options refactor. - posted by Jacob Janco <jj...@gmail.com> on 2018/10/11 23:14:32 UTC, 0 replies.
- Review Request 69003: WIP: Added `task exec` to new CLI. - posted by Armand Grillet <ag...@mesosphere.io> on 2018/10/12 05:20:39 UTC, 1 replies.
- Re: Review Request 68645: Updated IO switchboard to use subprocess's `whitelist_fds` parameter. - posted by James Peach <jp...@apache.org> on 2018/10/12 17:41:32 UTC, 1 replies.
- Re: Review Request 68646: Updated launchers to use subprocess's `whitelist_fds` parameter. - posted by James Peach <jp...@apache.org> on 2018/10/12 17:43:52 UTC, 1 replies.
- Re: Review Request 69003: Added `task exec` to new CLI. - posted by Armand Grillet <ag...@mesosphere.io> on 2018/10/12 21:18:04 UTC, 8 replies.
- Review Request 69009: Added a sync option for `write` and POSIX `rename`. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/10/12 23:18:38 UTC, 0 replies.
- Review Request 69010: Synced SLRP checkpoints to the filesystem. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/10/12 23:20:00 UTC, 30 replies.
- Re: Review Request 69009: Stout: Added a sync option for `write` and `rename`. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/10/12 23:53:28 UTC, 17 replies.
- Review Request 69007: Added `get_container_id` to util functions for the new CLI. - posted by Armand Grillet <ag...@mesosphere.io> on 2018/10/13 09:08:25 UTC, 1 replies.
- Review Request 69016: Added a test `SubprocessTest.WhiteListFds`. - posted by Qian Zhang <zh...@gmail.com> on 2018/10/14 14:02:27 UTC, 2 replies.
- Review Request 69023: Added `retry` argument to `request()` method for Resource object. - posted by Armand Grillet <ag...@mesosphere.io> on 2018/10/15 11:05:15 UTC, 0 replies.
- Review Request 69026: Changed usage documentation for new CLI. - posted by Armand Grillet <ag...@mesosphere.io> on 2018/10/15 11:45:43 UTC, 2 replies.
- Re: Review Request 67840: Renamed committer checklist into committer guidelines. - posted by Gastón Kleiman <ga...@mesosphere.io> on 2018/10/15 17:23:38 UTC, 2 replies.
- Re: Review Request 67841: Updated committer candidate guidelines. - posted by Gastón Kleiman <ga...@mesosphere.io> on 2018/10/15 17:26:10 UTC, 3 replies.
- Review Request 69033: Fixed a comment in SLRP. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/10/15 22:09:05 UTC, 3 replies.
- Re: Review Request 65784: Added validation of QuotaRequest. - posted by Benjamin Mahler <bm...@apache.org> on 2018/10/15 22:17:26 UTC, 0 replies.
- Review Request 69035: Added a comment for `Resource.provider_id`. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/10/16 04:07:44 UTC, 1 replies.
- Re: Review Request 69036: WIP: Added an optional `profile` field to `CreateDisk`. - posted by Mesos Reviewbot Windows <re...@mesos.apache.org> on 2018/10/16 05:39:31 UTC, 0 replies.
- Re: Review Request 69037: WIP: Added an optional `vendor` field to `DiskInfo.Source`. - posted by Mesos Reviewbot Windows <re...@mesos.apache.org> on 2018/10/16 07:04:34 UTC, 0 replies.
- Review Request 69041: Relaxed `Promise` constructor and assignment operator requirements. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/10/16 10:23:27 UTC, 2 replies.
- Review Request 69042: Enabled more constructors for master `RegistryOperation`. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/10/16 10:23:28 UTC, 4 replies.
- Review Request 69047: Updated Python library to be easier to handle as a Python module. - posted by Armand Grillet <ag...@mesosphere.io> on 2018/10/16 11:31:41 UTC, 1 replies.
- Re: Review Request 68971: Moved import of '../lib' from new CLI bootstrap to pip-requirements.txt. - posted by Armand Grillet <ag...@mesosphere.io> on 2018/10/16 11:33:22 UTC, 1 replies.
- Review Request 69043: Disabled warnings-as-errors for cares build. - posted by Benno Evers <be...@mesosphere.com> on 2018/10/16 12:03:38 UTC, 2 replies.
- Re: Review Request 68977: Added Record-IO encoder and decoder to Python library. - posted by Armand Grillet <ag...@mesosphere.io> on 2018/10/16 12:16:35 UTC, 1 replies.
- Review Request 69052: Added a test to ensure UUID size, variant, version. - posted by Benjamin Mahler <bm...@apache.org> on 2018/10/16 18:57:06 UTC, 0 replies.
- Review Request 69053: Documented that UUID is a 128 bits (or 16 bytes). - posted by Benjamin Mahler <bm...@apache.org> on 2018/10/16 18:57:09 UTC, 3 replies.
- Re: Review Request 68089: Added LevelDB compaction after replicated log truncation. - posted by Benjamin Mahler <bm...@apache.org> on 2018/10/16 21:02:37 UTC, 1 replies.
- Re: Review Request 68090: Added log_auto_compact flag to the master. - posted by Benjamin Mahler <bm...@apache.org> on 2018/10/16 21:03:28 UTC, 0 replies.
- Review Request 69032: Optimized resources filter operation. - posted by Meng Zhu <mz...@mesosphere.io> on 2018/10/16 23:16:01 UTC, 6 replies.
- Review Request 69059: Fixed the FreeBSD MACRO as '__FreeBSD__' in posix/pipe.hpp. - posted by Gilbert Song <so...@gmail.com> on 2018/10/17 08:00:25 UTC, 5 replies.
- Re: Review Request 69023: Added `retry` argument to `request()` method in Python library. - posted by Kevin Klues <kl...@gmail.com> on 2018/10/17 12:02:48 UTC, 0 replies.
- Re: Review Request 68147: Added agent support to remove local resource providers. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/10/17 14:07:14 UTC, 2 replies.
- Review Request 68795: Added deduplication for read-only master requests. - posted by Benno Evers <be...@mesosphere.com> on 2018/10/17 15:10:13 UTC, 1 replies.
- Review Request 69064: WIP: Added unit tests for Master HTTP endpoints. - posted by Benno Evers <be...@mesosphere.com> on 2018/10/17 15:10:29 UTC, 4 replies.
- Re: Review Request 68587: Fixed fetcher deadlock with duplicate URIs. - posted by Jiang Yan Xu <ya...@jxu.me> on 2018/10/17 17:49:07 UTC, 1 replies.
- Re: Review Request 68586: Add the output file to the hash on CommandInfo::URI. - posted by Jiang Yan Xu <ya...@jxu.me> on 2018/10/17 17:52:42 UTC, 2 replies.
- Re: Review Request 69036: WIP: Updated the semantics of `CREATE_DISK` and `DESTROY_DISK` operations. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/10/17 23:21:52 UTC, 2 replies.
- Review Request 69068: Added `hasGpu` flag in the allocator `Slave` struct. - posted by Meng Zhu <mz...@mesosphere.io> on 2018/10/17 23:41:40 UTC, 2 replies.
- Re: Review Request 69068: Cached whether agents have gpus to improve allocator performance. - posted by Meng Zhu <mz...@mesosphere.io> on 2018/10/18 01:14:07 UTC, 2 replies.
- Review Request 69071: Narrowed interface of `ReadOnlyHandler` members. - posted by Benno Evers <be...@mesosphere.com> on 2018/10/18 18:43:27 UTC, 0 replies.
- Review Request 69075: Updated docker image fetcher to enforce HTTP1.1. - posted by Till Toenshoff via Review Board <no...@reviews.apache.org> on 2018/10/18 22:57:43 UTC, 2 replies.
- Re: Review Request 69075: Updated docker image fetcher to enforce HTTP1.0. - posted by Till Toenshoff via Review Board <no...@reviews.apache.org> on 2018/10/18 23:41:21 UTC, 2 replies.
- Review Request 69084: Updated 'Makefile.am' to make new CLI build step more reliable. - posted by Armand Grillet <ag...@mesosphere.io> on 2018/10/19 15:22:20 UTC, 1 replies.
- Review Request 69086: Move the container `/dev` construction to the isolators. - posted by James Peach <jp...@apache.org> on 2018/10/19 17:38:09 UTC, 7 replies.
- Review Request 69085: Stout: Always `fsync` created directories in POSIX `mkdir`. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/10/19 17:54:17 UTC, 9 replies.
- Review Request 69089: Eliminated excessive label copying in the task label decorator hook. - posted by Benjamin Mahler <bm...@apache.org> on 2018/10/19 20:35:33 UTC, 2 replies.
- Review Request 69092: Added default arguments to `FrameworkProfile` in allocator benchmark. - posted by Meng Zhu <mz...@mesosphere.io> on 2018/10/20 01:27:18 UTC, 2 replies.
- Review Request 69093: Removed `used` argument in `AgentProfile` in the allocator benchmark. - posted by Meng Zhu <mz...@mesosphere.io> on 2018/10/20 01:27:32 UTC, 2 replies.
- Review Request 69094: Renamed one allocator benchmark to be more descriptive. - posted by Meng Zhu <mz...@mesosphere.io> on 2018/10/20 01:27:42 UTC, 1 replies.
- Review Request 69095: Added `hierarchical_allocator_benchmarks.cpp` to `CMakeLists.txt`. - posted by Meng Zhu <mz...@mesosphere.io> on 2018/10/20 01:27:49 UTC, 1 replies.
- Review Request 69096: Moved a few allocator test helpers to `tests/allocator.hpp`. - posted by Meng Zhu <mz...@mesosphere.io> on 2018/10/20 01:28:31 UTC, 2 replies.
- Review Request 69097: Added an allocator benchmark for quota performance. - posted by Meng Zhu <mz...@mesosphere.io> on 2018/10/20 01:29:55 UTC, 2 replies.
- Review Request 69098: Added a benchmark to compare quota and nonquota allocation performance. - posted by Meng Zhu <mz...@mesosphere.io> on 2018/10/20 06:05:37 UTC, 3 replies.
- Review Request 69103: Fixed bug in 'execute.cpp' with tty-based tasks and no 'containerInfo'. - posted by Kevin Klues <kl...@gmail.com> on 2018/10/20 08:57:25 UTC, 4 replies.
- Review Request 69104: Fixed formatting in subcommand help in the new CLI. - posted by Kevin Klues <kl...@gmail.com> on 2018/10/20 09:30:59 UTC, 3 replies.
- Review Request 69105: Added 'task atach' subcommand to new CLI. - posted by Armand Grillet <ag...@mesosphere.io> on 2018/10/20 10:04:08 UTC, 0 replies.
- Re: Review Request 69105: Added 'task attach' subcommand to new CLI. - posted by Kevin Klues <kl...@gmail.com> on 2018/10/20 10:53:47 UTC, 1 replies.
- Review Request 69109: Updated libprocess to log all socket errors consistently. - posted by Benjamin Mahler <bm...@apache.org> on 2018/10/21 23:40:08 UTC, 2 replies.
- Review Request 69110: Added task health check definitions to master API responses. - posted by Greg Mann <gr...@mesosphere.io> on 2018/10/22 04:31:49 UTC, 21 replies.
- Review Request 69114: Added 'exec_command' to test util functions for the new CLI. - posted by Armand Grillet <ag...@mesosphere.io> on 2018/10/22 10:31:23 UTC, 3 replies.
- Review Request 69048: Added tenacity to 'pip-requirements' for new CLI. - posted by Armand Grillet <ag...@mesosphere.io> on 2018/10/22 10:31:58 UTC, 1 replies.
- Review Request 69049: Added test for 'task exec'. - posted by Armand Grillet <ag...@mesosphere.io> on 2018/10/22 10:32:45 UTC, 6 replies.
- Re: Review Request 69075: Updated docker image fetcher to enforce HTTP 1.x. - posted by Till Toenshoff via Review Board <no...@reviews.apache.org> on 2018/10/22 11:22:37 UTC, 4 replies.
- Review Request 69115: Added test for interactive 'task exec'. - posted by Armand Grillet <ag...@mesosphere.io> on 2018/10/22 12:00:00 UTC, 5 replies.
- Review Request 69116: Added 'popen_tty' to test util functions for the new CLI. - posted by Armand Grillet <ag...@mesosphere.io> on 2018/10/22 12:23:46 UTC, 2 replies.
- Review Request 69119: Added new CLI constants 'TEST_DIRECTORY' and 'TEST_DATA_DIRECTORY'. - posted by Armand Grillet <ag...@mesosphere.io> on 2018/10/22 14:12:45 UTC, 1 replies.
- Re: Review Request 69075: Updated docker image fetcher to enforce HTTP 1.1. - posted by Till Toenshoff via Review Board <no...@reviews.apache.org> on 2018/10/22 16:22:17 UTC, 1 replies.
- Re: Review Request 68016: Added libseccomp to the build. - posted by Andrei Budnik <ab...@mesosphere.com> on 2018/10/22 17:04:06 UTC, 0 replies.
- Re: Review Request 68019: Added a parser for the Docker Seccomp config format. - posted by Andrei Budnik <ab...@mesosphere.com> on 2018/10/22 17:04:44 UTC, 0 replies.
- Re: Review Request 68018: Added `SeccompFilter` class. - posted by James Peach <jp...@apache.org> on 2018/10/22 17:15:34 UTC, 0 replies.
- Re: Review Request 68017: Added Seccomp-related protobuf messages. - posted by James Peach <jp...@apache.org> on 2018/10/22 17:18:54 UTC, 0 replies.
- Re: Review Request 69075: Updated docker image fetcher to enforce HTTP 1.1 where needed. - posted by Mesos Reviewbot Windows <re...@mesos.apache.org> on 2018/10/22 17:21:43 UTC, 0 replies.
- Re: Review Request 68022: Enabled Seccomp filter in the containerizer launcher. - posted by Mesos Reviewbot Windows <re...@mesos.apache.org> on 2018/10/22 17:23:46 UTC, 1 replies.
- Re: Review Request 69036: WIP: Changed the semantics of `CREATE_DISK` and `DESTROY_DISK` operations. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/10/23 02:37:33 UTC, 4 replies.
- Review Request 69123: Fixed an early fd close in the cgroups event notifier. - posted by Benjamin Mahler <bm...@apache.org> on 2018/10/23 03:08:18 UTC, 14 replies.
- Review Request 69132: Used mount(8) to make XFS loop device mounts. - posted by James Peach <jp...@apache.org> on 2018/10/23 23:17:18 UTC, 5 replies.
- Review Request 69138: Updated 'CLI_FILES' in 'cli_new/CmakeLists.txt'. - posted by Armand Grillet <ag...@mesosphere.io> on 2018/10/24 09:30:17 UTC, 2 replies.
- Review Request 69140: Allowed for unbundled libarchive on cmake builds. - posted by Till Toenshoff via Review Board <no...@reviews.apache.org> on 2018/10/24 12:25:51 UTC, 9 replies.
- Re: Review Request 68812: Added example framework for inverse-offers. - posted by Alexander Rukletsov <ru...@gmail.com> on 2018/10/24 15:43:25 UTC, 3 replies.
- Review Request 69082: Correctly propagated `close` failures in some instances. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/10/24 20:22:24 UTC, 1 replies.
- Review Request 69146: Made fetcher tests more robust by using the test sandbox. - posted by Meng Zhu <mz...@mesosphere.io> on 2018/10/24 22:23:54 UTC, 16 replies.
- Review Request 69149: Automatically remounted read-only bind mounts. - posted by James Peach <jp...@apache.org> on 2018/10/24 23:49:17 UTC, 4 replies.
- [GitHub] watermeion opened a new pull request #315: fix Disarding a Future -> Discarding a Future - posted by GitBox <gi...@apache.org> on 2018/10/25 07:22:45 UTC, 0 replies.
- Review Request 69157: Fixed handling for offer operation updates. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/10/25 10:47:23 UTC, 0 replies.
- Review Request 69158: Added an integration test for resource provider removal. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/10/25 10:47:24 UTC, 1 replies.
- Review Request 69159: Used an alias for reoccuring complicated type. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/10/25 10:54:29 UTC, 1 replies.
- Review Request 69160: Included corresponding header file first. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/10/25 10:54:31 UTC, 2 replies.
- Review Request 69161: Renamed a function argument to not reuse member name. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/10/25 10:54:33 UTC, 0 replies.
- Review Request 69162: Added agent and resource provider IDs to operation status messages. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/10/25 10:54:38 UTC, 2 replies.
- Review Request 69163: Set agent and/or resource provider ID in operation status updates. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/10/25 10:54:39 UTC, 5 replies.
- [GitHub] asfgit closed pull request #315: fix Disarding a Future -> Discarding a Future - posted by GitBox <gi...@apache.org> on 2018/10/25 16:00:19 UTC, 0 replies.
- Review Request 69171: Added validation of cache files to the URI Fetcher. - posted by Andrei Budnik <ab...@mesosphere.com> on 2018/10/25 20:47:31 UTC, 3 replies.
- Review Request 69172: Added `FetcherCacheTest.LocalCachedMissing` test. - posted by Andrei Budnik <ab...@mesosphere.com> on 2018/10/25 20:47:36 UTC, 3 replies.
- Review Request 69178: Fixed test `MasterTestPrePostReservationRefinement.LaunchGroup`. - posted by Meng Zhu <mz...@mesosphere.io> on 2018/10/25 23:11:05 UTC, 5 replies.
- Review Request 69176: Fixed flaky test `SchedulerHttpApiTest.UpdatePidToHttpScheduler`. - posted by Meng Zhu <mz...@mesosphere.io> on 2018/10/25 23:11:59 UTC, 3 replies.
- Review Request 69180: Enabled streaming requests on the master /api/v1 endpoint. - posted by Joseph Wu <jo...@mesosphere.io> on 2018/10/26 00:51:34 UTC, 1 replies.
- Review Request 69181: Passed streaming decoder from master /api/v1 to master actor. - posted by Joseph Wu <jo...@mesosphere.io> on 2018/10/26 00:53:55 UTC, 0 replies.
- Review Request 69182: Moved Master::Subscribers::Subscriber constructor into .cpp file. - posted by Joseph Wu <jo...@mesosphere.io> on 2018/10/26 00:54:33 UTC, 0 replies.
- Review Request 69183: Added optional heartbeat monitoring to the master /api/v1. - posted by Joseph Wu <jo...@mesosphere.io> on 2018/10/26 00:55:48 UTC, 0 replies.
- Review Request 69184: Marked internal::recordio::Reader as non-copyable/assignable. - posted by Joseph Wu <jo...@mesosphere.io> on 2018/10/26 00:56:09 UTC, 0 replies.
- Review Request 69185: Added streaming header support for /api/v1 SUBSCRIBE. - posted by Joseph Wu <jo...@mesosphere.io> on 2018/10/26 00:56:27 UTC, 2 replies.
- Review Request 69188: Fixed a wrong way to install callback for OOM notifier. - posted by Qian Zhang <zh...@gmail.com> on 2018/10/26 03:26:43 UTC, 2 replies.
- Review Request 69193: Added filters info to the `DECLINE` call log message. - posted by Meng Zhu <mz...@mesosphere.io> on 2018/10/26 17:42:24 UTC, 2 replies.
- Review Request 69186: Added tests for master SUBSCRIBE heartbeating. - posted by Joseph Wu <jo...@mesosphere.io> on 2018/10/26 21:57:27 UTC, 1 replies.
- Review Request 69194: Fixed test `MesosContainerizerSlaveRecoveryTest.ResourceStatistics`. - posted by Meng Zhu <mz...@mesosphere.io> on 2018/10/26 22:34:51 UTC, 2 replies.
- Re: Review Request 69188: Ensured failed / discarded cgroups OOM notification is logged. - posted by Qian Zhang <zh...@gmail.com> on 2018/10/29 04:11:25 UTC, 4 replies.
- Review Request 69203: Fixed LongLivedDefaultExecutorRestart GC test. - posted by Joseph Wu <jo...@mesosphere.io> on 2018/10/29 19:16:21 UTC, 4 replies.
- Review Request 69205: Fixed FetcherTest.DuplicateFileURI on OSX. - posted by Joseph Wu <jo...@mesosphere.io> on 2018/10/29 23:02:08 UTC, 3 replies.
- Review Request 69211: Improved the code comments for `getContainerDevicesPath`. - posted by James Peach <jp...@apache.org> on 2018/10/29 23:55:19 UTC, 4 replies.
- Review Request 69210: Used the MS_SILENT mount flag to elide unwanted logging. - posted by James Peach <jp...@apache.org> on 2018/10/29 23:55:44 UTC, 2 replies.
- Re: Review Request 69086: Moved container root construction to the isolators. - posted by James Peach <jp...@apache.org> on 2018/10/29 23:59:21 UTC, 1 replies.
- Review Request 69206: Added return value to new Mesos CLI commands. - posted by Armand Grillet <ag...@mesosphere.io> on 2018/10/30 00:51:04 UTC, 0 replies.
- Review Request 69207: Moved 'updated_tasks()' to new CLI tests base. - posted by Armand Grillet <ag...@mesosphere.io> on 2018/10/30 00:53:58 UTC, 0 replies.
- Review Request 69208: Updated new CLI task attach/exec exit strategy. - posted by Armand Grillet <ag...@mesosphere.io> on 2018/10/30 00:55:10 UTC, 1 replies.
- Review Request 69214: Mounted devpts with `gid=5` by default. - posted by James Peach <jp...@apache.org> on 2018/10/30 16:46:29 UTC, 6 replies.
- Review Request 69216: Added small style fix-ups for libevent unbundling on CMake builds. - posted by Till Toenshoff via Review Board <no...@reviews.apache.org> on 2018/10/30 20:19:54 UTC, 3 replies.
- Re: Review Request 69085: Stout: Added a sync option for `mkdir`. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/10/30 21:07:46 UTC, 0 replies.
- Review Request 69217: Fixed compile errors on clang 3.5. - posted by Andrei Budnik <ab...@mesosphere.com> on 2018/10/30 21:15:08 UTC, 2 replies.
- Review Request 69218: Fixed flaky `CgroupsIsolatorTest.ROOT_CGROUPS_CreateRecursively` test. - posted by Andrei Budnik <ab...@mesosphere.com> on 2018/10/30 22:02:20 UTC, 2 replies.
- Re: Review Request 68806: Fixed outdated comments for mocking the secret generator. - posted by Meng Zhu <mz...@mesosphere.io> on 2018/10/31 18:24:09 UTC, 0 replies.