You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by James Peach <jp...@apache.org> on 2018/10/29 23:55:19 UTC
Review Request 69211: Improved the code comments for
`getContainerDevicesPath`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69211/
-----------------------------------------------------------
Review request for mesos, Gilbert Song, Jason Lai, Jie Yu, and Jiang Yan Xu.
Bugs: MESOS-9319
https://issues.apache.org/jira/browse/MESOS-9319
Repository: mesos
Description
-------
Improved the code comments for `getContainerDevicesPath`.
Diffs
-----
src/slave/containerizer/mesos/paths.hpp de3981db7eb08e53901547037c947f594c8d46ab
Diff: https://reviews.apache.org/r/69211/diff/1/
Testing
-------
make check (Fedora 28)
Thanks,
James Peach
Re: Review Request 69211: Improved the code comments for
`getContainerDevicesPath`.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69211/#review210161
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['69086', '69210', '69211']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2547/mesos-review-69211
Relevant logs:
- [mesos-tests.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2547/mesos-review-69211/logs/mesos-tests.log):
```
W1030 01:41:28.595633 25880 slave.cpp:3923] Ignoring shutdown framework 837dc3d5-5be6-4530-b713-958210ceee5a-0000 because it is terminating
I1030 01:41:28.598637 22812 master.cpp:1273] Agent 837dc3d5-5be6-4530-b713-958210ceee5a-S0 at slave(461)@192.10.1.5:63554 (windows-02.aa0q4n2kgcyefckmv0xukjvy4f.xx.internal.cloudapp.net) disconnected
I1030 01:41:28.598637 22812 master.cpp:3289] Disconnecting agent 837dc3d5-5be6-4530-b713-958210ceee5a-S0 at slave(461)@192.10.1.5:63554 (windows-02.aa0q4n2kgcyefckmv0xukjvy4f.xx.internal.cloudapp.net)
I1030 01:41:28.598637 22812 master.cpp:3308] Deactivating agent 837dc3d5-5be6-4530-b713-958210ceee5a-S0 at slave(461)@192.10.1.5:63554 (windows-02.aa0q4n2kgcyefckmv0xukjvy4f.xx.internal.cloudapp.net)
I1030 01:41:28.599632 13408 hierarchical.cpp:357] Removed framework 837dc3d5-5be6-4530-b713-958210ceee5a-0000
I1030 01:41:28.599632 13408 hierarchical.cpp:801] Agent 837dc3d5-5be6-4530-b713-958210ceee5a-S0 deactivated
I1030 01:41:28.600651 21944 containerizer.cpp:2455] Destroying container ce965e82-8bd1-4faf-8ca2-0ad5190d25ce in RUNNING state
I1030 01:41:28.600651 21944 containerizer.cpp:3122] Transitioning the state of container ce965e82-8bd1-4faf-8ca2-0ad5190d25ce from RUNNING to DESTROYING
I1030 01:41:28.601649 21944 launcher.cpp:166] Asked to destroy container ce965e82-8bd1-4faf-8ca2-0ad5190d25ce
W1030 01:41:28.602648 23616 process.cpp:1423] Failed to recv on socket WindowsFD::Type::SOCKET=6104 to peer '192.10.1.5:65333': IO failed with error code: The specified network na[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (585 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (603 ms total)
[----------] Global test environment tear-down
[==========] 1052 tests from 103 test cases ran. (486701 ms total)
[ PASSED ] 1051 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] DockerFetcherPluginTest.INTERNET_CURL_FetchImage
1 FAILED TEST
YOU HAVE 232 DISABLED TESTS
me is no longer available.
W1030 01:41:28.603646 23616 process.cpp:838] Failed to recv on socket WindowsFD::Type::SOCKET=3324 to peer '192.10.1.5:65334': IO failed with error code: The specified network name is no longer available.
I1030 01:41:28.614650 13408 containerizer.cpp:2961] Container ce965e82-8bd1-4faf-8ca2-0ad5190d25ce has exited
I1030 01:41:28.648653 25880 master.cpp:1115] Master terminating
I1030 01:41:28.650632 21944 hierarchical.cpp:643] Removed agent 837dc3d5-5be6-4530-b713-958210ceee5a-S0
I1030 01:41:29.068639 23616 process.cpp:927] Stopped the socket accept loop
```
- Mesos Reviewbot Windows
On Oct. 29, 2018, 11:55 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69211/
> -----------------------------------------------------------
>
> (Updated Oct. 29, 2018, 11:55 p.m.)
>
>
> Review request for mesos, Gilbert Song, Jason Lai, Jie Yu, and Jiang Yan Xu.
>
>
> Bugs: MESOS-9319
> https://issues.apache.org/jira/browse/MESOS-9319
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Improved the code comments for `getContainerDevicesPath`.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/paths.hpp de3981db7eb08e53901547037c947f594c8d46ab
>
>
> Diff: https://reviews.apache.org/r/69211/diff/2/
>
>
> Testing
> -------
>
> make check (Fedora 28)
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 69211: Improved the code comments for
`getContainerDevicesPath`.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69211/
-----------------------------------------------------------
(Updated Oct. 30, 2018, 9:03 p.m.)
Review request for .
Bugs: MESOS-9319
https://issues.apache.org/jira/browse/MESOS-9319
Repository: mesos
Description
-------
Improved the code comments for `getContainerDevicesPath`.
Diffs (updated)
-----
src/slave/containerizer/mesos/paths.hpp de3981db7eb08e53901547037c947f594c8d46ab
Diff: https://reviews.apache.org/r/69211/diff/3/
Changes: https://reviews.apache.org/r/69211/diff/2-3/
Testing
-------
make check (Fedora 28)
Thanks,
James Peach
Re: Review Request 69211: Improved the code comments for
`getContainerDevicesPath`.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69211/#review210309
-----------------------------------------------------------
PASS: Mesos patch 69211 was successfully built and tested.
Reviews applied: `['69086', '69210', '69211']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2570/mesos-review-69211
- Mesos Reviewbot Windows
On Oct. 30, 2018, 9:04 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69211/
> -----------------------------------------------------------
>
> (Updated Oct. 30, 2018, 9:04 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-9319
> https://issues.apache.org/jira/browse/MESOS-9319
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Improved the code comments for `getContainerDevicesPath`.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/paths.hpp de3981db7eb08e53901547037c947f594c8d46ab
>
>
> Diff: https://reviews.apache.org/r/69211/diff/4/
>
>
> Testing
> -------
>
> make check (Fedora 28)
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 69211: Improved the code comments for
`getContainerDevicesPath`.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69211/#review210422
-----------------------------------------------------------
Bad review!
Reviews applied: []
Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.
- Mesos Reviewbot
On Oct. 30, 2018, 2:04 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69211/
> -----------------------------------------------------------
>
> (Updated Oct. 30, 2018, 2:04 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-9319
> https://issues.apache.org/jira/browse/MESOS-9319
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Improved the code comments for `getContainerDevicesPath`.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/paths.hpp de3981db7eb08e53901547037c947f594c8d46ab
>
>
> Diff: https://reviews.apache.org/r/69211/diff/6/
>
>
> Testing
> -------
>
> make check (Fedora 28)
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 69211: Improved the code comments for
`getContainerDevicesPath`.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69211/#review210882
-----------------------------------------------------------
PASS: Mesos patch 69211 was successfully built and tested.
Reviews applied: `['69086', '69210', '69450', '69211']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2651/mesos-review-69211
- Mesos Reviewbot Windows
On Nov. 17, 2018, 12:50 a.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69211/
> -----------------------------------------------------------
>
> (Updated Nov. 17, 2018, 12:50 a.m.)
>
>
> Review request for mesos, Gilbert Song, Jason Lai, Jie Yu, and Jiang Yan Xu.
>
>
> Bugs: MESOS-9319
> https://issues.apache.org/jira/browse/MESOS-9319
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Improved the code comments for `getContainerDevicesPath`.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/paths.hpp de3981db7eb08e53901547037c947f594c8d46ab
>
>
> Diff: https://reviews.apache.org/r/69211/diff/9/
>
>
> Testing
> -------
>
> make check (Fedora 28)
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 69211: Improved the code comments for
`getContainerDevicesPath`.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69211/#review211025
-----------------------------------------------------------
PASS: Mesos patch 69211 was successfully built and tested.
Reviews applied: `['69086', '69210', '69450', '69211']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2668/mesos-review-69211
- Mesos Reviewbot Windows
On Dec. 4, 2018, 1:19 a.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69211/
> -----------------------------------------------------------
>
> (Updated Dec. 4, 2018, 1:19 a.m.)
>
>
> Review request for mesos, Gilbert Song, Jason Lai, Jie Yu, and Jiang Yan Xu.
>
>
> Bugs: MESOS-9319
> https://issues.apache.org/jira/browse/MESOS-9319
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Improved the code comments for `getContainerDevicesPath`.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/paths.hpp de3981db7eb08e53901547037c947f594c8d46ab
>
>
> Diff: https://reviews.apache.org/r/69211/diff/11/
>
>
> Testing
> -------
>
> make check (Fedora 28)
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 69211: Improved the code comments for
`getContainerDevicesPath`.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69211/#review211008
-----------------------------------------------------------
PASS: Mesos patch 69211 was successfully built and tested.
Reviews applied: `['69086', '69210', '69450', '69211']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2667/mesos-review-69211
- Mesos Reviewbot Windows
On Dec. 4, 2018, 9:19 a.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69211/
> -----------------------------------------------------------
>
> (Updated Dec. 4, 2018, 9:19 a.m.)
>
>
> Review request for mesos, Gilbert Song, Jason Lai, Jie Yu, and Jiang Yan Xu.
>
>
> Bugs: MESOS-9319
> https://issues.apache.org/jira/browse/MESOS-9319
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Improved the code comments for `getContainerDevicesPath`.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/paths.hpp de3981db7eb08e53901547037c947f594c8d46ab
>
>
> Diff: https://reviews.apache.org/r/69211/diff/10/
>
>
> Testing
> -------
>
> make check (Fedora 28)
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 69211: Improved the code comments for
`getContainerDevicesPath`.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69211/#review211015
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Dec. 4, 2018, 1:19 a.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69211/
> -----------------------------------------------------------
>
> (Updated Dec. 4, 2018, 1:19 a.m.)
>
>
> Review request for mesos, Gilbert Song, Jason Lai, Jie Yu, and Jiang Yan Xu.
>
>
> Bugs: MESOS-9319
> https://issues.apache.org/jira/browse/MESOS-9319
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Improved the code comments for `getContainerDevicesPath`.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/paths.hpp de3981db7eb08e53901547037c947f594c8d46ab
>
>
> Diff: https://reviews.apache.org/r/69211/diff/10/
>
>
> Testing
> -------
>
> make check (Fedora 28)
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 69211: Improved the code comments for
`getContainerDevicesPath`.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69211/
-----------------------------------------------------------
(Updated Dec. 4, 2018, 1:19 a.m.)
Review request for mesos, Gilbert Song, Jason Lai, Jie Yu, and Jiang Yan Xu.
Bugs: MESOS-9319
https://issues.apache.org/jira/browse/MESOS-9319
Repository: mesos
Description
-------
Improved the code comments for `getContainerDevicesPath`.
Diffs (updated)
-----
src/slave/containerizer/mesos/paths.hpp de3981db7eb08e53901547037c947f594c8d46ab
Diff: https://reviews.apache.org/r/69211/diff/10/
Changes: https://reviews.apache.org/r/69211/diff/9-10/
Testing
-------
make check (Fedora 28)
Thanks,
James Peach
Re: Review Request 69211: Improved the code comments for
`getContainerDevicesPath`.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69211/#review210618
-----------------------------------------------------------
PASS: Mesos patch 69211 was successfully built and tested.
Reviews applied: `['69086', '69210', '69211']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2610/mesos-review-69211
- Mesos Reviewbot Windows
On Nov. 17, 2018, 1:50 a.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69211/
> -----------------------------------------------------------
>
> (Updated Nov. 17, 2018, 1:50 a.m.)
>
>
> Review request for mesos, Gilbert Song, Jason Lai, Jie Yu, and Jiang Yan Xu.
>
>
> Bugs: MESOS-9319
> https://issues.apache.org/jira/browse/MESOS-9319
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Improved the code comments for `getContainerDevicesPath`.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/paths.hpp de3981db7eb08e53901547037c947f594c8d46ab
>
>
> Diff: https://reviews.apache.org/r/69211/diff/8/
>
>
> Testing
> -------
>
> make check (Fedora 28)
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 69211: Improved the code comments for
`getContainerDevicesPath`.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69211/
-----------------------------------------------------------
(Updated Nov. 17, 2018, 12:50 a.m.)
Review request for mesos, Gilbert Song, Jason Lai, Jie Yu, and Jiang Yan Xu.
Bugs: MESOS-9319
https://issues.apache.org/jira/browse/MESOS-9319
Repository: mesos
Description
-------
Improved the code comments for `getContainerDevicesPath`.
Diffs (updated)
-----
src/slave/containerizer/mesos/paths.hpp de3981db7eb08e53901547037c947f594c8d46ab
Diff: https://reviews.apache.org/r/69211/diff/8/
Changes: https://reviews.apache.org/r/69211/diff/7-8/
Testing
-------
make check (Fedora 28)
Thanks,
James Peach
Re: Review Request 69211: Improved the code comments for
`getContainerDevicesPath`.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69211/#review210202
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['69211']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2554/mesos-review-69211
Relevant logs:
- [mesos-tests.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2554/mesos-review-69211/logs/mesos-tests.log):
```
W1031 00:09:07.553200 1264 slave.cpp:3923] Ignoring shutdown framework 90f4a26b-1977-408b-854a-1c148cf36d42-0000 because it is terminating
I1031 00:09:07.556200 7940 master.cpp:1273] Agent 90f4a26b-1977-408b-854a-1c148cf36d42-S0 at slave(461)@192.10.1.5:58231 (windows-02.aa0q4n2kgcyefckmv0xukjvy4f.xx.internal.cloudapp.net) disconnected
I1031 00:09:07.556200 7940 master.cpp:3289] Disconnecting agent 90f4a26b-1977-408b-854a-1c148cf36d42-S0 at slave(461)@192.10.1.5:58231 (windows-02.aa0q4n2kgcyefckmv0xukjvy4f.xx.internal.cloudapp.net)
I1031 00:09:07.556200 7940 master.cpp:3308] Deactivating agent 90f4a26b-1977-408b-854a-1c148cf36d42-S0 at slave(461)@192.10.1.5:58231 (windows-02.aa0q4n2kgcyefckmv0xukjvy4f.xx.internal.cloudapp.net)
I1031 00:09:07.557366 7344 hierarchical.cpp:357] Removed framework 90f4a26b-1977-408b-854a-1c148cf36d42-0000
I1031 00:09:07.557366 7344 hierarchical.cpp:801] Agent 90f4a26b-1977-408b-854a-1c148cf36d42-S0 deactivated
I1031 00:09:07.557366 1144 containerizer.cpp:2455] Destroying container 2447ce4b-7fec-4d82-9dbd-80e37f9be731 in RUNNING state
I1031 00:09:07.557366 1144 containerizer.cpp:3122] Transitioning the state of container 2447ce4b-7fec-4d82-9dbd-80e37f9be731 from RUNNING to DESTROYING
I1031 00:09:07.558208 1144 launcher.cpp:166] Asked to destroy container 2447ce4b-7fec-4d82-9dbd-80e37f9be731
W1031 00:09:07.559250 6312 process.cpp:1423] Failed to recv on so[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (677 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (696 ms total)
[----------] Global test environment tear-down
[==========] 1053 tests from 103 test cases ran. (491670 ms total)
[ PASSED ] 1052 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] DockerFetcherPluginTest.INTERNET_CURL_FetchBlob
1 FAILED TEST
YOU HAVE 231 DISABLED TESTS
cket WindowsFD::Type::SOCKET=5896 to peer '192.10.1.5:60023': IO failed with error code: The specified network name is no longer available.
W1031 00:09:07.559250 6312 process.cpp:838] Failed to recv on socket WindowsFD::Type::SOCKET=5720 to peer '192.10.1.5:60024': IO failed with error code: The specified network name is no longer available.
I1031 00:09:07.644536 1264 containerizer.cpp:2961] Container 2447ce4b-7fec-4d82-9dbd-80e37f9be731 has exited
I1031 00:09:07.672202 8528 master.cpp:1115] Master terminating
I1031 00:09:07.673211 7344 hierarchical.cpp:643] Removed agent 90f4a26b-1977-408b-854a-1c148cf36d42-S0
I1031 00:09:07.943238 6312 process.cpp:927] Stopped the socket accept loop
```
- Mesos Reviewbot Windows
On Oct. 30, 2018, 9:04 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69211/
> -----------------------------------------------------------
>
> (Updated Oct. 30, 2018, 9:04 p.m.)
>
>
> Review request for .
>
>
> Bugs: MESOS-9319
> https://issues.apache.org/jira/browse/MESOS-9319
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Improved the code comments for `getContainerDevicesPath`.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/paths.hpp de3981db7eb08e53901547037c947f594c8d46ab
>
>
> Diff: https://reviews.apache.org/r/69211/diff/3/
>
>
> Testing
> -------
>
> make check (Fedora 28)
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 69211: Improved the code comments for
`getContainerDevicesPath`.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69211/#review210429
-----------------------------------------------------------
PASS: Mesos patch 69211 was successfully built and tested.
Reviews applied: `['69086', '69210', '69211']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2587/mesos-review-69211
- Mesos Reviewbot Windows
On Oct. 30, 2018, 9:04 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69211/
> -----------------------------------------------------------
>
> (Updated Oct. 30, 2018, 9:04 p.m.)
>
>
> Review request for mesos, Gilbert Song, Jason Lai, Jie Yu, and Jiang Yan Xu.
>
>
> Bugs: MESOS-9319
> https://issues.apache.org/jira/browse/MESOS-9319
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Improved the code comments for `getContainerDevicesPath`.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/paths.hpp de3981db7eb08e53901547037c947f594c8d46ab
>
>
> Diff: https://reviews.apache.org/r/69211/diff/7/
>
>
> Testing
> -------
>
> make check (Fedora 28)
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 69211: Improved the code comments for
`getContainerDevicesPath`.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69211/#review210421
-----------------------------------------------------------
PASS: Mesos patch 69211 was successfully built and tested.
Reviews applied: `['69086', '69210', '69211']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2585/mesos-review-69211
- Mesos Reviewbot Windows
On Oct. 30, 2018, 9:04 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69211/
> -----------------------------------------------------------
>
> (Updated Oct. 30, 2018, 9:04 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-9319
> https://issues.apache.org/jira/browse/MESOS-9319
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Improved the code comments for `getContainerDevicesPath`.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/paths.hpp de3981db7eb08e53901547037c947f594c8d46ab
>
>
> Diff: https://reviews.apache.org/r/69211/diff/6/
>
>
> Testing
> -------
>
> make check (Fedora 28)
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 69211: Improved the code comments for
`getContainerDevicesPath`.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69211/#review210361
-----------------------------------------------------------
PASS: Mesos patch 69211 was successfully built and tested.
Reviews applied: `['69086', '69210', '69211']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2573/mesos-review-69211
- Mesos Reviewbot Windows
On Oct. 30, 2018, 2:04 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69211/
> -----------------------------------------------------------
>
> (Updated Oct. 30, 2018, 2:04 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-9319
> https://issues.apache.org/jira/browse/MESOS-9319
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Improved the code comments for `getContainerDevicesPath`.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/paths.hpp de3981db7eb08e53901547037c947f594c8d46ab
>
>
> Diff: https://reviews.apache.org/r/69211/diff/5/
>
>
> Testing
> -------
>
> make check (Fedora 28)
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 69211: Improved the code comments for
`getContainerDevicesPath`.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69211/#review210432
-----------------------------------------------------------
Patch looks great!
Reviews applied: [69086, 69210, 69211]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Oct. 30, 2018, 9:04 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69211/
> -----------------------------------------------------------
>
> (Updated Oct. 30, 2018, 9:04 p.m.)
>
>
> Review request for mesos, Gilbert Song, Jason Lai, Jie Yu, and Jiang Yan Xu.
>
>
> Bugs: MESOS-9319
> https://issues.apache.org/jira/browse/MESOS-9319
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Improved the code comments for `getContainerDevicesPath`.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/paths.hpp de3981db7eb08e53901547037c947f594c8d46ab
>
>
> Diff: https://reviews.apache.org/r/69211/diff/7/
>
>
> Testing
> -------
>
> make check (Fedora 28)
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 69211: Improved the code comments for
`getContainerDevicesPath`.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69211/
-----------------------------------------------------------
(Updated Oct. 30, 2018, 9:04 p.m.)
Review request for .
Bugs: MESOS-9319
https://issues.apache.org/jira/browse/MESOS-9319
Repository: mesos
Description
-------
Improved the code comments for `getContainerDevicesPath`.
Diffs (updated)
-----
src/slave/containerizer/mesos/paths.hpp de3981db7eb08e53901547037c947f594c8d46ab
Diff: https://reviews.apache.org/r/69211/diff/3/
Changes: https://reviews.apache.org/r/69211/diff/2-3/
Testing
-------
make check (Fedora 28)
Thanks,
James Peach