You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2018/10/04 05:26:41 UTC
Review Request 68924: Updated the Docker library to avoid
'os::killtree()'.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68924/
-----------------------------------------------------------
Review request for mesos, Gilbert Song and Jie Yu.
Bugs: MESOS-9283
https://issues.apache.org/jira/browse/MESOS-9283
Repository: mesos
Description
-------
This patch updates the Docker library to consistently use the
overload of `subprocess()` which runs its binary via `exec()`
rather than through a shell. This makes it safe to use
`os::kill()` rather than `os::killtree()` when discarding
these commands, which this patch also accomplishes.
Diffs
-----
src/docker/docker.cpp fb39f7480045c225096e07d7d55cd3aa7b870bc5
Diff: https://reviews.apache.org/r/68924/diff/1/
Testing
-------
`sudo bin/mesos-tests.sh --gtest_filter="*DOCKER*"`
Thanks,
Greg Mann
Re: Review Request 68924: Updated the Docker library to avoid
'os::killtree()'.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68924/#review209233
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Oct. 4, 2018, 5:26 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68924/
> -----------------------------------------------------------
>
> (Updated Oct. 4, 2018, 5:26 a.m.)
>
>
> Review request for mesos, Gilbert Song and Jie Yu.
>
>
> Bugs: MESOS-9283
> https://issues.apache.org/jira/browse/MESOS-9283
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch updates the Docker library to consistently use the
> overload of `subprocess()` which runs its binary via `exec()`
> rather than through a shell. This makes it safe to use
> `os::kill()` rather than `os::killtree()` when discarding
> these commands, which this patch also accomplishes.
>
>
> Diffs
> -----
>
> src/docker/docker.cpp fb39f7480045c225096e07d7d55cd3aa7b870bc5
>
>
> Diff: https://reviews.apache.org/r/68924/diff/1/
>
>
> Testing
> -------
>
> `sudo bin/mesos-tests.sh --gtest_filter="*DOCKER*"`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 68924: Updated the Docker library to avoid
'os::killtree()'.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68924/
-----------------------------------------------------------
(Updated Oct. 4, 2018, 10:14 p.m.)
Review request for mesos, Gilbert Song and Jie Yu.
Bugs: MESOS-9283
https://issues.apache.org/jira/browse/MESOS-9283
Repository: mesos
Description
-------
This patch updates the Docker library to consistently use the
overload of `subprocess()` which runs its binary via `exec()`
rather than through a shell. This makes it safe to use
`os::kill()` rather than `os::killtree()` when discarding
these commands, which this patch also accomplishes.
Diffs
-----
src/docker/docker.cpp fb39f7480045c225096e07d7d55cd3aa7b870bc5
Diff: https://reviews.apache.org/r/68924/diff/1/
Testing
-------
`sudo bin/mesos-tests.sh --gtest_filter="*DOCKER*"`
Thanks,
Greg Mann
Re: Review Request 68924: Updated the Docker library to avoid
'os::killtree()'.
Posted by Greg Mann <gr...@mesosphere.io>.
> On Oct. 4, 2018, 6:25 a.m., Mesos Reviewbot Windows wrote:
> > FAIL: Some of the unit tests failed. Please check the relevant logs.
> >
> > Reviews applied: `['68923', '68924']`
> >
> > Failed command: `Start-MesosCITesting`
> >
> > All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2418/mesos-review-68924
> >
> > Relevant logs:
> >
> > - [mesos-tests.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2418/mesos-review-68924/logs/mesos-tests.log):
> >
> > ```
> > I1004 06:25:30.318265 18864 executor.cpp:805] Shutting down
> > I1004 06:25:30.318265 18864 executor.cpp:918] Sending SIGTERM to process tree at pid 1106:25:30.315294 16068 slave.cpp:6640] Shutting down executor '4a510516-6cf6-475f-ad54-6e5202dee38a' of framework 455c5a23-b91c-4314-89df-13fed3c13608-0000 at executor(1)@192.10.1.5:50375
> > I1004 06:25:30.318265 19344 master.cpp:11030] Removing task 4a510516-6cf6-475f-ad54-6e5202dee38a with resources cpus(allocated: *):4; mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: *):[31000-32000] of framework 455c5a23-b91c-4314-89df-13fed3c13608-0000 on agent 455c5a23-b91c-4314-89df-13fed3c13608-S0 at slave(461)@192.10.1.5:64964 (windows-02.aa0q4n2kgcyefckmv0xukjvy4f.xx.internal.cloudapp.net)
> > I1004 06:25:30.318265 18956 slave.cpp:909] Agent terminating
> > W1004 06:25:30.318265 18956 slave.cpp:3917] Ignoring shutdown framework 455c5a23-b91c-4314-89df-13fed3c13608-0000 because it is terminating
> > I1004 06:25:30.320267 16328 master.cpp:1251] Agent 455c5a23-b91c-4314-89df-13fed3c13608-S0 at slave(461)@192.10.1.5:64964 (windows-02.aa0q4n2kgcyefckmv0xukjvy4f.xx.internal.cloudapp.net) disconnected
> > I1004 06:25:30.320267 16328 master.cpp:3267] Disconnecting agent 455c5a23-b91c-4314-89df-13fed3c13608-S0 at slave(461)@192.10.1.5:64964 (windows-02.aa0q4n2kgcyefckmv0xukjvy4f.xx.internal.cloudapp.net)
> > I1004 06:25:30.321262 16328 master.cpp:3286] Deactivating agent 455c5a23-b91c-4314-89df-13fed3c13608-S0 at slave(461)@192.10.1.5:64964 (windows-02.aa0q4n2kgcyefckmv0xukjvy4f.xx.internal.cloudapp.net)
> > I1004 06:25:30.321262 10404 hierarchical.cpp:359] Removed framework 455c5a23-b91c-4314-89df-13fed3c13608-0000
> > I1004 06:25:30.321262 10404 hierarchical.cpp:803] Agent 455c5a23-b91c-4314-89df-13fed3c13608-S0 deactivated
> > I1004 06:25:30.322278 10404 containerizer.cpp:2455] Destroying container 0b2a5b04-0cc8-455c-bc6e-3305a0ad3a7a in RUNNING state
> > I1004 06:25:30.322278 10404 containerizer.cpp:3122] Transitioning the state of container 0b2a5b04-0cc8-455c-bc6e-3305a0ad3a7a from RUNNING to DESTROYING
> > I1004 06:25:30.323292 10404 launcher.cpp:166] Asked to destroy container 0b2a5b04-0cc8-455c-bc6e-3305a0ad3a7a
> > I1004 06:25:30.366261 16328 contai[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (586 ms)
> > [----------] 1 test from IsolationFlag/MemoryIsolatorTest (604 ms total)
> >
> > [----------] Global test environment tear-down
> > [==========] 1051 tests from 103 test cases ran. (483700 ms total)
> > [ PASSED ] 1050 tests.
> > [ FAILED ] 1 test, listed below:
> > [ FAILED ] DockerFetcherPluginTest.INTERNET_CURL_FetchImage
> >
> > 1 FAILED TEST
> > YOU HAVE 232 DISABLED TESTS
> >
> > nerizer.cpp:2961] Container 0b2a5b04-0cc8-455c-bc6e-3305a0ad3a7a has exited
> > I1004 06:25:30.394275 18956 master.cpp:1093] Master terminating
> > I1004 06:25:30.396296 19016 hierarchical.cpp:645] Removed agent 455c5a23-b91c-4314-89df-13fed3c13608-S0
> > I1004 06:25:30.715306 8752 process.cpp:926] Stopped the socket accept loop
> > ```
Hmm... disconcerting that a Docker test failed on this chain, but I don't think it's related:
```
[ RUN ] DockerFetcherPluginTest.INTERNET_CURL_FetchImage
'hadoop' is not recognized as an internal or external command,
operable program or batch file.
d:\dcos\mesos\mesos\src\tests\uri_fetcher_tests.cpp(358): error: (fetcher.get()->fetch(uri, dir)).failure(): Collect failed: Unexpected 'curl' output:
d:\dcos\mesos\mesos\3rdparty\stout\include\stout\tests\utils.hpp(68): error: os::rmdir(sandbox.get()): The process cannot access the file because it is being used by another process.
[ FAILED ] DockerFetcherPluginTest.INTERNET_CURL_FetchImage (2415 ms)
```
- Greg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68924/#review209208
-----------------------------------------------------------
On Oct. 4, 2018, 5:26 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68924/
> -----------------------------------------------------------
>
> (Updated Oct. 4, 2018, 5:26 a.m.)
>
>
> Review request for mesos, Gilbert Song and Jie Yu.
>
>
> Bugs: MESOS-9283
> https://issues.apache.org/jira/browse/MESOS-9283
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch updates the Docker library to consistently use the
> overload of `subprocess()` which runs its binary via `exec()`
> rather than through a shell. This makes it safe to use
> `os::kill()` rather than `os::killtree()` when discarding
> these commands, which this patch also accomplishes.
>
>
> Diffs
> -----
>
> src/docker/docker.cpp fb39f7480045c225096e07d7d55cd3aa7b870bc5
>
>
> Diff: https://reviews.apache.org/r/68924/diff/1/
>
>
> Testing
> -------
>
> `sudo bin/mesos-tests.sh --gtest_filter="*DOCKER*"`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 68924: Updated the Docker library to avoid
'os::killtree()'.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68924/#review209208
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['68923', '68924']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2418/mesos-review-68924
Relevant logs:
- [mesos-tests.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2418/mesos-review-68924/logs/mesos-tests.log):
```
I1004 06:25:30.318265 18864 executor.cpp:805] Shutting down
I1004 06:25:30.318265 18864 executor.cpp:918] Sending SIGTERM to process tree at pid 1106:25:30.315294 16068 slave.cpp:6640] Shutting down executor '4a510516-6cf6-475f-ad54-6e5202dee38a' of framework 455c5a23-b91c-4314-89df-13fed3c13608-0000 at executor(1)@192.10.1.5:50375
I1004 06:25:30.318265 19344 master.cpp:11030] Removing task 4a510516-6cf6-475f-ad54-6e5202dee38a with resources cpus(allocated: *):4; mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: *):[31000-32000] of framework 455c5a23-b91c-4314-89df-13fed3c13608-0000 on agent 455c5a23-b91c-4314-89df-13fed3c13608-S0 at slave(461)@192.10.1.5:64964 (windows-02.aa0q4n2kgcyefckmv0xukjvy4f.xx.internal.cloudapp.net)
I1004 06:25:30.318265 18956 slave.cpp:909] Agent terminating
W1004 06:25:30.318265 18956 slave.cpp:3917] Ignoring shutdown framework 455c5a23-b91c-4314-89df-13fed3c13608-0000 because it is terminating
I1004 06:25:30.320267 16328 master.cpp:1251] Agent 455c5a23-b91c-4314-89df-13fed3c13608-S0 at slave(461)@192.10.1.5:64964 (windows-02.aa0q4n2kgcyefckmv0xukjvy4f.xx.internal.cloudapp.net) disconnected
I1004 06:25:30.320267 16328 master.cpp:3267] Disconnecting agent 455c5a23-b91c-4314-89df-13fed3c13608-S0 at slave(461)@192.10.1.5:64964 (windows-02.aa0q4n2kgcyefckmv0xukjvy4f.xx.internal.cloudapp.net)
I1004 06:25:30.321262 16328 master.cpp:3286] Deactivating agent 455c5a23-b91c-4314-89df-13fed3c13608-S0 at slave(461)@192.10.1.5:64964 (windows-02.aa0q4n2kgcyefckmv0xukjvy4f.xx.internal.cloudapp.net)
I1004 06:25:30.321262 10404 hierarchical.cpp:359] Removed framework 455c5a23-b91c-4314-89df-13fed3c13608-0000
I1004 06:25:30.321262 10404 hierarchical.cpp:803] Agent 455c5a23-b91c-4314-89df-13fed3c13608-S0 deactivated
I1004 06:25:30.322278 10404 containerizer.cpp:2455] Destroying container 0b2a5b04-0cc8-455c-bc6e-3305a0ad3a7a in RUNNING state
I1004 06:25:30.322278 10404 containerizer.cpp:3122] Transitioning the state of container 0b2a5b04-0cc8-455c-bc6e-3305a0ad3a7a from RUNNING to DESTROYING
I1004 06:25:30.323292 10404 launcher.cpp:166] Asked to destroy container 0b2a5b04-0cc8-455c-bc6e-3305a0ad3a7a
I1004 06:25:30.366261 16328 contai[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (586 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (604 ms total)
[----------] Global test environment tear-down
[==========] 1051 tests from 103 test cases ran. (483700 ms total)
[ PASSED ] 1050 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] DockerFetcherPluginTest.INTERNET_CURL_FetchImage
1 FAILED TEST
YOU HAVE 232 DISABLED TESTS
nerizer.cpp:2961] Container 0b2a5b04-0cc8-455c-bc6e-3305a0ad3a7a has exited
I1004 06:25:30.394275 18956 master.cpp:1093] Master terminating
I1004 06:25:30.396296 19016 hierarchical.cpp:645] Removed agent 455c5a23-b91c-4314-89df-13fed3c13608-S0
I1004 06:25:30.715306 8752 process.cpp:926] Stopped the socket accept loop
```
- Mesos Reviewbot Windows
On Oct. 4, 2018, 5:26 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68924/
> -----------------------------------------------------------
>
> (Updated Oct. 4, 2018, 5:26 a.m.)
>
>
> Review request for mesos, Gilbert Song and Jie Yu.
>
>
> Bugs: MESOS-9283
> https://issues.apache.org/jira/browse/MESOS-9283
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch updates the Docker library to consistently use the
> overload of `subprocess()` which runs its binary via `exec()`
> rather than through a shell. This makes it safe to use
> `os::kill()` rather than `os::killtree()` when discarding
> these commands, which this patch also accomplishes.
>
>
> Diffs
> -----
>
> src/docker/docker.cpp fb39f7480045c225096e07d7d55cd3aa7b870bc5
>
>
> Diff: https://reviews.apache.org/r/68924/diff/1/
>
>
> Testing
> -------
>
> `sudo bin/mesos-tests.sh --gtest_filter="*DOCKER*"`
>
>
> Thanks,
>
> Greg Mann
>
>