You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Mahler <bm...@apache.org> on 2018/10/21 23:40:08 UTC
Review Request 69109: Updated libprocess to log all socket errors
consistently.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69109/
-----------------------------------------------------------
Review request for mesos, Gastón Kleiman, Jie Yu, and Till Toenshoff.
Repository: mesos
Description
-------
Some of these errors were getting logged at VLOG(1), INFO, or
not at all. Notably, recv errors were either VLOG(1) or not
logged. Send errors were not logged.
Now, we log the socket fd, peer address, and error message at
the warning level whenever a socket error occurs.
Diffs
-----
3rdparty/libprocess/src/process.cpp fe89f557b763390fbb05b52b3ad18c4cc886e737
Diff: https://reviews.apache.org/r/69109/diff/1/
Testing
-------
make check
Thanks,
Benjamin Mahler
Re: Review Request 69109: Updated libprocess to log all socket errors
consistently.
Posted by Gastón Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69109/#review209993
-----------------------------------------------------------
Ship it!
Ship It!
- Gastón Kleiman
On Oct. 21, 2018, 4:40 p.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69109/
> -----------------------------------------------------------
>
> (Updated Oct. 21, 2018, 4:40 p.m.)
>
>
> Review request for mesos, Gastón Kleiman, Jie Yu, and Till Toenshoff.
>
>
> Bugs: MESOS-9340
> https://issues.apache.org/jira/browse/MESOS-9340
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Some of these errors were getting logged at VLOG(1), INFO, or
> not at all. Notably, recv errors were either VLOG(1) or not
> logged. Send errors were not logged.
>
> Now, we log the socket fd, peer address, and error message at
> the warning level whenever a socket error occurs.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/process.cpp fe89f557b763390fbb05b52b3ad18c4cc886e737
>
>
> Diff: https://reviews.apache.org/r/69109/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Mahler
>
>
Re: Review Request 69109: Updated libprocess to log all socket errors
consistently.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69109/#review209835
-----------------------------------------------------------
PASS: Mesos patch 69109 was successfully built and tested.
Reviews applied: `['69109']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2501/mesos-review-69109
- Mesos Reviewbot Windows
On Oct. 21, 2018, 11:40 p.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69109/
> -----------------------------------------------------------
>
> (Updated Oct. 21, 2018, 11:40 p.m.)
>
>
> Review request for mesos, Gastón Kleiman, Jie Yu, and Till Toenshoff.
>
>
> Bugs: MESOS-9340
> https://issues.apache.org/jira/browse/MESOS-9340
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Some of these errors were getting logged at VLOG(1), INFO, or
> not at all. Notably, recv errors were either VLOG(1) or not
> logged. Send errors were not logged.
>
> Now, we log the socket fd, peer address, and error message at
> the warning level whenever a socket error occurs.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/process.cpp fe89f557b763390fbb05b52b3ad18c4cc886e737
>
>
> Diff: https://reviews.apache.org/r/69109/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Mahler
>
>