You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Armand Grillet <ag...@mesosphere.io> on 2018/10/19 15:22:20 UTC
Review Request 69084: Updated 'Makefile.am' to make new CLI build
step more reliable.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69084/
-----------------------------------------------------------
Review request for mesos, Benjamin Bannier and Kevin Klues.
Repository: mesos
Description
-------
We list the files in 'MESOS_CLI_SRCDIR' when building the new CLI.
We were previously using 'find' and then removing the files in
the virtual environment but this is not enough as we now also
use tools like 'tox' which creates files we do not care about.
To filter more while simplifying the build step, we now use 'git
ls-files' to get a list of the files we need when building. Git
is a dependency of Apache Mesos and the files we have in the
repository are the only ones required to build the CLI,
making this solution simpler yet more future-proof.
Diffs
-----
src/Makefile.am 5795c7097a9ed1f659e169ad81a9f2c09481aa81
Diff: https://reviews.apache.org/r/69084/diff/1/
Testing
-------
```
$ ./bootstrap
$ mkdir build
$ cd build
$ ../configure --enable-new-cli --disable-java --disable-python
$ make check
$ ./src/mesos
Mesos CLI
...
```
Thanks,
Armand Grillet
Re: Review Request 69084: Updated 'Makefile.am' to make new CLI build
step more reliable.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69084/#review209789
-----------------------------------------------------------
PASS: Mesos patch 69084 was successfully built and tested.
Reviews applied: `['69084']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2490/mesos-review-69084
- Mesos Reviewbot Windows
On Oct. 19, 2018, 3:22 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69084/
> -----------------------------------------------------------
>
> (Updated Oct. 19, 2018, 3:22 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Kevin Klues.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> We list the files in 'MESOS_CLI_SRCDIR' when building the new CLI.
> We were previously using 'find' and then removing the files in
> the virtual environment but this is not enough as we now also
> use tools like 'tox' which creates files we do not care about.
>
> To filter more while simplifying the build step, we now use 'git
> ls-files' to get a list of the files we need when building. Git
> is a dependency of Apache Mesos and the files we have in the
> repository are the only ones required to build the CLI,
> making this solution simpler yet more future-proof.
>
>
> Diffs
> -----
>
> src/Makefile.am 5795c7097a9ed1f659e169ad81a9f2c09481aa81
>
>
> Diff: https://reviews.apache.org/r/69084/diff/1/
>
>
> Testing
> -------
>
> ```
> $ ./bootstrap
> $ mkdir build
> $ cd build
> $ ../configure --enable-new-cli --disable-java --disable-python
> $ make check
> $ ./src/mesos
> Mesos CLI
> ...
> ```
>
>
> Thanks,
>
> Armand Grillet
>
>