You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Armand Grillet <ag...@mesosphere.io> on 2018/10/09 09:37:18 UTC
Re: Review Request 66683: Updated address sanitization in new CLI to
accept DNS names.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66683/
-----------------------------------------------------------
(Updated Oct. 9, 2018, 11:37 a.m.)
Review request for mesos and Kevin Klues.
Summary (updated)
-----------------
Updated address sanitization in new CLI to accept DNS names.
Bugs: MESOS-8025
https://issues.apache.org/jira/browse/MESOS-8025
Repository: mesos
Description (updated)
-------
Updated address sanitization in new CLI to accept DNS names.
Diffs (updated)
-----
src/python/cli_new/lib/cli/config.py c88952b9f87f1cf558d7aef44803d7a24873d8bf
src/python/cli_new/lib/cli/http.py d1faac19cbe2b52ef941053ec6e2e52a1bfcd3db
src/python/cli_new/lib/cli/util.py e79268d57bc9be4514e8f087060ea971e9b09c3a
Diff: https://reviews.apache.org/r/66683/diff/5/
Changes: https://reviews.apache.org/r/66683/diff/4-5/
Testing
-------
Ran `mesos agent list` successfully with config:
```
[master]
address = "http://<address_of_a_remote_mesos_master>.com:5061"
```
On the server providing `http://<address_of_a_remote_mesos_master>.com` I had a Mesos master running with `bash mesos-master.sh --port='5061' --work_dir='/tmp/master1' --log_dir='/tmp/master1-log' --registry=in_memory`.
Also ran `mesos-cli-tests` successfully.
Thanks,
Armand Grillet
Re: Review Request 66683: Updated address sanitization in new CLI to
accept DNS names.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66683/#review209356
-----------------------------------------------------------
PASS: Mesos patch 66683 was successfully built and tested.
Reviews applied: `['66683']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2438/mesos-review-66683
- Mesos Reviewbot Windows
On Oct. 9, 2018, 5:37 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66683/
> -----------------------------------------------------------
>
> (Updated Oct. 9, 2018, 5:37 p.m.)
>
>
> Review request for mesos and Kevin Klues.
>
>
> Bugs: MESOS-8025
> https://issues.apache.org/jira/browse/MESOS-8025
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated address sanitization in new CLI to accept DNS names.
>
>
> Diffs
> -----
>
> src/python/cli_new/lib/cli/config.py c88952b9f87f1cf558d7aef44803d7a24873d8bf
> src/python/cli_new/lib/cli/http.py d1faac19cbe2b52ef941053ec6e2e52a1bfcd3db
> src/python/cli_new/lib/cli/util.py e79268d57bc9be4514e8f087060ea971e9b09c3a
>
>
> Diff: https://reviews.apache.org/r/66683/diff/5/
>
>
> Testing
> -------
>
> Ran `mesos agent list` successfully with config:
> ```
> [master]
> address = "http://<address_of_a_remote_mesos_master>.com:5061"
> ```
> On the server providing `http://<address_of_a_remote_mesos_master>.com` I had a Mesos master running with `bash mesos-master.sh --port='5061' --work_dir='/tmp/master1' --log_dir='/tmp/master1-log' --registry=in_memory`.
>
> Also ran `mesos-cli-tests` successfully.
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 66683: Updated address sanitization in new CLI to
accept DNS names.
Posted by Kevin Klues <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66683/#review209358
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Klues
On Okt. 9, 2018, 12:49 nachm., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66683/
> -----------------------------------------------------------
>
> (Updated Okt. 9, 2018, 12:49 nachm.)
>
>
> Review request for mesos and Kevin Klues.
>
>
> Bugs: MESOS-8025
> https://issues.apache.org/jira/browse/MESOS-8025
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated address sanitization in new CLI to accept DNS names.
>
>
> Diffs
> -----
>
> src/python/cli_new/lib/cli/config.py c88952b9f87f1cf558d7aef44803d7a24873d8bf
> src/python/cli_new/lib/cli/http.py d1faac19cbe2b52ef941053ec6e2e52a1bfcd3db
> src/python/cli_new/lib/cli/util.py e79268d57bc9be4514e8f087060ea971e9b09c3a
>
>
> Diff: https://reviews.apache.org/r/66683/diff/7/
>
>
> Testing
> -------
>
> Ran `mesos agent list` successfully with config:
> ```
> [master]
> address = "http://<address_of_a_remote_mesos_master>.com:5061"
> ```
> On the server providing `http://<address_of_a_remote_mesos_master>.com` I had a Mesos master running with `bash mesos-master.sh --port='5061' --work_dir='/tmp/master1' --log_dir='/tmp/master1-log' --registry=in_memory`.
>
> Also ran `mesos-cli-tests` successfully.
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 66683: Updated address sanitization in new CLI to
accept DNS names.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66683/#review209364
-----------------------------------------------------------
PASS: Mesos patch 66683 was successfully built and tested.
Reviews applied: `['66683']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2439/mesos-review-66683
- Mesos Reviewbot Windows
On Oct. 9, 2018, 12:49 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66683/
> -----------------------------------------------------------
>
> (Updated Oct. 9, 2018, 12:49 p.m.)
>
>
> Review request for mesos and Kevin Klues.
>
>
> Bugs: MESOS-8025
> https://issues.apache.org/jira/browse/MESOS-8025
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated address sanitization in new CLI to accept DNS names.
>
>
> Diffs
> -----
>
> src/python/cli_new/lib/cli/config.py c88952b9f87f1cf558d7aef44803d7a24873d8bf
> src/python/cli_new/lib/cli/http.py d1faac19cbe2b52ef941053ec6e2e52a1bfcd3db
> src/python/cli_new/lib/cli/util.py e79268d57bc9be4514e8f087060ea971e9b09c3a
>
>
> Diff: https://reviews.apache.org/r/66683/diff/7/
>
>
> Testing
> -------
>
> Ran `mesos agent list` successfully with config:
> ```
> [master]
> address = "http://<address_of_a_remote_mesos_master>.com:5061"
> ```
> On the server providing `http://<address_of_a_remote_mesos_master>.com` I had a Mesos master running with `bash mesos-master.sh --port='5061' --work_dir='/tmp/master1' --log_dir='/tmp/master1-log' --registry=in_memory`.
>
> Also ran `mesos-cli-tests` successfully.
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 66683: Updated address sanitization in new CLI to
accept DNS names.
Posted by Armand Grillet <ag...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66683/
-----------------------------------------------------------
(Updated Oct. 9, 2018, 2:49 p.m.)
Review request for mesos and Kevin Klues.
Changes
-------
Removed `master_address` variable and moved function.
Bugs: MESOS-8025
https://issues.apache.org/jira/browse/MESOS-8025
Repository: mesos
Description
-------
Updated address sanitization in new CLI to accept DNS names.
Diffs (updated)
-----
src/python/cli_new/lib/cli/config.py c88952b9f87f1cf558d7aef44803d7a24873d8bf
src/python/cli_new/lib/cli/http.py d1faac19cbe2b52ef941053ec6e2e52a1bfcd3db
src/python/cli_new/lib/cli/util.py e79268d57bc9be4514e8f087060ea971e9b09c3a
Diff: https://reviews.apache.org/r/66683/diff/7/
Changes: https://reviews.apache.org/r/66683/diff/6-7/
Testing
-------
Ran `mesos agent list` successfully with config:
```
[master]
address = "http://<address_of_a_remote_mesos_master>.com:5061"
```
On the server providing `http://<address_of_a_remote_mesos_master>.com` I had a Mesos master running with `bash mesos-master.sh --port='5061' --work_dir='/tmp/master1' --log_dir='/tmp/master1-log' --registry=in_memory`.
Also ran `mesos-cli-tests` successfully.
Thanks,
Armand Grillet
Re: Review Request 66683: Updated address sanitization in new CLI to
accept DNS names.
Posted by Armand Grillet <ag...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66683/
-----------------------------------------------------------
(Updated Oct. 9, 2018, 2:16 p.m.)
Review request for mesos and Kevin Klues.
Changes
-------
Published Kevin's review request.
Bugs: MESOS-8025
https://issues.apache.org/jira/browse/MESOS-8025
Repository: mesos
Description
-------
Updated address sanitization in new CLI to accept DNS names.
Diffs (updated)
-----
src/python/cli_new/lib/cli/config.py c88952b9f87f1cf558d7aef44803d7a24873d8bf
src/python/cli_new/lib/cli/http.py d1faac19cbe2b52ef941053ec6e2e52a1bfcd3db
src/python/cli_new/lib/cli/util.py e79268d57bc9be4514e8f087060ea971e9b09c3a
Diff: https://reviews.apache.org/r/66683/diff/6/
Changes: https://reviews.apache.org/r/66683/diff/5-6/
Testing
-------
Ran `mesos agent list` successfully with config:
```
[master]
address = "http://<address_of_a_remote_mesos_master>.com:5061"
```
On the server providing `http://<address_of_a_remote_mesos_master>.com` I had a Mesos master running with `bash mesos-master.sh --port='5061' --work_dir='/tmp/master1' --log_dir='/tmp/master1-log' --registry=in_memory`.
Also ran `mesos-cli-tests` successfully.
Thanks,
Armand Grillet