You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2018/10/03 15:12:01 UTC
Re: Review Request 68865: Put `TerminateEvent` at the end of the
queue in the Mesos library.
> On Sept. 27, 2018, 6:24 p.m., Vinod Kone wrote:
> > src/scheduler/scheduler.cpp
> > Line 1041 (original), 1041 (patched)
> > <https://reviews.apache.org/r/68865/diff/1/?file=2092452#file2092452line1041>
> >
> > Can you add a comment on why you are doing this for posterity?
+1
Could you also provide an explanation in the commit message?
- Greg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68865/#review209075
-----------------------------------------------------------
On Sept. 27, 2018, 5:41 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68865/
> -----------------------------------------------------------
>
> (Updated Sept. 27, 2018, 5:41 p.m.)
>
>
> Review request for mesos, Gastón Kleiman, Greg Mann, and Nicholas Parker.
>
>
> Bugs: MESOS-9274
> https://issues.apache.org/jira/browse/MESOS-9274
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/scheduler/scheduler.cpp 471152945d6af660c8983324b38702d872657f89
>
>
> Diff: https://reviews.apache.org/r/68865/diff/1/
>
>
> Testing
> -------
>
> See https://reviews.apache.org/r/68866/
>
>
> Thanks,
>
> Alexander Rukletsov
>
>