You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Armand Grillet <ag...@mesosphere.io> on 2018/10/30 00:55:10 UTC
Review Request 69208: Updated new CLI task attach/exec exit strategy.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69208/
-----------------------------------------------------------
Review request for mesos and Kevin Klues.
Bugs: MESOS-9363
https://issues.apache.org/jira/browse/MESOS-9363
Repository: mesos
Description
-------
Updated new CLI task attach/exec exit strategy.
Diffs
-----
src/python/cli_new/lib/cli/mesos.py 4a5777bf712c3e5fd20a2bfd6da8fb9f3975d120
src/python/cli_new/lib/cli/plugins/task/main.py 5866a23aa0c0dfe141fd8fbe4c9ccd04a2c13a08
src/python/cli_new/lib/cli/tests/task.py 4b03cf13185f1c718f24a990a75a4dd74e7e132a
Diff: https://reviews.apache.org/r/69208/diff/1/
Testing
-------
```
(mesos-cli) ? cli_new (exec-attach) ? mesos-cli-tests
Running the Mesos CLI unit tests
TestAgentPlugin
test_list (cli.tests.agent.TestAgentPlugin) ... ok
TestInfrastructure
test_capture_output (cli.tests.tests.TestInfrastructure) ... ok
test_launch_binaries (cli.tests.tests.TestInfrastructure) ... ok
TestTaskPlugin
test_exec (cli.tests.task.TestTaskPlugin) ... ok
test_exec_exit_status (cli.tests.task.TestTaskPlugin) ... ok
test_exec_interactive (cli.tests.task.TestTaskPlugin) ... ok
test_list (cli.tests.task.TestTaskPlugin) ... ok
----------------------------------------------------------------------
Ran 7 tests in 17.146s
OK
```
Thanks,
Armand Grillet
Re: Review Request 69208: Updated new CLI task attach/exec exit
strategy.
Posted by Kevin Klues <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69208/#review210308
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Klues
On Okt. 30, 2018, 12:55 vorm., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69208/
> -----------------------------------------------------------
>
> (Updated Okt. 30, 2018, 12:55 vorm.)
>
>
> Review request for mesos and Kevin Klues.
>
>
> Bugs: MESOS-9363
> https://issues.apache.org/jira/browse/MESOS-9363
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated new CLI task attach/exec exit strategy.
>
>
> Diffs
> -----
>
> src/python/cli_new/lib/cli/mesos.py 4a5777bf712c3e5fd20a2bfd6da8fb9f3975d120
> src/python/cli_new/lib/cli/plugins/task/main.py 5866a23aa0c0dfe141fd8fbe4c9ccd04a2c13a08
> src/python/cli_new/lib/cli/tests/task.py ce3a55d4b66ca74b6be892d058644281ee5c803d
>
>
> Diff: https://reviews.apache.org/r/69208/diff/2/
>
>
> Testing
> -------
>
> ```
> (mesos-cli) ? cli_new (exec-attach) ? mesos-cli-tests
> Running the Mesos CLI unit tests
>
> TestAgentPlugin
> test_list (cli.tests.agent.TestAgentPlugin) ... ok
>
> TestInfrastructure
> test_capture_output (cli.tests.tests.TestInfrastructure) ... ok
> test_launch_binaries (cli.tests.tests.TestInfrastructure) ... ok
>
> TestTaskPlugin
> test_exec (cli.tests.task.TestTaskPlugin) ... ok
> test_exec_exit_status (cli.tests.task.TestTaskPlugin) ... ok
> test_exec_interactive (cli.tests.task.TestTaskPlugin) ... ok
> test_list (cli.tests.task.TestTaskPlugin) ... ok
>
> ----------------------------------------------------------------------
> Ran 7 tests in 17.238s
>
> OK
> ```
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 69208: Updated new CLI task attach/exec exit
strategy.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69208/#review210162
-----------------------------------------------------------
FAIL: Failed to apply the dependent review: 69207.
Failed command: `python.exe .\support\apply-reviews.py -n -r 69207`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2548/mesos-review-69208
Relevant logs:
- [apply-review-69207.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2548/mesos-review-69208/logs/apply-review-69207.log):
```
error: patch failed: src/python/cli_new/lib/cli/tests/base.py:498
error: src/python/cli_new/lib/cli/tests/base.py: patch does not apply
error: patch failed: src/python/cli_new/lib/cli/tests/task.py:104
error: src/python/cli_new/lib/cli/tests/task.py: patch does not apply
```
- Mesos Reviewbot Windows
On Oct. 30, 2018, 1:55 a.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69208/
> -----------------------------------------------------------
>
> (Updated Oct. 30, 2018, 1:55 a.m.)
>
>
> Review request for mesos and Kevin Klues.
>
>
> Bugs: MESOS-9363
> https://issues.apache.org/jira/browse/MESOS-9363
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated new CLI task attach/exec exit strategy.
>
>
> Diffs
> -----
>
> src/python/cli_new/lib/cli/mesos.py 4a5777bf712c3e5fd20a2bfd6da8fb9f3975d120
> src/python/cli_new/lib/cli/plugins/task/main.py 5866a23aa0c0dfe141fd8fbe4c9ccd04a2c13a08
> src/python/cli_new/lib/cli/tests/task.py 4b03cf13185f1c718f24a990a75a4dd74e7e132a
>
>
> Diff: https://reviews.apache.org/r/69208/diff/1/
>
>
> Testing
> -------
>
> ```
> (mesos-cli) ? cli_new (exec-attach) ? mesos-cli-tests
> Running the Mesos CLI unit tests
>
> TestAgentPlugin
> test_list (cli.tests.agent.TestAgentPlugin) ... ok
>
> TestInfrastructure
> test_capture_output (cli.tests.tests.TestInfrastructure) ... ok
> test_launch_binaries (cli.tests.tests.TestInfrastructure) ... ok
>
> TestTaskPlugin
> test_exec (cli.tests.task.TestTaskPlugin) ... ok
> test_exec_exit_status (cli.tests.task.TestTaskPlugin) ... ok
> test_exec_interactive (cli.tests.task.TestTaskPlugin) ... ok
> test_list (cli.tests.task.TestTaskPlugin) ... ok
>
> ----------------------------------------------------------------------
> Ran 7 tests in 17.146s
>
> OK
> ```
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 69208: Updated new CLI task attach/exec exit
strategy.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69208/#review210307
-----------------------------------------------------------
PASS: Mesos patch 69208 was successfully built and tested.
Reviews applied: `['69206', '69208']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2569/mesos-review-69208
- Mesos Reviewbot Windows
On Oct. 30, 2018, 12:55 a.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69208/
> -----------------------------------------------------------
>
> (Updated Oct. 30, 2018, 12:55 a.m.)
>
>
> Review request for mesos and Kevin Klues.
>
>
> Bugs: MESOS-9363
> https://issues.apache.org/jira/browse/MESOS-9363
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated new CLI task attach/exec exit strategy.
>
>
> Diffs
> -----
>
> src/python/cli_new/lib/cli/mesos.py 4a5777bf712c3e5fd20a2bfd6da8fb9f3975d120
> src/python/cli_new/lib/cli/plugins/task/main.py 5866a23aa0c0dfe141fd8fbe4c9ccd04a2c13a08
> src/python/cli_new/lib/cli/tests/task.py ce3a55d4b66ca74b6be892d058644281ee5c803d
>
>
> Diff: https://reviews.apache.org/r/69208/diff/2/
>
>
> Testing
> -------
>
> ```
> (mesos-cli) ? cli_new (exec-attach) ? mesos-cli-tests
> Running the Mesos CLI unit tests
>
> TestAgentPlugin
> test_list (cli.tests.agent.TestAgentPlugin) ... ok
>
> TestInfrastructure
> test_capture_output (cli.tests.tests.TestInfrastructure) ... ok
> test_launch_binaries (cli.tests.tests.TestInfrastructure) ... ok
>
> TestTaskPlugin
> test_exec (cli.tests.task.TestTaskPlugin) ... ok
> test_exec_exit_status (cli.tests.task.TestTaskPlugin) ... ok
> test_exec_interactive (cli.tests.task.TestTaskPlugin) ... ok
> test_list (cli.tests.task.TestTaskPlugin) ... ok
>
> ----------------------------------------------------------------------
> Ran 7 tests in 17.238s
>
> OK
> ```
>
>
> Thanks,
>
> Armand Grillet
>
>