You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Meng Zhu <mz...@mesosphere.io> on 2018/10/25 23:11:59 UTC
Review Request 69176: Fixed flaky test
`SchedulerHttpApiTest.UpdatePidToHttpScheduler`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69176/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Bugs: MESOS-8343
https://issues.apache.org/jira/browse/MESOS-8343
Repository: mesos
Description
-------
The test was flaky due to race between scheduler driver stopping
during test teardown and the scheduler `error()` invocation.
Adding the missing synchronization for the expectation should
eliminate the race.
Diffs
-----
src/tests/scheduler_http_api_tests.cpp 64c000650acab30647d0c1e7d685bec954aa7118
Diff: https://reviews.apache.org/r/69176/diff/1/
Testing
-------
ran `chedulerHttpApiTest.UpdatePidToHttpScheduler` continously without failure.
Thanks,
Meng Zhu
Re: Review Request 69176: Fixed flaky test
`SchedulerHttpApiTest.UpdatePidToHttpScheduler`.
Posted by Meng Zhu <mz...@mesosphere.io>.
> On Oct. 26, 2018, 2:56 p.m., Joseph Wu wrote:
> > Good catch!
> >
> > Do you want to ship this (have your gotten your commit bits?), or shall I?
Thanks! I am still waiting for the account creation. If you can push this, that would be great!
- Meng
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69176/#review210110
-----------------------------------------------------------
On Oct. 25, 2018, 4:11 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69176/
> -----------------------------------------------------------
>
> (Updated Oct. 25, 2018, 4:11 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-8343
> https://issues.apache.org/jira/browse/MESOS-8343
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The test was flaky due to race between scheduler driver stopping
> during test teardown and the scheduler `error()` invocation.
> Adding the missing synchronization for the expectation should
> eliminate the race.
>
>
> Diffs
> -----
>
> src/tests/scheduler_http_api_tests.cpp 64c000650acab30647d0c1e7d685bec954aa7118
>
>
> Diff: https://reviews.apache.org/r/69176/diff/1/
>
>
> Testing
> -------
>
> ran `chedulerHttpApiTest.UpdatePidToHttpScheduler` continously without failure.
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 69176: Fixed flaky test
`SchedulerHttpApiTest.UpdatePidToHttpScheduler`.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69176/#review210110
-----------------------------------------------------------
Ship it!
Good catch!
Do you want to ship this (have your gotten your commit bits?), or shall I?
- Joseph Wu
On Oct. 25, 2018, 4:11 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69176/
> -----------------------------------------------------------
>
> (Updated Oct. 25, 2018, 4:11 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-8343
> https://issues.apache.org/jira/browse/MESOS-8343
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The test was flaky due to race between scheduler driver stopping
> during test teardown and the scheduler `error()` invocation.
> Adding the missing synchronization for the expectation should
> eliminate the race.
>
>
> Diffs
> -----
>
> src/tests/scheduler_http_api_tests.cpp 64c000650acab30647d0c1e7d685bec954aa7118
>
>
> Diff: https://reviews.apache.org/r/69176/diff/1/
>
>
> Testing
> -------
>
> ran `chedulerHttpApiTest.UpdatePidToHttpScheduler` continously without failure.
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 69176: Fixed flaky test
`SchedulerHttpApiTest.UpdatePidToHttpScheduler`.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69176/#review210064
-----------------------------------------------------------
PASS: Mesos patch 69176 was successfully built and tested.
Reviews applied: `['69176']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2534/mesos-review-69176
- Mesos Reviewbot Windows
On Oct. 25, 2018, 11:11 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69176/
> -----------------------------------------------------------
>
> (Updated Oct. 25, 2018, 11:11 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-8343
> https://issues.apache.org/jira/browse/MESOS-8343
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The test was flaky due to race between scheduler driver stopping
> during test teardown and the scheduler `error()` invocation.
> Adding the missing synchronization for the expectation should
> eliminate the race.
>
>
> Diffs
> -----
>
> src/tests/scheduler_http_api_tests.cpp 64c000650acab30647d0c1e7d685bec954aa7118
>
>
> Diff: https://reviews.apache.org/r/69176/diff/1/
>
>
> Testing
> -------
>
> ran `chedulerHttpApiTest.UpdatePidToHttpScheduler` continously without failure.
>
>
> Thanks,
>
> Meng Zhu
>
>