You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2018/10/26 00:54:33 UTC

Review Request 69182: Moved Master::Subscribers::Subscriber constructor into .cpp file.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69182/
-----------------------------------------------------------

Review request for mesos, Gastón Kleiman and Greg Mann.


Bugs: MESOS-9258
    https://issues.apache.org/jira/browse/MESOS-9258


Repository: mesos


Description
-------

The logic inside this class's constructor was originally in the master's
header file.  With the introduction of streaming request support (to be
added in subsequent commit(s)), the logic inside the constructor will be
increased; and as such would be better placed outside the header file.

This could potentially be squashed with:
https://reviews.apache.org/r/69181/


Diffs
-----

  src/master/master.hpp ea7e9242b62fe6c2cc0e717f9a9f2f0c1cc0a390 
  src/master/master.cpp 0c95c438975efd949cbf86f7d8bfea940c20a43a 


Diff: https://reviews.apache.org/r/69182/diff/1/


Testing
-------

make

See later in chain.


Thanks,

Joseph Wu