You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@apache.org> on 2018/10/15 22:09:05 UTC
Review Request 69033: Fixed a comment in SLRP.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69033/
-----------------------------------------------------------
Review request for mesos and Benjamin Bannier.
Repository: mesos
Description
-------
Fixed a comment in SLRP.
Diffs
-----
src/resource_provider/storage/provider.cpp db783b53558811081fb2671e005e8bbbd9edbede
Diff: https://reviews.apache.org/r/69033/diff/1/
Testing
-------
make check
Thanks,
Chun-Hung Hsiao
Re: Review Request 69033: Fixed a comment in SLRP.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69033/#review209578
-----------------------------------------------------------
PASS: Mesos patch 69033 was successfully built and tested.
Reviews applied: `['69033']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2465/mesos-review-69033
- Mesos Reviewbot Windows
On Oct. 15, 2018, 10:09 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69033/
> -----------------------------------------------------------
>
> (Updated Oct. 15, 2018, 10:09 p.m.)
>
>
> Review request for mesos and Benjamin Bannier.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed a comment in SLRP.
>
>
> Diffs
> -----
>
> src/resource_provider/storage/provider.cpp db783b53558811081fb2671e005e8bbbd9edbede
>
>
> Diff: https://reviews.apache.org/r/69033/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 69033: Fixed a comment in SLRP.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69033/#review210156
-----------------------------------------------------------
Patch looks great!
Reviews applied: [69033]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Oct. 15, 2018, 3:09 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69033/
> -----------------------------------------------------------
>
> (Updated Oct. 15, 2018, 3:09 p.m.)
>
>
> Review request for mesos and Benjamin Bannier.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed a comment in SLRP.
>
>
> Diffs
> -----
>
> src/resource_provider/storage/provider.cpp db783b53558811081fb2671e005e8bbbd9edbede
>
>
> Diff: https://reviews.apache.org/r/69033/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 69033: Fixed a comment in SLRP.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69033/#review210144
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Bannier
On Oct. 16, 2018, 12:09 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69033/
> -----------------------------------------------------------
>
> (Updated Oct. 16, 2018, 12:09 a.m.)
>
>
> Review request for mesos and Benjamin Bannier.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed a comment in SLRP.
>
>
> Diffs
> -----
>
> src/resource_provider/storage/provider.cpp db783b53558811081fb2671e005e8bbbd9edbede
>
>
> Diff: https://reviews.apache.org/r/69033/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>