You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benno Evers <be...@mesosphere.com> on 2018/10/18 18:43:27 UTC
Review Request 69071: Narrowed interface of `ReadOnlyHandler` members.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69071/
-----------------------------------------------------------
Review request for mesos and Alexander Rukletsov.
Repository: mesos
Description
-------
Since all endpoints handled by `ReadOnlyHandler` will ignore all parts of the request except for the query parameters, we enforce this invariant in the type system by changing the parameter types.
This also enables a correct implementation of request caching in the subsequent commit.
Diffs
-----
src/master/http.cpp d912789bcfdcf6eaefc29dba7b878fa4e02f9276
src/master/master.hpp ea7e9242b62fe6c2cc0e717f9a9f2f0c1cc0a390
src/master/readonly_handler.cpp 8895374499dc6baa2c4d8a8dd86fddac4e39be29
Diff: https://reviews.apache.org/r/69071/diff/1/
Testing
-------
Thanks,
Benno Evers
Re: Review Request 69071: Narrowed interface of `ReadOnlyHandler`
members.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69071/#review210959
-----------------------------------------------------------
Ship it!
LGTM, pending the other parts of the chain.
- Joseph Wu
On Nov. 21, 2018, 5:19 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69071/
> -----------------------------------------------------------
>
> (Updated Nov. 21, 2018, 5:19 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Previously, the members of `ReadOnlyHandler` would take a full `Request` as parameter, making it hard for clients to reason about which parts of the request are used internally, and even harder to guarantee that behaviour into the future.
>
> This commit changes the interface so only the query parameters get passed.
>
>
> Diffs
> -----
>
> src/master/http.cpp 68ee2a6dcffbc772afec6e797b1af8da48f61937
> src/master/master.hpp 3b3c1a4e61de9503c8d038dd3bee623ded5914c9
> src/master/readonly_handler.cpp 8895374499dc6baa2c4d8a8dd86fddac4e39be29
>
>
> Diff: https://reviews.apache.org/r/69071/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 69071: Narrowed interface of `ReadOnlyHandler`
members.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69071/#review211370
-----------------------------------------------------------
Ship it!
Ship It!
- Greg Mann
On Dec. 12, 2018, 8:47 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69071/
> -----------------------------------------------------------
>
> (Updated Dec. 12, 2018, 8:47 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Previously, the members of ReadOnlyHandler would take a full Request as parameter, making it hard for clients to reason about which parts of the request are used internally, and even harder to guarantee that behaviour into the future.
>
> This commit changes the interface so only the query parameters get passed.
>
>
> Diffs
> -----
>
> src/master/http.cpp 68ee2a6dcffbc772afec6e797b1af8da48f61937
> src/master/master.hpp c7becfa615964674dcf1ebd9424aa5818a0fdb85
> src/master/readonly_handler.cpp 8895374499dc6baa2c4d8a8dd86fddac4e39be29
>
>
> Diff: https://reviews.apache.org/r/69071/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 69071: Narrowed interface of `ReadOnlyHandler`
members.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69071/
-----------------------------------------------------------
(Updated Dec. 18, 2018, 1:24 a.m.)
Review request for mesos, Alexander Rukletsov and Joseph Wu.
Repository: mesos
Description (updated)
-------
Previously, the members of ReadOnlyHandler would take a full
Request as parameter, making it hard for clients to reason
about which parts of the request are used internally, and
even harder to guarantee that behaviour into the future.
This commit changes the interface so only the query
parameters get passed.
Diffs
-----
src/master/http.cpp 68ee2a6dcffbc772afec6e797b1af8da48f61937
src/master/master.hpp c7becfa615964674dcf1ebd9424aa5818a0fdb85
src/master/readonly_handler.cpp 8895374499dc6baa2c4d8a8dd86fddac4e39be29
Diff: https://reviews.apache.org/r/69071/diff/3/
Testing
-------
Thanks,
Benno Evers
Re: Review Request 69071: Narrowed interface of `ReadOnlyHandler`
members.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69071/
-----------------------------------------------------------
(Updated Dec. 12, 2018, 8:47 p.m.)
Review request for mesos, Alexander Rukletsov and Joseph Wu.
Changes
-------
Rebased onto latest master again.
Repository: mesos
Description (updated)
-------
Previously, the members of ReadOnlyHandler would take a full Request as parameter, making it hard for clients to reason about which parts of the request are used internally, and even harder to guarantee that behaviour into the future.
This commit changes the interface so only the query parameters get passed.
Diffs (updated)
-----
src/master/http.cpp 68ee2a6dcffbc772afec6e797b1af8da48f61937
src/master/master.hpp c7becfa615964674dcf1ebd9424aa5818a0fdb85
src/master/readonly_handler.cpp 8895374499dc6baa2c4d8a8dd86fddac4e39be29
Diff: https://reviews.apache.org/r/69071/diff/3/
Changes: https://reviews.apache.org/r/69071/diff/2-3/
Testing
-------
Thanks,
Benno Evers
Re: Review Request 69071: Narrowed interface of `ReadOnlyHandler`
members.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69071/
-----------------------------------------------------------
(Updated Nov. 22, 2018, 1:19 a.m.)
Review request for mesos, Alexander Rukletsov and Joseph Wu.
Changes
-------
Rebased onto latest master.
Repository: mesos
Description (updated)
-------
Previously, the members of `ReadOnlyHandler` would take a full `Request` as parameter, making it hard for clients to reason about which parts of the request are used internally, and even harder to guarantee that behaviour into the future.
This commit changes the interface so only the query parameters get passed.
Diffs (updated)
-----
src/master/http.cpp 68ee2a6dcffbc772afec6e797b1af8da48f61937
src/master/master.hpp 3b3c1a4e61de9503c8d038dd3bee623ded5914c9
src/master/readonly_handler.cpp 8895374499dc6baa2c4d8a8dd86fddac4e39be29
Diff: https://reviews.apache.org/r/69071/diff/2/
Changes: https://reviews.apache.org/r/69071/diff/1-2/
Testing
-------
Thanks,
Benno Evers