You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Armand Grillet <ag...@mesosphere.io> on 2018/10/12 21:18:04 UTC
Re: Review Request 69003: Added `task exec` to new CLI.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69003/
-----------------------------------------------------------
(Updated oct. 12, 2018, 11:18 après-midi)
Review request for mesos and Kevin Klues.
Changes
-------
Added arguments.
Summary (updated)
-----------------
Added `task exec` to new CLI.
Bugs: MESOS-6551
https://issues.apache.org/jira/browse/MESOS-6551
Repository: mesos
Description (updated)
-------
Added `task exec` to new CLI.
Diffs (updated)
-----
src/python/cli_new/lib/cli/plugins/task/main.py a47a8c53ee2d8d468ea0f9947ea3f65d81fc9251
Diff: https://reviews.apache.org/r/69003/diff/2/
Changes: https://reviews.apache.org/r/69003/diff/1-2/
Testing (updated)
-------
Only tested manually at the moment.
Thanks,
Armand Grillet
Re: Review Request 69003: Added `task exec` to new CLI.
Posted by Kevin Klues <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69003/#review209748
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Klues
On Okt. 15, 2018, 6:53 vorm., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69003/
> -----------------------------------------------------------
>
> (Updated Okt. 15, 2018, 6:53 vorm.)
>
>
> Review request for mesos and Kevin Klues.
>
>
> Bugs: MESOS-6551
> https://issues.apache.org/jira/browse/MESOS-6551
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added `task exec` to new CLI.
>
>
> Diffs
> -----
>
> src/python/cli_new/lib/cli/plugins/task/main.py a47a8c53ee2d8d468ea0f9947ea3f65d81fc9251
>
>
> Diff: https://reviews.apache.org/r/69003/diff/4/
>
>
> Testing
> -------
>
> Only tested manually at the moment.
> ```
> $ mesos task exec --interactive --tty <task-id> vi
> $ mesos task exec -it <task-id> bash
> $ mesos task exec <task-id> cat stderr
> $ echo "hello" | mesos task exec --interactive <task-id> cat
> ```
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 69003: Added `task exec` to new CLI.
Posted by Kevin Klues <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69003/#review209750
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Klues
On Okt. 15, 2018, 6:53 vorm., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69003/
> -----------------------------------------------------------
>
> (Updated Okt. 15, 2018, 6:53 vorm.)
>
>
> Review request for mesos and Kevin Klues.
>
>
> Bugs: MESOS-6551
> https://issues.apache.org/jira/browse/MESOS-6551
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added `task exec` to new CLI.
>
>
> Diffs
> -----
>
> src/python/cli_new/lib/cli/plugins/task/main.py a47a8c53ee2d8d468ea0f9947ea3f65d81fc9251
>
>
> Diff: https://reviews.apache.org/r/69003/diff/4/
>
>
> Testing
> -------
>
> Only tested manually at the moment.
> ```
> $ mesos task exec --interactive --tty <task-id> vi
> $ mesos task exec -it <task-id> bash
> $ mesos task exec <task-id> cat stderr
> $ echo "hello" | mesos task exec --interactive <task-id> cat
> ```
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 69003: Added `task exec` to new CLI.
Posted by Kevin Klues <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69003/#review209749
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Klues
On Okt. 15, 2018, 6:53 vorm., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69003/
> -----------------------------------------------------------
>
> (Updated Okt. 15, 2018, 6:53 vorm.)
>
>
> Review request for mesos and Kevin Klues.
>
>
> Bugs: MESOS-6551
> https://issues.apache.org/jira/browse/MESOS-6551
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added `task exec` to new CLI.
>
>
> Diffs
> -----
>
> src/python/cli_new/lib/cli/plugins/task/main.py a47a8c53ee2d8d468ea0f9947ea3f65d81fc9251
>
>
> Diff: https://reviews.apache.org/r/69003/diff/4/
>
>
> Testing
> -------
>
> Only tested manually at the moment.
> ```
> $ mesos task exec --interactive --tty <task-id> vi
> $ mesos task exec -it <task-id> bash
> $ mesos task exec <task-id> cat stderr
> $ echo "hello" | mesos task exec --interactive <task-id> cat
> ```
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 69003: Added `task exec` to new CLI.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69003/#review209534
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['68971', '68977', '69007', '68978', '69003']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2462/mesos-review-69003
Relevant logs:
- [mesos-tests.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2462/mesos-review-69003/logs/mesos-tests.log):
```
I1015 07:56:49.690887 37788 master.cpp:10932] Updating the state of task b86c469d-ee59-40a7-8479-41b7e6cc2ba0 of framework abd078b0-74b4-4c53-b096-76d02399ac12-0000 (latest state: TASK_KILLED, status update state: TASK_KILLED)
I1015 07:56:49.690887 22068 slave.cpp:6640] Shutting down executor 'b86c469d-ee59-40a7-8479-41b7e6cc2ba0' of framework abd078b0-74b4-4c53-b096-76d02399ac12-0000 at executor(1)@192.10.1.5:62625
I1015 07:56:49.692890 22068 slave.cpp:909] Agent terminating
W1015 07:56:49.693907 22068 slave.cpp:3917] Ignoring shutdown framework abd078b0-74b4-4c53-b096-76d02399ac12-0000 because it is terminating
I1015 07:56:49.693907 37788 master.cpp:11030] Removing task b86c469d-ee59-40a7-8479-41b7e6cc2ba0 with resources cpus(allocated: *):4; mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: *):[31000-32000] of framework abd078b0-74b4-4c53-b096-76d02399ac12-0000 on agent abd078b0-74b4-4c53-b096-76d02399ac12-S0 at slave(461)@192.10.1.5:60840 (windows-02.aa0q4n2kgcyefckmv0xukjvy4f.xx.internal.cloudapp.net)
I1015 07:56:49.696890 37788 master.cpp:1251] Agent abd078b0-74b4-4c53-b096-76d02399ac12-S0 at slave(461)@192.10.1.5:60840 (windows-02.aa0q4n2kgcyefckmv0xukjvy4f.xx.internal.cloudapp.net) disconnected
I1015 07:56:49.696890 37788 master.cpp:3267] Disconnecting agent abd078b0-74b4-4c53-b096-76d02399ac12-S0 at slave(461)@192.10.1.5:60840 (windows-02.aa0q4n2kgcyefckmv0xukjvy4f.xx.internal.cloudapp.net)
I1015 07:56:49.696890 37788 master.cpp:3286] Deactivating agent abd078b0-74b4-4c53-b096-76d02399ac12-S0 at slave(461)@192.10.1.5:60840 (windows-02.aa0q4n2kgcyefckmv0xukjvy4f.xx.internal.cloudapp.net)
I1015 07:56:49.696890 39008 hierarchical.cpp:359] Removed framework abd078b0-74b4-4c53-b096-76d02399ac12-0000
I1015 07:56:49.697888 39008 hierarchical.cpp:803] Agent abd078b0-74b4-4c53-b096-76d02399ac12-S0 deactivated
I1015 07:56:49.697888 40836 containerizer.cpp:2455] Destroying container 9851c272-4072-4a74-bddd-d8527eacca99 in RUNNING state
I1015 07:56:49.697888 40[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (587 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (605 ms total)
[----------] Global test environment tear-down
[==========] 1051 tests from 103 test cases ran. (489415 ms total)
[ PASSED ] 1050 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] DockerFetcherPluginTest.INTERNET_CURL_FetchBlob
1 FAILED TEST
YOU HAVE 232 DISABLED TESTS
836 containerizer.cpp:3122] Transitioning the state of container 9851c272-4072-4a74-bddd-d8527eacca99 from RUNNING to DESTROYING
I1015 07:56:49.698887 40836 launcher.cpp:166] Asked to destroy container 9851c272-4072-4a74-bddd-d8527eacca99
I1015 07:56:49.719933 22068 containerizer.cpp:2961] Container 9851c272-4072-4a74-bddd-d8527eacca99 has exited
I1015 07:56:49.749883 37788 master.cpp:1093] Master terminating
I1015 07:56:49.750902 13060 hierarchical.cpp:645] Removed agent abd078b0-74b4-4c53-b096-76d02399ac12-S0
I1015 07:56:50.353435 38144 process.cpp:926] Stopped the socket accept loop
```
- Mesos Reviewbot Windows
On Oct. 15, 2018, 8:53 a.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69003/
> -----------------------------------------------------------
>
> (Updated Oct. 15, 2018, 8:53 a.m.)
>
>
> Review request for mesos and Kevin Klues.
>
>
> Bugs: MESOS-6551
> https://issues.apache.org/jira/browse/MESOS-6551
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added `task exec` to new CLI.
>
>
> Diffs
> -----
>
> src/python/cli_new/lib/cli/plugins/task/main.py a47a8c53ee2d8d468ea0f9947ea3f65d81fc9251
>
>
> Diff: https://reviews.apache.org/r/69003/diff/4/
>
>
> Testing
> -------
>
> Only tested manually at the moment.
> ```
> $ mesos task exec --interactive --tty <task-id> vi
> $ mesos task exec -it <task-id> bash
> $ mesos task exec <task-id> cat stderr
> $ echo "hello" | mesos task exec --interactive <task-id> cat
> ```
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 69003: Added `task exec` to new CLI.
Posted by Armand Grillet <ag...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69003/
-----------------------------------------------------------
(Updated Oct. 15, 2018, 8:53 a.m.)
Review request for mesos and Kevin Klues.
Changes
-------
Fixed issues.
Bugs: MESOS-6551
https://issues.apache.org/jira/browse/MESOS-6551
Repository: mesos
Description
-------
Added `task exec` to new CLI.
Diffs (updated)
-----
src/python/cli_new/lib/cli/plugins/task/main.py a47a8c53ee2d8d468ea0f9947ea3f65d81fc9251
Diff: https://reviews.apache.org/r/69003/diff/4/
Changes: https://reviews.apache.org/r/69003/diff/3-4/
Testing
-------
Only tested manually at the moment.
```
$ mesos task exec --interactive --tty <task-id> vi
$ mesos task exec -it <task-id> bash
$ mesos task exec <task-id> cat stderr
$ echo "hello" | mesos task exec --interactive <task-id> cat
```
Thanks,
Armand Grillet
Re: Review Request 69003: Added `task exec` to new CLI.
Posted by Kevin Klues <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69003/#review209526
-----------------------------------------------------------
src/python/cli_new/lib/cli/plugins/task/main.py
Lines 60-62 (patched)
<https://reviews.apache.org/r/69003/#comment294016>
This comment is incorrect.
src/python/cli_new/lib/cli/plugins/task/main.py
Lines 70-71 (patched)
<https://reviews.apache.org/r/69003/#comment294017>
We usually either put all arguments on one line, or just one per line.
- Kevin Klues
On Okt. 12, 2018, 9:18 nachm., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69003/
> -----------------------------------------------------------
>
> (Updated Okt. 12, 2018, 9:18 nachm.)
>
>
> Review request for mesos and Kevin Klues.
>
>
> Bugs: MESOS-6551
> https://issues.apache.org/jira/browse/MESOS-6551
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added `task exec` to new CLI.
>
>
> Diffs
> -----
>
> src/python/cli_new/lib/cli/plugins/task/main.py a47a8c53ee2d8d468ea0f9947ea3f65d81fc9251
>
>
> Diff: https://reviews.apache.org/r/69003/diff/3/
>
>
> Testing
> -------
>
> Only tested manually at the moment.
> ```
> $ mesos task exec --interactive --tty <task-id> vi
> $ mesos task exec -it <task-id> bash
> $ mesos task exec <task-id> cat stderr
> $ echo "hello" | mesos task exec --interactive <task-id> cat
> ```
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 69003: Added `task exec` to new CLI.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69003/#review209525
-----------------------------------------------------------
PASS: Mesos patch 69003 was successfully built and tested.
Reviews applied: `['68971', '68977', '69007', '68978', '69003']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2461/mesos-review-69003
- Mesos Reviewbot Windows
On Oct. 12, 2018, 9:18 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69003/
> -----------------------------------------------------------
>
> (Updated Oct. 12, 2018, 9:18 p.m.)
>
>
> Review request for mesos and Kevin Klues.
>
>
> Bugs: MESOS-6551
> https://issues.apache.org/jira/browse/MESOS-6551
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added `task exec` to new CLI.
>
>
> Diffs
> -----
>
> src/python/cli_new/lib/cli/plugins/task/main.py a47a8c53ee2d8d468ea0f9947ea3f65d81fc9251
>
>
> Diff: https://reviews.apache.org/r/69003/diff/3/
>
>
> Testing
> -------
>
> Only tested manually at the moment.
> ```
> $ mesos task exec --interactive --tty <task-id> vi
> $ mesos task exec -it <task-id> bash
> $ mesos task exec <task-id> cat stderr
> $ echo "hello" | mesos task exec --interactive <task-id> cat
> ```
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 69003: Added `task exec` to new CLI.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69003/#review209515
-----------------------------------------------------------
PASS: Mesos patch 69003 was successfully built and tested.
Reviews applied: `['68971', '68977', '69007', '68978', '69003']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2460/mesos-review-69003
- Mesos Reviewbot Windows
On Oct. 13, 2018, 2:48 a.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69003/
> -----------------------------------------------------------
>
> (Updated Oct. 13, 2018, 2:48 a.m.)
>
>
> Review request for mesos and Kevin Klues.
>
>
> Bugs: MESOS-6551
> https://issues.apache.org/jira/browse/MESOS-6551
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added `task exec` to new CLI.
>
>
> Diffs
> -----
>
> src/python/cli_new/lib/cli/plugins/task/main.py a47a8c53ee2d8d468ea0f9947ea3f65d81fc9251
>
>
> Diff: https://reviews.apache.org/r/69003/diff/2/
>
>
> Testing
> -------
>
> Only tested manually at the moment.
>
>
> Thanks,
>
> Armand Grillet
>
>