You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by James Peach <jp...@apache.org> on 2018/10/01 17:37:03 UTC
Re: Review Request 63655: Switched to `net::socketpair` in
`ns::clone`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63655/
-----------------------------------------------------------
(Updated Oct. 1, 2018, 5:37 p.m.)
Review request for mesos, Benjamin Bannier and Jie Yu.
Bugs: MESOS-8156
https://issues.apache.org/jira/browse/MESOS-8156
Repository: mesos
Description
-------
Started using to `net::socketpair` in `ns::clone` so that we don't
have to deal with `SOCK_CLOEXEC` portability.
Diffs (updated)
-----
src/linux/ns.cpp ffa9b65b7caf891a5bee1e20be128c37487335e4
Diff: https://reviews.apache.org/r/63655/diff/3/
Changes: https://reviews.apache.org/r/63655/diff/2-3/
Testing
-------
make check (Fedora 26, macOS)
Thanks,
James Peach
Re: Review Request 63655: Switched to `net::socketpair` in
`ns::clone`.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63655/#review209138
-----------------------------------------------------------
PASS: Mesos patch 63655 was successfully built and tested.
Reviews applied: `['63654', '63655']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2409/mesos-review-63655
- Mesos Reviewbot Windows
On Oct. 1, 2018, 5:37 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63655/
> -----------------------------------------------------------
>
> (Updated Oct. 1, 2018, 5:37 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Jie Yu.
>
>
> Bugs: MESOS-8156
> https://issues.apache.org/jira/browse/MESOS-8156
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Started using to `net::socketpair` in `ns::clone` so that we don't
> have to deal with `SOCK_CLOEXEC` portability.
>
>
> Diffs
> -----
>
> src/linux/ns.cpp ffa9b65b7caf891a5bee1e20be128c37487335e4
>
>
> Diff: https://reviews.apache.org/r/63655/diff/3/
>
>
> Testing
> -------
>
> make check (Fedora 26, macOS)
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 63655: Switched to `net::socketpair` in
`ns::clone`.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63655/#review209608
-----------------------------------------------------------
Fix it, then Ship it!
src/linux/ns.cpp
Lines 274 (patched)
<https://reviews.apache.org/r/63655/#comment294136>
Use `template <` instead.
src/linux/ns.cpp
Lines 277 (patched)
<https://reviews.apache.org/r/63655/#comment294137>
Remove two spaces.
src/linux/ns.cpp
Line 356 (original), 368 (patched)
<https://reviews.apache.org/r/63655/#comment294138>
Fits on a single line.
- Benjamin Bannier
On Oct. 1, 2018, 7:37 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63655/
> -----------------------------------------------------------
>
> (Updated Oct. 1, 2018, 7:37 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Jie Yu.
>
>
> Bugs: MESOS-8156
> https://issues.apache.org/jira/browse/MESOS-8156
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Started using to `net::socketpair` in `ns::clone` so that we don't
> have to deal with `SOCK_CLOEXEC` portability.
>
>
> Diffs
> -----
>
> src/linux/ns.cpp ffa9b65b7caf891a5bee1e20be128c37487335e4
>
>
> Diff: https://reviews.apache.org/r/63655/diff/3/
>
>
> Testing
> -------
>
> make check (Fedora 26, macOS)
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 63655: Switched to `net::socketpair` in
`ns::clone`.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63655/#review209668
-----------------------------------------------------------
PASS: Mesos patch 63655 was successfully built and tested.
Reviews applied: `['63654', '63655']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2477/mesos-review-63655
- Mesos Reviewbot Windows
On Oct. 16, 2018, 10:26 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63655/
> -----------------------------------------------------------
>
> (Updated Oct. 16, 2018, 10:26 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Jie Yu.
>
>
> Bugs: MESOS-8156
> https://issues.apache.org/jira/browse/MESOS-8156
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Started using to `net::socketpair` in `ns::clone` so that we don't
> have to deal with `SOCK_CLOEXEC` portability.
>
>
> Diffs
> -----
>
> src/linux/ns.cpp ffa9b65b7caf891a5bee1e20be128c37487335e4
>
>
> Diff: https://reviews.apache.org/r/63655/diff/4/
>
>
> Testing
> -------
>
> make check (Fedora 26, macOS)
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 63655: Switched to `net::socketpair` in
`ns::clone`.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63655/
-----------------------------------------------------------
(Updated Oct. 16, 2018, 10:26 p.m.)
Review request for mesos, Benjamin Bannier and Jie Yu.
Bugs: MESOS-8156
https://issues.apache.org/jira/browse/MESOS-8156
Repository: mesos
Description
-------
Started using to `net::socketpair` in `ns::clone` so that we don't
have to deal with `SOCK_CLOEXEC` portability.
Diffs (updated)
-----
src/linux/ns.cpp ffa9b65b7caf891a5bee1e20be128c37487335e4
Diff: https://reviews.apache.org/r/63655/diff/4/
Changes: https://reviews.apache.org/r/63655/diff/3-4/
Testing
-------
make check (Fedora 26, macOS)
Thanks,
James Peach
Re: Review Request 63655: Switched to `net::socketpair` in
`ns::clone`.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63655/#review209600
-----------------------------------------------------------
Ship it!
Ship It!
- Gilbert Song
On Oct. 1, 2018, 10:37 a.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63655/
> -----------------------------------------------------------
>
> (Updated Oct. 1, 2018, 10:37 a.m.)
>
>
> Review request for mesos, Benjamin Bannier and Jie Yu.
>
>
> Bugs: MESOS-8156
> https://issues.apache.org/jira/browse/MESOS-8156
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Started using to `net::socketpair` in `ns::clone` so that we don't
> have to deal with `SOCK_CLOEXEC` portability.
>
>
> Diffs
> -----
>
> src/linux/ns.cpp ffa9b65b7caf891a5bee1e20be128c37487335e4
>
>
> Diff: https://reviews.apache.org/r/63655/diff/3/
>
>
> Testing
> -------
>
> make check (Fedora 26, macOS)
>
>
> Thanks,
>
> James Peach
>
>