You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Armand Grillet <ag...@mesosphere.io> on 2018/10/16 11:33:22 UTC
Re: Review Request 68971: Moved import of '../lib' from new CLI
bootstrap to pip-requirements.txt.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68971/
-----------------------------------------------------------
(Updated Oct. 16, 2018, 1:33 p.m.)
Review request for mesos and Kevin Klues.
Changes
-------
Rebased.
Bugs: MESOS-6551
https://issues.apache.org/jira/browse/MESOS-6551
Repository: mesos
Description (updated)
-------
This adds the Mesos Python package to the requirements needed by the
new CLI. We were previously adding the path to the package when setting
up the CLI virtual environment but this does not work with Pylint when
it is run from the linters virtual environment.
By setting things in `pip-requirements.txt`, Pylint does not report
inexisting linting errors when doing imports such as `import mesos`.
Diffs (updated)
-----
src/python/cli_new/bootstrap a6183d4c28281bf6d29c8b7f825ae474056f027b
src/python/cli_new/pip-requirements.txt d1822bf752ce76aa5da5999057fe1efb83747fd0
Diff: https://reviews.apache.org/r/68971/diff/3/
Changes: https://reviews.apache.org/r/68971/diff/2-3/
Testing
-------
Updated the agent plugin to do `from mesos.exceptions import MesosException` and use `MesosException`. Commited to see the git hook running and saw the error `E0401: Unable to import 'mesos.exceptions' (import-error).`. Updated `support/pylint.config`, run the git hook again and saw that the error was gone.
Thanks,
Armand Grillet
Re: Review Request 68971: Moved import of '../lib' from new CLI
bootstrap to pip-requirements.txt.
Posted by Kevin Klues <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68971/#review209615
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Klues
On Okt. 16, 2018, 11:33 vorm., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68971/
> -----------------------------------------------------------
>
> (Updated Okt. 16, 2018, 11:33 vorm.)
>
>
> Review request for mesos and Kevin Klues.
>
>
> Bugs: MESOS-8795
> https://issues.apache.org/jira/browse/MESOS-8795
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This adds the Mesos Python package to the requirements needed by the
> new CLI. We were previously adding the path to the package when setting
> up the CLI virtual environment but this does not work with Pylint when
> it is run from the linters virtual environment.
>
> By setting things in `pip-requirements.txt`, Pylint does not report
> inexisting linting errors when doing imports such as `import mesos`.
>
>
> Diffs
> -----
>
> src/python/cli_new/bootstrap a6183d4c28281bf6d29c8b7f825ae474056f027b
> src/python/cli_new/pip-requirements.txt d1822bf752ce76aa5da5999057fe1efb83747fd0
>
>
> Diff: https://reviews.apache.org/r/68971/diff/3/
>
>
> Testing
> -------
>
> Updated the agent plugin to do `from mesos.exceptions import MesosException` and use `MesosException`. Commited to see the git hook running and saw the error `E0401: Unable to import 'mesos.exceptions' (import-error).`. Updated `support/pylint.config`, run the git hook again and saw that the error was gone.
>
>
> Thanks,
>
> Armand Grillet
>
>