You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@apache.org> on 2018/10/11 05:18:02 UTC

Review Request 68987: Fixed protobuf map equality check in the URI disk profile adaptor.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68987/
-----------------------------------------------------------

Review request for mesos and Jie Yu.


Bugs: MESOS-9308
    https://issues.apache.org/jira/browse/MESOS-9308


Repository: mesos


Description
-------

Fixed protobuf map equality check in the URI disk profile adaptor.


Diffs
-----

  src/resource_provider/storage/uri_disk_profile_adaptor.cpp d214af89f20f3e8184df83e89512e39e3daa1fc1 


Diff: https://reviews.apache.org/r/68987/diff/1/


Testing
-------

make check


Thanks,

Chun-Hung Hsiao


Re: Review Request 68987: Fixed protobuf map equality check in the URI disk profile adaptor.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68987/#review209439
-----------------------------------------------------------



PASS: Mesos patch 68987 was successfully built and tested.

Reviews applied: `['68987']`

All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2450/mesos-review-68987

- Mesos Reviewbot Windows


On Oct. 11, 2018, 5:18 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68987/
> -----------------------------------------------------------
> 
> (Updated Oct. 11, 2018, 5:18 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-9308
>     https://issues.apache.org/jira/browse/MESOS-9308
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed protobuf map equality check in the URI disk profile adaptor.
> 
> 
> Diffs
> -----
> 
>   src/resource_provider/storage/uri_disk_profile_adaptor.cpp d214af89f20f3e8184df83e89512e39e3daa1fc1 
> 
> 
> Diff: https://reviews.apache.org/r/68987/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Re: Review Request 68987: Fixed protobuf map equality check in the URI disk profile adaptor.

Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68987/#review209434
-----------------------------------------------------------


Ship it!




Ship It!

- Gilbert Song


On Oct. 10, 2018, 10:18 p.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68987/
> -----------------------------------------------------------
> 
> (Updated Oct. 10, 2018, 10:18 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-9308
>     https://issues.apache.org/jira/browse/MESOS-9308
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed protobuf map equality check in the URI disk profile adaptor.
> 
> 
> Diffs
> -----
> 
>   src/resource_provider/storage/uri_disk_profile_adaptor.cpp d214af89f20f3e8184df83e89512e39e3daa1fc1 
> 
> 
> Diff: https://reviews.apache.org/r/68987/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Re: Review Request 68987: Fixed protobuf map equality check in the URI disk profile adaptor.

Posted by Chun-Hung Hsiao <ch...@apache.org>.

> On Oct. 11, 2018, 5:19 a.m., Gilbert Song wrote:
> > Do we want a simple unit test?

I'll follow up with one tomorrow.


- Chun-Hung


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68987/#review209435
-----------------------------------------------------------


On Oct. 11, 2018, 5:18 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68987/
> -----------------------------------------------------------
> 
> (Updated Oct. 11, 2018, 5:18 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-9308
>     https://issues.apache.org/jira/browse/MESOS-9308
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed protobuf map equality check in the URI disk profile adaptor.
> 
> 
> Diffs
> -----
> 
>   src/resource_provider/storage/uri_disk_profile_adaptor.cpp d214af89f20f3e8184df83e89512e39e3daa1fc1 
> 
> 
> Diff: https://reviews.apache.org/r/68987/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Re: Review Request 68987: Fixed protobuf map equality check in the URI disk profile adaptor.

Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68987/#review209435
-----------------------------------------------------------



Do we want a simple unit test?

- Gilbert Song


On Oct. 10, 2018, 10:18 p.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68987/
> -----------------------------------------------------------
> 
> (Updated Oct. 10, 2018, 10:18 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-9308
>     https://issues.apache.org/jira/browse/MESOS-9308
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed protobuf map equality check in the URI disk profile adaptor.
> 
> 
> Diffs
> -----
> 
>   src/resource_provider/storage/uri_disk_profile_adaptor.cpp d214af89f20f3e8184df83e89512e39e3daa1fc1 
> 
> 
> Diff: https://reviews.apache.org/r/68987/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Re: Review Request 68987: Fixed protobuf map equality check in the URI disk profile adaptor.

Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68987/#review209433
-----------------------------------------------------------


Ship it!




Ship It!

- Jie Yu


On Oct. 11, 2018, 5:18 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68987/
> -----------------------------------------------------------
> 
> (Updated Oct. 11, 2018, 5:18 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-9308
>     https://issues.apache.org/jira/browse/MESOS-9308
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed protobuf map equality check in the URI disk profile adaptor.
> 
> 
> Diffs
> -----
> 
>   src/resource_provider/storage/uri_disk_profile_adaptor.cpp d214af89f20f3e8184df83e89512e39e3daa1fc1 
> 
> 
> Diff: https://reviews.apache.org/r/68987/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>