You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Kevin Klues <kl...@gmail.com> on 2018/10/17 12:02:48 UTC
Re: Review Request 69023: Added `retry` argument to `request()`
method in Python library.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69023/#review209693
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Klues
On Okt. 15, 2018, 11:05 vorm., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69023/
> -----------------------------------------------------------
>
> (Updated Okt. 15, 2018, 11:05 vorm.)
>
>
> Review request for mesos and Kevin Klues.
>
>
> Bugs: MESOS-6551
> https://issues.apache.org/jira/browse/MESOS-6551
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This allows us to do HTTP requests without using `tenacity.retry()`. We
> need to be able to disable these retries to stream data for a long
> period of time, such as when using the upcoming `mesos task exec`.
>
>
> Diffs
> -----
>
> src/python/lib/mesos/http.py cd1587797db7d75c6b839851f0f3e5671269307c
>
>
> Diff: https://reviews.apache.org/r/69023/diff/2/
>
>
> Testing
> -------
>
> Used `task exec` successfully later in this chain. Tests suite of the lib still passing.
>
>
> Thanks,
>
> Armand Grillet
>
>