You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Till Toenshoff via Review Board <no...@reviews.apache.org> on 2018/10/03 20:55:02 UTC
Review Request 68919: Removed unbundling by default for libevent on
macOS when using CMake.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68919/
-----------------------------------------------------------
Review request for mesos, Benjamin Bannier and James Peach.
Repository: mesos
Description
-------
Removed unbundling by default for libevent on macOS when using CMake.
Diffs
-----
cmake/CompilationConfigure.cmake a820c867b41d2120525c5a32128812ae527ffeba
Diff: https://reviews.apache.org/r/68919/diff/1/
Testing
-------
macos: cmake .. -DENABLE_SSL=ON -DENABLE_LIBEVENT=ON -DOPENSSL_ROOT_DIR=/usr/local/opt/openssl -DCMAKE_EXPORT_COMPILE_COMMANDS=1 -G Ninja && ninja check -j12
macos: cmake .. -DUNBUNDLED_LIBEVENT=ON -DENABLE_SSL=ON -DENABLE_LIBEVENT=ON -DOPENSSL_ROOT_DIR=/usr/local/opt/openssl -DCMAKE_EXPORT_COMPILE_COMMANDS=1 -G Ninja && ninja check -j12
Thanks,
Till Toenshoff
Re: Review Request 68919: Removed unbundling by default for libevent
on macOS when using CMake.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68919/#review209199
-----------------------------------------------------------
PASS: Mesos patch 68919 was successfully built and tested.
Reviews applied: `['68919']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2416/mesos-review-68919
- Mesos Reviewbot Windows
On Oct. 3, 2018, 8:55 p.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68919/
> -----------------------------------------------------------
>
> (Updated Oct. 3, 2018, 8:55 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and James Peach.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Removed unbundling by default for libevent on macOS when using CMake.
>
>
> Diffs
> -----
>
> cmake/CompilationConfigure.cmake a820c867b41d2120525c5a32128812ae527ffeba
>
>
> Diff: https://reviews.apache.org/r/68919/diff/1/
>
>
> Testing
> -------
>
> macos: cmake .. -DENABLE_SSL=ON -DENABLE_LIBEVENT=ON -DOPENSSL_ROOT_DIR=/usr/local/opt/openssl -DCMAKE_EXPORT_COMPILE_COMMANDS=1 -G Ninja && ninja check -j12
> macos: cmake .. -DUNBUNDLED_LIBEVENT=ON -DENABLE_SSL=ON -DENABLE_LIBEVENT=ON -DOPENSSL_ROOT_DIR=/usr/local/opt/openssl -DCMAKE_EXPORT_COMPILE_COMMANDS=1 -G Ninja && ninja check -j12
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 68919: Removed unbundling by default for libevent
on macOS when using CMake.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68919/#review209218
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Rojas
On Oct. 3, 2018, 10:55 p.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68919/
> -----------------------------------------------------------
>
> (Updated Oct. 3, 2018, 10:55 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and James Peach.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Removed unbundling by default for libevent on macOS when using CMake.
>
>
> Diffs
> -----
>
> cmake/CompilationConfigure.cmake a820c867b41d2120525c5a32128812ae527ffeba
>
>
> Diff: https://reviews.apache.org/r/68919/diff/1/
>
>
> Testing
> -------
>
> macos: cmake .. -DENABLE_SSL=ON -DENABLE_LIBEVENT=ON -DOPENSSL_ROOT_DIR=/usr/local/opt/openssl -DCMAKE_EXPORT_COMPILE_COMMANDS=1 -G Ninja && ninja check -j12
> macos: cmake .. -DUNBUNDLED_LIBEVENT=ON -DENABLE_SSL=ON -DENABLE_LIBEVENT=ON -DOPENSSL_ROOT_DIR=/usr/local/opt/openssl -DCMAKE_EXPORT_COMPILE_COMMANDS=1 -G Ninja && ninja check -j12
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 68919: Removed unbundling by default for libevent
on macOS when using CMake.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68919/#review213053
-----------------------------------------------------------
Bad review!
Reviews applied: [68919]
Error:
2019-02-21 21:46:07 URL:https://reviews.apache.org/r/68919/diff/raw/ [725/725] -> "68919.patch" [1]
error: patch failed: cmake/CompilationConfigure.cmake:80
error: cmake/CompilationConfigure.cmake: patch does not apply
- Mesos Reviewbot
On Oct. 3, 2018, 8:55 p.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68919/
> -----------------------------------------------------------
>
> (Updated Oct. 3, 2018, 8:55 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and James Peach.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Removed unbundling by default for libevent on macOS when using CMake.
>
>
> Diffs
> -----
>
> cmake/CompilationConfigure.cmake a820c867b41d2120525c5a32128812ae527ffeba
>
>
> Diff: https://reviews.apache.org/r/68919/diff/1/
>
>
> Testing
> -------
>
> macos: cmake .. -DENABLE_SSL=ON -DENABLE_LIBEVENT=ON -DOPENSSL_ROOT_DIR=/usr/local/opt/openssl -DCMAKE_EXPORT_COMPILE_COMMANDS=1 -G Ninja && ninja check -j12
> macos: cmake .. -DUNBUNDLED_LIBEVENT=ON -DENABLE_SSL=ON -DENABLE_LIBEVENT=ON -DOPENSSL_ROOT_DIR=/usr/local/opt/openssl -DCMAKE_EXPORT_COMPILE_COMMANDS=1 -G Ninja && ninja check -j12
>
>
> Thanks,
>
> Till Toenshoff
>
>