You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2018/10/26 00:55:48 UTC

Review Request 69183: Added optional heartbeat monitoring to the master /api/v1.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69183/
-----------------------------------------------------------

Review request for mesos, Gastón Kleiman and Greg Mann.


Bugs: MESOS-9258
    https://issues.apache.org/jira/browse/MESOS-9258


Repository: mesos


Description
-------

When a client of the master SUBSCRIBE /api/v1 makes a streaming request,
this logic will check that the client sends a heartbeat at least
once every 30 seconds (2x the default heartbeat interval).  If the
heartbeat times out, the connection breaks, or a malformed message is
sent as a heartbeat, the master will actively break the connection.


Diffs
-----

  src/master/master.hpp ea7e9242b62fe6c2cc0e717f9a9f2f0c1cc0a390 
  src/master/master.cpp 0c95c438975efd949cbf86f7d8bfea940c20a43a 


Diff: https://reviews.apache.org/r/69183/diff/1/


Testing
-------

make

See later in chain.


Thanks,

Joseph Wu