You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@apache.org> on 2018/10/30 21:07:46 UTC

Re: Review Request 69085: Stout: Added a sync option for `mkdir`.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69085/
-----------------------------------------------------------

(Updated Oct. 30, 2018, 9:07 p.m.)


Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.


Changes
-------

Made `sync` optional.


Summary (updated)
-----------------

Stout: Added a sync option for `mkdir`.


Bugs: MESOS-9281
    https://issues.apache.org/jira/browse/MESOS-9281


Repository: mesos


Description (updated)
-------

To ensure the directories created by `mkdir` are commited to their
filesystems, an `fsync` will be called on the parent of each created
directory if the `sync` option is set to true. This option has no
effect on Windows.


Diffs (updated)
-----

  3rdparty/stout/include/stout/os/posix/mkdir.hpp 418db9af310ed763a5ae4735c2ebdd1ca38738ba 
  3rdparty/stout/include/stout/os/windows/mkdir.hpp 2aef22a47a80eddc9db0cd4e4ae3daf77c52c05b 


Diff: https://reviews.apache.org/r/69085/diff/4/

Changes: https://reviews.apache.org/r/69085/diff/3-4/


Testing
-------

make check


Thanks,

Chun-Hung Hsiao