You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2018/10/25 10:54:31 UTC
Review Request 69160: Included corresponding header file first.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69160/
-----------------------------------------------------------
Review request for mesos and Chun-Hung Hsiao.
Repository: mesos
Description
-------
Included corresponding header file first.
Diffs
-----
src/common/protobuf_utils.cpp 77139d8a3931dc1e9e00fcea83d77d96244a34f3
Diff: https://reviews.apache.org/r/69160/diff/1/
Testing
-------
`make check`
Thanks,
Benjamin Bannier
Re: Review Request 69160: Included corresponding header file first.
Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69160/#review210090
-----------------------------------------------------------
Ship it!
Ship It!
- Jan Schlicht
On Oct. 25, 2018, 12:54 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69160/
> -----------------------------------------------------------
>
> (Updated Oct. 25, 2018, 12:54 p.m.)
>
>
> Review request for mesos and Chun-Hung Hsiao.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Included corresponding header file first.
>
>
> Diffs
> -----
>
> src/common/protobuf_utils.cpp 77139d8a3931dc1e9e00fcea83d77d96244a34f3
>
>
> Diff: https://reviews.apache.org/r/69160/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 69160: Included corresponding header file first.
Posted by Till Toenshoff via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69160/#review210096
-----------------------------------------------------------
Ship it!
Ship It!
- Till Toenshoff
On Oct. 25, 2018, 10:54 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69160/
> -----------------------------------------------------------
>
> (Updated Oct. 25, 2018, 10:54 a.m.)
>
>
> Review request for mesos and Chun-Hung Hsiao.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Included corresponding header file first.
>
>
> Diffs
> -----
>
> src/common/protobuf_utils.cpp 77139d8a3931dc1e9e00fcea83d77d96244a34f3
>
>
> Diff: https://reviews.apache.org/r/69160/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>