You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Qian Zhang <zh...@gmail.com> on 2018/10/14 14:02:27 UTC
Review Request 69016: Added a test `SubprocessTest.WhiteListFds`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69016/
-----------------------------------------------------------
Review request for mesos, Gilbert Song and James Peach.
Bugs: MESOS-9152
https://issues.apache.org/jira/browse/MESOS-9152
Repository: mesos
Description
-------
Added a test `SubprocessTest.WhiteListFds`.
Diffs
-----
3rdparty/libprocess/src/tests/subprocess_tests.cpp e6742ecfc8f5e0a5cf7f4a53f3df4a3dd48e5ea9
Diff: https://reviews.apache.org/r/69016/diff/1/
Testing
-------
sudo make check
Thanks,
Qian Zhang
Re: Review Request 69016: Added a test `SubprocessTest.WhiteListFds`.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69016/#review209637
-----------------------------------------------------------
Ship it!
3rdparty/libprocess/src/tests/subprocess_tests.cpp
Lines 1067 (patched)
<https://reviews.apache.org/r/69016/#comment294177>
Just a suggestion ... you could avoid the need for temporary files by using `dup` or `socket` to create file descriptors.
- James Peach
On Oct. 14, 2018, 2:11 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69016/
> -----------------------------------------------------------
>
> (Updated Oct. 14, 2018, 2:11 p.m.)
>
>
> Review request for mesos, Gilbert Song and James Peach.
>
>
> Bugs: MESOS-9152 and MESOS-9164
> https://issues.apache.org/jira/browse/MESOS-9152
> https://issues.apache.org/jira/browse/MESOS-9164
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test `SubprocessTest.WhiteListFds`.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/tests/subprocess_tests.cpp e6742ecfc8f5e0a5cf7f4a53f3df4a3dd48e5ea9
>
>
> Diff: https://reviews.apache.org/r/69016/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 69016: Added a test `SubprocessTest.WhiteListFds`.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69016/#review210409
-----------------------------------------------------------
Ship it!
Ship It!
- Gilbert Song
On Oct. 14, 2018, 7:11 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69016/
> -----------------------------------------------------------
>
> (Updated Oct. 14, 2018, 7:11 a.m.)
>
>
> Review request for mesos, Gilbert Song and James Peach.
>
>
> Bugs: MESOS-9152 and MESOS-9164
> https://issues.apache.org/jira/browse/MESOS-9152
> https://issues.apache.org/jira/browse/MESOS-9164
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test `SubprocessTest.WhiteListFds`.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/tests/subprocess_tests.cpp e6742ecfc8f5e0a5cf7f4a53f3df4a3dd48e5ea9
>
>
> Diff: https://reviews.apache.org/r/69016/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 69016: Added a test `SubprocessTest.WhiteListFds`.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69016/
-----------------------------------------------------------
(Updated Oct. 14, 2018, 10:11 p.m.)
Review request for mesos, Gilbert Song and James Peach.
Bugs: MESOS-9152 and MESOS-9164
https://issues.apache.org/jira/browse/MESOS-9152
https://issues.apache.org/jira/browse/MESOS-9164
Repository: mesos
Description
-------
Added a test `SubprocessTest.WhiteListFds`.
Diffs
-----
3rdparty/libprocess/src/tests/subprocess_tests.cpp e6742ecfc8f5e0a5cf7f4a53f3df4a3dd48e5ea9
Diff: https://reviews.apache.org/r/69016/diff/1/
Testing
-------
sudo make check
Thanks,
Qian Zhang