You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2018/10/22 04:31:49 UTC
Review Request 69110: Added task health check definitions to master
API responses.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69110/
-----------------------------------------------------------
Review request for mesos, Alexander Rukletsov, Gastón Kleiman, and Vinod Kone.
Bugs: MESOS-8780
https://issues.apache.org/jira/browse/MESOS-8780
Repository: mesos
Description
-------
The `Task` protobuf message is updated to include the health check
definition of a task when it is specified. Associated helpers are
also updated along with a test which verifies that this field is
reflected in master API responses.
Diffs
-----
include/mesos/mesos.proto 72966da75bc90d4b5d891e209e786e5326155d17
include/mesos/v1/mesos.proto c6c1dae5494d9270a7a43a2d838769574ae47872
src/common/http.cpp 80848aafe27eb0c35222ad236e671a32c4ab10aa
src/common/protobuf_utils.cpp 77139d8a3931dc1e9e00fcea83d77d96244a34f3
src/tests/health_check_tests.cpp c972b9003196b4b4272d7c34311c84c117b1ae3d
Diff: https://reviews.apache.org/r/69110/diff/1/
Testing
-------
`make check`
Thanks,
Greg Mann
Re: Review Request 69110: Added task health check definitions to
master API responses.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69110/#review209840
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['69110']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2502/mesos-review-69110
Relevant logs:
- [mesos-tests-cmake.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2502/mesos-review-69110/logs/mesos-tests-cmake.log):
```
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\zookeeper.c(3426): warning C4996: 'strerror': This function or variable may be unsafe. Consider using strerror_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\zookeeper.c(3500): warning C4996: 'inet_ntoa': Use inet_ntop() or InetNtop() instead or define _WINSOCK_DEPRECATED_NO_WARNINGS to disable deprecated API warnings [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\zookeeper.c(3501): warning C4996: 'sprintf': This function or variable may be unsafe. Consider using sprintf_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\zookeeper.c(3479): warning C4101: 'addrstr': unreferenced local variable [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\recordio.c(170): warning C4267: '=': conversion from 'size_t' to 'int32_t', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\mt_adaptor.c(496): warning C4244: '=': conversion from 'time_t' to 'int32_t', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\winport.c(256): warning C4090: 'function': different 'const' qualifiers [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\winport.c(166): warning C4716: 'pthread_cond_broadcast': must return a value [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\winport.c(205): warning C4716: 'pthread_cond_wait': must return a value [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(124): warning C4996: 'fopen': This function or variable may be unsafe. Consider using fopen_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(128): warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(279): warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(301): warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(368): warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(372): warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(512): warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(543): warning C4996: 'strcpy': This function or variable may be unsafe. Consider using strcpy_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(548): warning C4996: 'fopen': This function or variable may be unsafe. Consider using fopen_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(569): warning C4996: 'strcpy': This function or variable may be unsafe. Consider using strcpy_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
"D:\DCOS\mesos\src\tests\mesos-tests.vcxproj" (default target) (1) ->
(ClCompile target) ->
d:\dcos\mesos\mesos\src\tests\health_check_tests.cpp(478): error C3861: 'Failure': identifier not found [D:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
172 Warning(s)
1 Error(s)
Time Elapsed 00:28:04.64
```
- Mesos Reviewbot Windows
On Oct. 22, 2018, 4:31 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69110/
> -----------------------------------------------------------
>
> (Updated Oct. 22, 2018, 4:31 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Gastón Kleiman, and Vinod Kone.
>
>
> Bugs: MESOS-8780
> https://issues.apache.org/jira/browse/MESOS-8780
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The `Task` protobuf message is updated to include the health check
> definition of a task when it is specified. Associated helpers are
> also updated along with a test which verifies that this field is
> reflected in master API responses.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 72966da75bc90d4b5d891e209e786e5326155d17
> include/mesos/v1/mesos.proto c6c1dae5494d9270a7a43a2d838769574ae47872
> src/common/http.cpp 80848aafe27eb0c35222ad236e671a32c4ab10aa
> src/common/protobuf_utils.cpp 77139d8a3931dc1e9e00fcea83d77d96244a34f3
> src/tests/health_check_tests.cpp c972b9003196b4b4272d7c34311c84c117b1ae3d
>
>
> Diff: https://reviews.apache.org/r/69110/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 69110: Added task health check definitions to
master API responses.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69110/#review209867
-----------------------------------------------------------
Patch looks great!
Reviews applied: [69110]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Oct. 22, 2018, 5:35 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69110/
> -----------------------------------------------------------
>
> (Updated Oct. 22, 2018, 5:35 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Gastón Kleiman, and Vinod Kone.
>
>
> Bugs: MESOS-8780
> https://issues.apache.org/jira/browse/MESOS-8780
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The Task protobuf message is updated to include the health check
> definition of a task when it is specified. Associated helpers are
> also updated along with a test which verifies that this field is
> reflected in master API responses.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 72966da75bc90d4b5d891e209e786e5326155d17
> include/mesos/v1/mesos.proto c6c1dae5494d9270a7a43a2d838769574ae47872
> src/common/http.cpp 80848aafe27eb0c35222ad236e671a32c4ab10aa
> src/common/protobuf_utils.cpp 77139d8a3931dc1e9e00fcea83d77d96244a34f3
> src/tests/health_check_tests.cpp c972b9003196b4b4272d7c34311c84c117b1ae3d
>
>
> Diff: https://reviews.apache.org/r/69110/diff/2/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 69110: Added task health check definitions to
master API responses.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69110/#review209841
-----------------------------------------------------------
PASS: Mesos patch 69110 was successfully built and tested.
Reviews applied: `['69110']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2503/mesos-review-69110
- Mesos Reviewbot Windows
On Oct. 22, 2018, 5:35 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69110/
> -----------------------------------------------------------
>
> (Updated Oct. 22, 2018, 5:35 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Gastón Kleiman, and Vinod Kone.
>
>
> Bugs: MESOS-8780
> https://issues.apache.org/jira/browse/MESOS-8780
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The Task protobuf message is updated to include the health check
> definition of a task when it is specified. Associated helpers are
> also updated along with a test which verifies that this field is
> reflected in master API responses.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 72966da75bc90d4b5d891e209e786e5326155d17
> include/mesos/v1/mesos.proto c6c1dae5494d9270a7a43a2d838769574ae47872
> src/common/http.cpp 80848aafe27eb0c35222ad236e671a32c4ab10aa
> src/common/protobuf_utils.cpp 77139d8a3931dc1e9e00fcea83d77d96244a34f3
> src/tests/health_check_tests.cpp c972b9003196b4b4272d7c34311c84c117b1ae3d
>
>
> Diff: https://reviews.apache.org/r/69110/diff/2/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 69110: Added task health check definitions to
master API responses.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69110/#review210017
-----------------------------------------------------------
PASS: Mesos patch 69110 was successfully built and tested.
Reviews applied: `['69110']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2527/mesos-review-69110
- Mesos Reviewbot Windows
On Oct. 24, 2018, 5:51 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69110/
> -----------------------------------------------------------
>
> (Updated Oct. 24, 2018, 5:51 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Gastón Kleiman, and Vinod Kone.
>
>
> Bugs: MESOS-8780
> https://issues.apache.org/jira/browse/MESOS-8780
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The Task protobuf message is updated to include the health check
> definition of a task when it is specified. Associated helpers are
> also updated along with a test which verifies that this field is
> reflected in master API responses.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 72966da75bc90d4b5d891e209e786e5326155d17
> include/mesos/v1/mesos.proto c6c1dae5494d9270a7a43a2d838769574ae47872
> src/common/http.cpp 80848aafe27eb0c35222ad236e671a32c4ab10aa
> src/common/protobuf_utils.cpp 77139d8a3931dc1e9e00fcea83d77d96244a34f3
> src/tests/api_tests.cpp c681b9b0b83f7472312083730a5433e3d6f0efc0
> src/tests/health_check_tests.cpp c972b9003196b4b4272d7c34311c84c117b1ae3d
>
>
> Diff: https://reviews.apache.org/r/69110/diff/4/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 69110: Added task health check definitions to
master API responses.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69110/#review210122
-----------------------------------------------------------
PASS: Mesos patch 69110 was successfully built and tested.
Reviews applied: `['69110']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2540/mesos-review-69110
- Mesos Reviewbot Windows
On Oct. 26, 2018, 3:08 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69110/
> -----------------------------------------------------------
>
> (Updated Oct. 26, 2018, 3:08 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Gastón Kleiman, and Vinod Kone.
>
>
> Bugs: MESOS-8780
> https://issues.apache.org/jira/browse/MESOS-8780
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The Task protobuf message is updated to include the health check
> definition of a task when it is specified. Associated helpers are
> also updated along with a test which verifies that this field is
> reflected in master API responses.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 72966da75bc90d4b5d891e209e786e5326155d17
> include/mesos/v1/mesos.proto c6c1dae5494d9270a7a43a2d838769574ae47872
> src/common/http.cpp 80848aafe27eb0c35222ad236e671a32c4ab10aa
> src/common/protobuf_utils.cpp 77139d8a3931dc1e9e00fcea83d77d96244a34f3
> src/tests/api_tests.cpp 97fd0bb891235302beda37f2eb8418677317df93
> src/tests/health_check_tests.cpp c972b9003196b4b4272d7c34311c84c117b1ae3d
>
>
> Diff: https://reviews.apache.org/r/69110/diff/6/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 69110: Added task health check definitions to
master API responses.
Posted by Gastón Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69110/#review210120
-----------------------------------------------------------
Ship it!
Ship It!
- Gastón Kleiman
On Oct. 26, 2018, 3:08 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69110/
> -----------------------------------------------------------
>
> (Updated Oct. 26, 2018, 3:08 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Gastón Kleiman, and Vinod Kone.
>
>
> Bugs: MESOS-8780
> https://issues.apache.org/jira/browse/MESOS-8780
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The Task protobuf message is updated to include the health check
> definition of a task when it is specified. Associated helpers are
> also updated along with a test which verifies that this field is
> reflected in master API responses.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 72966da75bc90d4b5d891e209e786e5326155d17
> include/mesos/v1/mesos.proto c6c1dae5494d9270a7a43a2d838769574ae47872
> src/common/http.cpp 80848aafe27eb0c35222ad236e671a32c4ab10aa
> src/common/protobuf_utils.cpp 77139d8a3931dc1e9e00fcea83d77d96244a34f3
> src/tests/api_tests.cpp 97fd0bb891235302beda37f2eb8418677317df93
> src/tests/health_check_tests.cpp c972b9003196b4b4272d7c34311c84c117b1ae3d
>
>
> Diff: https://reviews.apache.org/r/69110/diff/6/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 69110: Added task health check definitions to
master API responses.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69110/#review210142
-----------------------------------------------------------
PASS: Mesos patch 69110 was successfully built and tested.
Reviews applied: `['69110']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2544/mesos-review-69110
- Mesos Reviewbot Windows
On Oct. 29, 2018, 5:54 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69110/
> -----------------------------------------------------------
>
> (Updated Oct. 29, 2018, 5:54 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Gastón Kleiman, and Vinod Kone.
>
>
> Bugs: MESOS-8780
> https://issues.apache.org/jira/browse/MESOS-8780
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The Task protobuf message is updated to include the health check
> definition of a task when it is specified. Associated helpers are
> also updated along with a test which verifies that this field is
> reflected in master API responses.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 72966da75bc90d4b5d891e209e786e5326155d17
> include/mesos/v1/mesos.proto c6c1dae5494d9270a7a43a2d838769574ae47872
> src/common/http.cpp 80848aafe27eb0c35222ad236e671a32c4ab10aa
> src/common/protobuf_utils.cpp 77139d8a3931dc1e9e00fcea83d77d96244a34f3
> src/tests/api_tests.cpp 97fd0bb891235302beda37f2eb8418677317df93
> src/tests/health_check_tests.cpp c972b9003196b4b4272d7c34311c84c117b1ae3d
>
>
> Diff: https://reviews.apache.org/r/69110/diff/7/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 69110: Added task health check definitions to
master API responses.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69110/
-----------------------------------------------------------
(Updated Oct. 29, 2018, 5:54 p.m.)
Review request for mesos, Alexander Rukletsov, Gastón Kleiman, and Vinod Kone.
Bugs: MESOS-8780
https://issues.apache.org/jira/browse/MESOS-8780
Repository: mesos
Description
-------
The Task protobuf message is updated to include the health check
definition of a task when it is specified. Associated helpers are
also updated along with a test which verifies that this field is
reflected in master API responses.
Diffs (updated)
-----
include/mesos/mesos.proto 72966da75bc90d4b5d891e209e786e5326155d17
include/mesos/v1/mesos.proto c6c1dae5494d9270a7a43a2d838769574ae47872
src/common/http.cpp 80848aafe27eb0c35222ad236e671a32c4ab10aa
src/common/protobuf_utils.cpp 77139d8a3931dc1e9e00fcea83d77d96244a34f3
src/tests/api_tests.cpp 97fd0bb891235302beda37f2eb8418677317df93
src/tests/health_check_tests.cpp c972b9003196b4b4272d7c34311c84c117b1ae3d
Diff: https://reviews.apache.org/r/69110/diff/7/
Changes: https://reviews.apache.org/r/69110/diff/6-7/
Testing
-------
`make check`
Thanks,
Greg Mann
Re: Review Request 69110: Added task health check definitions to
master API responses.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69110/
-----------------------------------------------------------
(Updated Oct. 26, 2018, 10:08 p.m.)
Review request for mesos, Alexander Rukletsov, Gastón Kleiman, and Vinod Kone.
Bugs: MESOS-8780
https://issues.apache.org/jira/browse/MESOS-8780
Repository: mesos
Description
-------
The Task protobuf message is updated to include the health check
definition of a task when it is specified. Associated helpers are
also updated along with a test which verifies that this field is
reflected in master API responses.
Diffs (updated)
-----
include/mesos/mesos.proto 72966da75bc90d4b5d891e209e786e5326155d17
include/mesos/v1/mesos.proto c6c1dae5494d9270a7a43a2d838769574ae47872
src/common/http.cpp 80848aafe27eb0c35222ad236e671a32c4ab10aa
src/common/protobuf_utils.cpp 77139d8a3931dc1e9e00fcea83d77d96244a34f3
src/tests/api_tests.cpp 97fd0bb891235302beda37f2eb8418677317df93
src/tests/health_check_tests.cpp c972b9003196b4b4272d7c34311c84c117b1ae3d
Diff: https://reviews.apache.org/r/69110/diff/6/
Changes: https://reviews.apache.org/r/69110/diff/5-6/
Testing
-------
`make check`
Thanks,
Greg Mann
Re: Review Request 69110: Added task health check definitions to
master API responses.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69110/#review210058
-----------------------------------------------------------
PASS: Mesos patch 69110 was successfully built and tested.
Reviews applied: `['69110']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2532/mesos-review-69110
- Mesos Reviewbot Windows
On Oct. 25, 2018, 9:01 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69110/
> -----------------------------------------------------------
>
> (Updated Oct. 25, 2018, 9:01 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Gastón Kleiman, and Vinod Kone.
>
>
> Bugs: MESOS-8780
> https://issues.apache.org/jira/browse/MESOS-8780
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The Task protobuf message is updated to include the health check
> definition of a task when it is specified. Associated helpers are
> also updated along with a test which verifies that this field is
> reflected in master API responses.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 72966da75bc90d4b5d891e209e786e5326155d17
> include/mesos/v1/mesos.proto c6c1dae5494d9270a7a43a2d838769574ae47872
> src/common/http.cpp 80848aafe27eb0c35222ad236e671a32c4ab10aa
> src/common/protobuf_utils.cpp 77139d8a3931dc1e9e00fcea83d77d96244a34f3
> src/tests/api_tests.cpp 97fd0bb891235302beda37f2eb8418677317df93
> src/tests/health_check_tests.cpp c972b9003196b4b4272d7c34311c84c117b1ae3d
>
>
> Diff: https://reviews.apache.org/r/69110/diff/5/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 69110: Added task health check definitions to
master API responses.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69110/
-----------------------------------------------------------
(Updated Oct. 25, 2018, 9:01 p.m.)
Review request for mesos, Alexander Rukletsov, Gastón Kleiman, and Vinod Kone.
Bugs: MESOS-8780
https://issues.apache.org/jira/browse/MESOS-8780
Repository: mesos
Description
-------
The Task protobuf message is updated to include the health check
definition of a task when it is specified. Associated helpers are
also updated along with a test which verifies that this field is
reflected in master API responses.
Diffs (updated)
-----
include/mesos/mesos.proto 72966da75bc90d4b5d891e209e786e5326155d17
include/mesos/v1/mesos.proto c6c1dae5494d9270a7a43a2d838769574ae47872
src/common/http.cpp 80848aafe27eb0c35222ad236e671a32c4ab10aa
src/common/protobuf_utils.cpp 77139d8a3931dc1e9e00fcea83d77d96244a34f3
src/tests/api_tests.cpp 97fd0bb891235302beda37f2eb8418677317df93
src/tests/health_check_tests.cpp c972b9003196b4b4272d7c34311c84c117b1ae3d
Diff: https://reviews.apache.org/r/69110/diff/5/
Changes: https://reviews.apache.org/r/69110/diff/4-5/
Testing
-------
`make check`
Thanks,
Greg Mann
Re: Review Request 69110: Added task health check definitions to
master API responses.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69110/
-----------------------------------------------------------
(Updated Oct. 25, 2018, 12:51 a.m.)
Review request for mesos, Alexander Rukletsov, Gastón Kleiman, and Vinod Kone.
Bugs: MESOS-8780
https://issues.apache.org/jira/browse/MESOS-8780
Repository: mesos
Description
-------
The Task protobuf message is updated to include the health check
definition of a task when it is specified. Associated helpers are
also updated along with a test which verifies that this field is
reflected in master API responses.
Diffs (updated)
-----
include/mesos/mesos.proto 72966da75bc90d4b5d891e209e786e5326155d17
include/mesos/v1/mesos.proto c6c1dae5494d9270a7a43a2d838769574ae47872
src/common/http.cpp 80848aafe27eb0c35222ad236e671a32c4ab10aa
src/common/protobuf_utils.cpp 77139d8a3931dc1e9e00fcea83d77d96244a34f3
src/tests/api_tests.cpp c681b9b0b83f7472312083730a5433e3d6f0efc0
src/tests/health_check_tests.cpp c972b9003196b4b4272d7c34311c84c117b1ae3d
Diff: https://reviews.apache.org/r/69110/diff/4/
Changes: https://reviews.apache.org/r/69110/diff/3-4/
Testing
-------
`make check`
Thanks,
Greg Mann
Re: Review Request 69110: Added task health check definitions to
master API responses.
Posted by Greg Mann <gr...@mesosphere.io>.
> On Oct. 23, 2018, 8:56 a.m., Alexander Rukletsov wrote:
> > src/tests/health_check_tests.cpp
> > Lines 460-466 (patched)
> > <https://reviews.apache.org/r/69110/diff/3/?file=2101856#file2101856line460>
> >
> > What do you think about moving this blob to `AgentAPITest::GetState`? It will be consistent with the `TASK_ADDED` test.
I went ahead and did this thing.
- Greg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69110/#review209914
-----------------------------------------------------------
On Oct. 25, 2018, 12:51 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69110/
> -----------------------------------------------------------
>
> (Updated Oct. 25, 2018, 12:51 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Gastón Kleiman, and Vinod Kone.
>
>
> Bugs: MESOS-8780
> https://issues.apache.org/jira/browse/MESOS-8780
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The Task protobuf message is updated to include the health check
> definition of a task when it is specified. Associated helpers are
> also updated along with a test which verifies that this field is
> reflected in master API responses.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 72966da75bc90d4b5d891e209e786e5326155d17
> include/mesos/v1/mesos.proto c6c1dae5494d9270a7a43a2d838769574ae47872
> src/common/http.cpp 80848aafe27eb0c35222ad236e671a32c4ab10aa
> src/common/protobuf_utils.cpp 77139d8a3931dc1e9e00fcea83d77d96244a34f3
> src/tests/api_tests.cpp c681b9b0b83f7472312083730a5433e3d6f0efc0
> src/tests/health_check_tests.cpp c972b9003196b4b4272d7c34311c84c117b1ae3d
>
>
> Diff: https://reviews.apache.org/r/69110/diff/4/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 69110: Added task health check definitions to
master API responses.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69110/#review209914
-----------------------------------------------------------
src/tests/health_check_tests.cpp
Lines 460-466 (patched)
<https://reviews.apache.org/r/69110/#comment294552>
What do you think about moving this blob to `AgentAPITest::GetState`? It will be consistent with the `TASK_ADDED` test.
- Alexander Rukletsov
On Oct. 22, 2018, 6:37 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69110/
> -----------------------------------------------------------
>
> (Updated Oct. 22, 2018, 6:37 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Gastón Kleiman, and Vinod Kone.
>
>
> Bugs: MESOS-8780
> https://issues.apache.org/jira/browse/MESOS-8780
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The Task protobuf message is updated to include the health check
> definition of a task when it is specified. Associated helpers are
> also updated along with a test which verifies that this field is
> reflected in master API responses.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 72966da75bc90d4b5d891e209e786e5326155d17
> include/mesos/v1/mesos.proto c6c1dae5494d9270a7a43a2d838769574ae47872
> src/common/http.cpp 80848aafe27eb0c35222ad236e671a32c4ab10aa
> src/common/protobuf_utils.cpp 77139d8a3931dc1e9e00fcea83d77d96244a34f3
> src/tests/api_tests.cpp c681b9b0b83f7472312083730a5433e3d6f0efc0
> src/tests/health_check_tests.cpp c972b9003196b4b4272d7c34311c84c117b1ae3d
>
>
> Diff: https://reviews.apache.org/r/69110/diff/3/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 69110: Added task health check definitions to
master API responses.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69110/#review209896
-----------------------------------------------------------
PASS: Mesos patch 69110 was successfully built and tested.
Reviews applied: `['69110']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2511/mesos-review-69110
- Mesos Reviewbot Windows
On Oct. 22, 2018, 6:37 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69110/
> -----------------------------------------------------------
>
> (Updated Oct. 22, 2018, 6:37 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Gastón Kleiman, and Vinod Kone.
>
>
> Bugs: MESOS-8780
> https://issues.apache.org/jira/browse/MESOS-8780
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The Task protobuf message is updated to include the health check
> definition of a task when it is specified. Associated helpers are
> also updated along with a test which verifies that this field is
> reflected in master API responses.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 72966da75bc90d4b5d891e209e786e5326155d17
> include/mesos/v1/mesos.proto c6c1dae5494d9270a7a43a2d838769574ae47872
> src/common/http.cpp 80848aafe27eb0c35222ad236e671a32c4ab10aa
> src/common/protobuf_utils.cpp 77139d8a3931dc1e9e00fcea83d77d96244a34f3
> src/tests/api_tests.cpp c681b9b0b83f7472312083730a5433e3d6f0efc0
> src/tests/health_check_tests.cpp c972b9003196b4b4272d7c34311c84c117b1ae3d
>
>
> Diff: https://reviews.apache.org/r/69110/diff/3/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 69110: Added task health check definitions to
master API responses.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69110/
-----------------------------------------------------------
(Updated Oct. 22, 2018, 6:37 p.m.)
Review request for mesos, Alexander Rukletsov, Gastón Kleiman, and Vinod Kone.
Bugs: MESOS-8780
https://issues.apache.org/jira/browse/MESOS-8780
Repository: mesos
Description (updated)
-------
The Task protobuf message is updated to include the health check
definition of a task when it is specified. Associated helpers are
also updated along with a test which verifies that this field is
reflected in master API responses.
Diffs
-----
include/mesos/mesos.proto 72966da75bc90d4b5d891e209e786e5326155d17
include/mesos/v1/mesos.proto c6c1dae5494d9270a7a43a2d838769574ae47872
src/common/http.cpp 80848aafe27eb0c35222ad236e671a32c4ab10aa
src/common/protobuf_utils.cpp 77139d8a3931dc1e9e00fcea83d77d96244a34f3
src/tests/api_tests.cpp c681b9b0b83f7472312083730a5433e3d6f0efc0
src/tests/health_check_tests.cpp c972b9003196b4b4272d7c34311c84c117b1ae3d
Diff: https://reviews.apache.org/r/69110/diff/3/
Testing
-------
`make check`
Thanks,
Greg Mann
Re: Review Request 69110: Added task health check definitions to
master API responses.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69110/
-----------------------------------------------------------
(Updated Oct. 22, 2018, 6:20 p.m.)
Review request for mesos, Alexander Rukletsov, Gastón Kleiman, and Vinod Kone.
Bugs: MESOS-8780
https://issues.apache.org/jira/browse/MESOS-8780
Repository: mesos
Description (updated)
-------
Added task health check definitions to master API responses.
Diffs (updated)
-----
include/mesos/mesos.proto 72966da75bc90d4b5d891e209e786e5326155d17
include/mesos/v1/mesos.proto c6c1dae5494d9270a7a43a2d838769574ae47872
src/common/http.cpp 80848aafe27eb0c35222ad236e671a32c4ab10aa
src/common/protobuf_utils.cpp 77139d8a3931dc1e9e00fcea83d77d96244a34f3
src/tests/api_tests.cpp c681b9b0b83f7472312083730a5433e3d6f0efc0
src/tests/health_check_tests.cpp c972b9003196b4b4272d7c34311c84c117b1ae3d
Diff: https://reviews.apache.org/r/69110/diff/3/
Changes: https://reviews.apache.org/r/69110/diff/2-3/
Testing
-------
`make check`
Thanks,
Greg Mann
Re: Review Request 69110: Added task health check definitions to
master API responses.
Posted by Greg Mann <gr...@mesosphere.io>.
> On Oct. 22, 2018, 8:42 a.m., Alexander Rukletsov wrote:
> > include/mesos/mesos.proto
> > Lines 2200-2201 (patched)
> > <https://reviews.apache.org/r/69110/diff/2/?file=2101740#file2101740line2200>
> >
> > Let's add a `TODO` here for `CheckInfo`. Here and below.
I went ahead and modified `MasterAPITest.Subscribe` to verify the TASK_ADDED event, PTAL.
- Greg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69110/#review209842
-----------------------------------------------------------
On Oct. 22, 2018, 6:20 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69110/
> -----------------------------------------------------------
>
> (Updated Oct. 22, 2018, 6:20 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Gastón Kleiman, and Vinod Kone.
>
>
> Bugs: MESOS-8780
> https://issues.apache.org/jira/browse/MESOS-8780
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added task health check definitions to master API responses.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 72966da75bc90d4b5d891e209e786e5326155d17
> include/mesos/v1/mesos.proto c6c1dae5494d9270a7a43a2d838769574ae47872
> src/common/http.cpp 80848aafe27eb0c35222ad236e671a32c4ab10aa
> src/common/protobuf_utils.cpp 77139d8a3931dc1e9e00fcea83d77d96244a34f3
> src/tests/api_tests.cpp c681b9b0b83f7472312083730a5433e3d6f0efc0
> src/tests/health_check_tests.cpp c972b9003196b4b4272d7c34311c84c117b1ae3d
>
>
> Diff: https://reviews.apache.org/r/69110/diff/3/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 69110: Added task health check definitions to
master API responses.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69110/#review209842
-----------------------------------------------------------
Fix it, then Ship it!
Let's make sure we also add a test for the contents of `TASK_ADDED` soon and add expose check definitions as well.
include/mesos/mesos.proto
Lines 2200-2201 (patched)
<https://reviews.apache.org/r/69110/#comment294455>
Let's add a `TODO` here for `CheckInfo`. Here and below.
- Alexander Rukletsov
On Oct. 22, 2018, 5:35 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69110/
> -----------------------------------------------------------
>
> (Updated Oct. 22, 2018, 5:35 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Gastón Kleiman, and Vinod Kone.
>
>
> Bugs: MESOS-8780
> https://issues.apache.org/jira/browse/MESOS-8780
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The Task protobuf message is updated to include the health check
> definition of a task when it is specified. Associated helpers are
> also updated along with a test which verifies that this field is
> reflected in master API responses.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 72966da75bc90d4b5d891e209e786e5326155d17
> include/mesos/v1/mesos.proto c6c1dae5494d9270a7a43a2d838769574ae47872
> src/common/http.cpp 80848aafe27eb0c35222ad236e671a32c4ab10aa
> src/common/protobuf_utils.cpp 77139d8a3931dc1e9e00fcea83d77d96244a34f3
> src/tests/health_check_tests.cpp c972b9003196b4b4272d7c34311c84c117b1ae3d
>
>
> Diff: https://reviews.apache.org/r/69110/diff/2/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 69110: Added task health check definitions to
master API responses.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69110/
-----------------------------------------------------------
(Updated Oct. 22, 2018, 5:35 a.m.)
Review request for mesos, Alexander Rukletsov, Gastón Kleiman, and Vinod Kone.
Bugs: MESOS-8780
https://issues.apache.org/jira/browse/MESOS-8780
Repository: mesos
Description (updated)
-------
The Task protobuf message is updated to include the health check
definition of a task when it is specified. Associated helpers are
also updated along with a test which verifies that this field is
reflected in master API responses.
Diffs
-----
include/mesos/mesos.proto 72966da75bc90d4b5d891e209e786e5326155d17
include/mesos/v1/mesos.proto c6c1dae5494d9270a7a43a2d838769574ae47872
src/common/http.cpp 80848aafe27eb0c35222ad236e671a32c4ab10aa
src/common/protobuf_utils.cpp 77139d8a3931dc1e9e00fcea83d77d96244a34f3
src/tests/health_check_tests.cpp c972b9003196b4b4272d7c34311c84c117b1ae3d
Diff: https://reviews.apache.org/r/69110/diff/2/
Testing
-------
`make check`
Thanks,
Greg Mann
Re: Review Request 69110: Added task health check definitions to
master API responses.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69110/
-----------------------------------------------------------
(Updated Oct. 22, 2018, 5:35 a.m.)
Review request for mesos, Alexander Rukletsov, Gastón Kleiman, and Vinod Kone.
Bugs: MESOS-8780
https://issues.apache.org/jira/browse/MESOS-8780
Repository: mesos
Description (updated)
-------
Added task health check definitions to master API responses.
Diffs (updated)
-----
include/mesos/mesos.proto 72966da75bc90d4b5d891e209e786e5326155d17
include/mesos/v1/mesos.proto c6c1dae5494d9270a7a43a2d838769574ae47872
src/common/http.cpp 80848aafe27eb0c35222ad236e671a32c4ab10aa
src/common/protobuf_utils.cpp 77139d8a3931dc1e9e00fcea83d77d96244a34f3
src/tests/health_check_tests.cpp c972b9003196b4b4272d7c34311c84c117b1ae3d
Diff: https://reviews.apache.org/r/69110/diff/2/
Changes: https://reviews.apache.org/r/69110/diff/1-2/
Testing
-------
`make check`
Thanks,
Greg Mann