You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Meng Zhu <mz...@mesosphere.io> on 2018/10/20 01:27:32 UTC
Review Request 69093: Removed `used` argument in `AgentProfile` in the
allocator benchmark.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69093/
-----------------------------------------------------------
Review request for mesos, Benjamin Mahler and Gastón Kleiman.
Repository: mesos
Description
-------
Currently in the `HierarchicalAllocations_BENCHMARK_TestBase`,
it is not easy to add agents with used resources because
frameworks are created during the initialization which is
after the agent profiles creation.
Diffs
-----
src/tests/hierarchical_allocator_benchmarks.cpp bf9167b63747f7b8a402d950947028436307082a
Diff: https://reviews.apache.org/r/69093/diff/1/
Testing
-------
make check
Thanks,
Meng Zhu
Re: Review Request 69093: Removed `used` argument in `AgentProfile`
in the allocator benchmark.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69093/#review210289
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Mahler
On Oct. 20, 2018, 1:27 a.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69093/
> -----------------------------------------------------------
>
> (Updated Oct. 20, 2018, 1:27 a.m.)
>
>
> Review request for mesos, Benjamin Mahler and Gastón Kleiman.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Currently in the `HierarchicalAllocations_BENCHMARK_TestBase`,
> it is not easy to add agents with used resources because
> frameworks are created during the initialization which is
> after the agent profiles creation.
>
>
> Diffs
> -----
>
> src/tests/hierarchical_allocator_benchmarks.cpp bf9167b63747f7b8a402d950947028436307082a
>
>
> Diff: https://reviews.apache.org/r/69093/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 69093: Removed `used` argument in `AgentProfile`
in the allocator benchmark.
Posted by Meng Zhu <mz...@mesosphere.io>.
> On Oct. 24, 2018, 5:20 p.m., Benjamin Mahler wrote:
> > src/tests/hierarchical_allocator_benchmarks.cpp
> > Line 234 (original), 234 (patched)
> > <https://reviews.apache.org/r/69093/diff/1/?file=2101097#file2101097line237>
> >
> > Hm.. how were you able to change this while it remained correct? Was this just an empty map always?
Yeah, it is currently not used. (So far there is only one benchmark in the suite and it does not utilize it). During the fixture code review, I recommended Kapil to add the option to specify used resources because some of the existing benchmarks in `hierarchical_allocator_test.cpp ` setup agents with pre-allocated resources.
Now I realize that we can't easily do this during our cluster setup. Because when we specify the `agentProfile`, no framework has been created yet. I am actually not quite sure why we need to specify `used`. In the future if necessary, we can always create a bunch of frameworks with their own quota roles to simulate this right after the cluster initialization.
- Meng
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69093/#review210007
-----------------------------------------------------------
On Oct. 19, 2018, 6:27 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69093/
> -----------------------------------------------------------
>
> (Updated Oct. 19, 2018, 6:27 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and Gastón Kleiman.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Currently in the `HierarchicalAllocations_BENCHMARK_TestBase`,
> it is not easy to add agents with used resources because
> frameworks are created during the initialization which is
> after the agent profiles creation.
>
>
> Diffs
> -----
>
> src/tests/hierarchical_allocator_benchmarks.cpp bf9167b63747f7b8a402d950947028436307082a
>
>
> Diff: https://reviews.apache.org/r/69093/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 69093: Removed `used` argument in `AgentProfile`
in the allocator benchmark.
Posted by Benjamin Mahler <bm...@apache.org>.
> On Oct. 25, 2018, 12:20 a.m., Benjamin Mahler wrote:
> > src/tests/hierarchical_allocator_benchmarks.cpp
> > Line 234 (original), 234 (patched)
> > <https://reviews.apache.org/r/69093/diff/1/?file=2101097#file2101097line237>
> >
> > Hm.. how were you able to change this while it remained correct? Was this just an empty map always?
>
> Meng Zhu wrote:
> Yeah, it is currently not used. (So far there is only one benchmark in the suite and it does not utilize it). During the fixture code review, I recommended Kapil to add the option to specify used resources because some of the existing benchmarks in `hierarchical_allocator_test.cpp ` setup agents with pre-allocated resources.
>
> Now I realize that we can't easily do this during our cluster setup. Because when we specify the `agentProfile`, no framework has been created yet. I am actually not quite sure why we need to specify `used`. In the future if necessary, we can always create a bunch of frameworks with their own quota roles to simulate this right after the cluster initialization.
Can you clarify some of this in the description?
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69093/#review210007
-----------------------------------------------------------
On Oct. 20, 2018, 1:27 a.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69093/
> -----------------------------------------------------------
>
> (Updated Oct. 20, 2018, 1:27 a.m.)
>
>
> Review request for mesos, Benjamin Mahler and Gastón Kleiman.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Currently in the `HierarchicalAllocations_BENCHMARK_TestBase`,
> it is not easy to add agents with used resources because
> frameworks are created during the initialization which is
> after the agent profiles creation.
>
>
> Diffs
> -----
>
> src/tests/hierarchical_allocator_benchmarks.cpp bf9167b63747f7b8a402d950947028436307082a
>
>
> Diff: https://reviews.apache.org/r/69093/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 69093: Removed `used` argument in `AgentProfile`
in the allocator benchmark.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69093/#review210007
-----------------------------------------------------------
src/tests/hierarchical_allocator_benchmarks.cpp
Line 234 (original), 234 (patched)
<https://reviews.apache.org/r/69093/#comment294644>
Hm.. how were you able to change this while it remained correct? Was this just an empty map always?
- Benjamin Mahler
On Oct. 20, 2018, 1:27 a.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69093/
> -----------------------------------------------------------
>
> (Updated Oct. 20, 2018, 1:27 a.m.)
>
>
> Review request for mesos, Benjamin Mahler and Gastón Kleiman.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Currently in the `HierarchicalAllocations_BENCHMARK_TestBase`,
> it is not easy to add agents with used resources because
> frameworks are created during the initialization which is
> after the agent profiles creation.
>
>
> Diffs
> -----
>
> src/tests/hierarchical_allocator_benchmarks.cpp bf9167b63747f7b8a402d950947028436307082a
>
>
> Diff: https://reviews.apache.org/r/69093/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>