You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Armand Grillet <ag...@mesosphere.io> on 2018/10/10 14:45:02 UTC
Review Request 68977: Added Record-IO encoder and decoder to new CLI.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68977/
-----------------------------------------------------------
Review request for mesos and Kevin Klues.
Bugs: MESOS-6551
https://issues.apache.org/jira/browse/MESOS-6551
Repository: mesos
Description
-------
Added Record-IO encoder and decoder to new CLI.
Diffs
-----
src/python/cli_new/lib/cli/recordio.py PRE-CREATION
Diff: https://reviews.apache.org/r/68977/diff/1/
Testing
-------
Thanks,
Armand Grillet
Re: Review Request 68977: Added Record-IO encoder and decoder to
Python library.
Posted by Armand Grillet <ag...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68977/
-----------------------------------------------------------
(Updated Okt. 16, 2018, 12:35 nachm.)
Review request for mesos and Kevin Klues.
Changes
-------
Updated test instructions
Bugs: MESOS-6551
https://issues.apache.org/jira/browse/MESOS-6551
Repository: mesos
Description
-------
Added Record-IO encoder and decoder to Python library.
This code was pulled directly from:
https://github.com/dcos/dcos-core-cli/blob/7fd55421939a7782c237e2b8719c0fe2f543acd7/python/lib/dcos/dcos/recordio.py
https://github.com/dcos/dcos-core-cli/blob/7fd55421939a7782c237e2b8719c0fe2f543acd7/python/lib/dcos/tests/test_recordio.py
It will be used by the new CLI for commands such as `task exec`.
Diffs
-----
src/python/lib/mesos/__init__.py 40219c5e03915754b61fc5d7263a063f0d18cca1
src/python/lib/mesos/recordio.py PRE-CREATION
src/python/lib/tests/test_recordio.py PRE-CREATION
Diff: https://reviews.apache.org/r/68977/diff/4/
Testing (updated)
-------
```
$ tox -e py3-test -- -vvv -k test_recordio
py3-test installed: atomicwrites==1.2.1,attrs==18.2.0,certifi==2018.10.15,chardet==3.0.4,coverage==4.5.1,idna==2.7,mock==2.0.0,more-itertools==4.3.0,pbr==4.3.0,pluggy==0.8.0,py==1.7.0,pytest==3.7.3,pytest-cov==2.5.1,requests==2.19.1,six==1.11.0,tenacity==4.12.0,ujson==1.35,urllib3==1.23
py3-test runtests: PYTHONHASHSEED='3750347574'
py3-test runtests: commands[0] | py.test -vvv -k test_recordio
==================================================================== test session starts ====================================================================
platform linux -- Python 3.6.2, pytest-3.7.3, py-1.7.0, pluggy-0.8.0 -- /home/mesosphere.com/klueska/mesos/src/python/lib/.tox/py3-test/bin/python3
cachedir: .pytest_cache
rootdir: /home/mesosphere.com/klueska/mesos/src/python/lib, inifile:
plugins: cov-2.5.1
collected 26 items / 24 deselected
tests/test_recordio.py::test_encode PASSED [ 50%]
tests/test_recordio.py::test_encode_decode PASSED [100%]
========================================================== 2 passed, 24 deselected in 0.18 seconds ==========================================================
__________________________________________________________________________ summary __________________________________________________________________________
py3-test: commands succeeded
congratulations :)
```
Thanks,
Armand Grillet
Re: Review Request 68977: Added Record-IO encoder and decoder to
Python library.
Posted by Armand Grillet <ag...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68977/
-----------------------------------------------------------
(Updated Okt. 16, 2018, 12:16 nachm.)
Review request for mesos and Kevin Klues.
Changes
-------
Changed description
Bugs: MESOS-6551
https://issues.apache.org/jira/browse/MESOS-6551
Repository: mesos
Description (updated)
-------
Added Record-IO encoder and decoder to Python library.
This code was pulled directly from:
https://github.com/dcos/dcos-core-cli/blob/7fd55421939a7782c237e2b8719c0fe2f543acd7/python/lib/dcos/dcos/recordio.py
https://github.com/dcos/dcos-core-cli/blob/7fd55421939a7782c237e2b8719c0fe2f543acd7/python/lib/dcos/tests/test_recordio.py
It will be used by the new CLI for commands such as `task exec`.
Diffs
-----
src/python/lib/mesos/__init__.py 40219c5e03915754b61fc5d7263a063f0d18cca1
src/python/lib/mesos/recordio.py PRE-CREATION
src/python/lib/tests/test_recordio.py PRE-CREATION
Diff: https://reviews.apache.org/r/68977/diff/4/
Testing
-------
```
(mesos-cli) ? python (MESOS-6551) ? mesos-cli-tests
Running the Mesos CLI unit tests
TestAgentPlugin
test_list (cli.tests.agent.TestAgentPlugin) ... ok
TestInfrastructure
test_capture_output (cli.tests.tests.TestInfrastructure) ... ok
test_launch_binaries (cli.tests.tests.TestInfrastructure) ... ok
TestRecordIO
test_encode (cli.tests.recordio.TestRecordIO) ... ok
test_encode_decode (cli.tests.recordio.TestRecordIO) ... ok
TestTaskPlugin
test_list (cli.tests.task.TestTaskPlugin) ... ok
----------------------------------------------------------------------
Ran 6 tests in 5.008s
OK
```
Thanks,
Armand Grillet
Re: Review Request 68977: Added Record-IO encoder and decoder to new
CLI.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68977/#review209507
-----------------------------------------------------------
PASS: Mesos patch 68977 was successfully built and tested.
Reviews applied: `['68971', '68977']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2458/mesos-review-68977
- Mesos Reviewbot Windows
On Oct. 12, 2018, 9:16 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68977/
> -----------------------------------------------------------
>
> (Updated Oct. 12, 2018, 9:16 p.m.)
>
>
> Review request for mesos and Kevin Klues.
>
>
> Bugs: MESOS-6551
> https://issues.apache.org/jira/browse/MESOS-6551
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added Record-IO encoder and decoder to new CLI.
>
>
> Diffs
> -----
>
> src/python/cli_new/lib/cli/recordio.py PRE-CREATION
> src/python/cli_new/lib/cli/tests/__init__.py 144cb338e9453c7f68d74a58620ee9d2345e363d
> src/python/cli_new/lib/cli/tests/recordio.py PRE-CREATION
> src/python/cli_new/tests/main.py ef02fdd6ae30ef4eaaf7fb534baed594b28349e6
>
>
> Diff: https://reviews.apache.org/r/68977/diff/3/
>
>
> Testing
> -------
>
> ```
> (mesos-cli) ? python (MESOS-6551) ? mesos-cli-tests
> Running the Mesos CLI unit tests
>
> TestAgentPlugin
> test_list (cli.tests.agent.TestAgentPlugin) ... ok
>
> TestInfrastructure
> test_capture_output (cli.tests.tests.TestInfrastructure) ... ok
> test_launch_binaries (cli.tests.tests.TestInfrastructure) ... ok
>
> TestRecordIO
> test_encode (cli.tests.recordio.TestRecordIO) ... ok
> test_encode_decode (cli.tests.recordio.TestRecordIO) ... ok
>
> TestTaskPlugin
> test_list (cli.tests.task.TestTaskPlugin) ... ok
>
> ----------------------------------------------------------------------
> Ran 6 tests in 5.008s
>
> OK
> ```
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 68977: Added Record-IO encoder and decoder to new
CLI.
Posted by Armand Grillet <ag...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68977/
-----------------------------------------------------------
(Updated oct. 12, 2018, 11:16 après-midi)
Review request for mesos and Kevin Klues.
Changes
-------
Added tests.
Bugs: MESOS-6551
https://issues.apache.org/jira/browse/MESOS-6551
Repository: mesos
Description
-------
Added Record-IO encoder and decoder to new CLI.
Diffs (updated)
-----
src/python/cli_new/lib/cli/recordio.py PRE-CREATION
src/python/cli_new/lib/cli/tests/__init__.py 144cb338e9453c7f68d74a58620ee9d2345e363d
src/python/cli_new/lib/cli/tests/recordio.py PRE-CREATION
src/python/cli_new/tests/main.py ef02fdd6ae30ef4eaaf7fb534baed594b28349e6
Diff: https://reviews.apache.org/r/68977/diff/3/
Changes: https://reviews.apache.org/r/68977/diff/2-3/
Testing (updated)
-------
```
(mesos-cli) ? python (MESOS-6551) ? mesos-cli-tests
Running the Mesos CLI unit tests
TestAgentPlugin
test_list (cli.tests.agent.TestAgentPlugin) ... ok
TestInfrastructure
test_capture_output (cli.tests.tests.TestInfrastructure) ... ok
test_launch_binaries (cli.tests.tests.TestInfrastructure) ... ok
TestRecordIO
test_encode (cli.tests.recordio.TestRecordIO) ... ok
test_encode_decode (cli.tests.recordio.TestRecordIO) ... ok
TestTaskPlugin
test_list (cli.tests.task.TestTaskPlugin) ... ok
----------------------------------------------------------------------
Ran 6 tests in 5.008s
OK
```
Thanks,
Armand Grillet