You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Till Toenshoff via Review Board <no...@reviews.apache.org> on 2018/10/03 16:51:03 UTC
Review Request 68914: Updated libevent linkage to adhere to best
practices.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68914/
-----------------------------------------------------------
Review request for mesos, Benjamin Bannier and James Peach.
Bugs: MESOS-9222
https://issues.apache.org/jira/browse/MESOS-9222
Repository: mesos
Description
-------
libevent is a combination of libevent_core and libevent_extra. Mesos
and libprocess do not make use of any libevent_extra functionality.
Additionally, linking against libevent is against best practices.
Replaces use of libevent with libevent_core in both libevent.m4 as
well as the libprocess linkage.
Diffs
-----
3rdparty/libprocess/Makefile.am 22b1395ce69f4ac630367427542fa1ad4c88b50b
3rdparty/libprocess/m4/libevent.m4 3a7fcad7d0c2d967fb308714c4b1f631c988001b
Diff: https://reviews.apache.org/r/68914/diff/1/
Testing
-------
make check
Thanks,
Till Toenshoff
Re: Review Request 68914: Updated libevent linkage to adhere to best
practices.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68914/#review209213
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Rojas
On Oct. 3, 2018, 6:51 p.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68914/
> -----------------------------------------------------------
>
> (Updated Oct. 3, 2018, 6:51 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and James Peach.
>
>
> Bugs: MESOS-9222
> https://issues.apache.org/jira/browse/MESOS-9222
>
>
> Repository: mesos
>
>
> Description
> -------
>
> libevent is a combination of libevent_core and libevent_extra. Mesos
> and libprocess do not make use of any libevent_extra functionality.
>
> Additionally, linking against libevent is against best practices.
>
> Replaces use of libevent with libevent_core in both libevent.m4 as
> well as the libprocess linkage.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/Makefile.am 22b1395ce69f4ac630367427542fa1ad4c88b50b
> 3rdparty/libprocess/m4/libevent.m4 3a7fcad7d0c2d967fb308714c4b1f631c988001b
>
>
> Diff: https://reviews.apache.org/r/68914/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 68914: Updated libevent linkage to adhere to best
practices.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68914/#review209237
-----------------------------------------------------------
Ship it!
Ship It!
- James Peach
On Oct. 3, 2018, 4:51 p.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68914/
> -----------------------------------------------------------
>
> (Updated Oct. 3, 2018, 4:51 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and James Peach.
>
>
> Bugs: MESOS-9222
> https://issues.apache.org/jira/browse/MESOS-9222
>
>
> Repository: mesos
>
>
> Description
> -------
>
> libevent is a combination of libevent_core and libevent_extra. Mesos
> and libprocess do not make use of any libevent_extra functionality.
>
> Additionally, linking against libevent is against best practices.
>
> Replaces use of libevent with libevent_core in both libevent.m4 as
> well as the libprocess linkage.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/Makefile.am 22b1395ce69f4ac630367427542fa1ad4c88b50b
> 3rdparty/libprocess/m4/libevent.m4 3a7fcad7d0c2d967fb308714c4b1f631c988001b
>
>
> Diff: https://reviews.apache.org/r/68914/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Till Toenshoff
>
>