You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2018/10/25 10:47:24 UTC

Review Request 69158: Added an integration test for resource provider removal.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69158/
-----------------------------------------------------------

Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.


Bugs: MESOS-8403
    https://issues.apache.org/jira/browse/MESOS-8403


Repository: mesos


Description
-------

Added an integration test for resource provider removal.


Diffs
-----

  src/tests/slave_tests.cpp 637bedce20f63dfc1702ef549bcea8f790477be3 


Diff: https://reviews.apache.org/r/69158/diff/1/


Testing
-------

`make check`


Thanks,

Benjamin Bannier


Re: Review Request 69158: Added an integration test for resource provider removal.

Posted by Benjamin Bannier <be...@mesosphere.io>.

> On Jan. 15, 2019, 6:58 a.m., Chun-Hung Hsiao wrote:
> > src/tests/slave_tests.cpp
> > Lines 10625-10626 (patched)
> > <https://reviews.apache.org/r/69158/diff/4/?file=2111265#file2111265line10625>
> >
> >     ```
> >     Owned<MasterDetector> detector = master.get()->createDetector();
> >     Try<Owned<cluster::Slave>> slave = StartSlave(detector.get(), slavFlags);
> >     ```

Could you explain the pattern we follow? I mostly went for a `StandaloneMasterDetector` instead of an `Owned<MasterDetector>` because of the conceptually simpler type (value vs pointer), but we seem to use both here.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69158/#review211996
-----------------------------------------------------------


On Jan. 15, 2019, 4:03 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69158/
> -----------------------------------------------------------
> 
> (Updated Jan. 15, 2019, 4:03 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.
> 
> 
> Bugs: MESOS-8403
>     https://issues.apache.org/jira/browse/MESOS-8403
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added an integration test for resource provider removal.
> 
> 
> Diffs
> -----
> 
>   src/tests/slave_tests.cpp dc711de96053ebecb6b71b98f14f22cb9b050c52 
> 
> 
> Diff: https://reviews.apache.org/r/69158/diff/5/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Re: Review Request 69158: Added an integration test for resource provider removal.

Posted by Benjamin Bannier <be...@mesosphere.io>.

> On Jan. 15, 2019, 6:58 a.m., Chun-Hung Hsiao wrote:
> > src/tests/slave_tests.cpp
> > Lines 10625-10626 (patched)
> > <https://reviews.apache.org/r/69158/diff/4/?file=2111265#file2111265line10625>
> >
> >     ```
> >     Owned<MasterDetector> detector = master.get()->createDetector();
> >     Try<Owned<cluster::Slave>> slave = StartSlave(detector.get(), slavFlags);
> >     ```
> 
> Benjamin Bannier wrote:
>     Could you explain the pattern we follow? I mostly went for a `StandaloneMasterDetector` instead of an `Owned<MasterDetector>` because of the conceptually simpler type (value vs pointer), but we seem to use both here.

Dropping, see discussion in https://reviews.apache.org/r/68147/#comment_rc297584-212023.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69158/#review211996
-----------------------------------------------------------


On Jan. 16, 2019, 11:51 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69158/
> -----------------------------------------------------------
> 
> (Updated Jan. 16, 2019, 11:51 a.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.
> 
> 
> Bugs: MESOS-8403
>     https://issues.apache.org/jira/browse/MESOS-8403
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added an integration test for resource provider removal.
> 
> 
> Diffs
> -----
> 
>   src/tests/slave_tests.cpp dc711de96053ebecb6b71b98f14f22cb9b050c52 
> 
> 
> Diff: https://reviews.apache.org/r/69158/diff/6/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Re: Review Request 69158: Added an integration test for resource provider removal.

Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69158/#review211996
-----------------------------------------------------------




src/tests/slave_tests.cpp
Lines 10617 (patched)
<https://reviews.apache.org/r/69158/#comment297583>

    We could rename it to `updateSlaveMessage` and reuse it below.



src/tests/slave_tests.cpp
Lines 10625-10626 (patched)
<https://reviews.apache.org/r/69158/#comment297585>

    ```
    Owned<MasterDetector> detector = master.get()->createDetector();
    Try<Owned<cluster::Slave>> slave = StartSlave(detector.get(), slavFlags);
    ```



src/tests/slave_tests.cpp
Lines 10633 (patched)
<https://reviews.apache.org/r/69158/#comment297586>

    `org.apache.mesos.rp.test`, or maybe `org.apache.mesos.rp.mock`, for consistency.



src/tests/slave_tests.cpp
Lines 10652 (patched)
<https://reviews.apache.org/r/69158/#comment297582>

    `std::move(endpointDetector)`


- Chun-Hung Hsiao


On Oct. 25, 2018, 10:47 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69158/
> -----------------------------------------------------------
> 
> (Updated Oct. 25, 2018, 10:47 a.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.
> 
> 
> Bugs: MESOS-8403
>     https://issues.apache.org/jira/browse/MESOS-8403
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added an integration test for resource provider removal.
> 
> 
> Diffs
> -----
> 
>   src/tests/slave_tests.cpp 1e918712d73d0a03c4c15b41babff1f649ba9c07 
> 
> 
> Diff: https://reviews.apache.org/r/69158/diff/4/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Re: Review Request 69158: Added an integration test for resource provider removal.

Posted by Benjamin Bannier <be...@mesosphere.io>.

> On Jan. 17, 2019, 6:13 a.m., Chun-Hung Hsiao wrote:
> > src/tests/slave_tests.cpp
> > Lines 10755 (patched)
> > <https://reviews.apache.org/r/69158/diff/6/?file=2119934#file2119934line10755>
> >
> >     We can use a const reference here: `const v1::ResourceProviderID&`

Moved down to first use.


> On Jan. 17, 2019, 6:13 a.m., Chun-Hung Hsiao wrote:
> > src/tests/slave_tests.cpp
> > Lines 10834 (patched)
> > <https://reviews.apache.org/r/69158/diff/6/?file=2119934#file2119934line10834>
> >
> >     If you think it is a good idea to create this alias, how about moving it to the beginning so the above two occurrences of `ContentType::PROTOBUF` can all be replaced?

Hmm. The other uses of `ContentType`s have no relation to the one here and do not need to be identical. We need all entities using `contentType` to use the same value though. Dropping.


> On Jan. 17, 2019, 6:13 a.m., Chun-Hung Hsiao wrote:
> > src/tests/slave_tests.cpp
> > Lines 10895-10902 (patched)
> > <https://reviews.apache.org/r/69158/diff/6/?file=2119934#file2119934line10895>
> >
> >     Is the order guaranteed? If yes, it seems to me that it is sufficient to just verify that the scheduler receives `OPERATION_GONE_BY_OPERATOR` right? The order validation here makes the test a bit hard to follow, so I suggest just remove the check here, as well as the two futures.
> >     
> >     If the order is not guaranteed, then it seems we have a problem to resolve.

Yes, with the way the agent handler for `ResourceProviderMessage::Type::REMOVE` is written we currently always send the status update before the agent resource update. Removed this extra test. Like you write, should we ever break this invariant this test would already fail.

I added a comment to `src/slave.cpp` in https://reviews.apache.org/r/68147 to make this more explicit.


> On Jan. 17, 2019, 6:13 a.m., Chun-Hung Hsiao wrote:
> > src/tests/slave_tests.cpp
> > Lines 10924-10926 (patched)
> > <https://reviews.apache.org/r/69158/diff/6/?file=2119934#file2119934line10924>
> >
> >     To make this check more reliable, we should add a `Clock::settle()` at the end of the test.
> >     
> >     Even so, it cannot 100% verify the property to test since HTTP messages could be in transmission when the test stops.

Good point about settling the clock.

While I agree that a test for "X never happens" can never be 100% certain (one would need to wait forever to test "never"), it sets up a falsifiable model for the test which adds value (a single failure would be enough to prove that the test assumption are incorrect; see K. Popper et al. :D ).


> On Jan. 17, 2019, 6:13 a.m., Chun-Hung Hsiao wrote:
> > src/tests/slave_tests.cpp
> > Lines 10946 (patched)
> > <https://reviews.apache.org/r/69158/diff/6/?file=2119934#file2119934line10946>
> >
> >     Let's check that the operation status has an agent ID but no resource provider ID.

Very good point. Adding this check uncovered that we didn't set the agent ID in the status update like noted by you here, https://reviews.apache.org/r/68147/#comment297704.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69158/#review212104
-----------------------------------------------------------


On Jan. 17, 2019, 12:17 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69158/
> -----------------------------------------------------------
> 
> (Updated Jan. 17, 2019, 12:17 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.
> 
> 
> Bugs: MESOS-8403
>     https://issues.apache.org/jira/browse/MESOS-8403
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added an integration test for resource provider removal.
> 
> 
> Diffs
> -----
> 
>   src/tests/slave_tests.cpp dc711de96053ebecb6b71b98f14f22cb9b050c52 
> 
> 
> Diff: https://reviews.apache.org/r/69158/diff/7/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Re: Review Request 69158: Added an integration test for resource provider removal.

Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69158/#review212104
-----------------------------------------------------------




src/tests/slave_tests.cpp
Lines 10731 (patched)
<https://reviews.apache.org/r/69158/#comment297710>

    `v1::ResourceProviderInfo`



src/tests/slave_tests.cpp
Lines 10755 (patched)
<https://reviews.apache.org/r/69158/#comment297709>

    We can use a const reference here: `const v1::ResourceProviderID&`



src/tests/slave_tests.cpp
Lines 10834 (patched)
<https://reviews.apache.org/r/69158/#comment297711>

    If you think it is a good idea to create this alias, how about moving it to the beginning so the above two occurrences of `ContentType::PROTOBUF` can all be replaced?



src/tests/slave_tests.cpp
Lines 10895-10902 (patched)
<https://reviews.apache.org/r/69158/#comment297712>

    Is the order guaranteed? If yes, it seems to me that it is sufficient to just verify that the scheduler receives `OPERATION_GONE_BY_OPERATOR` right? The order validation here makes the test a bit hard to follow, so I suggest just remove the check here, as well as the two futures.
    
    If the order is not guaranteed, then it seems we have a problem to resolve.



src/tests/slave_tests.cpp
Lines 10924-10926 (patched)
<https://reviews.apache.org/r/69158/#comment297713>

    To make this check more reliable, we should add a `Clock::settle()` at the end of the test.
    
    Even so, it cannot 100% verify the property to test since HTTP messages could be in transmission when the test stops.



src/tests/slave_tests.cpp
Lines 10946 (patched)
<https://reviews.apache.org/r/69158/#comment297714>

    Let's check that the operation status has an agent ID but no resource provider ID.


- Chun-Hung Hsiao


On Jan. 16, 2019, 10:51 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69158/
> -----------------------------------------------------------
> 
> (Updated Jan. 16, 2019, 10:51 a.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.
> 
> 
> Bugs: MESOS-8403
>     https://issues.apache.org/jira/browse/MESOS-8403
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added an integration test for resource provider removal.
> 
> 
> Diffs
> -----
> 
>   src/tests/slave_tests.cpp dc711de96053ebecb6b71b98f14f22cb9b050c52 
> 
> 
> Diff: https://reviews.apache.org/r/69158/diff/6/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Re: Review Request 69158: Added an integration test for resource provider removal.

Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69158/#review212097
-----------------------------------------------------------



Patch looks great!

Reviews applied: [68147, 69158]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Jan. 16, 2019, 10:51 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69158/
> -----------------------------------------------------------
> 
> (Updated Jan. 16, 2019, 10:51 a.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.
> 
> 
> Bugs: MESOS-8403
>     https://issues.apache.org/jira/browse/MESOS-8403
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added an integration test for resource provider removal.
> 
> 
> Diffs
> -----
> 
>   src/tests/slave_tests.cpp dc711de96053ebecb6b71b98f14f22cb9b050c52 
> 
> 
> Diff: https://reviews.apache.org/r/69158/diff/6/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Re: Review Request 69158: Added an integration test for resource provider removal.

Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69158/#review212124
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/slave_tests.cpp
Lines 10721 (patched)
<https://reviews.apache.org/r/69158/#comment297744>

    This is not necessary.



src/tests/slave_tests.cpp
Lines 10792-10794 (patched)
<https://reviews.apache.org/r/69158/#comment297747>

    Nit: indent by extra 2 spaces. I'd suggest that we don't break the line after `if (`, or break it after the first &&:
    ```
    if (resource.has_provider_id() &&
        resource.has_disk() &&
        ...) {
      rawDisk = resources;
      break;
    }
    ```
    So the condition and body are distinguishable.



src/tests/slave_tests.cpp
Lines 10802 (patched)
<https://reviews.apache.org/r/69158/#comment297748>

    The term "inject" make me think that this operation is injected through an internal mechanism. How about just say "Create a pending operation."?



src/tests/slave_tests.cpp
Lines 10863 (patched)
<https://reviews.apache.org/r/69158/#comment297742>

    an operation



src/tests/slave_tests.cpp
Lines 10880 (patched)
<https://reviews.apache.org/r/69158/#comment297749>

    there is no resource managed


- Chun-Hung Hsiao


On Jan. 17, 2019, 11:17 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69158/
> -----------------------------------------------------------
> 
> (Updated Jan. 17, 2019, 11:17 a.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.
> 
> 
> Bugs: MESOS-8403
>     https://issues.apache.org/jira/browse/MESOS-8403
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added an integration test for resource provider removal.
> 
> 
> Diffs
> -----
> 
>   src/tests/slave_tests.cpp dc711de96053ebecb6b71b98f14f22cb9b050c52 
> 
> 
> Diff: https://reviews.apache.org/r/69158/diff/7/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Re: Review Request 69158: Added an integration test for resource provider removal.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69158/#review212138
-----------------------------------------------------------



PASS: Mesos patch 69158 was successfully built and tested.

Reviews applied: `['68147', '69158']`

All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2800/mesos-review-69158

- Mesos Reviewbot Windows


On Jan. 18, 2019, 9:39 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69158/
> -----------------------------------------------------------
> 
> (Updated Jan. 18, 2019, 9:39 a.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.
> 
> 
> Bugs: MESOS-8403
>     https://issues.apache.org/jira/browse/MESOS-8403
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added an integration test for resource provider removal.
> 
> 
> Diffs
> -----
> 
>   src/tests/slave_tests.cpp dc711de96053ebecb6b71b98f14f22cb9b050c52 
> 
> 
> Diff: https://reviews.apache.org/r/69158/diff/8/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Re: Review Request 69158: Added an integration test for resource provider removal.

Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69158/
-----------------------------------------------------------

(Updated Jan. 18, 2019, 10:39 a.m.)


Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.


Changes
-------

Addressed comments from Chun.


Bugs: MESOS-8403
    https://issues.apache.org/jira/browse/MESOS-8403


Repository: mesos


Description
-------

Added an integration test for resource provider removal.


Diffs (updated)
-----

  src/tests/slave_tests.cpp dc711de96053ebecb6b71b98f14f22cb9b050c52 


Diff: https://reviews.apache.org/r/69158/diff/8/

Changes: https://reviews.apache.org/r/69158/diff/7-8/


Testing
-------

`make check`


Thanks,

Benjamin Bannier


Re: Review Request 69158: Added an integration test for resource provider removal.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69158/#review212111
-----------------------------------------------------------



PASS: Mesos patch 69158 was successfully built and tested.

Reviews applied: `['69782', '68147', '69158']`

All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2797/mesos-review-69158

- Mesos Reviewbot Windows


On Jan. 17, 2019, 3:17 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69158/
> -----------------------------------------------------------
> 
> (Updated Jan. 17, 2019, 3:17 a.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.
> 
> 
> Bugs: MESOS-8403
>     https://issues.apache.org/jira/browse/MESOS-8403
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added an integration test for resource provider removal.
> 
> 
> Diffs
> -----
> 
>   src/tests/slave_tests.cpp dc711de96053ebecb6b71b98f14f22cb9b050c52 
> 
> 
> Diff: https://reviews.apache.org/r/69158/diff/7/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Re: Review Request 69158: Added an integration test for resource provider removal.

Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69158/
-----------------------------------------------------------

(Updated Jan. 17, 2019, 12:17 p.m.)


Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.


Bugs: MESOS-8403
    https://issues.apache.org/jira/browse/MESOS-8403


Repository: mesos


Description
-------

Added an integration test for resource provider removal.


Diffs (updated)
-----

  src/tests/slave_tests.cpp dc711de96053ebecb6b71b98f14f22cb9b050c52 


Diff: https://reviews.apache.org/r/69158/diff/7/

Changes: https://reviews.apache.org/r/69158/diff/6-7/


Testing
-------

`make check`


Thanks,

Benjamin Bannier


Re: Review Request 69158: Added an integration test for resource provider removal.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69158/#review212062
-----------------------------------------------------------



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['68147', '69158']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2787/mesos-review-69158

Relevant logs:

- [mesos-tests.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2787/mesos-review-69158/logs/mesos-tests.log):

```
[  FAILED  ] DockerContainerizerTest.ROOT_DOCKER_SkipRecoverMalformedUUID
[  FAILED  ] DockerContainerizerTest.ROOT_DOCKER_Logs
[  FAILED  ] DockerContainerizerTest.ROOT_DOCKER_Default_CMD
[  FAILED  ] DockerContainerizerTest.ROOT_DOCKER_Default_CMD_Override
[  FAILED  ] DockerContainerizerTest.ROOT_DOCKER_Default_CMD_Args
[  FAILED  ] DockerContainerizerTest.ROOT_DOCKER_SlaveRecoveryTaskContainer
[  FAILED  ] DockerContainerizerTest.ROOT_DOCKER_DestroyWhileFetching
[  FAILED  ] DockerContainerizerTest.ROOT_DOCKER_DestroyWhilePulling
[  FAILED  ] DockerContainerizerTest.ROOT_DOCKER_DestroyUnknownContainer
[  FAILED  ] DockerContainerizerTest.ROOT_DOCKER_ExecutorCleanupWhenLaunchFailed
[  FAILED  ] DockerContainerizerTest.ROOT_DOCKER_FetchFailure
[  FAILED  ] DockerContainerizerTest.ROOT_DOCKER_DockerPullFailure
[  FAILED  ] DockerContainerizerTest.ROOT_DOCKER_DockerInspectDiscard
[  FAILED  ] DockerContainerizerTest.ROOT_DOCKER_WaitUnknownContainer
[  FAILED  ] DockerContainerizerTest.ROOT_DOCKER_NoTransitionFromKillingToRunning
[  FAILED  ] DockerContainerizerTest.ROOT_DOCKER_DefaultDNS
[  FAILED  ] HungDockerTest.ROOT_DOCKER_InspectHungDuringPull

28 FAILED TESTS
  YOU HAVE 231 DISABLED TESTS

W0116 12:02:21.055682 22508 process.cpp:1423] Failed to recv on socket WindowsFD::Type::SOCKET=4972 to peer '192.10.1.6:61888': IO failed with error code: The specified network name is no longer available.

W0116 12:02:21.056619 22508 process.cpp:838] Failed to recv on socket WindowsFD::Type::SOCKET=5024 to peer '192.10.1.6:61889': IO failed with error code: The specified network name is no longer available.

I0116 12:02:21.063669 26216 containerizer.cpp:2975] Container 9e9bf139-68d6-446c-bb0c-0d7f4ca0759c has exited
I0116 12:02:21.092643 27024 master.cpp:1109] Master terminating
I0116 12:02:21.093622 26036 hierarchical.cpp:644] Removed agent 5bc25a6c-ba74-49a0-8ed6-f78f7bc7aec3-S0
I0116 12:02:21.535652 22508 process.cpp:927] Stopped the socket accept loop
```

- Mesos Reviewbot Windows


On Jan. 16, 2019, 10:51 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69158/
> -----------------------------------------------------------
> 
> (Updated Jan. 16, 2019, 10:51 a.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.
> 
> 
> Bugs: MESOS-8403
>     https://issues.apache.org/jira/browse/MESOS-8403
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added an integration test for resource provider removal.
> 
> 
> Diffs
> -----
> 
>   src/tests/slave_tests.cpp dc711de96053ebecb6b71b98f14f22cb9b050c52 
> 
> 
> Diff: https://reviews.apache.org/r/69158/diff/6/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Re: Review Request 69158: Added an integration test for resource provider removal.

Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69158/
-----------------------------------------------------------

(Updated Jan. 16, 2019, 11:51 a.m.)


Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.


Changes
-------

Rebased.


Bugs: MESOS-8403
    https://issues.apache.org/jira/browse/MESOS-8403


Repository: mesos


Description
-------

Added an integration test for resource provider removal.


Diffs (updated)
-----

  src/tests/slave_tests.cpp dc711de96053ebecb6b71b98f14f22cb9b050c52 


Diff: https://reviews.apache.org/r/69158/diff/6/

Changes: https://reviews.apache.org/r/69158/diff/5-6/


Testing
-------

`make check`


Thanks,

Benjamin Bannier


Re: Review Request 69158: Added an integration test for resource provider removal.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69158/#review212042
-----------------------------------------------------------



PASS: Mesos patch 69158 was successfully built and tested.

Reviews applied: `['68147', '69158']`

All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2786/mesos-review-69158

- Mesos Reviewbot Windows


On Jan. 15, 2019, 7:03 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69158/
> -----------------------------------------------------------
> 
> (Updated Jan. 15, 2019, 7:03 a.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.
> 
> 
> Bugs: MESOS-8403
>     https://issues.apache.org/jira/browse/MESOS-8403
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added an integration test for resource provider removal.
> 
> 
> Diffs
> -----
> 
>   src/tests/slave_tests.cpp dc711de96053ebecb6b71b98f14f22cb9b050c52 
> 
> 
> Diff: https://reviews.apache.org/r/69158/diff/5/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Re: Review Request 69158: Added an integration test for resource provider removal.

Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69158/
-----------------------------------------------------------

(Updated Jan. 15, 2019, 4:03 p.m.)


Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.


Changes
-------

Addressed comments from Chun.


Bugs: MESOS-8403
    https://issues.apache.org/jira/browse/MESOS-8403


Repository: mesos


Description
-------

Added an integration test for resource provider removal.


Diffs (updated)
-----

  src/tests/slave_tests.cpp dc711de96053ebecb6b71b98f14f22cb9b050c52 


Diff: https://reviews.apache.org/r/69158/diff/5/

Changes: https://reviews.apache.org/r/69158/diff/4-5/


Testing
-------

`make check`


Thanks,

Benjamin Bannier


Re: Review Request 69158: Added an integration test for resource provider removal.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69158/#review212001
-----------------------------------------------------------



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['68147', '69158']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2777/mesos-review-69158

Relevant logs:

- [mesos-tests.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2777/mesos-review-69158/logs/mesos-tests.log):

```
I0115 07:01:03.731181 22536 master.cpp:11261] Removing task f96991dc-9e45-48b2-b6f6-d489f376b9ef with resources cpus(allocated: *):4; mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: *):[31000-32000] of framework 7972cd61-c070-44f2-b12d-f375b0d167d6-0000 on agent 7972cd61-c070-44f2-b12d-f375b0d167d6-S0 at slave(471)@192.10.1.6:55857 (windows-02.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0115 07:01:03.734197 22536 master.cpp:1269] Agent 7972cd61-c070-44f2-b12d-f375b0d167d6-S0 at slave(471)@192.10.1.6:55857 (windows-02.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net) disconnected
I0115 07:01:03.734197 22536 master.cpp:3272] Disconnecting agent 7972cd61-c070-44f2-b12d-f375b0d167d6-S0 at slave(471)@192.10.1.6:55857 (windows-02.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0115 07:01:03.734197 22536 master.cpp:3291] Deactivating agent 7972cd61-c070-44f2-b12d-f375b0d167d6-S0 at slave(471)@192.10.1.6:55857 (windows-02.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0115 07:01:03.735185 22808 hierarchical.cpp:358] Removed framework 7972cd61-c070-44f2-b12d-f375b0d167d6-0000
I0115 07:01:03.735185 22808 hierarchical.cpp:802] Agent 7972cd61-c070-44f2-b12d-f375b0d167d6-S0 deactivated
I0115 07:01:03.736189 17752 containerizer.cpp:2469] Destroying container 26fb0c01-af27-4d31-b9ce-8294baba13ea in RUNNING state
I0115 07:01:03.736189 17752 containerizer.cpp:3136] Transitioning the state of container 26fb0c01-af27-4d31-b9ce-8294b[       OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (590 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (606 ms total)

[----------] Global test environment tear-down
[==========] 1088 tests from 104 test cases ran. (501935 ms total)
[  PASSED  ] 1087 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] ContentType/MasterAPITest.OperationUpdatesUponAgentGone/0, where GetParam() = application/x-protobuf

 1 FAILED TEST
  YOU HAVE 231 DISABLED TESTS

aba13ea from RUNNING to DESTROYING
I0115 07:01:03.736189 17752 launcher.cpp:161] Asked to destroy container 26fb0c01-af27-4d31-b9ce-8294baba13ea
W0115 07:01:03.737174 24084 process.cpp:1423] Failed to recv on socket WindowsFD::Type::SOCKET=11992 to peer '192.10.1.6:57736': IO failed with error code: The specified network name is no longer available.

W0115 07:01:03.737174 24084 process.cpp:838] Failed to recv on socket WindowsFD::Type::SOCKET=12044 to peer '192.10.1.6:57737': IO failed with error code: The specified network name is no longer available.

I0115 07:01:03.743180 22536 containerizer.cpp:2975] Container 26fb0c01-af27-4d31-b9ce-8294baba13ea has exited
I0115 07:01:03.771181  2236 master.cpp:1109] Master terminating
I0115 07:01:03.773178 20280 hierarchical.cpp:644] Removed agent 7972cd61-c070-44f2-b12d-f375b0d167d6-S0
I0115 07:01:04.118175 24084 process.cpp:927] Stopped the socket accept loop
```

- Mesos Reviewbot Windows


On Oct. 25, 2018, 6:47 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69158/
> -----------------------------------------------------------
> 
> (Updated Oct. 25, 2018, 6:47 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.
> 
> 
> Bugs: MESOS-8403
>     https://issues.apache.org/jira/browse/MESOS-8403
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added an integration test for resource provider removal.
> 
> 
> Diffs
> -----
> 
>   src/tests/slave_tests.cpp 1e918712d73d0a03c4c15b41babff1f649ba9c07 
> 
> 
> Diff: https://reviews.apache.org/r/69158/diff/4/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Re: Review Request 69158: Added an integration test for resource provider removal.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69158/#review210032
-----------------------------------------------------------



PASS: Mesos patch 69158 was successfully built and tested.

Reviews applied: `['68147', '69157', '69158']`

All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2528/mesos-review-69158

- Mesos Reviewbot Windows


On Oct. 25, 2018, 10:47 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69158/
> -----------------------------------------------------------
> 
> (Updated Oct. 25, 2018, 10:47 a.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.
> 
> 
> Bugs: MESOS-8403
>     https://issues.apache.org/jira/browse/MESOS-8403
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added an integration test for resource provider removal.
> 
> 
> Diffs
> -----
> 
>   src/tests/slave_tests.cpp 637bedce20f63dfc1702ef549bcea8f790477be3 
> 
> 
> Diff: https://reviews.apache.org/r/69158/diff/1/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Re: Review Request 69158: Added an integration test for resource provider removal.

Posted by Benjamin Bannier <be...@mesosphere.io>.

> On Jan. 15, 2019, 7:08 a.m., Chun-Hung Hsiao wrote:
> > src/tests/slave_tests.cpp
> > Lines 10609 (patched)
> > <https://reviews.apache.org/r/69158/diff/4/?file=2111265#file2111265line10609>
> >
> >     Maybe move this to `AgentAPITest.OperationStatusUpdateUponResourceProviderGone`? We have `MasterAPITest.TaskUpdatesUponAgentGone` there.

Unfortunately this tests multiple aspects (disconnection of gone RPs, transition of operations -- updated the test docstring to account for that). Given the former, I believe it makes more sense to keep it here. WDYT?


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69158/#review211998
-----------------------------------------------------------


On Jan. 15, 2019, 4:03 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69158/
> -----------------------------------------------------------
> 
> (Updated Jan. 15, 2019, 4:03 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.
> 
> 
> Bugs: MESOS-8403
>     https://issues.apache.org/jira/browse/MESOS-8403
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added an integration test for resource provider removal.
> 
> 
> Diffs
> -----
> 
>   src/tests/slave_tests.cpp dc711de96053ebecb6b71b98f14f22cb9b050c52 
> 
> 
> Diff: https://reviews.apache.org/r/69158/diff/5/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Re: Review Request 69158: Added an integration test for resource provider removal.

Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69158/#review211998
-----------------------------------------------------------




src/tests/slave_tests.cpp
Lines 10609 (patched)
<https://reviews.apache.org/r/69158/#comment297587>

    Maybe move this to `AgentAPITest.OperationStatusUpdateUponResourceProviderGone`? We have `MasterAPITest.TaskUpdatesUponAgentGone` there.


- Chun-Hung Hsiao


On Oct. 25, 2018, 10:47 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69158/
> -----------------------------------------------------------
> 
> (Updated Oct. 25, 2018, 10:47 a.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.
> 
> 
> Bugs: MESOS-8403
>     https://issues.apache.org/jira/browse/MESOS-8403
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added an integration test for resource provider removal.
> 
> 
> Diffs
> -----
> 
>   src/tests/slave_tests.cpp 1e918712d73d0a03c4c15b41babff1f649ba9c07 
> 
> 
> Diff: https://reviews.apache.org/r/69158/diff/4/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>