You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jan Schlicht <ja...@mesosphere.io> on 2018/10/05 09:10:46 UTC
Review Request 68936: Fixed libevent dependency.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68936/
-----------------------------------------------------------
Review request for mesos and Till Toenshoff.
Repository: mesos
Description
-------
Using CMake with an unbundled libevent resulted in a configuration
error, because the libevent target wasn't defined.
Diffs
-----
3rdparty/CMakeLists.txt 05cbb03c6cfdceb3b10e58c42b521c792a0690ce
Diff: https://reviews.apache.org/r/68936/diff/1/
Testing
-------
On macOS:
mkdir build && cd build
cmake -DENABLE_LIBEVENT=ON -DUNBUNDLED_LIBEVENT=ON -GNinja ..
ninja
Thanks,
Jan Schlicht
Re: Review Request 68936: Fixed libevent dependency.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68936/#review209255
-----------------------------------------------------------
PASS: Mesos patch 68936 was successfully built and tested.
Reviews applied: `['68936']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2422/mesos-review-68936
- Mesos Reviewbot Windows
On Oct. 5, 2018, 9:10 a.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68936/
> -----------------------------------------------------------
>
> (Updated Oct. 5, 2018, 9:10 a.m.)
>
>
> Review request for mesos and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Using CMake with an unbundled libevent resulted in a configuration
> error, because the libevent target wasn't defined.
>
>
> Diffs
> -----
>
> 3rdparty/CMakeLists.txt 05cbb03c6cfdceb3b10e58c42b521c792a0690ce
>
>
> Diff: https://reviews.apache.org/r/68936/diff/1/
>
>
> Testing
> -------
>
> On macOS:
> mkdir build && cd build
> cmake -DENABLE_LIBEVENT=ON -DUNBUNDLED_LIBEVENT=ON -GNinja ..
> ninja
>
>
> Thanks,
>
> Jan Schlicht
>
>
Re: Review Request 68936: Fixed libevent dependency.
Posted by Till Toenshoff via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68936/#review209254
-----------------------------------------------------------
Ship it!
Ship It!
- Till Toenshoff
On Oct. 5, 2018, 9:10 a.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68936/
> -----------------------------------------------------------
>
> (Updated Oct. 5, 2018, 9:10 a.m.)
>
>
> Review request for mesos and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Using CMake with an unbundled libevent resulted in a configuration
> error, because the libevent target wasn't defined.
>
>
> Diffs
> -----
>
> 3rdparty/CMakeLists.txt 05cbb03c6cfdceb3b10e58c42b521c792a0690ce
>
>
> Diff: https://reviews.apache.org/r/68936/diff/1/
>
>
> Testing
> -------
>
> On macOS:
> mkdir build && cd build
> cmake -DENABLE_LIBEVENT=ON -DUNBUNDLED_LIBEVENT=ON -GNinja ..
> ninja
>
>
> Thanks,
>
> Jan Schlicht
>
>