You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Qian Zhang <zh...@gmail.com> on 2018/10/11 14:12:41 UTC
Review Request 68995: Removed the child hook `UNSET_CLOEXEC`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68995/
-----------------------------------------------------------
Review request for mesos, Gilbert Song and James Peach.
Bugs: MESOS-9152
https://issues.apache.org/jira/browse/MESOS-9152
Repository: mesos
Description
-------
We do not need this child hook since any file descripters need
to unset the close-on-exec flag can be put in the `whitelist_fds`
parameter of the `subprocess` method.
Diffs
-----
3rdparty/libprocess/include/process/subprocess.hpp 135bf243c7e51c88fed6c67804af7f04a2098981
3rdparty/libprocess/src/subprocess.cpp c0640de2dc4278b884282dfaad98c49c3b067a5b
Diff: https://reviews.apache.org/r/68995/diff/1/
Testing
-------
sudo make check
Thanks,
Qian Zhang
Re: Review Request 68995: Removed the child hook `UNSET_CLOEXEC`.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68995/#review209495
-----------------------------------------------------------
Ship it!
Ship It!
- James Peach
On Oct. 11, 2018, 2:12 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68995/
> -----------------------------------------------------------
>
> (Updated Oct. 11, 2018, 2:12 p.m.)
>
>
> Review request for mesos, Gilbert Song and James Peach.
>
>
> Bugs: MESOS-9152
> https://issues.apache.org/jira/browse/MESOS-9152
>
>
> Repository: mesos
>
>
> Description
> -------
>
> We do not need this child hook since any file descripters need
> to unset the close-on-exec flag can be put in the `whitelist_fds`
> parameter of the `subprocess` method.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/subprocess.hpp 135bf243c7e51c88fed6c67804af7f04a2098981
> 3rdparty/libprocess/src/subprocess.cpp c0640de2dc4278b884282dfaad98c49c3b067a5b
>
>
> Diff: https://reviews.apache.org/r/68995/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 68995: Removed the child hook `UNSET_CLOEXEC`.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68995/#review210412
-----------------------------------------------------------
Ship it!
Ship It!
- Gilbert Song
On Oct. 14, 2018, 7:14 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68995/
> -----------------------------------------------------------
>
> (Updated Oct. 14, 2018, 7:14 a.m.)
>
>
> Review request for mesos, Gilbert Song and James Peach.
>
>
> Bugs: MESOS-9164
> https://issues.apache.org/jira/browse/MESOS-9164
>
>
> Repository: mesos
>
>
> Description
> -------
>
> We do not need this child hook since any file descripters need
> to unset the close-on-exec flag can be put in the `whitelist_fds`
> parameter of the `subprocess` method.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/subprocess.hpp 135bf243c7e51c88fed6c67804af7f04a2098981
> 3rdparty/libprocess/src/subprocess.cpp c0640de2dc4278b884282dfaad98c49c3b067a5b
>
>
> Diff: https://reviews.apache.org/r/68995/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 68995: Removed the child hook `UNSET_CLOEXEC`.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68995/
-----------------------------------------------------------
(Updated Oct. 14, 2018, 10:14 p.m.)
Review request for mesos, Gilbert Song and James Peach.
Bugs: MESOS-9164
https://issues.apache.org/jira/browse/MESOS-9164
Repository: mesos
Description
-------
We do not need this child hook since any file descripters need
to unset the close-on-exec flag can be put in the `whitelist_fds`
parameter of the `subprocess` method.
Diffs
-----
3rdparty/libprocess/include/process/subprocess.hpp 135bf243c7e51c88fed6c67804af7f04a2098981
3rdparty/libprocess/src/subprocess.cpp c0640de2dc4278b884282dfaad98c49c3b067a5b
Diff: https://reviews.apache.org/r/68995/diff/1/
Testing
-------
sudo make check
Thanks,
Qian Zhang
Re: Review Request 68995: Removed the child hook `UNSET_CLOEXEC`.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68995/#review209505
-----------------------------------------------------------
Patch looks great!
Reviews applied: [68642, 68991, 68643, 68644, 68645, 68646, 68995]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Oct. 11, 2018, 2:12 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68995/
> -----------------------------------------------------------
>
> (Updated Oct. 11, 2018, 2:12 p.m.)
>
>
> Review request for mesos, Gilbert Song and James Peach.
>
>
> Bugs: MESOS-9152
> https://issues.apache.org/jira/browse/MESOS-9152
>
>
> Repository: mesos
>
>
> Description
> -------
>
> We do not need this child hook since any file descripters need
> to unset the close-on-exec flag can be put in the `whitelist_fds`
> parameter of the `subprocess` method.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/subprocess.hpp 135bf243c7e51c88fed6c67804af7f04a2098981
> 3rdparty/libprocess/src/subprocess.cpp c0640de2dc4278b884282dfaad98c49c3b067a5b
>
>
> Diff: https://reviews.apache.org/r/68995/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 68995: Removed the child hook `UNSET_CLOEXEC`.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68995/#review209458
-----------------------------------------------------------
PASS: Mesos patch 68995 was successfully built and tested.
Reviews applied: `['68642', '68991', '68643', '68644', '68645', '68646', '68995']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2453/mesos-review-68995
- Mesos Reviewbot Windows
On Oct. 11, 2018, 2:12 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68995/
> -----------------------------------------------------------
>
> (Updated Oct. 11, 2018, 2:12 p.m.)
>
>
> Review request for mesos, Gilbert Song and James Peach.
>
>
> Bugs: MESOS-9152
> https://issues.apache.org/jira/browse/MESOS-9152
>
>
> Repository: mesos
>
>
> Description
> -------
>
> We do not need this child hook since any file descripters need
> to unset the close-on-exec flag can be put in the `whitelist_fds`
> parameter of the `subprocess` method.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/subprocess.hpp 135bf243c7e51c88fed6c67804af7f04a2098981
> 3rdparty/libprocess/src/subprocess.cpp c0640de2dc4278b884282dfaad98c49c3b067a5b
>
>
> Diff: https://reviews.apache.org/r/68995/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Qian Zhang
>
>