You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Till Toenshoff via Review Board <no...@reviews.apache.org> on 2018/10/30 20:19:54 UTC
Review Request 69216: Added small style fix-ups for libevent
unbundling on CMake builds.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69216/
-----------------------------------------------------------
Review request for mesos, Benjamin Bannier and Joseph Wu.
Repository: mesos
Description
-------
Added small style fix-ups for libevent unbundling on CMake builds.
Diffs
-----
3rdparty/cmake/FindLIBEVENT.cmake 5741ef0ba450cc15a79a31b289cb8b260f16f3f2
cmake/CompilationConfigure.cmake 5d2be0adc55ac5302c2e0e62131feb65657466be
Diff: https://reviews.apache.org/r/69216/diff/1/
Testing
-------
```
cmake .. -DUNBUNDLED_LIBEVENT=ON -DUNBUNDLED_LIBARCHIVE=ON -DENABLE_SSL=ON -DENABLE_LIBEVENT=ON -G Ninja
```
Thanks,
Till Toenshoff
Re: Review Request 69216: Added small style fix-ups for libevent
unbundling on CMake builds.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69216/#review210209
-----------------------------------------------------------
Patch looks great!
Reviews applied: [69140, 69216]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Oct. 30, 2018, 8:19 p.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69216/
> -----------------------------------------------------------
>
> (Updated Oct. 30, 2018, 8:19 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added small style fix-ups for libevent unbundling on CMake builds.
>
>
> Diffs
> -----
>
> 3rdparty/cmake/FindLIBEVENT.cmake 5741ef0ba450cc15a79a31b289cb8b260f16f3f2
> cmake/CompilationConfigure.cmake 5d2be0adc55ac5302c2e0e62131feb65657466be
>
>
> Diff: https://reviews.apache.org/r/69216/diff/1/
>
>
> Testing
> -------
>
> ```
> cmake .. -DUNBUNDLED_LIBEVENT=ON -DUNBUNDLED_LIBARCHIVE=ON -DENABLE_SSL=ON -DENABLE_LIBEVENT=ON -G Ninja
> ```
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 69216: Added small style fix-ups for libevent
unbundling on CMake builds.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69216/#review210192
-----------------------------------------------------------
PASS: Mesos patch 69216 was successfully built and tested.
Reviews applied: `['69140', '69216']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2551/mesos-review-69216
- Mesos Reviewbot Windows
On Oct. 30, 2018, 9:19 p.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69216/
> -----------------------------------------------------------
>
> (Updated Oct. 30, 2018, 9:19 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added small style fix-ups for libevent unbundling on CMake builds.
>
>
> Diffs
> -----
>
> 3rdparty/cmake/FindLIBEVENT.cmake 5741ef0ba450cc15a79a31b289cb8b260f16f3f2
> cmake/CompilationConfigure.cmake 5d2be0adc55ac5302c2e0e62131feb65657466be
>
>
> Diff: https://reviews.apache.org/r/69216/diff/1/
>
>
> Testing
> -------
>
> ```
> cmake .. -DUNBUNDLED_LIBEVENT=ON -DUNBUNDLED_LIBARCHIVE=ON -DENABLE_SSL=ON -DENABLE_LIBEVENT=ON -G Ninja
> ```
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 69216: Added small style fix-ups for libevent
unbundling on CMake builds.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69216/#review210185
-----------------------------------------------------------
Ship it!
Ship It!
- Joseph Wu
On Oct. 30, 2018, 1:19 p.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69216/
> -----------------------------------------------------------
>
> (Updated Oct. 30, 2018, 1:19 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added small style fix-ups for libevent unbundling on CMake builds.
>
>
> Diffs
> -----
>
> 3rdparty/cmake/FindLIBEVENT.cmake 5741ef0ba450cc15a79a31b289cb8b260f16f3f2
> cmake/CompilationConfigure.cmake 5d2be0adc55ac5302c2e0e62131feb65657466be
>
>
> Diff: https://reviews.apache.org/r/69216/diff/1/
>
>
> Testing
> -------
>
> ```
> cmake .. -DUNBUNDLED_LIBEVENT=ON -DUNBUNDLED_LIBARCHIVE=ON -DENABLE_SSL=ON -DENABLE_LIBEVENT=ON -G Ninja
> ```
>
>
> Thanks,
>
> Till Toenshoff
>
>