You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rukletsov <ru...@gmail.com> on 2018/10/11 14:16:36 UTC
Review Request 68992: Added 'received' timestamp into
`process::Request`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68992/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman, Benno Evers, Benjamin Mahler, Gastón Kleiman, and Till Toenshoff.
Repository: mesos
Description
-------
This allows us to note when a request comes in and
hence calculate request processing time.
Diffs
-----
3rdparty/libprocess/include/process/http.hpp bbcd0bac8bab51da2dae6c052896d11a86753744
Diff: https://reviews.apache.org/r/68992/diff/1/
Testing
-------
See https://reviews.apache.org/r/68994/
Thanks,
Alexander Rukletsov
Re: Review Request 68992: Added 'received' timestamp into
`process::Request`.
Posted by Alexander Rukletsov <ru...@gmail.com>.
> On Oct. 16, 2018, 11:41 a.m., Till Toenshoff wrote:
> > 3rdparty/libprocess/include/process/http.hpp
> > Lines 568-569 (patched)
> > <https://reviews.apache.org/r/68992/diff/1/?file=2096383#file2096383line568>
> >
> > As discussed out of band, let's come up with a proper story here in a JIRA first and then get back to it.
Agreed — this suggests one possible solution, I'll remove the TODO.
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68992/#review209605
-----------------------------------------------------------
On Oct. 11, 2018, 2:16 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68992/
> -----------------------------------------------------------
>
> (Updated Oct. 11, 2018, 2:16 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Benno Evers, Benjamin Mahler, Gastón Kleiman, and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This allows us to note when a request comes in and
> hence calculate request processing time.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/http.hpp bbcd0bac8bab51da2dae6c052896d11a86753744
>
>
> Diff: https://reviews.apache.org/r/68992/diff/1/
>
>
> Testing
> -------
>
> See https://reviews.apache.org/r/68994/
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 68992: Added 'received' timestamp into
`process::Request`.
Posted by Till Toenshoff via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68992/#review209605
-----------------------------------------------------------
Fix it, then Ship it!
3rdparty/libprocess/include/process/http.hpp
Lines 568-569 (patched)
<https://reviews.apache.org/r/68992/#comment294129>
As discussed out of band, let's come up with a proper story here in a JIRA first and then get back to it.
- Till Toenshoff
On Oct. 11, 2018, 2:16 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68992/
> -----------------------------------------------------------
>
> (Updated Oct. 11, 2018, 2:16 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Benno Evers, Benjamin Mahler, Gastón Kleiman, and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This allows us to note when a request comes in and
> hence calculate request processing time.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/http.hpp bbcd0bac8bab51da2dae6c052896d11a86753744
>
>
> Diff: https://reviews.apache.org/r/68992/diff/1/
>
>
> Testing
> -------
>
> See https://reviews.apache.org/r/68994/
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 68992: Added 'received' timestamp into
`process::Request`.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68992/
-----------------------------------------------------------
(Updated Oct. 16, 2018, 11:56 a.m.)
Review request for mesos, Benjamin Hindman, Benno Evers, Benjamin Mahler, Gastón Kleiman, and Till Toenshoff.
Repository: mesos
Description
-------
This allows us to note when a request comes in and
hence calculate request processing time.
Diffs (updated)
-----
3rdparty/libprocess/include/process/http.hpp bbcd0bac8bab51da2dae6c052896d11a86753744
Diff: https://reviews.apache.org/r/68992/diff/2/
Changes: https://reviews.apache.org/r/68992/diff/1-2/
Testing
-------
See https://reviews.apache.org/r/68994/
Thanks,
Alexander Rukletsov
Re: Review Request 68992: Added 'received' timestamp into
`process::Request`.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68992/#review209457
-----------------------------------------------------------
Ship it!
Ship It!
- Benno Evers
On Oct. 11, 2018, 2:16 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68992/
> -----------------------------------------------------------
>
> (Updated Oct. 11, 2018, 2:16 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Benno Evers, Benjamin Mahler, Gastón Kleiman, and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This allows us to note when a request comes in and
> hence calculate request processing time.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/http.hpp bbcd0bac8bab51da2dae6c052896d11a86753744
>
>
> Diff: https://reviews.apache.org/r/68992/diff/1/
>
>
> Testing
> -------
>
> See https://reviews.apache.org/r/68994/
>
>
> Thanks,
>
> Alexander Rukletsov
>
>