You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Vinod Kone <vi...@apache.org> on 2018/10/03 15:05:29 UTC
Review Request 68912: Added a log line to
`MesosContainerizer::kill()`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68912/
-----------------------------------------------------------
Review request for mesos and Gilbert Song.
Repository: mesos
Description
-------
Added a log line to `MesosContainerizer::kill()`.
Diffs
-----
src/slave/containerizer/mesos/containerizer.cpp 82d64e9928abd5e22493fa697d7b0910211533f3
Diff: https://reviews.apache.org/r/68912/diff/1/
Testing
-------
make -j3 check
Ran it through internal CI.
Thanks,
Vinod Kone
Re: Review Request 68912: Added a log line to
`MesosContainerizer::kill()`.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68912/#review209192
-----------------------------------------------------------
Ship it!
Ship It!
- Gilbert Song
On Oct. 3, 2018, 8:05 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68912/
> -----------------------------------------------------------
>
> (Updated Oct. 3, 2018, 8:05 a.m.)
>
>
> Review request for mesos and Gilbert Song.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a log line to `MesosContainerizer::kill()`.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/containerizer.cpp 82d64e9928abd5e22493fa697d7b0910211533f3
>
>
> Diff: https://reviews.apache.org/r/68912/diff/1/
>
>
> Testing
> -------
>
> make -j3 check
>
> Ran it through internal CI.
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 68912: Added a log line to
`MesosContainerizer::kill()`.
Posted by Vinod Kone <vi...@apache.org>.
> On Oct. 3, 2018, 4:05 p.m., Mesos Reviewbot Windows wrote:
> > FAIL: Some of the unit tests failed. Please check the relevant logs.
> >
> > Reviews applied: `['68912']`
> >
> > Failed command: `Start-MesosCITesting`
> >
> > All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2413/mesos-review-68912
> >
> > Relevant logs:
> >
> > - [mesos-tests.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2413/mesos-review-68912/logs/mesos-tests.log):
> >
> > ```
> > W1003 16:05:33.435480 12912 slave.cpp:3917] Ignoring shutdown framework d7d1a6b8-7f3b-439c-a27a-847a8acd066c-0000 because it is terminating
> > I1003 16:05:33.436484 15652 master.cpp:1251] Agent d7d1a6b8-7f3b-439c-a27a-847a8acd066c-S0 at slave(461)@192.10.1.5:54865 (windows-02.aa0q4n2kgcyefckmv0xukjvy4f.xx.internal.cloudapp.net) disconnected
> > I1003 16:05:33.437479 15652 master.cpp:3267] Disconnecting agent d7d1a6b8-7f3b-439c-a27a-847a8acd066c-S0 at slave(461)@192.10.1.5:54865 (windows-02.aa0q4n2kgcyefckmv0xukjvy4f.xx.internal.cloudapp.net)
> > I1003 16:05:33.437479 15652 master.cpp:3286] Deactivating agent d7d1a6b8-7f3b-439c-a27a-847a8acd066c-S0 at slave(461)@192.10.1.5:54865 (windows-02.aa0q4n2kgcyefckmv0xukjvy4f.xx.internal.cloudapp.net)
> > I1003 16:05:33.437479 7924 hierarchical.cpp:359] Removed framework d7d1a6b8-7f3b-439c-a27a-847a8acd066c-0000
> > I1003 16:05:33.437479 7924 hierarchical.cpp:803] Agent d7d1a6b8-7f3b-439c-a27a-847a8acd066c-S0 deactivated
> > I1003 16:05:33.439498 8116 containerizer.cpp:2455] Destroying container 0da637c0-98a8-4ad4-ac65-6cf607cbba39 in RUNNING state
> > I1003 16:05:33.439498 8116 containerizer.cpp:3122] Transitioning the state of container 0da637c0-98a8-4ad4-ac65-6cf607cbba39 from RUNNING to DESTROYING
> > I1003 16:05:33.439498 8116 launcher.cpp:166] Asked to destroy containe[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (584 ms)
> > [----------] 1 test from IsolationFlag/MemoryIsolatorTest (603 ms total)
> >
> > [----------] Global test environment tear-down
> > d:\dcos\mesos\mesos\src\tests\environment.cpp(1126): error: Failed
> > Tests completed with child processes remaining:
> > -+- 1244 00000024FFD8E6DC
> > --- 15936 00000024FFD8E6DC
> > [==========] 1051 tests from 103 test cases ran. (489504 ms total)
> > [ PASSED ] 1051 tests.
> > [ FAILED ] 0 tests, listed below:
> >
> > 0 FAILED TESTS
> >
> > YOU HAVE 232 DISABLED TESTS
> >
> > r 0da637c0-98a8-4ad4-ac65-6cf607cbba39
> > I1003 16:05:33.471307 7924 containerizer.cpp:2961] Container 0da637c0-98a8-4ad4-ac65-6cf607cbba39 has exited
> > I1003 16:05:33.500296 14928 master.cpp:1093] Master terminating
> > I1003 16:05:33.502277 15652 hierarchical.cpp:645] Removed agent d7d1a6b8-7f3b-439c-a27a-847a8acd066c-S0
> > I1003 16:05:33.824251 17340 process.cpp:926] Stopped the socket accept loop
> > ```
@andy Is this a known issue with windows reviewbot?
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68912/#review209187
-----------------------------------------------------------
On Oct. 3, 2018, 3:05 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68912/
> -----------------------------------------------------------
>
> (Updated Oct. 3, 2018, 3:05 p.m.)
>
>
> Review request for mesos and Gilbert Song.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a log line to `MesosContainerizer::kill()`.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/containerizer.cpp 82d64e9928abd5e22493fa697d7b0910211533f3
>
>
> Diff: https://reviews.apache.org/r/68912/diff/1/
>
>
> Testing
> -------
>
> make -j3 check
>
> Ran it through internal CI.
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 68912: Added a log line to
`MesosContainerizer::kill()`.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68912/#review209187
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['68912']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2413/mesos-review-68912
Relevant logs:
- [mesos-tests.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2413/mesos-review-68912/logs/mesos-tests.log):
```
W1003 16:05:33.435480 12912 slave.cpp:3917] Ignoring shutdown framework d7d1a6b8-7f3b-439c-a27a-847a8acd066c-0000 because it is terminating
I1003 16:05:33.436484 15652 master.cpp:1251] Agent d7d1a6b8-7f3b-439c-a27a-847a8acd066c-S0 at slave(461)@192.10.1.5:54865 (windows-02.aa0q4n2kgcyefckmv0xukjvy4f.xx.internal.cloudapp.net) disconnected
I1003 16:05:33.437479 15652 master.cpp:3267] Disconnecting agent d7d1a6b8-7f3b-439c-a27a-847a8acd066c-S0 at slave(461)@192.10.1.5:54865 (windows-02.aa0q4n2kgcyefckmv0xukjvy4f.xx.internal.cloudapp.net)
I1003 16:05:33.437479 15652 master.cpp:3286] Deactivating agent d7d1a6b8-7f3b-439c-a27a-847a8acd066c-S0 at slave(461)@192.10.1.5:54865 (windows-02.aa0q4n2kgcyefckmv0xukjvy4f.xx.internal.cloudapp.net)
I1003 16:05:33.437479 7924 hierarchical.cpp:359] Removed framework d7d1a6b8-7f3b-439c-a27a-847a8acd066c-0000
I1003 16:05:33.437479 7924 hierarchical.cpp:803] Agent d7d1a6b8-7f3b-439c-a27a-847a8acd066c-S0 deactivated
I1003 16:05:33.439498 8116 containerizer.cpp:2455] Destroying container 0da637c0-98a8-4ad4-ac65-6cf607cbba39 in RUNNING state
I1003 16:05:33.439498 8116 containerizer.cpp:3122] Transitioning the state of container 0da637c0-98a8-4ad4-ac65-6cf607cbba39 from RUNNING to DESTROYING
I1003 16:05:33.439498 8116 launcher.cpp:166] Asked to destroy containe[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (584 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (603 ms total)
[----------] Global test environment tear-down
d:\dcos\mesos\mesos\src\tests\environment.cpp(1126): error: Failed
Tests completed with child processes remaining:
-+- 1244 00000024FFD8E6DC
--- 15936 00000024FFD8E6DC
[==========] 1051 tests from 103 test cases ran. (489504 ms total)
[ PASSED ] 1051 tests.
[ FAILED ] 0 tests, listed below:
0 FAILED TESTS
YOU HAVE 232 DISABLED TESTS
r 0da637c0-98a8-4ad4-ac65-6cf607cbba39
I1003 16:05:33.471307 7924 containerizer.cpp:2961] Container 0da637c0-98a8-4ad4-ac65-6cf607cbba39 has exited
I1003 16:05:33.500296 14928 master.cpp:1093] Master terminating
I1003 16:05:33.502277 15652 hierarchical.cpp:645] Removed agent d7d1a6b8-7f3b-439c-a27a-847a8acd066c-S0
I1003 16:05:33.824251 17340 process.cpp:926] Stopped the socket accept loop
```
- Mesos Reviewbot Windows
On Oct. 3, 2018, 3:05 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68912/
> -----------------------------------------------------------
>
> (Updated Oct. 3, 2018, 3:05 p.m.)
>
>
> Review request for mesos and Gilbert Song.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a log line to `MesosContainerizer::kill()`.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/containerizer.cpp 82d64e9928abd5e22493fa697d7b0910211533f3
>
>
> Diff: https://reviews.apache.org/r/68912/diff/1/
>
>
> Testing
> -------
>
> make -j3 check
>
> Ran it through internal CI.
>
>
> Thanks,
>
> Vinod Kone
>
>