You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2018/10/24 20:22:24 UTC
Review Request 69082: Correctly propagated `close` failures in some
instances.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69082/
-----------------------------------------------------------
Review request for mesos, Chun-Hung Hsiao and Alex Clemmer.
Repository: mesos
Description
-------
When e.g., writing to disk, errors from write might only manifest at
`::close` time. We update some instances to correctly propagate these
errors instead of dropping them silently. We only propagate the
`::close` error if the write operation succeeded, otherwise we just
propagate the error from the write operation.
Diffs
-----
3rdparty/stout/include/stout/os/posix/mktemp.hpp 63b3d1a7720d07f877fa1d4eb7f32a548916637a
3rdparty/stout/include/stout/os/write.hpp cd35285a9595004bac627abf687588050aef8161
3rdparty/stout/include/stout/protobuf.hpp 1d03e1e3a8dd642f7239d777fb04759caf100a8b
Diff: https://reviews.apache.org/r/69082/diff/1/
Testing
-------
`make check`
Thanks,
Benjamin Bannier
Re: Review Request 69082: Correctly propagated `close` failures in
some instances.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69082/#review209994
-----------------------------------------------------------
PASS: Mesos patch 69082 was successfully built and tested.
Reviews applied: `['69082']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2521/mesos-review-69082
- Mesos Reviewbot Windows
On Oct. 24, 2018, 8:22 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69082/
> -----------------------------------------------------------
>
> (Updated Oct. 24, 2018, 8:22 p.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao and Alex Clemmer.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> When e.g., writing to disk, errors from write might only manifest at
> `::close` time. We update some instances to correctly propagate these
> errors instead of dropping them silently. We only propagate the
> `::close` error if the write operation succeeded, otherwise we just
> propagate the error from the write operation.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/os/posix/mktemp.hpp 63b3d1a7720d07f877fa1d4eb7f32a548916637a
> 3rdparty/stout/include/stout/os/write.hpp cd35285a9595004bac627abf687588050aef8161
> 3rdparty/stout/include/stout/protobuf.hpp 1d03e1e3a8dd642f7239d777fb04759caf100a8b
>
>
> Diff: https://reviews.apache.org/r/69082/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 69082: Correctly propagated `close` failures in
some instances.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69082/#review211357
-----------------------------------------------------------
PASS: Mesos patch 69082 was successfully built and tested.
Reviews applied: `['69082']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2713/mesos-review-69082
- Mesos Reviewbot Windows
On Dec. 17, 2018, 10:54 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69082/
> -----------------------------------------------------------
>
> (Updated Dec. 17, 2018, 10:54 a.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao and Alex Clemmer.
>
>
> Bugs: MESOS-9331
> https://issues.apache.org/jira/browse/MESOS-9331
>
>
> Repository: mesos
>
>
> Description
> -------
>
> When e.g., writing to disk, errors from write might only manifest at
> ::close time. We update some instances to correctly propagate these
> errors instead of dropping them silently. We only propagate the
> ::close error if the write operation succeeded, otherwise we just
> propagate the error from the write operation.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/os/posix/mktemp.hpp 63b3d1a7720d07f877fa1d4eb7f32a548916637a
> 3rdparty/stout/include/stout/os/write.hpp f7538f94f5a953a7a90a05bc1d2f138b6c17f814
> 3rdparty/stout/include/stout/protobuf.hpp eb4adef56f1701e3c101284e05e4e6c66eef9180
>
>
> Diff: https://reviews.apache.org/r/69082/diff/2/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 69082: Correctly propagated `close` failures in
some instances.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69082/#review211369
-----------------------------------------------------------
Patch looks great!
Reviews applied: [69082]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Dec. 17, 2018, 10:54 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69082/
> -----------------------------------------------------------
>
> (Updated Dec. 17, 2018, 10:54 a.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao and Alex Clemmer.
>
>
> Bugs: MESOS-9331
> https://issues.apache.org/jira/browse/MESOS-9331
>
>
> Repository: mesos
>
>
> Description
> -------
>
> When e.g., writing to disk, errors from write might only manifest at
> ::close time. We update some instances to correctly propagate these
> errors instead of dropping them silently. We only propagate the
> ::close error if the write operation succeeded, otherwise we just
> propagate the error from the write operation.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/os/posix/mktemp.hpp 63b3d1a7720d07f877fa1d4eb7f32a548916637a
> 3rdparty/stout/include/stout/os/write.hpp f7538f94f5a953a7a90a05bc1d2f138b6c17f814
> 3rdparty/stout/include/stout/protobuf.hpp eb4adef56f1701e3c101284e05e4e6c66eef9180
>
>
> Diff: https://reviews.apache.org/r/69082/diff/2/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 69082: Correctly propagated `close` failures in
some instances.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69082/
-----------------------------------------------------------
(Updated Dec. 17, 2018, 11:54 a.m.)
Review request for mesos, Chun-Hung Hsiao and Alex Clemmer.
Changes
-------
Rebased.
Bugs: MESOS-9331
https://issues.apache.org/jira/browse/MESOS-9331
Repository: mesos
Description (updated)
-------
When e.g., writing to disk, errors from write might only manifest at
::close time. We update some instances to correctly propagate these
errors instead of dropping them silently. We only propagate the
::close error if the write operation succeeded, otherwise we just
propagate the error from the write operation.
Diffs (updated)
-----
3rdparty/stout/include/stout/os/posix/mktemp.hpp 63b3d1a7720d07f877fa1d4eb7f32a548916637a
3rdparty/stout/include/stout/os/write.hpp f7538f94f5a953a7a90a05bc1d2f138b6c17f814
3rdparty/stout/include/stout/protobuf.hpp eb4adef56f1701e3c101284e05e4e6c66eef9180
Diff: https://reviews.apache.org/r/69082/diff/2/
Changes: https://reviews.apache.org/r/69082/diff/1-2/
Testing
-------
`make check`
Thanks,
Benjamin Bannier