You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rukletsov <ru...@gmail.com> on 2018/10/07 15:16:06 UTC
Review Request 68944: Used delegating constructors in `Response`
types.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68944/
-----------------------------------------------------------
Review request for mesos and Benno Evers.
Repository: mesos
Description
-------
For clarity and brevity, use delegating constructors (available
since C++11) in descendants of the `Response` class.
Diffs
-----
3rdparty/libprocess/include/process/http.hpp cef511a1563a26e170ce7f4a49de12776b4512e7
Diff: https://reviews.apache.org/r/68944/diff/1/
Testing
-------
See https://reviews.apache.org/r/68945/
Thanks,
Alexander Rukletsov
Re: Review Request 68944: Used delegating constructors in `Response`
types.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68944/#review209306
-----------------------------------------------------------
Ship it!
Nice find, I think this is exactly the use-case delegating constructors were invented for. :)
- Benno Evers
On Oct. 7, 2018, 3:16 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68944/
> -----------------------------------------------------------
>
> (Updated Oct. 7, 2018, 3:16 p.m.)
>
>
> Review request for mesos and Benno Evers.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> For clarity and brevity, use delegating constructors (available
> since C++11) in descendants of the `Response` class.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/http.hpp cef511a1563a26e170ce7f4a49de12776b4512e7
>
>
> Diff: https://reviews.apache.org/r/68944/diff/1/
>
>
> Testing
> -------
>
> See https://reviews.apache.org/r/68945/
>
>
> Thanks,
>
> Alexander Rukletsov
>
>