You are viewing the static version of this archive.
For the interactive version, please visit: This page
I've reverted a couple of commits that I accidentally pushed to master. Sorry for the inconvenience.
asfgit closed pull request #353: WICKET-6656 bean validation handle required annotations URL: https://github.com/apache/wicket/pull/353 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, pleas...
martin-g closed pull request #354: ReplaceAll() to replace() for non-regex patterns URL: https://github.com/apache/wicket/pull/354 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log...
*Hi Martin, * *OpenJDK builds *- JDK 13 - Early Access build 18 is available at http://jdk.java.net/13/ * These early-access , open-source builds are provided under the o GNU General Public License, version 2, with the Classpath Exception <http://openjdk.java.net/legal/gplv2+ce....
d3ns0n opened a new pull request #355: WICKET-6660 do not trim PasswordTextField input URL: https://github.com/apache/wicket/pull/355 override FormComponent.shouldTrimInput() in PasswordTextField to prevent passwords from being trimmed --------------------------------------------------------...
Hi Colleagues! Are there any plans about refactoring / modernisation of wicket's front-end code? What comes to my mind: - Start using TypeScript for a new code, so we can have type safety on the front end side as well. TypeScript is also released under apache license, so I think there sh...
Hi Colleagues! Are there any plans about refactoring / modernisation of wicket's front-end code? What comes to my mind: Start using TypeScript for a new code, so we can have type safety on the front end side as well. TypeScript is also released under apache license, so I think there should be no l...
Hi all, before starting a larger effort on our JS code, we could do some smaller cleanups. - remove Ajax debug mode
bitstorm opened a new pull request #356: Wicket 6662 URL: https://github.com/apache/wicket/pull/356 see discussion at https://issues.apache.org/jira/browse/WICKET-6662 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. T...
Hi, as I said some time ago I'd like to refactor the current code to get rid of custom utility classes from package org.apache.wicket.util.time in wicket-util module. I guess these classes where created in a "pre Java-8 era" (or even in a pre Joda time era...) to handle and manipulate time en...
mattrpav opened a new pull request #357: [WICKET-6661] Upgrade to jquery 3.4.1 URL: https://github.com/apache/wicket/pull/357 Upgrade to jquery 3.4.1 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the m...
martin-g merged pull request #357: [WICKET-6661] Upgrade to jquery 3.4.1 URL: https://github.com/apache/wicket/pull/357 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH...
svenmeier commented on issue #355: WICKET-6660 do not trim PasswordTextField input URL: https://github.com/apache/wicket/pull/355#issuecomment-488947502 @d3ns0n please close this pull request if you're fine with Wicket continuing to trim passwords - IMHO it's a matter of taste so I'd prefer t...
martin-g commented on issue #356: Wicket 6662 URL: https://github.com/apache/wicket/pull/356#issuecomment-488947913 I've glanced over several files and the changes look good! I will make a proper review in the coming days. But I'd prefer to keep the old classes as deprecated for Wic...
d3ns0n closed pull request #355: WICKET-6660 do not trim PasswordTextField input URL: https://github.com/apache/wicket/pull/355 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on...
bitstorm commented on issue #356: Wicket 6662 URL: https://github.com/apache/wicket/pull/356#issuecomment-489436880 @martin-g normally I would do the same thing, but to me these are more classes for internal uses. I don't think many people use them directly with Wicket. Once we remove them f...
bitstorm edited a comment on issue #356: Wicket 6662 URL: https://github.com/apache/wicket/pull/356#issuecomment-489436880 @martin-g normally I would do the same thing, but to me these are more classes for internal use. I don't think many people use them directly with Wicket. Once we remove ...
martin-g commented on issue #356: Wicket 6662 URL: https://github.com/apache/wicket/pull/356#issuecomment-489462577 @bitstorm My reasoning is: If the classes are public then they have to be deprecated before being removed. There is no way to tell how many applications use any of those classes...
All, Last week Oracle and the Eclipse Foundation shared that they were unable to reach an amicable agreement on the use of javax.* packages by the Jakarta EE project. The Jakarta EE project is the continuation of the Java EE specifications board and would be responsible for publishing the Java EE ...
bitstorm commented on issue #356: Wicket 6662 URL: https://github.com/apache/wicket/pull/356#issuecomment-489975813 @martin-g done! I've reintroduced and deprecated package org.apache.wicket.util.time ---------------------------------------------------------------- This is an automated messa...
martin-g commented on a change in pull request #356: Wicket 6662 URL: https://github.com/apache/wicket/pull/356#discussion_r281527093 ########## File path: wicket-util/src/main/java/org/apache/wicket/util/string/StringValue.java ########## @@ -548,7 +552,14 @@ public final Double toDoubleOb...
martin-g commented on a change in pull request #356: Wicket 6662 URL: https://github.com/apache/wicket/pull/356#discussion_r281519669 ########## File path: wicket-core/src/main/java/org/apache/wicket/request/resource/DynamicImageResource.java ########## @@ -19,13 +19,12 @@ import java.awt....
martin-g commented on a change in pull request #356: Wicket 6662 URL: https://github.com/apache/wicket/pull/356#discussion_r281520703 ########## File path: wicket-core/src/test/java/org/apache/wicket/ajax/AjaxRequestHandlerTest.java ########## @@ -284,14 +283,14 @@ void ajaxRedirectSetsNoCa...
martin-g commented on a change in pull request #356: Wicket 6662 URL: https://github.com/apache/wicket/pull/356#discussion_r281522816 ########## File path: wicket-jmx/src/main/java/org/apache/wicket/jmx/wrapper/RequestCycleSettings.java ########## @@ -117,9 +117,9 @@ public void setResponse...
martin-g commented on a change in pull request #356: Wicket 6662 URL: https://github.com/apache/wicket/pull/356#discussion_r281521341 ########## File path: wicket-core/src/test/java/org/apache/wicket/page/PageAccessSynchronizerTest.java ########## @@ -98,13 +106,13 @@ public void run() T...
martin-g commented on a change in pull request #356: Wicket 6662 URL: https://github.com/apache/wicket/pull/356#discussion_r281520703 ########## File path: wicket-core/src/test/java/org/apache/wicket/ajax/AjaxRequestHandlerTest.java ########## @@ -284,14 +283,14 @@ void ajaxRedirectSetsNoCa...
bitstorm commented on a change in pull request #356: Wicket 6662 URL: https://github.com/apache/wicket/pull/356#discussion_r281580379 ########## File path: wicket-jmx/src/main/java/org/apache/wicket/jmx/wrapper/RequestCycleSettings.java ########## @@ -117,9 +117,9 @@ public void setResponse...
martin-g commented on a change in pull request #356: Wicket 6662 URL: https://github.com/apache/wicket/pull/356#discussion_r281585885 ########## File path: wicket-jmx/src/main/java/org/apache/wicket/jmx/wrapper/RequestCycleSettings.java ########## @@ -117,9 +117,9 @@ public void setResponse...
bitstorm commented on a change in pull request #356: Wicket 6662 URL: https://github.com/apache/wicket/pull/356#discussion_r281646311 ########## File path: wicket-core/src/test/java/org/apache/wicket/ajax/AjaxRequestHandlerTest.java ########## @@ -284,14 +283,14 @@ void ajaxRedirectSetsNoCa...
mattrpav opened a new pull request #358: [WICKET-6665] Upgrade various dependencies URL: https://github.com/apache/wicket/pull/358 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log...
svenmeier opened a new pull request #359: Wicket js cleanup URL: https://github.com/apache/wicket/pull/359 Before moving to a new technology I'd rather clean up the current JavaScript first. I've took the effort to separate all changes into separate commits, so anyone interested can as...
martin-g commented on a change in pull request #359: Wicket js cleanup URL: https://github.com/apache/wicket/pull/359#discussion_r282362119 ########## File path: wicket-core/src/test/js/dom.js ########## @@ -112,38 +112,6 @@ jQuery(document).ready(function() { equal( el.style.display, ''...
martin-g commented on a change in pull request #359: Wicket js cleanup URL: https://github.com/apache/wicket/pull/359#discussion_r282361940 ########## File path: wicket-core/src/test/js/all.html ########## @@ -181,8 +181,6 @@ <div id="usedAsContextWicket5025"></div> - <input type="t...
martin-g commented on a change in pull request #359: Wicket js cleanup URL: https://github.com/apache/wicket/pull/359#discussion_r282362774 ########## File path: wicket-examples/src/main/java/org/apache/wicket/examples/ajax/builtin/modal/ModalContent1Page.html ########## @@ -20,9 +20,5 @@ ...
andruhon commented on a change in pull request #359: Wicket js cleanup URL: https://github.com/apache/wicket/pull/359#discussion_r282364806 ########## File path: wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js ########## @@ -1143,23 +1085,9 @...
martin-g commented on a change in pull request #359: Wicket js cleanup URL: https://github.com/apache/wicket/pull/359#discussion_r282368339 ########## File path: wicket-core/src/test/js/all.html ########## @@ -181,8 +181,6 @@ <div id="usedAsContextWicket5025"></div> - <input type="t...
martin-g commented on a change in pull request #359: Wicket js cleanup URL: https://github.com/apache/wicket/pull/359#discussion_r282368719 ########## File path: wicket-examples/src/main/java/org/apache/wicket/examples/ajax/builtin/modal/ModalContent1Page.html ########## @@ -20,9 +20,5 @@ ...
svenmeier commented on a change in pull request #359: Wicket js cleanup URL: https://github.com/apache/wicket/pull/359#discussion_r282450510 ########## File path: wicket-core/src/test/js/dom.js ########## @@ -112,38 +112,6 @@ jQuery(document).ready(function() { equal( el.style.display, '...
svenmeier commented on a change in pull request #359: Wicket js cleanup URL: https://github.com/apache/wicket/pull/359#discussion_r282451295 ########## File path: wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js ########## @@ -1143,23 +1085,9 ...
martin-g commented on a change in pull request #359: Wicket js cleanup URL: https://github.com/apache/wicket/pull/359#discussion_r282453579 ########## File path: wicket-core/src/test/js/dom.js ########## @@ -112,38 +112,6 @@ jQuery(document).ready(function() { equal( el.style.display, ''...
andruhon commented on a change in pull request #359: Wicket js cleanup URL: https://github.com/apache/wicket/pull/359#discussion_r282454458 ########## File path: wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js ########## @@ -1143,23 +1085,9 @...
svenmeier commented on a change in pull request #359: Wicket js cleanup URL: https://github.com/apache/wicket/pull/359#discussion_r282456466 ########## File path: wicket-core/src/test/js/dom.js ########## @@ -112,38 +112,6 @@ jQuery(document).ready(function() { equal( el.style.display, '...
martin-g commented on a change in pull request #359: Wicket js cleanup URL: https://github.com/apache/wicket/pull/359#discussion_r282457492 ########## File path: wicket-core/src/test/js/dom.js ########## @@ -112,38 +112,6 @@ jQuery(document).ready(function() { equal( el.style.display, ''...
martin-g commented on a change in pull request #359: Wicket js cleanup URL: https://github.com/apache/wicket/pull/359#discussion_r282458532 ########## File path: wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js ########## @@ -1143,23 +1085,9 @...
svenmeier commented on a change in pull request #359: Wicket js cleanup URL: https://github.com/apache/wicket/pull/359#discussion_r282461028 ########## File path: wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js ########## @@ -1143,23 +1085,9 ...
svenmeier commented on a change in pull request #359: Wicket js cleanup URL: https://github.com/apache/wicket/pull/359#discussion_r282465153 ########## File path: wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js ########## @@ -1143,23 +1085,9 ...
ivaynberg commented on a change in pull request #359: Wicket js cleanup URL: https://github.com/apache/wicket/pull/359#discussion_r282535350 ########## File path: wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js ########## @@ -1143,23 +1085,9 ...
andruhon commented on a change in pull request #359: Wicket js cleanup URL: https://github.com/apache/wicket/pull/359#discussion_r282687431 ########## File path: wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js ########## @@ -1143,23 +1085,9 @...
andreikondratev opened a new pull request #360: update Dockerfile to point to tomcat:8.5-jre11 URL: https://github.com/apache/wicket/pull/360 because a new build target is 11 ---------------------------------------------------------------- This is an automated message from the Apache Git Ser...
andruhon commented on a change in pull request #359: Wicket js cleanup URL: https://github.com/apache/wicket/pull/359#discussion_r282724954 ########## File path: wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-ajax-jquery.js ########## @@ -36,66 +36,28 @@ return; } - /...
martin-g commented on a change in pull request #359: Wicket js cleanup URL: https://github.com/apache/wicket/pull/359#discussion_r282746367 ########## File path: wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-ajax-jquery.js ########## @@ -36,66 +36,28 @@ return; } - /...
martin-g commented on a change in pull request #359: Wicket js cleanup URL: https://github.com/apache/wicket/pull/359#discussion_r282746881 ########## File path: wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js ########## @@ -1143,23 +1085,9 @...
martin-g commented on a change in pull request #359: Wicket js cleanup URL: https://github.com/apache/wicket/pull/359#discussion_r282747259 ########## File path: wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js ########## @@ -1143,23 +1085,9 @...
martin-g commented on a change in pull request #359: Wicket js cleanup URL: https://github.com/apache/wicket/pull/359#discussion_r282747333 ########## File path: wicket-core/src/test/js/dom.js ########## @@ -112,38 +112,6 @@ jQuery(document).ready(function() { equal( el.style.display, ''...
martin-g merged pull request #360: update Dockerfile to point to tomcat:8.5-jre11 URL: https://github.com/apache/wicket/pull/360 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log o...
martin-g commented on issue #360: update Dockerfile to point to tomcat:8.5-jre11 URL: https://github.com/apache/wicket/pull/360#issuecomment-491158492 Thank you, @andreikondratev ! ---------------------------------------------------------------- This is an automated message from the Apache G...
andruhon commented on a change in pull request #359: Wicket js cleanup URL: https://github.com/apache/wicket/pull/359#discussion_r282748206 ########## File path: wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js ########## @@ -1143,23 +1085,9 @...
martin-g commented on a change in pull request #359: Wicket js cleanup URL: https://github.com/apache/wicket/pull/359#discussion_r282749392 ########## File path: wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js ########## @@ -1143,23 +1085,9 @...
solomax commented on issue #360: update Dockerfile to point to tomcat:8.5-jre11 URL: https://github.com/apache/wicket/pull/360#issuecomment-491166455 Maybe it worth to use tomcat9? ---------------------------------------------------------------- This is an automated message from the Apache G...
martin-g commented on issue #360: update Dockerfile to point to tomcat:8.5-jre11 URL: https://github.com/apache/wicket/pull/360#issuecomment-491169667 :+1: ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond t...
svenmeier commented on issue #359: Wicket js cleanup URL: https://github.com/apache/wicket/pull/359#issuecomment-491184522 Just a note that amd.html/.js fails currently. I'm unable to fix it though: as soon as I remove "WicketDebugWindow" from the requires, qunit isn't found. Strange. ------...
martin-g commented on issue #359: Wicket js cleanup URL: https://github.com/apache/wicket/pull/359#issuecomment-491191431 > Just a note that amd.html/.js fails currently. I'm unable to fix it though: as soon as I remove "WicketDebugWindow" from the requires, qunit isn't found. Strange. ...
andruhon commented on a change in pull request #359: Wicket js cleanup URL: https://github.com/apache/wicket/pull/359#discussion_r282781933 ########## File path: wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js ########## @@ -1143,23 +1085,9 @...
Hi Martin, *OpenJDK builds *- JDK 13 - Early Access build 20 is available at http://jdk.java.net/13/ * These early-access , open-source builds are provided under the o GNU General Public License, version 2, with the Classpath Exception <http://openjdk.java.net/legal/...
martin-g merged pull request #358: [WICKET-6665] Upgrade various dependencies URL: https://github.com/apache/wicket/pull/358 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to...
martin-g commented on issue #358: [WICKET-6665] Upgrade various dependencies URL: https://github.com/apache/wicket/pull/358#issuecomment-491220838 Thank you, @mattrpav ! ---------------------------------------------------------------- This is an automated message from the Apache Git Service....
ivaynberg opened a new pull request #361: WICKET-6666 initial checkin of new ModalDialog URL: https://github.com/apache/wicket/pull/361 I dont think this is ready to be merged, its just here to start a conversation... ---------------------------------------------------------------- This is a...
bitstorm commented on issue #356: Wicket 6662 URL: https://github.com/apache/wicket/pull/356#issuecomment-491428738 @martin-g I would proceed merging this PR If there are no other change requests. ---------------------------------------------------------------- This is an automated message f...
martin-g commented on issue #356: Wicket 6662 URL: https://github.com/apache/wicket/pull/356#issuecomment-491484471 Go ahead! On Sat, May 11, 2019, 00:00 Andrea Del Bene <notifications@github.com> wrote: > @martin-g <https://github.com/martin-g> I would proceed merging this P...
bitstorm merged pull request #356: Wicket 6662 URL: https://github.com/apache/wicket/pull/356 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t...
andruhon opened a new pull request #362: update Dockerfile to point to tomcat:9.0-jre11 URL: https://github.com/apache/wicket/pull/362 As it was suggested in #360 by @solomax I tried to point to Tomcat 9 and it worked well. ---------------------------------------------------------------- Thi...
martin-g merged pull request #362: update Dockerfile to point to tomcat:9.0-jre11 URL: https://github.com/apache/wicket/pull/362 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log o...
bitstorm commented on a change in pull request #359: Wicket js cleanup URL: https://github.com/apache/wicket/pull/359#discussion_r283276011 ########## File path: wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js ########## @@ -1143,23 +1085,9 @...
andruhon opened a new pull request #363: Convert wicket ajax to typescript URL: https://github.com/apache/wicket/pull/363 Continuing discussion about converting wicket-ajax-jquery.js into TypeScript. Finally I reached the stage when all tests passing and I can run ajax section in wicke...
andruhon commented on a change in pull request #359: Wicket js cleanup URL: https://github.com/apache/wicket/pull/359#discussion_r283334685 ########## File path: wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js ########## @@ -1143,23 +1085,9 @...
andruhon commented on a change in pull request #361: WICKET-6666 initial checkin of new ModalDialog URL: https://github.com/apache/wicket/pull/361#discussion_r283336671 ########## File path: wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/ModalDialog.js ##...
martin-g commented on issue #363: Convert wicket ajax to typescript URL: https://github.com/apache/wicket/pull/363#issuecomment-491822968 I am +1 to make these changes! But we should apply the changes from https://github.com/apache/wicket/pull/359 ----------------------------------------...
ivaynberg commented on a change in pull request #361: WICKET-6666 initial checkin of new ModalDialog URL: https://github.com/apache/wicket/pull/361#discussion_r283391608 ########## File path: wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/ModalDialog.js #...
andruhon commented on issue #363: Convert wicket ajax to typescript URL: https://github.com/apache/wicket/pull/363#issuecomment-492022858 Another important point to discuss is a format. The IIFE is currently configured is good to make it compatible with Wicket 8 stuff. Essentially what I have...
andruhon commented on a change in pull request #361: WICKET-6666 initial checkin of new ModalDialog URL: https://github.com/apache/wicket/pull/361#discussion_r283532822 ########## File path: wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/ModalDialogReferen...
andruhon commented on issue #361: WICKET-6666 initial checkin of new ModalDialog URL: https://github.com/apache/wicket/pull/361#issuecomment-492038830 Another thing I really want it to do is to work nicely with the Select2 (maybe it already does). Select2 inside of the old ModalWindow was a p...
ivaynberg commented on issue #361: WICKET-6666 initial checkin of new ModalDialog URL: https://github.com/apache/wicket/pull/361#issuecomment-492057737 it already supports select2 ---------------------------------------------------------------- This is an automated message from the Apache Gi...
ivaynberg commented on a change in pull request #361: WICKET-6666 initial checkin of new ModalDialog URL: https://github.com/apache/wicket/pull/361#discussion_r283607451 ########## File path: wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/ModalDialogRefere...
ivaynberg commented on issue #361: WICKET-6666 initial checkin of new ModalDialog URL: https://github.com/apache/wicket/pull/361#issuecomment-492058445 > I believe that some abstract component such as AbstractModalDialog should be created in core to represent dialogs, it could be squeezed in ...
andruhon commented on a change in pull request #361: WICKET-6666 initial checkin of new ModalDialog URL: https://github.com/apache/wicket/pull/361#discussion_r283608085 ########## File path: wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/ModalDialog-skin.c...
andruhon commented on issue #361: WICKET-6666 initial checkin of new ModalDialog URL: https://github.com/apache/wicket/pull/361#issuecomment-492059377 Just tested the modal in Chrome, FF, Edge and IE11 all good. Looks a bit dodgy in IE11. > I doubt that is possible. Each dialog works i...
andruhon edited a comment on issue #361: WICKET-6666 initial checkin of new ModalDialog URL: https://github.com/apache/wicket/pull/361#issuecomment-492059377 Just tested the modal in Chrome, FF, Edge and IE11 all good. Looks a bit dodgy in IE11. > I doubt that is possible. Each dialog ...
martin-g commented on a change in pull request #361: WICKET-6666 initial checkin of new ModalDialog URL: https://github.com/apache/wicket/pull/361#discussion_r283630264 ########## File path: wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/ModalDialog.js ##...
martin-g commented on a change in pull request #361: WICKET-6666 initial checkin of new ModalDialog URL: https://github.com/apache/wicket/pull/361#discussion_r283631302 ########## File path: wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/ModalDialog.java ...
martin-g commented on a change in pull request #361: WICKET-6666 initial checkin of new ModalDialog URL: https://github.com/apache/wicket/pull/361#discussion_r283632622 ########## File path: wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/ModalDialog.js ##...
martin-g commented on a change in pull request #361: WICKET-6666 initial checkin of new ModalDialog URL: https://github.com/apache/wicket/pull/361#discussion_r283631020 ########## File path: wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/ModalDialog.css #...
martin-g commented on a change in pull request #361: WICKET-6666 initial checkin of new ModalDialog URL: https://github.com/apache/wicket/pull/361#discussion_r283631883 ########## File path: wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/ModalDialog.java ...
martin-g commented on a change in pull request #361: WICKET-6666 initial checkin of new ModalDialog URL: https://github.com/apache/wicket/pull/361#discussion_r283631121 ########## File path: wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/ModalDialog.css #...
martin-g commented on a change in pull request #361: WICKET-6666 initial checkin of new ModalDialog URL: https://github.com/apache/wicket/pull/361#discussion_r283633541 ########## File path: wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/ModalDialog.js ##...
martin-g commented on a change in pull request #361: WICKET-6666 initial checkin of new ModalDialog URL: https://github.com/apache/wicket/pull/361#discussion_r283633181 ########## File path: wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/ModalDialog.js ##...
martin-g commented on a change in pull request #361: WICKET-6666 initial checkin of new ModalDialog URL: https://github.com/apache/wicket/pull/361#discussion_r283632320 ########## File path: wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/ModalDialog.java ...
martin-g commented on issue #363: Convert wicket ajax to typescript URL: https://github.com/apache/wicket/pull/363#issuecomment-492088961 > I think for future Wicket releases we can consider other options such as AMD, UMD or CommonJS I do not see a reason for this. No one ever asked fo...
svenmeier commented on issue #361: WICKET-6666 initial checkin of new ModalDialog URL: https://github.com/apache/wicket/pull/361#issuecomment-492198078 Thanks Igor, it's much easier to start with something instead of starting from scratch. I would like to improve some general points: ...
svenmeier commented on issue #359: Wicket js cleanup URL: https://github.com/apache/wicket/pull/359#issuecomment-492198899 I'll create a Jira issue and merge. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond...
ivaynberg commented on a change in pull request #361: WICKET-6666 initial checkin of new ModalDialog URL: https://github.com/apache/wicket/pull/361#discussion_r283849785 ########## File path: wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/ModalDialog.css ...
ivaynberg commented on a change in pull request #361: WICKET-6666 initial checkin of new ModalDialog URL: https://github.com/apache/wicket/pull/361#discussion_r283852759 ########## File path: wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/ModalDialog.java ...
ivaynberg commented on a change in pull request #361: WICKET-6666 initial checkin of new ModalDialog URL: https://github.com/apache/wicket/pull/361#discussion_r283853512 ########## File path: wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/ModalDialog.java ...
ivaynberg commented on a change in pull request #361: WICKET-6666 initial checkin of new ModalDialog URL: https://github.com/apache/wicket/pull/361#discussion_r283856710 ########## File path: wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/ModalDialog.js #...
martin-g commented on a change in pull request #361: WICKET-6666 initial checkin of new ModalDialog URL: https://github.com/apache/wicket/pull/361#discussion_r283856955 ########## File path: wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/ModalDialog.java ...
ivaynberg commented on a change in pull request #361: WICKET-6666 initial checkin of new ModalDialog URL: https://github.com/apache/wicket/pull/361#discussion_r283859155 ########## File path: wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/ModalDialog.js #...
martin-g commented on a change in pull request #361: WICKET-6666 initial checkin of new ModalDialog URL: https://github.com/apache/wicket/pull/361#discussion_r283860195 ########## File path: wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/ModalDialog.java ...
ivaynberg commented on issue #361: WICKET-6666 initial checkin of new ModalDialog URL: https://github.com/apache/wicket/pull/361#issuecomment-492294684 > Thanks Igor, it's much easier to start with something instead of starting from scratch. > > I would like to improve some general poi...
ivaynberg commented on a change in pull request #361: WICKET-6666 initial checkin of new ModalDialog URL: https://github.com/apache/wicket/pull/361#discussion_r283879433 ########## File path: wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/ModalDialog.java ...
andruhon commented on a change in pull request #361: WICKET-6666 initial checkin of new ModalDialog URL: https://github.com/apache/wicket/pull/361#discussion_r284056415 ########## File path: wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/ModalDialog.js ##...
svenmeier commented on issue #361: WICKET-6666 initial checkin of new ModalDialog URL: https://github.com/apache/wicket/pull/361#issuecomment-492684806 Hi Igor, > my only word of caution is that a big reason why the old modal window was such a mess and so hard to maintain is because we...
svenmeier commented on issue #361: WICKET-6666 initial checkin of new ModalDialog URL: https://github.com/apache/wicket/pull/361#issuecomment-492696234 Regarding the location of the dialog in the DOM - in case of a dialog nested inside a form, a page refresh produces invalid markup with two n...
svenmeier commented on issue #359: WICKET-6667 Wicket js cleanup URL: https://github.com/apache/wicket/pull/359#issuecomment-492829796 Thanks to all! ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the m...
svenmeier closed pull request #359: WICKET-6667 Wicket js cleanup URL: https://github.com/apache/wicket/pull/359 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and ...
andruhon commented on issue #361: WICKET-6666 initial checkin of new ModalDialog URL: https://github.com/apache/wicket/pull/361#issuecomment-492849181 Another concern is a presence of jQuery. It doesn't do much here now. As far as I remember Wicket has dropped support for IE9 and IE10 in v8. ...
svenmeier commented on issue #361: WICKET-6666 initial checkin of new ModalDialog URL: https://github.com/apache/wicket/pull/361#issuecomment-492980635 >most selectors are used downstream of the overlay element I've double checked, your right :) ---------------------------------------...
andreikondratev commented on issue #359: WICKET-6667 Wicket js cleanup URL: https://github.com/apache/wicket/pull/359#issuecomment-493267682 I injected this JS into our wicket 7.10 application and send it to our build server to see how Selenium UI tests run. passed: 1915 tests, failed 8. A...
andreikondratev removed a comment on issue #359: WICKET-6667 Wicket js cleanup URL: https://github.com/apache/wicket/pull/359#issuecomment-493267682 I injected this JS into our wicket 7.10 application and send it to our build server to see how Selenium UI tests run. passed: 1915 tests, fai...
andruhon commented on issue #359: WICKET-6667 Wicket js cleanup URL: https://github.com/apache/wicket/pull/359#issuecomment-493267814 I injected this JS into our wicket 7.10 application and send it to our build server to see how Selenium UI tests run. passed: 1915 tests, failed 8. All 8 ar...
martin-g commented on issue #359: WICKET-6667 Wicket js cleanup URL: https://github.com/apache/wicket/pull/359#issuecomment-493281094 Hi Andrew, You will have to update your tests to trigger "input" event instead of "inputchange" event. Maybe we should provide support for inputch...
andreikondratev commented on issue #359: WICKET-6667 Wicket js cleanup URL: https://github.com/apache/wicket/pull/359#issuecomment-493281600 Mi Martin! I think it's redundant to add this support. They failed just because OnChangeAjaxBehavior hasn't been replaced. -------------------...
andreikondratev edited a comment on issue #359: WICKET-6667 Wicket js cleanup URL: https://github.com/apache/wicket/pull/359#issuecomment-493281600 Mi Martin! I think it's redundant to add this support. They failed just because OnChangeAjaxBehavior hasn't been replaced. (sorry...
andruhon commented on issue #359: WICKET-6667 Wicket js cleanup URL: https://github.com/apache/wicket/pull/359#issuecomment-493286672 I think this behaviour was broken before wicket cleanup http://examples8x.wicket.apache.org/ajax/on-change-ajax-behavior Very similar thing is broken in...
andruhon commented on issue #363: Convert wicket ajax to typescript URL: https://github.com/apache/wicket/pull/363#issuecomment-493288087 It seems to work pretty well. Should I continue and try adding a WICKET-6667 #359 into this one? ---------------------------------------------------------...
martin-g commented on issue #363: Convert wicket ajax to typescript URL: https://github.com/apache/wicket/pull/363#issuecomment-493289448 I am +1 but others didn't give their opinion yet. Let's discuss at dev@ first before wasting your time. On Fri, May 17, 2019, 04:43 Andrew Kondra...
andruhon commented on issue #363: Convert wicket ajax to typescript URL: https://github.com/apache/wicket/pull/363#issuecomment-493289708 > dev@ @martin-g do you refer to the dev@wicket.apache.org mail list? ---------------------------------------------------------------- This is an a...
ivaynberg commented on issue #363: Convert wicket ajax to typescript URL: https://github.com/apache/wicket/pull/363#issuecomment-493290593 i am +1 on this as long as it is committed in such a way that git log --follow will stick pick up the history of the old js files.. ---------------------...
andreikondratev commented on issue #363: Convert wicket ajax to typescript URL: https://github.com/apache/wicket/pull/363#issuecomment-493297740 @ivaynberg It's achevable. I can do it with moving and merging back which will lead to a bunch of commits for each ts file in the history. P...
andruhon opened a new pull request #364: Improve OnChangeAjaxBehavior demo URL: https://github.com/apache/wicket/pull/364 The demo was misleading. I thought it will just display what I typed in the label, I typed 555 and though it's broken. Updated the demo to be more obvious. -------------...
andruhon commented on issue #359: WICKET-6667 Wicket js cleanup URL: https://github.com/apache/wicket/pull/359#issuecomment-493314105 Ah, sorry. The demo works, it just a bit misleading without looking at the code. Created a PR to make it more obvious: #364 ---------------------------------...
solomax commented on a change in pull request #364: Improve OnChangeAjaxBehavior demo URL: https://github.com/apache/wicket/pull/364#discussion_r284974403 ########## File path: wicket-examples/src/main/java/org/apache/wicket/examples/ajax/builtin/OnChangeAjaxBehaviorPage.java ########## @@ ...
martin-g commented on issue #363: Convert wicket ajax to typescript URL: https://github.com/apache/wicket/pull/363#issuecomment-493321548 > @martin-g do you refer to the [dev@wicket.apache.org](mailto:dev@wicket.apache.org) mail list? Yes. ---------------------------------------------...
The Travel Assistance Committee (TAC) are pleased to announce that travel assistance applications for ApacheCon NA 2019 are now open! We will be supporting ApacheCon NA Las Vegas, Nevada on 9th - 12th September 2019 TAC exists to help those that would like to attend ApacheCon events, but are unab...
Hi, today I've noted that using version 9.0.0-M2-SNAPSHOT led to a constant usage of CPU from task ModificationWatcher. I've spotted a silly line of code I wrote for WICKET-6662. Since no one opened an issue for it I directly committed the fix. Hope is not a problem.
andruhon commented on issue #363: Convert wicket ajax to typescript URL: https://github.com/apache/wicket/pull/363#issuecomment-493794645 Closing this PR because it has been decided to not proceed with these changes. A permalink to mail list discussion as a reference. https://lists.apa...
andruhon closed pull request #363: Convert wicket ajax to typescript URL: https://github.com/apache/wicket/pull/363 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a...