You are viewing the static version of this archive.
For the interactive version, please visit: This page
abogaart opened a new pull request #372: Identify javascript template literals to prevent stripping too much code URL: https://github.com/apache/wicket/pull/372 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To resp...
Hello Rory, Could you please update the row for Apache Wicket at https://wiki.openjdk.java.net/display/quality/Quality+Outreach and add: - https://ci.apache.org/builders/wicket-master-java14 (Wicket 9.x built against Java 14) Thank you! Regards, Martin
martin-g merged pull request #372: Identify javascript template literals to prevent stripping too much code URL: https://github.com/apache/wicket/pull/372 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to...
martin-g commented on issue #372: Identify javascript template literals to prevent stripping too much code URL: https://github.com/apache/wicket/pull/372#issuecomment-507244584 Thank you, @abogaart ! ---------------------------------------------------------------- This is an automated messag...
reiern70 opened a new pull request #373: make autolable funtionality more flexible by introducing a locator interface that allow to specify the component the wicket:for refers too URL: https://github.com/apache/wicket/pull/373 make autolable funtionality more flexible by introducing a locator...
solomax commented on a change in pull request #373: make autolable funtionality more flexible by introducing a locator interface that allow to specify the component the wicket:for refers too URL: https://github.com/apache/wicket/pull/373#discussion_r300854474 ########## File path: wicket-core...
solomax commented on a change in pull request #373: make autolable funtionality more flexible by introducing a locator interface that allow to specify the component the wicket:for refers too URL: https://github.com/apache/wicket/pull/373#discussion_r300854397 ########## File path: wicket-core...
reiern70 commented on a change in pull request #373: make autolable funtionality more flexible by introducing a locator interface that allow to specify the component the wicket:for refers too URL: https://github.com/apache/wicket/pull/373#discussion_r300855338 ########## File path: wicket-cor...
reiern70 commented on a change in pull request #373: make autolable funtionality more flexible by introducing a locator interface that allow to specify the component the wicket:for refers too URL: https://github.com/apache/wicket/pull/373#discussion_r300855352 ########## File path: wicket-cor...
reiern70 commented on a change in pull request #373: make autolable funtionality more flexible by introducing a locator interface that allow to specify the component the wicket:for refers too URL: https://github.com/apache/wicket/pull/373#discussion_r300855614 ########## File path: wicket-cor...
reiern70 commented on issue #373: make autolable funtionality more flexible by introducing a locator interface that allow to specify the component the wicket:for refers too URL: https://github.com/apache/wicket/pull/373#issuecomment-508981513 @solomax Thanks for review and comments. If...
martin-g commented on issue #373: make autolabel functionality more flexible by introducing a locator interface that allow to specify the component the wicket:for refers too URL: https://github.com/apache/wicket/pull/373#issuecomment-509091722 @reiern70 Please create a ticket in JIRA and amen...
martin-g commented on a change in pull request #373: make autolabel functionality more flexible by introducing a locator interface that allow to specify the component the wicket:for refers too URL: https://github.com/apache/wicket/pull/373#discussion_r300936180 ########## File path: wicket-co...
martin-g commented on a change in pull request #373: make autolabel functionality more flexible by introducing a locator interface that allow to specify the component the wicket:for refers too URL: https://github.com/apache/wicket/pull/373#discussion_r300933725 ########## File path: wicket-co...
martin-g commented on a change in pull request #373: make autolabel functionality more flexible by introducing a locator interface that allow to specify the component the wicket:for refers too URL: https://github.com/apache/wicket/pull/373#discussion_r300935141 ########## File path: wicket-co...
martin-g commented on a change in pull request #373: make autolabel functionality more flexible by introducing a locator interface that allow to specify the component the wicket:for refers too URL: https://github.com/apache/wicket/pull/373#discussion_r300936261 ########## File path: wicket-co...
martin-g commented on a change in pull request #373: make autolabel functionality more flexible by introducing a locator interface that allow to specify the component the wicket:for refers too URL: https://github.com/apache/wicket/pull/373#discussion_r300933865 ########## File path: wicket-co...
martin-g commented on a change in pull request #373: make autolabel functionality more flexible by introducing a locator interface that allow to specify the component the wicket:for refers too URL: https://github.com/apache/wicket/pull/373#discussion_r300934913 ########## File path: wicket-co...
martin-g commented on a change in pull request #373: make autolabel functionality more flexible by introducing a locator interface that allow to specify the component the wicket:for refers too URL: https://github.com/apache/wicket/pull/373#discussion_r300936009 ########## File path: wicket-co...
reiern70 commented on a change in pull request #373: make autolabel functionality more flexible by introducing a locator interface that allow to specify the component the wicket:for refers too URL: https://github.com/apache/wicket/pull/373#discussion_r300944044 ########## File path: wicket-co...
reiern70 commented on issue #373: make autolabel functionality more flexible by introducing a locator interface that allow to specify the component the wicket:for refers too URL: https://github.com/apache/wicket/pull/373#issuecomment-509102080 > @reiern70 Please create a ticket in JIRA and am...
reiern70 commented on a change in pull request #373: make autolabel functionality more flexible by introducing a locator interface that allow to specify the component the wicket:for refers too URL: https://github.com/apache/wicket/pull/373#discussion_r300944713 ########## File path: wicket-co...
reiern70 commented on a change in pull request #373: make autolabel functionality more flexible by introducing a locator interface that allow to specify the component the wicket:for refers too URL: https://github.com/apache/wicket/pull/373#discussion_r300945538 ########## File path: wicket-co...
reiern70 commented on a change in pull request #373: make autolabel functionality more flexible by introducing a locator interface that allow to specify the component the wicket:for refers too URL: https://github.com/apache/wicket/pull/373#discussion_r300946929 ########## File path: wicket-co...
reiern70 commented on a change in pull request #373: make autolabel functionality more flexible by introducing a locator interface that allow to specify the component the wicket:for refers too URL: https://github.com/apache/wicket/pull/373#discussion_r300947955 ########## File path: wicket-co...
reiern70 commented on a change in pull request #373: make autolabel functionality more flexible by introducing a locator interface that allow to specify the component the wicket:for refers too URL: https://github.com/apache/wicket/pull/373#discussion_r300947993 ########## File path: wicket-co...
reiern70 commented on issue #373: make autolabel functionality more flexible by introducing a locator interface that allow to specify the component the wicket:for refers too URL: https://github.com/apache/wicket/pull/373#issuecomment-509106799 @martin-g Many thanks for review. Included you co...
reiern70 edited a comment on issue #373: make autolabel functionality more flexible by introducing a locator interface that allow to specify the component the wicket:for refers too URL: https://github.com/apache/wicket/pull/373#issuecomment-509106799 @martin-g Many thanks for review. Included...
reiern70 commented on issue #373: make autolabel functionality more flexible by introducing a locator interface that allow to specify the component the wicket:for refers too URL: https://github.com/apache/wicket/pull/373#issuecomment-509143383 @martin-g and @solomax Any more changes needed? ...
martin-g commented on issue #373: make autolabel functionality more flexible by introducing a locator interface that allow to specify the component the wicket:for refers too URL: https://github.com/apache/wicket/pull/373#issuecomment-509145539 Not from me! -----------------------------------...
solomax commented on issue #373: make autolabel functionality more flexible by introducing a locator interface that allow to specify the component the wicket:for refers too URL: https://github.com/apache/wicket/pull/373#issuecomment-509150881 +1 to merge :) ----------------------------------...
reiern70 commented on issue #373: make autolabel functionality more flexible by introducing a locator interface that allow to specify the component the wicket:for refers too URL: https://github.com/apache/wicket/pull/373#issuecomment-509156885 ok. Then once this is merged I will update docume...
Hi Martin, **OpenJDK* 13 Early Access build **28 is now available **at : - jdk.java.net/13/* * These early-access, open-source builds are provided under the GNU General Public License, version 2, with the Classpath Exception <http://openjdk.java.net/legal/gplv2+ce.html>. * Changes...
martin-g merged pull request #373: make autolabel functionality more flexible by introducing a locator interface that allow to specify the component the wicket:for refers too URL: https://github.com/apache/wicket/pull/373 ---------------------------------------------------------------- This...
andruhon opened a new pull request #374: WICKET-6682 add CSP nonce support: initial commit URL: https://github.com/apache/wicket/pull/374 This PR adds a CSP nonce support to Wicket. Just want to start a discussion. Certainly not ready to be merged yet. --------------------------------...
svenmeier commented on issue #374: WICKET-6682 add CSP nonce support: initial commit URL: https://github.com/apache/wicket/pull/374#issuecomment-510029334 A simpler solution is a new DecoratingHeaderResponse that may set a new "nonce" member on JavaScriptContentHeaderItem. Just like JavaSc...
andruhon commented on issue #374: WICKET-6682 add CSP nonce support: initial commit URL: https://github.com/apache/wicket/pull/374#issuecomment-510035699 Thank you @svenmeier ! I'll have a look. ---------------------------------------------------------------- This is an automated message f...
svenmeier opened a new pull request #375: WICKET-6666 modal dialog URL: https://github.com/apache/wicket/pull/375 This is my take on a new modal dialog/window for Wicket. I've taken Igor's work as a base but changed a lot of things, so I thought a separate pull-request would be easier ...
andruhon commented on issue #375: WICKET-6666 modal dialog URL: https://github.com/apache/wicket/pull/375#issuecomment-510254434 I just wanted to have a look at the modal, and I can't build: `wicket> mvn clean install -DskipTests=true` ``` ... [INFO] Reactor Summary: [INFO] ...
andruhon commented on issue #375: WICKET-6666 modal dialog URL: https://github.com/apache/wicket/pull/375#issuecomment-510260997 Don't mind the above. The mvn also needed JAVA_HOME to be same as one in the toolchain. I'm pretty sure it was working with other version of maven. ---------------...
andruhon commented on issue #375: WICKET-6666 modal dialog URL: https://github.com/apache/wicket/pull/375#issuecomment-510266632 If I open dialog with a `Link` in a new tab, it just blinks and disappears immediately (tested in FF, Chrome and Edge). -------------------------------------------...
andruhon commented on issue #374: WICKET-6682 add CSP nonce support: initial commit URL: https://github.com/apache/wicket/pull/374#issuecomment-510269255 @svenmeier Right, I agree with what you say in #273. It would be nice to have some interface for extra header item attributes. -----------...
svenmeier commented on issue #375: WICKET-6666 modal dialog URL: https://github.com/apache/wicket/pull/375#issuecomment-510498546 That's just AjaxNewWindowNotifyingBehavior creating a new page instance when it detects that you open a page in two different browser tabs. ---------------------...
andruhon opened a new pull request #376: WICKET-6682 add CSP nonce support: initial commit URL: https://github.com/apache/wicket/pull/376 Another approach to handle CSP nonce as alternative to #374 ---------------------------------------------------------------- This is an automated message ...
andruhon commented on issue #376: WICKET-6682 add CSP nonce support: initial commit URL: https://github.com/apache/wicket/pull/376#issuecomment-510891071 @svenmeier is it close to what you suggested about the DecoratingHeaderResponse? ---------------------------------------------------------...
solomax commented on a change in pull request #376: WICKET-6682 add CSP nonce support: initial commit URL: https://github.com/apache/wicket/pull/376#discussion_r302989065 ########## File path: wicket-core/src/main/java/org/apache/wicket/core/util/string/CssUtils.java ########## @@ -60,17 +6...
solomax commented on a change in pull request #376: WICKET-6682 add CSP nonce support: initial commit URL: https://github.com/apache/wicket/pull/376#discussion_r302990094 ########## File path: wicket-core/src/main/java/org/apache/wicket/core/util/string/CssUtils.java ########## @@ -119,27 +...
solomax commented on a change in pull request #376: WICKET-6682 add CSP nonce support: initial commit URL: https://github.com/apache/wicket/pull/376#discussion_r302991438 ########## File path: wicket-core/src/main/java/org/apache/wicket/core/util/string/JavaScriptUtils.java ########## @@ -2...
solomax commented on a change in pull request #376: WICKET-6682 add CSP nonce support: initial commit URL: https://github.com/apache/wicket/pull/376#discussion_r302991282 ########## File path: wicket-core/src/main/java/org/apache/wicket/core/util/string/JavaScriptUtils.java ########## @@ -2...
solomax commented on a change in pull request #376: WICKET-6682 add CSP nonce support: initial commit URL: https://github.com/apache/wicket/pull/376#discussion_r302991884 ########## File path: wicket-core/src/main/java/org/apache/wicket/markup/head/filter/CspNonceHeaderResponse.java ########...
Problem with javadoc-maven-plugin 3.1.x and CI: https://issues.apache.org/jira/browse/INFRA-18741 -- Andrea Del Bene. Apache Wicket committer.
svenmeier commented on issue #376: WICKET-6682 add CSP nonce support: initial commit URL: https://github.com/apache/wicket/pull/376#issuecomment-510968126 Yeah that's much simpler, isn't it? See my inline comments. ---------------------------------------------------------------- This is an a...
svenmeier commented on a change in pull request #376: WICKET-6682 add CSP nonce support: initial commit URL: https://github.com/apache/wicket/pull/376#discussion_r303078295 ########## File path: wicket-core/src/main/java/org/apache/wicket/markup/head/filter/CspNonceHeaderResponse.java ######...
svenmeier commented on a change in pull request #376: WICKET-6682 add CSP nonce support: initial commit URL: https://github.com/apache/wicket/pull/376#discussion_r303079004 ########## File path: wicket-core/src/main/java/org/apache/wicket/core/util/string/JavaScriptUtils.java ########## @@ ...
svenmeier commented on a change in pull request #376: WICKET-6682 add CSP nonce support: initial commit URL: https://github.com/apache/wicket/pull/376#discussion_r303079623 ########## File path: wicket-core/src/main/java/org/apache/wicket/markup/head/filter/CspNonceHeaderResponse.java ######...
svenmeier commented on a change in pull request #376: WICKET-6682 add CSP nonce support: initial commit URL: https://github.com/apache/wicket/pull/376#discussion_r303080030 ########## File path: wicket-util/src/main/java/org/apache/wicket/util/value/HeaderItemAttributeMap.java ########## @@...
andruhon commented on a change in pull request #376: WICKET-6682 add CSP nonce support: initial commit URL: https://github.com/apache/wicket/pull/376#discussion_r303191789 ########## File path: wicket-core/src/main/java/org/apache/wicket/core/util/string/JavaScriptUtils.java ########## @@ -...
andruhon commented on a change in pull request #376: WICKET-6682 add CSP nonce support: initial commit URL: https://github.com/apache/wicket/pull/376#discussion_r303191933 ########## File path: wicket-util/src/main/java/org/apache/wicket/util/value/HeaderItemAttributeMap.java ########## @@ ...
andruhon commented on a change in pull request #376: WICKET-6682 add CSP nonce support: initial commit URL: https://github.com/apache/wicket/pull/376#discussion_r303193907 ########## File path: wicket-core/src/main/java/org/apache/wicket/markup/head/filter/CspNonceHeaderResponse.java #######...
svenmeier commented on a change in pull request #376: WICKET-6682 add CSP nonce support: initial commit URL: https://github.com/apache/wicket/pull/376#discussion_r303195128 ########## File path: wicket-core/src/main/java/org/apache/wicket/core/util/string/JavaScriptUtils.java ########## @@ ...
andruhon commented on a change in pull request #376: WICKET-6682 add CSP nonce support: initial commit URL: https://github.com/apache/wicket/pull/376#discussion_r303195348 ########## File path: wicket-core/src/main/java/org/apache/wicket/core/util/string/JavaScriptUtils.java ########## @@ -...
svenmeier commented on a change in pull request #376: WICKET-6682 add CSP nonce support: initial commit URL: https://github.com/apache/wicket/pull/376#discussion_r303195834 ########## File path: wicket-core/src/main/java/org/apache/wicket/core/util/string/JavaScriptUtils.java ########## @@ ...
martin-g commented on a change in pull request #374: WICKET-6682 add CSP nonce support: initial commit URL: https://github.com/apache/wicket/pull/374#discussion_r303217930 ########## File path: wicket-core/src/main/java/org/apache/wicket/markup/head/INonceStrategy.java ########## @@ -0,0 +1...
martin-g commented on a change in pull request #374: WICKET-6682 add CSP nonce support: initial commit URL: https://github.com/apache/wicket/pull/374#discussion_r303217943 ########## File path: wicket-core/src/main/java/org/apache/wicket/markup/head/INonceStrategy.java ########## @@ -0,0 +1...
martin-g commented on a change in pull request #374: WICKET-6682 add CSP nonce support: initial commit URL: https://github.com/apache/wicket/pull/374#discussion_r303218028 ########## File path: wicket-core/src/main/java/org/apache/wicket/markup/head/nonce/AbstractNonceStrategy.java #########...
martin-g commented on a change in pull request #374: WICKET-6682 add CSP nonce support: initial commit URL: https://github.com/apache/wicket/pull/374#discussion_r303218212 ########## File path: wicket-core/src/main/java/org/apache/wicket/settings/SecuritySettings.java ########## @@ -243,4 +...
martin-g commented on a change in pull request #374: WICKET-6682 add CSP nonce support: initial commit URL: https://github.com/apache/wicket/pull/374#discussion_r303218087 ########## File path: wicket-core/src/main/java/org/apache/wicket/markup/head/nonce/CspUtils.java ########## @@ -0,0 +1...
martin-g commented on a change in pull request #374: WICKET-6682 add CSP nonce support: initial commit URL: https://github.com/apache/wicket/pull/374#discussion_r303218202 ########## File path: wicket-core/src/main/java/org/apache/wicket/markup/head/nonce/PerSessionNonceStrategy.java #######...
martin-g commented on a change in pull request #374: WICKET-6682 add CSP nonce support: initial commit URL: https://github.com/apache/wicket/pull/374#discussion_r303217903 ########## File path: wicket-core/src/main/java/org/apache/wicket/core/util/string/JavaScriptUtils.java ########## @@ -...
andruhon commented on issue #374: WICKET-6682 add CSP nonce support: initial commit URL: https://github.com/apache/wicket/pull/374#issuecomment-511157387 Thanks @martin-g ! There's another PR for the same issue https://github.com/apache/wicket/pull/376 . Sven recommended to try different appr...
andruhon commented on issue #376: WICKET-6682 add CSP nonce support: DecoratingHeaderResponse approach URL: https://github.com/apache/wicket/pull/376#issuecomment-511187971 @svenmeier @martin-g @solomax I pushed some after review improvements and fixed tests. --------------------------------...
svenmeier commented on issue #376: WICKET-6682 add CSP nonce support: DecoratingHeaderResponse approach URL: https://github.com/apache/wicket/pull/376#issuecomment-511236892 @andruhon actually I'm impressed how well this worked out ;) This definitely fits nicely into the existing frame...
andruhon commented on issue #376: WICKET-6682 add CSP nonce support: DecoratingHeaderResponse approach URL: https://github.com/apache/wicket/pull/376#issuecomment-511240892 Thanks @svenmeier ! I'm waiting for comments then. This PR is pointing to wicket-8, I wanted to make it a non-breaki...
andruhon commented on issue #376: WICKET-6682 add CSP nonce support: DecoratingHeaderResponse approach URL: https://github.com/apache/wicket/pull/376#issuecomment-511241586 Speaking about versions. I think that in wicket-8 this feature should produce same or almost the same HTML as before, bu...
andruhon commented on issue #376: WICKET-6682 add CSP nonce support: DecoratingHeaderResponse approach URL: https://github.com/apache/wicket/pull/376#issuecomment-511242460 By the way. https://cwiki.apache.org/confluence/display/WICKET/Wicket+Source+Code+Style Is this one still somewhat up to...
solomax commented on issue #376: WICKET-6682 add CSP nonce support: DecoratingHeaderResponse approach URL: https://github.com/apache/wicket/pull/376#issuecomment-511267588 I'll try to set up `apache-rat-plugin` and `maven-checkstyle-plugin` to perform automatic checks and will prepare PR ...
solomax commented on a change in pull request #376: WICKET-6682 add CSP nonce support: DecoratingHeaderResponse approach URL: https://github.com/apache/wicket/pull/376#discussion_r303282678 ########## File path: wicket-core/src/main/java/org/apache/wicket/core/util/string/CssUtils.java #####...
solomax commented on a change in pull request #376: WICKET-6682 add CSP nonce support: DecoratingHeaderResponse approach URL: https://github.com/apache/wicket/pull/376#discussion_r303282781 ########## File path: wicket-core/src/main/java/org/apache/wicket/core/util/string/JavaScriptUtils.java...
martin-g commented on a change in pull request #376: WICKET-6682 add CSP nonce support: DecoratingHeaderResponse approach URL: https://github.com/apache/wicket/pull/376#discussion_r303298114 ########## File path: wicket-core/src/main/java/org/apache/wicket/core/util/string/CssUtils.java ####...
martin-g commented on a change in pull request #376: WICKET-6682 add CSP nonce support: DecoratingHeaderResponse approach URL: https://github.com/apache/wicket/pull/376#discussion_r303299242 ########## File path: wicket-core/src/main/java/org/apache/wicket/markup/head/JavaScriptHeaderItem.jav...
martin-g commented on a change in pull request #376: WICKET-6682 add CSP nonce support: DecoratingHeaderResponse approach URL: https://github.com/apache/wicket/pull/376#discussion_r303298670 ########## File path: wicket-core/src/main/java/org/apache/wicket/core/util/string/JavaScriptUtils.jav...
martin-g commented on a change in pull request #376: WICKET-6682 add CSP nonce support: DecoratingHeaderResponse approach URL: https://github.com/apache/wicket/pull/376#discussion_r303299424 ########## File path: wicket-core/src/main/java/org/apache/wicket/markup/head/OnLoadHeaderItem.java #...
martin-g commented on a change in pull request #376: WICKET-6682 add CSP nonce support: DecoratingHeaderResponse approach URL: https://github.com/apache/wicket/pull/376#discussion_r303299391 ########## File path: wicket-core/src/main/java/org/apache/wicket/markup/head/OnDomReadyHeaderItem.jav...
martin-g commented on a change in pull request #376: WICKET-6682 add CSP nonce support: DecoratingHeaderResponse approach URL: https://github.com/apache/wicket/pull/376#discussion_r303299095 ########## File path: wicket-core/src/main/java/org/apache/wicket/markup/head/CssHeaderItem.java ####...
martin-g commented on a change in pull request #376: WICKET-6682 add CSP nonce support: DecoratingHeaderResponse approach URL: https://github.com/apache/wicket/pull/376#discussion_r303300298 ########## File path: wicket-util/src/main/java/org/apache/wicket/util/value/AttributeMap.java ######...
martin-g commented on issue #376: WICKET-6682 add CSP nonce support: DecoratingHeaderResponse approach URL: https://github.com/apache/wicket/pull/376#issuecomment-511292522 > By the way. [cwiki.apache.org/confluence/display/WICKET/Wicket+Source+Code+Style](https://cwiki.apache.org/confluence/...
andruhon commented on a change in pull request #376: WICKET-6682 add CSP nonce support: DecoratingHeaderResponse approach URL: https://github.com/apache/wicket/pull/376#discussion_r303316003 ########## File path: wicket-util/src/main/java/org/apache/wicket/util/value/AttributeMap.java ######...
andruhon commented on issue #376: WICKET-6682 add CSP nonce support: DecoratingHeaderResponse approach URL: https://github.com/apache/wicket/pull/376#issuecomment-511303804 Thank you everyone! I'll go through comments a bit later. -------------------------------------------------------------...
martin-g commented on a change in pull request #376: WICKET-6682 add CSP nonce support: DecoratingHeaderResponse approach URL: https://github.com/apache/wicket/pull/376#discussion_r303320119 ########## File path: wicket-util/src/main/java/org/apache/wicket/util/value/AttributeMap.java ######...
andruhon commented on issue #376: WICKET-6682 add CSP nonce support: DecoratingHeaderResponse approach URL: https://github.com/apache/wicket/pull/376#issuecomment-511346497 I went a bit further with cleaning names in utility classes and emphasized those which are inline ones, it was hard to r...
svenmeier commented on a change in pull request #376: WICKET-6682 add CSP nonce support: DecoratingHeaderResponse approach URL: https://github.com/apache/wicket/pull/376#discussion_r303398070 ########## File path: wicket-core/src/main/java/org/apache/wicket/markup/head/CssHeaderItem.java ###...
svenmeier commented on a change in pull request #376: WICKET-6682 add CSP nonce support: DecoratingHeaderResponse approach URL: https://github.com/apache/wicket/pull/376#discussion_r303398863 ########## File path: wicket-util/src/main/java/org/apache/wicket/util/value/HeaderItemAttribute.java...
svenmeier commented on a change in pull request #376: WICKET-6682 add CSP nonce support: DecoratingHeaderResponse approach URL: https://github.com/apache/wicket/pull/376#discussion_r303398973 ########## File path: wicket-util/src/main/java/org/apache/wicket/util/value/IAttributeMapKey.java #...
andruhon commented on a change in pull request #376: WICKET-6682 add CSP nonce support: DecoratingHeaderResponse approach URL: https://github.com/apache/wicket/pull/376#discussion_r303403279 ########## File path: wicket-util/src/main/java/org/apache/wicket/util/value/HeaderItemAttribute.java ...
andruhon commented on a change in pull request #376: WICKET-6682 add CSP nonce support: DecoratingHeaderResponse approach URL: https://github.com/apache/wicket/pull/376#discussion_r303404547 ########## File path: wicket-core/src/main/java/org/apache/wicket/markup/head/CssHeaderItem.java ####...
andruhon commented on a change in pull request #376: WICKET-6682 add CSP nonce support: DecoratingHeaderResponse approach URL: https://github.com/apache/wicket/pull/376#discussion_r303403279 ########## File path: wicket-util/src/main/java/org/apache/wicket/util/value/HeaderItemAttribute.java ...
solomax commented on a change in pull request #376: WICKET-6682 add CSP nonce support: DecoratingHeaderResponse approach URL: https://github.com/apache/wicket/pull/376#discussion_r303412607 ########## File path: wicket-core/src/main/java/org/apache/wicket/markup/head/CssHeaderItem.java #####...
andruhon commented on a change in pull request #376: WICKET-6682 add CSP nonce support: DecoratingHeaderResponse approach URL: https://github.com/apache/wicket/pull/376#discussion_r303427180 ########## File path: wicket-core/src/main/java/org/apache/wicket/markup/head/CssHeaderItem.java ####...
andruhon commented on issue #376: WICKET-6682 add CSP nonce support: DecoratingHeaderResponse approach URL: https://github.com/apache/wicket/pull/376#issuecomment-511400657 I've got into a trouble with this stuff. Need help. The issue is that we really want all attributes to be escaped, excep...
svenmeier commented on issue #376: WICKET-6682 add CSP nonce support: DecoratingHeaderResponse approach URL: https://github.com/apache/wicket/pull/376#issuecomment-511423099 I'm confused now - why shouldn't all attributes be escaped? I've read WICKET-4777 but I don't understand it. ---------...
andruhon commented on issue #376: WICKET-6682 add CSP nonce support: DecoratingHeaderResponse approach URL: https://github.com/apache/wicket/pull/376#issuecomment-511424374 @svenmeier I'm also confused. The url for the CSS is escaped, the url for JS is not. I have a solution, will push soon, ...
andruhon commented on issue #376: WICKET-6682 add CSP nonce support: DecoratingHeaderResponse approach URL: https://github.com/apache/wicket/pull/376#issuecomment-511425486 @svenmeier the issue, I think that escape markup simply swallows parameters spearated by &, because they are replaced wi...
andruhon edited a comment on issue #376: WICKET-6682 add CSP nonce support: DecoratingHeaderResponse approach URL: https://github.com/apache/wicket/pull/376#issuecomment-511425486 @svenmeier the issue, I think that escape markup simply swallows parameters spearated by &, because they are repl...
andruhon commented on issue #376: WICKET-6682 add CSP nonce support: DecoratingHeaderResponse approach URL: https://github.com/apache/wicket/pull/376#issuecomment-511429413 I suppose, the answer is generally that all URLs should be escaped and there, probably, must be a special header item wh...
andruhon commented on issue #376: WICKET-6682 add CSP nonce support: DecoratingHeaderResponse approach URL: https://github.com/apache/wicket/pull/376#issuecomment-511440398 I removed enums, and updated tests. It now produces the same output, including links for JS ---------------------------...
andruhon closed pull request #374: WICKET-6682 add CSP nonce support: strategy approach URL: https://github.com/apache/wicket/pull/374 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please...
andruhon commented on issue #374: WICKET-6682 add CSP nonce support: strategy approach URL: https://github.com/apache/wicket/pull/374#issuecomment-511443776 I think this one should be closed. ---------------------------------------------------------------- This is an automated message from t...
svenmeier commented on issue #376: WICKET-6682 add CSP nonce support: DecoratingHeaderResponse approach URL: https://github.com/apache/wicket/pull/376#issuecomment-511476813 We should reconsider the change introduced WICKET-4777 ... @martin-g can you explain why that JavScript url attribute s...
martin-g commented on issue #376: WICKET-6682 add CSP nonce support: DecoratingHeaderResponse approach URL: https://github.com/apache/wicket/pull/376#issuecomment-511688691 WICKET-4777 is almost 7 years old. My memory capacity is not that big. I guess my thinking was in the line of: If...
martin-g commented on a change in pull request #376: WICKET-6682 add CSP nonce support: DecoratingHeaderResponse approach URL: https://github.com/apache/wicket/pull/376#discussion_r303750156 ########## File path: wicket-core/src/main/java/org/apache/wicket/markup/head/CssHeaderItem.java ####...
martin-g commented on issue #376: WICKET-6682 add CSP nonce support: DecoratingHeaderResponse approach URL: https://github.com/apache/wicket/pull/376#issuecomment-511691773 Is `AttributeMap#compute(Object, Supplier)` still used ? I see you replaced all (?) callers to use the BiFunction va...
andruhon commented on issue #376: WICKET-6682 add CSP nonce support: DecoratingHeaderResponse approach URL: https://github.com/apache/wicket/pull/376#issuecomment-511694465 @martin-g the `AttributeMap#compute` has already been removed. --------------------------------------------------------...
andruhon commented on issue #376: WICKET-6682 add CSP nonce support: DecoratingHeaderResponse approach URL: https://github.com/apache/wicket/pull/376#issuecomment-511695375 This PR is for wicket-8.x, I propose to merge it to the wicket-8.x with behavior replicating existing one. And to create...
svenmeier commented on a change in pull request #376: WICKET-6682 add CSP nonce support: DecoratingHeaderResponse approach URL: https://github.com/apache/wicket/pull/376#discussion_r303434018 ########## File path: wicket-core/src/main/java/org/apache/wicket/markup/head/CssHeaderItem.java ###...
svenmeier commented on a change in pull request #376: WICKET-6682 add CSP nonce support: DecoratingHeaderResponse approach URL: https://github.com/apache/wicket/pull/376#discussion_r303400434 ########## File path: wicket-core/src/main/java/org/apache/wicket/markup/head/JavaScriptHeaderItem.ja...
svenmeier commented on a change in pull request #376: WICKET-6682 add CSP nonce support: DecoratingHeaderResponse approach URL: https://github.com/apache/wicket/pull/376#discussion_r303400169 ########## File path: wicket-core/src/main/java/org/apache/wicket/markup/head/JavaScriptHeaderItem.ja...
andruhon commented on a change in pull request #376: WICKET-6682 add CSP nonce support: DecoratingHeaderResponse approach URL: https://github.com/apache/wicket/pull/376#discussion_r303823925 ########## File path: wicket-core/src/main/java/org/apache/wicket/markup/head/JavaScriptHeaderItem.jav...
andruhon commented on a change in pull request #376: WICKET-6682 add CSP nonce support: DecoratingHeaderResponse approach URL: https://github.com/apache/wicket/pull/376#discussion_r303835058 ########## File path: wicket-core/src/main/java/org/apache/wicket/markup/head/JavaScriptHeaderItem.jav...
andruhon commented on a change in pull request #376: WICKET-6682 add CSP nonce support: DecoratingHeaderResponse approach URL: https://github.com/apache/wicket/pull/376#discussion_r303837404 ########## File path: wicket-core/src/main/java/org/apache/wicket/markup/head/JavaScriptHeaderItem.jav...
andruhon commented on a change in pull request #376: WICKET-6682 add CSP nonce support: DecoratingHeaderResponse approach URL: https://github.com/apache/wicket/pull/376#discussion_r303839694 ########## File path: wicket-core/src/main/java/org/apache/wicket/markup/head/JavaScriptHeaderItem.jav...
andruhon commented on issue #376: WICKET-6682 add CSP nonce support: DecoratingHeaderResponse approach URL: https://github.com/apache/wicket/pull/376#issuecomment-511792269 I think this isn't going to be possible with wicket 8. Pointed this PR to master. @svenmeier please have a look at re...
andruhon commented on issue #376: WICKET-6682 add CSP nonce support: DecoratingHeaderResponse approach URL: https://github.com/apache/wicket/pull/376#issuecomment-511976815 I'm not sure that what I did with url encoding is correct. Essentially all attributes have slightly different rule. ...
andruhon commented on issue #376: WICKET-6682 add CSP nonce support: DecoratingHeaderResponse approach URL: https://github.com/apache/wicket/pull/376#issuecomment-512007729 Pushed another commit removing escaping from the ValueMap and delegating this job to appropriate header items ---------...
m4ns0ur opened a new pull request #377: WICKET-6689 fix ClientProperties.getTimezone() UTC-DST difference calculation. URL: https://github.com/apache/wicket/pull/377 Fixes [WICKET-6689](https://issues.apache.org/jira/browse/WICKET-6689). ------------------------------------------------------...
andruhon commented on issue #273: WICKET-6321 Support Integrity and Crossorigin attributes URL: https://github.com/apache/wicket/pull/273#issuecomment-512625174 #376 should open a relatively easy way for integrity and crossorigin once merged --------------------------------------------------...
svenmeier commented on issue #273: WICKET-6321 Support Integrity and Crossorigin attributes URL: https://github.com/apache/wicket/pull/273#issuecomment-512713964 Indeed. ---------------------------------------------------------------- This is an automated message from the Apache Git Service....
andruhon opened a new pull request #378: WICKET-6688 add RFC support (to avoid unsafe eval) URL: https://github.com/apache/wicket/pull/378 Initial commit addressing https://issues.apache.org/jira/browse/WICKET-6688. Please have a look if it makes sense. If it is I can add documentation...
solomax commented on a change in pull request #378: WICKET-6688 add RFC support (to avoid unsafe eval) URL: https://github.com/apache/wicket/pull/378#discussion_r304790048 ########## File path: wicket-core/src/main/java/org/apache/wicket/ajax/RemoteFunctionCallUtils.java ########## @@ -0,0 ...
solomax commented on a change in pull request #378: WICKET-6688 add RFC support (to avoid unsafe eval) URL: https://github.com/apache/wicket/pull/378#discussion_r304792704 ########## File path: wicket-examples/src/main/java/org/apache/wicket/examples/ajax/builtin/RFCPage.html ########## @@ ...
solomax commented on a change in pull request #378: WICKET-6688 add RFC support (to avoid unsafe eval) URL: https://github.com/apache/wicket/pull/378#discussion_r304791684 ########## File path: wicket-examples/src/main/java/org/apache/wicket/examples/ajax/builtin/RFCPage.java ########## @@ ...
solomax commented on a change in pull request #378: WICKET-6688 add RFC support (to avoid unsafe eval) URL: https://github.com/apache/wicket/pull/378#discussion_r304790455 ########## File path: wicket-core/src/main/java/org/apache/wicket/ajax/RemoteFunctionCallUtils.java ########## @@ -0,0 ...
svenmeier commented on a change in pull request #378: WICKET-6688 add RFC support (to avoid unsafe eval) URL: https://github.com/apache/wicket/pull/378#discussion_r304796350 ########## File path: wicket-core/src/main/java/org/apache/wicket/ajax/AjaxRequestHandler.java ########## @@ -16,14 +...
andruhon commented on a change in pull request #378: WICKET-6688 add RFC support (to avoid unsafe eval) URL: https://github.com/apache/wicket/pull/378#discussion_r304820758 ########## File path: wicket-core/src/main/java/org/apache/wicket/ajax/RemoteFunctionCallUtils.java ########## @@ -0,0...