You are viewing the static version of this archive.
For the interactive version, please visit: This page
stevedlawrence opened a new pull request #77: Modifications to IO layer to support streaming input data URL: https://github.com/apache/incubator-daffodil/pull/77 - Modify the ByteBufferDataInputStream to no longer depend on ByteBuffers. It is now an InputSourceDataInputStream, and one ca...
stevedlawrence opened a new pull request #78: Configure the Travis CI build environment for more memory URL: https://github.com/apache/incubator-daffodil/pull/78 The default Travis CI build environment (sudo: false, dist: trusty) is container based on only provides a max of 4GB of memory. ...
stevedlawrence commented on issue #77: Modifications to IO layer to support streaming input data URL: https://github.com/apache/incubator-daffodil/pull/77#issuecomment-403092811 Note that the Travis CI build failure appears to be an out of memory error, which is fixed by bumping up the memory...
stevedlawrence commented on issue #76: Allow Daffodil to build against Scala 2.12 URL: https://github.com/apache/incubator-daffodil/pull/76#issuecomment-403449259 I realized that the LICENSE and eclipse classpath files needed to be updated to the new scala and scallop versions. Just added a c...
stevedlawrence closed pull request #78: Configure the Travis CI build environment for more memory URL: https://github.com/apache/incubator-daffodil/pull/78 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provena...
stevedlawrence commented on issue #76: Allow Daffodil to build against Scala 2.12 URL: https://github.com/apache/incubator-daffodil/pull/76#issuecomment-403498257 I was imagining we we still support both 2.11 and 2.12 (e.g. we will publish both versions to maven), but default to 2.12 for deve...
stevedlawrence commented on issue #73: Enable the sbt-rat plugin to perform Apache Rat checks URL: https://github.com/apache/incubator-daffodil/pull/73#issuecomment-403502464 Release Audit Tool. It's usually run by incubator mentors/voters during releases to make sure there aren't incorrectly...
jadams-tresys closed pull request #75: Daffodil 1738 zoned decimal URL: https://github.com/apache/incubator-daffodil/pull/75 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull...
mbeckerle commented on a change in pull request #77: Modifications to IO layer to support streaming input data URL: https://github.com/apache/incubator-daffodil/pull/77#discussion_r201041175 ########## File path: daffodil-io/src/main/scala/org/apache/daffodil/processors/charset/BitsCharsetDec...
mbeckerle commented on a change in pull request #77: Modifications to IO layer to support streaming input data URL: https://github.com/apache/incubator-daffodil/pull/77#discussion_r201029459 ########## File path: daffodil-lib/src/main/scala/org/apache/daffodil/util/BitOrder.scala ########## ...
mbeckerle commented on a change in pull request #77: Modifications to IO layer to support streaming input data URL: https://github.com/apache/incubator-daffodil/pull/77#discussion_r201043593 ########## File path: daffodil-io/src/main/scala/org/apache/daffodil/io/InputSource.scala ########## ...
mbeckerle commented on a change in pull request #77: Modifications to IO layer to support streaming input data URL: https://github.com/apache/incubator-daffodil/pull/77#discussion_r201027993 ########## File path: daffodil-io/src/main/scala/org/apache/daffodil/io/ByteBufferDataInputStream.scal...
mbeckerle commented on a change in pull request #77: Modifications to IO layer to support streaming input data URL: https://github.com/apache/incubator-daffodil/pull/77#discussion_r201035109 ########## File path: daffodil-core/src/main/scala/org/apache/daffodil/compiler/Compiler.scala ######...
mbeckerle commented on a change in pull request #77: Modifications to IO layer to support streaming input data URL: https://github.com/apache/incubator-daffodil/pull/77#discussion_r201042080 ########## File path: daffodil-io/src/main/scala/org/apache/daffodil/processors/charset/BitsCharset.sc...
mbeckerle commented on a change in pull request #77: Modifications to IO layer to support streaming input data URL: https://github.com/apache/incubator-daffodil/pull/77#discussion_r201046173 ########## File path: daffodil-io/src/main/scala/org/apache/daffodil/io/InputSource.scala ########## ...
mbeckerle commented on a change in pull request #77: Modifications to IO layer to support streaming input data URL: https://github.com/apache/incubator-daffodil/pull/77#discussion_r201048198 ########## File path: daffodil-io/src/main/scala/org/apache/daffodil/io/InputSourceDataInputStream.sca...
stevedlawrence closed pull request #73: Enable the sbt-rat plugin to perform Apache Rat checks URL: https://github.com/apache/incubator-daffodil/pull/73 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance...
stevedlawrence commented on a change in pull request #77: Modifications to IO layer to support streaming input data URL: https://github.com/apache/incubator-daffodil/pull/77#discussion_r201095086 ########## File path: daffodil-io/src/main/scala/org/apache/daffodil/io/ByteBufferDataInputStream...
stevedlawrence commented on a change in pull request #77: Modifications to IO layer to support streaming input data URL: https://github.com/apache/incubator-daffodil/pull/77#discussion_r201096952 ########## File path: daffodil-io/src/main/scala/org/apache/daffodil/processors/charset/BitsChars...
stevedlawrence commented on a change in pull request #77: Modifications to IO layer to support streaming input data URL: https://github.com/apache/incubator-daffodil/pull/77#discussion_r201099700 ########## File path: daffodil-core/src/main/scala/org/apache/daffodil/compiler/Compiler.scala #...
stevedlawrence commented on a change in pull request #77: Modifications to IO layer to support streaming input data URL: https://github.com/apache/incubator-daffodil/pull/77#discussion_r201097800 ########## File path: daffodil-lib/src/main/scala/org/apache/daffodil/util/BitOrder.scala ######...
stevedlawrence commented on a change in pull request #77: Modifications to IO layer to support streaming input data URL: https://github.com/apache/incubator-daffodil/pull/77#discussion_r201101774 ########## File path: daffodil-io/src/main/scala/org/apache/daffodil/io/InputSource.scala ######...
stevedlawrence commented on a change in pull request #77: Modifications to IO layer to support streaming input data URL: https://github.com/apache/incubator-daffodil/pull/77#discussion_r201103236 ########## File path: daffodil-io/src/main/scala/org/apache/daffodil/io/InputSource.scala ######...
stevedlawrence commented on a change in pull request #77: Modifications to IO layer to support streaming input data URL: https://github.com/apache/incubator-daffodil/pull/77#discussion_r201105027 ########## File path: daffodil-io/src/main/scala/org/apache/daffodil/io/InputSourceDataInputStrea...
stevedlawrence commented on a change in pull request #77: Modifications to IO layer to support streaming input data URL: https://github.com/apache/incubator-daffodil/pull/77#discussion_r201109033 ########## File path: daffodil-io/src/main/scala/org/apache/daffodil/processors/charset/BitsChars...
mbeckerle opened a new pull request #79: TDMLRunner explicit roundTrip="twoPass" feature. URL: https://github.com/apache/incubator-daffodil/pull/79 Added feature where tests are explicit about number of roundTrip tries. I needed this feature to help with debugging the 100+ test failure...
stevedlawrence closed pull request #76: Allow Daffodil to build against Scala 2.12 URL: https://github.com/apache/incubator-daffodil/pull/76 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this i...
stevedlawrence commented on a change in pull request #79: TDMLRunner explicit roundTrip="twoPass" feature. URL: https://github.com/apache/incubator-daffodil/pull/79#discussion_r201310203 ########## File path: daffodil-lib/src/main/resources/org/apache/daffodil/xsd/tdml.xsd ########## @@ -15...
stevedlawrence commented on a change in pull request #79: TDMLRunner explicit roundTrip="twoPass" feature. URL: https://github.com/apache/incubator-daffodil/pull/79#discussion_r201311327 ########## File path: daffodil-tdml/src/main/scala/org/apache/daffodil/tdml/TDMLRunner.scala ########## ...
stevedlawrence commented on issue #79: TDMLRunner explicit roundTrip="twoPass" feature. URL: https://github.com/apache/incubator-daffodil/pull/79#issuecomment-403796667 Can you modify the commit message to include some of the information in the PR message? Alot of that would be useful to have...
jadams-tresys commented on a change in pull request #79: TDMLRunner explicit roundTrip="twoPass" feature. URL: https://github.com/apache/incubator-daffodil/pull/79#discussion_r202067491 ########## File path: daffodil-lib/src/main/resources/org/apache/daffodil/xsd/tdml.xsd ########## @@ -151...
mbeckerle commented on a change in pull request #79: TDMLRunner explicit roundTrip="twoPass" feature. URL: https://github.com/apache/incubator-daffodil/pull/79#discussion_r202360569 ########## File path: daffodil-lib/src/main/resources/org/apache/daffodil/xsd/tdml.xsd ########## @@ -151,12 ...
mbeckerle commented on a change in pull request #79: TDMLRunner explicit roundTrip="twoPass" feature. URL: https://github.com/apache/incubator-daffodil/pull/79#discussion_r202360628 ########## File path: daffodil-tdml/src/main/scala/org/apache/daffodil/tdml/TDMLRunner.scala ########## @@ -7...
marshalljmiller opened a new pull request #80: added a layer transform that swaps bytes within an array of 32 bit words URL: https://github.com/apache/incubator-daffodil/pull/80 This is a layer transform that allows Daffodil to support parsing Link-16 J messages embedded within DIS PDUs, comm...
stevedlawrence closed pull request #79: TDMLRunner explicit roundTrip="twoPass" feature. URL: https://github.com/apache/incubator-daffodil/pull/79 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As ...
stevedlawrence closed pull request #77: Modifications to IO layer to support streaming input data URL: https://github.com/apache/incubator-daffodil/pull/77 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provena...
stevedlawrence opened a new pull request #81: Reduce memory usage regressions in commit 07ee2434bb URL: https://github.com/apache/incubator-daffodil/pull/81 The modifications to the IO layer to support streaming made changes that substantially increased memory usage. This makes the followi...
Hello, I submitted pull request 80 to add a layer transform that swaps bytes within 32 bit words. Unfortunately I failed to follow the contributor workflow. How would you like me to proceed? Marshall Miller
stevedlawrence commented on a change in pull request #80: added a layer transform that swaps bytes within an array of 32 bit words URL: https://github.com/apache/incubator-daffodil/pull/80#discussion_r202673710 ########## File path: daffodil-core/src/test/scala/org/apache/daffodil/layers/Test...
stevedlawrence commented on a change in pull request #80: added a layer transform that swaps bytes within an array of 32 bit words URL: https://github.com/apache/incubator-daffodil/pull/80#discussion_r202689363 ########## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/layers/...
stevedlawrence commented on a change in pull request #80: added a layer transform that swaps bytes within an array of 32 bit words URL: https://github.com/apache/incubator-daffodil/pull/80#discussion_r202673284 ########## File path: daffodil-core/src/test/scala/org/apache/daffodil/layers/Test...
marshalljmiller commented on a change in pull request #80: added a layer transform that swaps bytes within an array of 32 bit words URL: https://github.com/apache/incubator-daffodil/pull/80#discussion_r202708101 ########## File path: daffodil-core/src/test/scala/org/apache/daffodil/layers/Tes...
marshalljmiller commented on a change in pull request #80: added a layer transform that swaps bytes within an array of 32 bit words URL: https://github.com/apache/incubator-daffodil/pull/80#discussion_r202708122 ########## File path: daffodil-core/src/test/scala/org/apache/daffodil/layers/Tes...
marshalljmiller commented on a change in pull request #80: added a layer transform that swaps bytes within an array of 32 bit words URL: https://github.com/apache/incubator-daffodil/pull/80#discussion_r202708148 ########## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/layers...
marshalljmiller commented on issue #80: added a layer transform that swaps bytes within an array of 32 bit words URL: https://github.com/apache/incubator-daffodil/pull/80#issuecomment-405270564 I will update the commit message so that it is formatted correctly and with more detail. Should I ...
stevedlawrence commented on issue #80: added a layer transform that swaps bytes within an array of 32 bit words URL: https://github.com/apache/incubator-daffodil/pull/80#issuecomment-405277157 We've found that amend and --force commits has caused old review comments to disappear from GitHub s...
stevedlawrence opened a new pull request #82: Support the --stream option with the unparse subcommand URL: https://github.com/apache/incubator-daffodil/pull/82 - When the --stream option is provided to the parse command, output a NUL character (\u0000) after each infoset is output to act...
mbeckerle commented on a change in pull request #82: Support the --stream option with the unparse subcommand URL: https://github.com/apache/incubator-daffodil/pull/82#discussion_r202993126 ########## File path: daffodil-io/src/main/scala/org/apache/daffodil/io/DirectOrBufferedDataOutputStream...
mbeckerle commented on a change in pull request #80: added a layer transform that swaps bytes within an array of 32 bit words URL: https://github.com/apache/incubator-daffodil/pull/80#discussion_r202993779 ########## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/layers/ByteS...
mbeckerle commented on a change in pull request #80: added a layer transform that swaps bytes within an array of 32 bit words URL: https://github.com/apache/incubator-daffodil/pull/80#discussion_r202994409 ########## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/layers/ByteS...
mbeckerle commented on a change in pull request #80: added a layer transform that swaps bytes within an array of 32 bit words URL: https://github.com/apache/incubator-daffodil/pull/80#discussion_r202994877 ########## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/layers/ByteS...
stevedlawrence closed pull request #81: Reduce memory usage regressions in commit 07ee2434bb URL: https://github.com/apache/incubator-daffodil/pull/81 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: ...
stevedlawrence closed pull request #82: Support the --stream option with the unparse subcommand URL: https://github.com/apache/incubator-daffodil/pull/82 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenanc...
Hello, We have encountered a data format that requires use of the XPath sum function, but it appears that this is not supported. The data format of interest is the Minefield Data PDU as described by IEEE STD 1278.1a-1998 section 5.3.10.3. It includes a sequence of integer fields that describe the...
stevedlawrence commented on issue #80: added a layer transform that swaps bytes within an array of 32 bit words URL: https://github.com/apache/incubator-daffodil/pull/80#issuecomment-405661619 +1. If you now squash your changes into a single commit and --force commit, it'll be good to merge. ...
marshalljmiller commented on issue #80: added a layer transform that swaps bytes within an array of 32 bit words URL: https://github.com/apache/incubator-daffodil/pull/80#issuecomment-405690001 I squashed my commits and rebased on master. -----------------------------------------------------...
stevedlawrence closed pull request #80: added a layer transform that swaps bytes within an array of 32 bit words URL: https://github.com/apache/incubator-daffodil/pull/80 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the ...
stevedlawrence commented on issue #80: added a layer transform that swaps bytes within an array of 32 bit words URL: https://github.com/apache/incubator-daffodil/pull/80#issuecomment-405718280 Merged. Thanks for you contribution! --------------------------------------------------------------...
efinnegan opened a new pull request #83: Adding value of 'bcd' to binaryCalendarRep URL: https://github.com/apache/incubator-daffodil/pull/83 Adds parsing and unparsing capability for binary representation of xs:date, xs:time, and xs:dateTime with a binaryCalendarRep of 'bcd', including...
efinnegan commented on a change in pull request #83: Adding value of 'bcd' to binaryCalendarRep URL: https://github.com/apache/incubator-daffodil/pull/83#discussion_r203184491 ########## File path: daffodil-test/src/test/resources/org/apache/daffodil/section05/simple_types/SimpleTypes.tdml #...
stevedlawrence commented on a change in pull request #83: Adding value of 'bcd' to binaryCalendarRep URL: https://github.com/apache/incubator-daffodil/pull/83#discussion_r203350253 ########## File path: daffodil-core/src/main/scala/org/apache/daffodil/grammar/primitives/PrimitivesDateTime.sca...
stevedlawrence commented on a change in pull request #83: Adding value of 'bcd' to binaryCalendarRep URL: https://github.com/apache/incubator-daffodil/pull/83#discussion_r203352300 ########## File path: daffodil-core/src/main/scala/org/apache/daffodil/grammar/primitives/PrimitivesDateTime.sca...
stevedlawrence commented on a change in pull request #83: Adding value of 'bcd' to binaryCalendarRep URL: https://github.com/apache/incubator-daffodil/pull/83#discussion_r203367585 ########## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/parsers/PrimitivesDateTime...
stevedlawrence commented on a change in pull request #83: Adding value of 'bcd' to binaryCalendarRep URL: https://github.com/apache/incubator-daffodil/pull/83#discussion_r203360722 ########## File path: daffodil-runtime1-unparser/src/main/scala/org/apache/daffodil/processors/unparsers/Convert...
stevedlawrence commented on a change in pull request #83: Adding value of 'bcd' to binaryCalendarRep URL: https://github.com/apache/incubator-daffodil/pull/83#discussion_r203374405 ########## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/parsers/PrimitivesDateTime...
stevedlawrence commented on a change in pull request #83: Adding value of 'bcd' to binaryCalendarRep URL: https://github.com/apache/incubator-daffodil/pull/83#discussion_r203363509 ########## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/parsers/PrimitivesDateTime...
stevedlawrence commented on a change in pull request #83: Adding value of 'bcd' to binaryCalendarRep URL: https://github.com/apache/incubator-daffodil/pull/83#discussion_r203358898 ########## File path: daffodil-runtime1-unparser/src/main/scala/org/apache/daffodil/processors/unparsers/Convert...
stevedlawrence commented on a change in pull request #83: Adding value of 'bcd' to binaryCalendarRep URL: https://github.com/apache/incubator-daffodil/pull/83#discussion_r203352970 ########## File path: daffodil-core/src/main/scala/org/apache/daffodil/grammar/primitives/PrimitivesDateTime.sca...
stevedlawrence commented on a change in pull request #83: Adding value of 'bcd' to binaryCalendarRep URL: https://github.com/apache/incubator-daffodil/pull/83#discussion_r203375347 ########## File path: daffodil-test/src/test/resources/org/apache/daffodil/section05/simple_types/SimpleTypes.td...
stevedlawrence commented on a change in pull request #83: Adding value of 'bcd' to binaryCalendarRep URL: https://github.com/apache/incubator-daffodil/pull/83#discussion_r203368789 ########## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/parsers/PrimitivesDateTime...
stevedlawrence commented on a change in pull request #83: Adding value of 'bcd' to binaryCalendarRep URL: https://github.com/apache/incubator-daffodil/pull/83#discussion_r203364951 ########## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/parsers/PrimitivesDateTime...
efinnegan commented on a change in pull request #83: Adding value of 'bcd' to binaryCalendarRep URL: https://github.com/apache/incubator-daffodil/pull/83#discussion_r203418967 ########## File path: daffodil-test/src/test/resources/org/apache/daffodil/section05/simple_types/SimpleTypes.tdml #...
efinnegan commented on a change in pull request #83: Adding value of 'bcd' to binaryCalendarRep URL: https://github.com/apache/incubator-daffodil/pull/83#discussion_r203422531 ########## File path: daffodil-core/src/main/scala/org/apache/daffodil/grammar/primitives/PrimitivesDateTime.scala #...
mbeckerle commented on a change in pull request #83: Adding value of 'bcd' to binaryCalendarRep URL: https://github.com/apache/incubator-daffodil/pull/83#discussion_r203408658 ########## File path: daffodil-core/src/main/scala/org/apache/daffodil/grammar/primitives/PrimitivesDateTime.scala #...
mbeckerle commented on a change in pull request #83: Adding value of 'bcd' to binaryCalendarRep URL: https://github.com/apache/incubator-daffodil/pull/83#discussion_r203415316 ########## File path: daffodil-test/src/test/resources/org/apache/daffodil/section05/simple_types/SimpleTypes.tdml #...
mbeckerle commented on a change in pull request #83: Adding value of 'bcd' to binaryCalendarRep URL: https://github.com/apache/incubator-daffodil/pull/83#discussion_r203411185 ########## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/parsers/PrimitivesDateTime1.sca...
mbeckerle commented on a change in pull request #83: Adding value of 'bcd' to binaryCalendarRep URL: https://github.com/apache/incubator-daffodil/pull/83#discussion_r203408094 ########## File path: daffodil-core/src/main/scala/org/apache/daffodil/grammar/primitives/PrimitivesDateTime.scala #...
mbeckerle commented on a change in pull request #83: Adding value of 'bcd' to binaryCalendarRep URL: https://github.com/apache/incubator-daffodil/pull/83#discussion_r203423231 ########## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/parsers/PrimitivesDateTime1.sca...
mbeckerle commented on a change in pull request #83: Adding value of 'bcd' to binaryCalendarRep URL: https://github.com/apache/incubator-daffodil/pull/83#discussion_r203414958 ########## File path: daffodil-test/src/test/resources/org/apache/daffodil/section05/simple_types/SimpleTypes.tdml #...
mbeckerle commented on a change in pull request #83: Adding value of 'bcd' to binaryCalendarRep URL: https://github.com/apache/incubator-daffodil/pull/83#discussion_r203413075 ########## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/PackedBinaryTraits.scala #####...
mbeckerle commented on a change in pull request #83: Adding value of 'bcd' to binaryCalendarRep URL: https://github.com/apache/incubator-daffodil/pull/83#discussion_r203413448 ########## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/PackedBinaryTraits.scala #####...
mbeckerle commented on a change in pull request #83: Adding value of 'bcd' to binaryCalendarRep URL: https://github.com/apache/incubator-daffodil/pull/83#discussion_r203422914 ########## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/parsers/PrimitivesDateTime1.sca...
mbeckerle commented on a change in pull request #83: Adding value of 'bcd' to binaryCalendarRep URL: https://github.com/apache/incubator-daffodil/pull/83#discussion_r203417717 ########## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/parsers/PrimitivesDateTime1.sca...
mbeckerle commented on a change in pull request #83: Adding value of 'bcd' to binaryCalendarRep URL: https://github.com/apache/incubator-daffodil/pull/83#discussion_r203416468 ########## File path: daffodil-test/src/test/scala/org/apache/daffodil/section05/simple_types/TestSimpleTypes.scala ...
stevedlawrence commented on a change in pull request #83: Adding value of 'bcd' to binaryCalendarRep URL: https://github.com/apache/incubator-daffodil/pull/83#discussion_r203427601 ########## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/parsers/PrimitivesDateTime...
efinnegan commented on a change in pull request #83: Adding value of 'bcd' to binaryCalendarRep URL: https://github.com/apache/incubator-daffodil/pull/83#discussion_r203428429 ########## File path: daffodil-test/src/test/scala/org/apache/daffodil/section05/simple_types/TestSimpleTypes.scala ...
jadams-tresys opened a new pull request #84: Daffodil 1923 - Allow use of the same character for escapeBlockEnd and escapeEscapeCharacter URL: https://github.com/apache/incubator-daffodil/pull/84 This commit allows the same character(s) to be used for the escapeBlockEnd and escapeEscapeCharac...
stevedlawrence commented on a change in pull request #84: Daffodil 1923 - Allow use of the same character for escapeBlockEnd and escapeEscapeCharacter URL: https://github.com/apache/incubator-daffodil/pull/84#discussion_r203449901 ########## File path: daffodil-runtime1/src/main/scala/org/apa...
jadams-tresys commented on a change in pull request #84: Daffodil 1923 - Allow use of the same character for escapeBlockEnd and escapeEscapeCharacter URL: https://github.com/apache/incubator-daffodil/pull/84#discussion_r203464555 ########## File path: daffodil-runtime1/src/main/scala/org/apac...
stevedlawrence opened a new pull request #85: Fix bugs associated with truncateSpecifiedLengthString="yes" URL: https://github.com/apache/incubator-daffodil/pull/85 - Check to make sure an explicit length string actually needs to be truncated before trying to truncate it, otherwise it re...
I have been at this problem of separators and separator suppression behavior in Daffodil for around 3 full weeks of my time now, so I wanted to explain the status of the work. The prior code-review pull-request will not be updated. I will incorporate the suggestions from it that are still relevant...
mbeckerle commented on a change in pull request #84: Daffodil 1923 - Allow use of the same character for escapeBlockEnd and escapeEscapeCharacter URL: https://github.com/apache/incubator-daffodil/pull/84#discussion_r204049977 ########## File path: daffodil-runtime1/src/main/scala/org/apache/d...
mbeckerle commented on a change in pull request #84: Daffodil 1923 - Allow use of the same character for escapeBlockEnd and escapeEscapeCharacter URL: https://github.com/apache/incubator-daffodil/pull/84#discussion_r204049433 ########## File path: daffodil-runtime1/src/main/scala/org/apache/d...
mbeckerle closed pull request #74: Daffodil trailing sep URL: https://github.com/apache/incubator-daffodil/pull/74 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (...
mbeckerle commented on issue #74: Daffodil trailing sep URL: https://github.com/apache/incubator-daffodil/pull/74#issuecomment-406607804 Closing - will incorporate changes, but this PR was really a very preliminary code review, and the code has evolved in structure substantially since this PR...
mbeckerle commented on a change in pull request #74: Daffodil trailing sep URL: https://github.com/apache/incubator-daffodil/pull/74#discussion_r204055199 ########## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/Term.scala ########## @@ -359,6 +360,25 @@ trait Term def...
mbeckerle commented on a change in pull request #74: Daffodil trailing sep URL: https://github.com/apache/incubator-daffodil/pull/74#discussion_r204069230 ########## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/Term.scala ########## @@ -359,6 +360,25 @@ trait Term def...
mbeckerle commented on a change in pull request #74: Daffodil trailing sep URL: https://github.com/apache/incubator-daffodil/pull/74#discussion_r204075439 ########## File path: daffodil-core/src/main/scala/org/apache/daffodil/grammar/SequenceGrammarMixin.scala ########## @@ -17,36 +17,113 @...
mbeckerle commented on a change in pull request #74: Daffodil trailing sep URL: https://github.com/apache/incubator-daffodil/pull/74#discussion_r204077054 ########## File path: daffodil-core/src/main/scala/org/apache/daffodil/grammar/primitives/ChoiceCombinator.scala ########## @@ -0,0 +1,1...
mbeckerle commented on a change in pull request #74: Daffodil trailing sep URL: https://github.com/apache/incubator-daffodil/pull/74#discussion_r204080825 ########## File path: daffodil-core/src/main/scala/org/apache/daffodil/grammar/primitives/ComplexTypeCombinator.scala ########## @@ -0,0...
mbeckerle commented on a change in pull request #74: Daffodil trailing sep URL: https://github.com/apache/incubator-daffodil/pull/74#discussion_r204081776 ########## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/RuntimeData.scala ########## @@ -618,8 +622,9 @@ f...
mbeckerle commented on a change in pull request #74: Daffodil trailing sep URL: https://github.com/apache/incubator-daffodil/pull/74#discussion_r204082615 ########## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/parsers/DelimiterParsers.scala ########## @@ -158,...
mbeckerle commented on a change in pull request #74: Daffodil trailing sep URL: https://github.com/apache/incubator-daffodil/pull/74#discussion_r204083507 ########## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/parsers/NilEmptyCombinatorParsers.scala ########## ...
mbeckerle commented on a change in pull request #74: Daffodil trailing sep URL: https://github.com/apache/incubator-daffodil/pull/74#discussion_r204083795 ########## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/parsers/SeparatedSequenceParsers.scala ########## ...
mbeckerle commented on a change in pull request #74: Daffodil trailing sep URL: https://github.com/apache/incubator-daffodil/pull/74#discussion_r204084444 ########## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/parsers/SequenceParserBases.scala ########## @@ -0...