You are viewing the static version of this archive.
For the interactive version, please visit: This page
stevedlawrence commented on issue #159: Restrict coercion of a whole expression URL: https://github.com/apache/incubator-daffodil/pull/159#issuecomment-451214473 Came back to this to add some negative tests, and I dont' think this is really the complete solution. This change still allows coer...
mbeckerle commented on issue #159: Restrict coercion of a whole expression URL: https://github.com/apache/incubator-daffodil/pull/159#issuecomment-451219295 In what way is the expression 2 not an xs:int ? Our DPath compiler might choose to make all integers xs:integer and represent them as bi...
stevedlawrence commented on issue #159: Restrict coercion of a whole expression URL: https://github.com/apache/incubator-daffodil/pull/159#issuecomment-451223345 According to w3c XPath, integer literals are alwyas xs:integer and then coerecion happens as needed. But this change is to disable ...
stevedlawrence opened a new pull request #161: Make the JAPI/SAPI DataProcessors serializable URL: https://github.com/apache/incubator-daffodil/pull/161 Some tools, like Apache Spark, need the ability to serialize the DataProcessor to be sent to cluster nodes where it is then deserialized ...
mbeckerle commented on a change in pull request #161: Make the JAPI/SAPI DataProcessors serializable URL: https://github.com/apache/incubator-daffodil/pull/161#discussion_r245372700 ########## File path: daffodil-japi/src/test/java/org/apache/daffodil/example/TestJavaAPI.java ########## @@ ...
stevedlawrence commented on a change in pull request #161: Make the JAPI/SAPI DataProcessors serializable URL: https://github.com/apache/incubator-daffodil/pull/161#discussion_r245387563 ########## File path: daffodil-japi/src/test/java/org/apache/daffodil/example/TestJavaAPI.java ##########...
mbeckerle commented on a change in pull request #161: Make the JAPI/SAPI DataProcessors serializable URL: https://github.com/apache/incubator-daffodil/pull/161#discussion_r245394755 ########## File path: daffodil-japi/src/test/java/org/apache/daffodil/example/TestJavaAPI.java ########## @@ ...
jadams-tresys commented on a change in pull request #158: Daffodil 1080 sequences and separators - preliminary review URL: https://github.com/apache/incubator-daffodil/pull/158#discussion_r245399881 ########## File path: daffodil-core/src/main/scala/org/apache/daffodil/grammar/primitives/Sequ...
stevedlawrence commented on issue #161: Make the JAPI/SAPI DataProcessors serializable URL: https://github.com/apache/incubator-daffodil/pull/161#issuecomment-451925371 Added comments explaining the purpose of the function. Also made the function prviate to help self-document that it should o...
stevedlawrence closed pull request #161: Make the JAPI/SAPI DataProcessors serializable URL: https://github.com/apache/incubator-daffodil/pull/161 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As ...
jadams-tresys opened a new pull request #162: Properly handle malformed binding files URL: https://github.com/apache/incubator-daffodil/pull/162 There were a few unhandled exceptions that were originating from being unable to resolve QNames in external variable config files. With these ...
mbeckerle commented on a change in pull request #162: Properly handle malformed binding files URL: https://github.com/apache/incubator-daffodil/pull/162#discussion_r246178015 ########## File path: daffodil-cli/src/main/scala/org/apache/daffodil/Main.scala ########## @@ -627,7 +630,22 @@ obj...
mbeckerle commented on a change in pull request #162: Properly handle malformed binding files URL: https://github.com/apache/incubator-daffodil/pull/162#discussion_r246178739 ########## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/externalvars/ExternalVariablesLoader.scala ...
mbeckerle commented on a change in pull request #162: Properly handle malformed binding files URL: https://github.com/apache/incubator-daffodil/pull/162#discussion_r246178469 ########## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/SchemaSet.scala ########## @@ -472,7 +47...
mbeckerle commented on a change in pull request #162: Properly handle malformed binding files URL: https://github.com/apache/incubator-daffodil/pull/162#discussion_r246176572 ########## File path: daffodil-cli/src/main/scala/org/apache/daffodil/Main.scala ########## @@ -238,8 +238,11 @@ cla...
stevedlawrence commented on a change in pull request #162: Properly handle malformed binding files URL: https://github.com/apache/incubator-daffodil/pull/162#discussion_r246367079 ########## File path: daffodil-cli/src/main/scala/org/apache/daffodil/Main.scala ########## @@ -627,7 +630,22 @...
Hi all, I am currently looking for a solution to the following question: In the Apache PLC4X (incubating) project we are implementing a lot of different industry protocols. Each protocol sends packets following a particular format. For each of these we currently implement an internal model, s...
jadams-tresys commented on a change in pull request #162: Properly handle malformed binding files URL: https://github.com/apache/incubator-daffodil/pull/162#discussion_r246401349 ########## File path: daffodil-cli/src/main/scala/org/apache/daffodil/Main.scala ########## @@ -627,7 +630,22 @@...
mbeckerle commented on a change in pull request #162: Properly handle malformed binding files URL: https://github.com/apache/incubator-daffodil/pull/162#discussion_r246573525 ########## File path: daffodil-lib/src/main/scala/org/apache/daffodil/externalvars/Binding.scala ########## @@ -45,6...
(This time the full message) Hi Mike, so I converted one of my Protocols into a Xml-Schema with some utilization of the DFDL namespace (Trying to get started) Unfortunately I'm having a little problem with how to define type inheritance ... so I have for example parameter elements which al...
stevedlawrence commented on a change in pull request #162: Properly handle malformed binding files URL: https://github.com/apache/incubator-daffodil/pull/162#discussion_r246885930 ########## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/SchemaSet.scala ########## @@ -472,...
stevedlawrence commented on a change in pull request #162: Properly handle malformed binding files URL: https://github.com/apache/incubator-daffodil/pull/162#discussion_r246886373 ########## File path: daffodil-lib/src/main/scala/org/apache/daffodil/externalvars/Binding.scala ########## @@ ...
stevedlawrence opened a new pull request #163: Fix performance issues with recent hexBinary changes URL: https://github.com/apache/incubator-daffodil/pull/163 Commit af489bc6ea modified the behavior of hexBinary parsing to effectively ignore byteOrder. It did this by no longer using the ...
Hi, I am now trying to update my dfdl using the PCAP example … when running it in the debugger, I’m getting warnings and errors, unfortunately it’s only telling me the file name and not what element is missing an attribute. [error] Schema Definition Error: Property lengthKind is not defi...
stevedlawrence closed pull request #159: Restrict coercion of a whole expression URL: https://github.com/apache/incubator-daffodil/pull/159 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is...
jadams-tresys opened a new pull request #164: Avoid CircularDefinition error for appinfo URL: https://github.com/apache/incubator-daffodil/pull/164 When we were detecting that an appinfo annotation did not have a source attribute we would try to show a schema definition warning. However, t...
jadams-tresys commented on issue #164: Avoid CircularDefinition error for appinfo URL: https://github.com/apache/incubator-daffodil/pull/164#issuecomment-453531867 Mike thought that there might be a similar case of avoiding OOLAG/LV calls for position in ElementBase, but I did not find anythi...
jadams-tresys closed pull request #162: Properly handle malformed binding files URL: https://github.com/apache/incubator-daffodil/pull/162 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is ...
Hi all, As I am expecting to be participating here in the near future I started tracking down some problems I was having with debugging the CLI … Here’s a summary of things I noticed: General Observations: The Readme claims to require Java 7 or above … I think it requires 8 … even if ...
stevedlawrence commented on a change in pull request #164: Avoid CircularDefinition error for appinfo URL: https://github.com/apache/incubator-daffodil/pull/164#discussion_r247589175 ########## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/ModelGroup.scala ########## @@ -...
stevedlawrence opened a new pull request #165: Update README to require Java 8+ URL: https://github.com/apache/incubator-daffodil/pull/165 DAFFODIL-2025 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to th...
jadams-tresys commented on a change in pull request #164: Avoid CircularDefinition error for appinfo URL: https://github.com/apache/incubator-daffodil/pull/164#discussion_r247627076 ########## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/ModelGroup.scala ########## @@ -1...
jadams-tresys merged pull request #164: Avoid CircularDefinition error for appinfo URL: https://github.com/apache/incubator-daffodil/pull/164 As this is a foreign pull request (from a fork), the diff has been sent to your commit mailing list, commits@daffodil.apache.org -------------------...
All: I am a new DAFFODIL developer working with Stephen Lawrence and Mike Beckerle at Tresys. I have opened a new bug for a large number of tests that do not work properly on the Windows platform. I am hereby requesting permissions sufficient to modify and assign DAFFODIL-2051 to myself for remedia...
mbeckerle commented on a change in pull request #163: Fix performance issues with recent hexBinary changes URL: https://github.com/apache/incubator-daffodil/pull/163#discussion_r247676525 ########## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/RuntimePropertyMixins.scala ...
mbeckerle commented on a change in pull request #163: Fix performance issues with recent hexBinary changes URL: https://github.com/apache/incubator-daffodil/pull/163#discussion_r247682262 ########## File path: daffodil-io/src/main/scala/org/apache/daffodil/io/InputSourceDataInputStream.scala ...
mbeckerle commented on a change in pull request #163: Fix performance issues with recent hexBinary changes URL: https://github.com/apache/incubator-daffodil/pull/163#discussion_r247678978 ########## File path: daffodil-io/src/main/scala/org/apache/daffodil/io/InputSourceDataInputStream.scala ...
mbeckerle commented on a change in pull request #163: Fix performance issues with recent hexBinary changes URL: https://github.com/apache/incubator-daffodil/pull/163#discussion_r247679360 ########## File path: daffodil-io/src/main/scala/org/apache/daffodil/io/InputSourceDataInputStream.scala ...
stevedlawrence commented on a change in pull request #163: Fix performance issues with recent hexBinary changes URL: https://github.com/apache/incubator-daffodil/pull/163#discussion_r247875751 ########## File path: daffodil-io/src/main/scala/org/apache/daffodil/io/InputSourceDataInputStream.s...
stevedlawrence commented on a change in pull request #163: Fix performance issues with recent hexBinary changes URL: https://github.com/apache/incubator-daffodil/pull/163#discussion_r247876032 ########## File path: daffodil-io/src/main/scala/org/apache/daffodil/io/InputSourceDataInputStream.s...
stevedlawrence commented on a change in pull request #163: Fix performance issues with recent hexBinary changes URL: https://github.com/apache/incubator-daffodil/pull/163#discussion_r247885728 ########## File path: daffodil-io/src/main/scala/org/apache/daffodil/io/InputSourceDataInputStream.s...
Hi all, after working though the 6 tutorials on DFDL in general I think I have a much greater understanding on how I have to do things. I even managed to get my S7 protocol messages schema in a somewhat working condition. Right now I’m having one problem: A S7 Messages consists of a header, a...
stevedlawrence merged pull request #163: Fix performance issues with recent hexBinary changes URL: https://github.com/apache/incubator-daffodil/pull/163 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to t...
stevedlawrence opened a new pull request #166: Change expression result type coercion to be a warning URL: https://github.com/apache/incubator-daffodil/pull/166 Commit a2f56a3f44 modified expression coercion to be strict about the result type of an expression matching the expected type. Th...
ltapilot opened a new pull request #167: Daffodil 2051 tests broken in windows URL: https://github.com/apache/incubator-daffodil/pull/167 Remaining tests now fixed. Should be platform and OS independent. ---------------------------------------------------------------- This is an automated me...
mbeckerle commented on a change in pull request #167: Daffodil 2051 tests broken in windows URL: https://github.com/apache/incubator-daffodil/pull/167#discussion_r248490624 ########## File path: daffodil-test-ibm1/src/test/resources/test-suite/tresys-contributed/AG.tdml ########## @@ -24,9 ...
mbeckerle commented on a change in pull request #167: Daffodil 2051 tests broken in windows URL: https://github.com/apache/incubator-daffodil/pull/167#discussion_r248491876 ########## File path: daffodil-test/src/test/resources/org/apache/daffodil/section06/namespaces/namespaces.tdml #######...
stevedlawrence commented on a change in pull request #167: Daffodil 2051 tests broken in windows URL: https://github.com/apache/incubator-daffodil/pull/167#discussion_r248675800 ########## File path: daffodil-test/src/test/resources/org/apache/daffodil/section06/namespaces/namespaces.tdml ##...
stevedlawrence commented on a change in pull request #167: Daffodil 2051 tests broken in windows URL: https://github.com/apache/incubator-daffodil/pull/167#discussion_r248674418 ########## File path: daffodil-test-ibm1/src/test/resources/test-suite/tresys-contributed/AG.tdml ########## @@ -...
mbeckerle commented on a change in pull request #167: Daffodil 2051 tests broken in windows URL: https://github.com/apache/incubator-daffodil/pull/167#discussion_r248491876 ########## File path: daffodil-test/src/test/resources/org/apache/daffodil/section06/namespaces/namespaces.tdml #######...
mbeckerle commented on a change in pull request #167: Daffodil 2051 tests broken in windows URL: https://github.com/apache/incubator-daffodil/pull/167#discussion_r248681966 ########## File path: daffodil-test/src/test/resources/org/apache/daffodil/section06/namespaces/namespaces.tdml #######...
mbeckerle commented on issue #167: Daffodil 2051 tests broken in windows URL: https://github.com/apache/incubator-daffodil/pull/167#issuecomment-455183662 The travis CI build failed due to rat check failure - a file was introduced that needs an apache license banner I believe. ------...
stevedlawrence commented on issue #167: Daffodil 2051 tests broken in windows URL: https://github.com/apache/incubator-daffodil/pull/167#issuecomment-455184370 That rat failure was introduced in commit 912f7d2b73 and we missed it. It was then fixed as part of the next commit 69bb0a185e, but t...
stevedlawrence commented on issue #167: Daffodil 2051 tests broken in windows URL: https://github.com/apache/incubator-daffodil/pull/167#issuecomment-455186678 Also, apparently TravisCI now supports windows: https://blog.travis-ci.com/2018-10-11-windows-early-release It might be...
stevedlawrence commented on issue #167: Daffodil 2051 tests broken in windows URL: https://github.com/apache/incubator-daffodil/pull/167#issuecomment-455187436 Actually, it looking more closing, TravisCI does not support java/scala yet, so we'll have to hold off on that. --------------------...
Hi all, I just wanted to report that after finishing a first version of my S7 dfdl, I pretty quickly finished the 2 underlying protocols too. https://github.com/apache/incubator-plc4x/tree/develop/src/main/dfdl Next I will probably start with using daffodil for parsing/serializing test-data...
stevedlawrence merged pull request #165: Update README to require Java 8+ URL: https://github.com/apache/incubator-daffodil/pull/165 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please l...
stevedlawrence merged pull request #166: Change expression result type coercion to be a warning URL: https://github.com/apache/incubator-daffodil/pull/166 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to...
stevedlawrence commented on issue #167: Daffodil 2051 tests broken in windows URL: https://github.com/apache/incubator-daffodil/pull/167#issuecomment-455574596 Looks like the ratCheck is still failing. Can you please look into that? I think you maybe just need to fetch the latest and rebase o...
stevedlawrence merged pull request #167: Daffodil 2051 tests broken in windows URL: https://github.com/apache/incubator-daffodil/pull/167 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, ple...
jadams-tresys opened a new pull request #168: Keep line/column info for Daffodil tests URL: https://github.com/apache/incubator-daffodil/pull/168 We had been adding line and column attributes to the schemas we were testing against in order to provide more helpful error messages. These a...
Hi all, well I think I managed to setup the basic testing using Daffodil and Junit5 with Maven … strangely the test is failing Surefire however still is reporting the test to be successful. However if I run it in IntelliJ I get failures. Here’s the module with the code (3 Protocols in src...
Hi all, I am stuck with a little problem … I am reading a packet, which is usually contained inside another. Therefore it doesn’t provide any means of providing it’s length. So the packet is just a small header + binary data … now I want to read “all the rest” after the header into a...
stevedlawrence commented on a change in pull request #168: Keep line/column info for Daffodil tests URL: https://github.com/apache/incubator-daffodil/pull/168#discussion_r249778945 ########## File path: daffodil-tdml-lib/src/main/scala/org/apache/daffodil/tdml/TDMLRunner.scala ########## @@...
stevedlawrence commented on a change in pull request #168: Keep line/column info for Daffodil tests URL: https://github.com/apache/incubator-daffodil/pull/168#discussion_r249779770 ########## File path: daffodil-tdml-lib/src/main/scala/org/apache/daffodil/tdml/TDMLRunner.scala ########## @@...
stevedlawrence commented on a change in pull request #168: Keep line/column info for Daffodil tests URL: https://github.com/apache/incubator-daffodil/pull/168#discussion_r249777949 ########## File path: daffodil-lib/src/main/scala/org/apache/daffodil/xml/DaffodilConstructingLoader.scala ####...
stevedlawrence commented on a change in pull request #168: Keep line/column info for Daffodil tests URL: https://github.com/apache/incubator-daffodil/pull/168#discussion_r249782726 ########## File path: daffodil-tdml-lib/src/main/scala/org/apache/daffodil/tdml/TDMLRunner.scala ########## @@...
jadams-tresys commented on a change in pull request #168: Keep line/column info for Daffodil tests URL: https://github.com/apache/incubator-daffodil/pull/168#discussion_r249798609 ########## File path: daffodil-lib/src/main/scala/org/apache/daffodil/xml/DaffodilConstructingLoader.scala #####...
jadams-tresys commented on a change in pull request #168: Keep line/column info for Daffodil tests URL: https://github.com/apache/incubator-daffodil/pull/168#discussion_r249801959 ########## File path: daffodil-tdml-lib/src/main/scala/org/apache/daffodil/tdml/TDMLRunner.scala ########## @@ ...
stevedlawrence opened a new pull request #169: Fix incorrect line numbers and ensure XML errors include line numbers URL: https://github.com/apache/incubator-daffodil/pull/169 - A bug in scala-xml caused line numbers to be reset to zero after parsing CDATA and processing instructions. Th...
jadams-tresys commented on a change in pull request #169: Fix incorrect line numbers and ensure XML errors include line numbers URL: https://github.com/apache/incubator-daffodil/pull/169#discussion_r249933776 ########## File path: daffodil-lib/src/main/scala/org/apache/daffodil/xml/DaffodilCo...
stevedlawrence merged pull request #169: Fix incorrect line numbers and ensure XML errors include line numbers URL: https://github.com/apache/incubator-daffodil/pull/169 ---------------------------------------------------------------- This is an automated message from the Apache Git Service...
jadams-tresys commented on a change in pull request #168: Keep line/column info for Daffodil tests URL: https://github.com/apache/incubator-daffodil/pull/168#discussion_r250242945 ########## File path: daffodil-tdml-lib/src/main/scala/org/apache/daffodil/tdml/TDMLRunner.scala ########## @@ ...
jadams-tresys merged pull request #168: Keep line/column info for Daffodil tests URL: https://github.com/apache/incubator-daffodil/pull/168 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, p...