You are viewing the static version of this archive.
For the interactive version, please visit: This page
bsloane1650 opened a new pull request #210: Add midBitsToEnd layer transform URL: https://github.com/apache/incubator-daffodil/pull/210 Add new layer transform that can move a single contiguous block of bits from a layer's content area to the end of the layer's content area. DAFF...
jadams-tresys opened a new pull request #211: Escape all delimiters when unparsing URL: https://github.com/apache/incubator-daffodil/pull/211 Previously we were only escaping the first delimiter in the list of delimiters specified by initiator, terminator and separator. Now we will esca...
bsloane1650 commented on a change in pull request #201: Fix bug in handling parse errors URL: https://github.com/apache/incubator-daffodil/pull/201#discussion_r277408855 ########## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/ProcessingError.scala ########## @@...
I am trying to work through a bug surrounding changing the bitOrder mid schema and am having trouble figuring out how Daffodil handles bitOrder in general. I see that in InputSourceData, we have code to mask for the correct bits and shift out the gaps, but I do not see where we actually invert the...
mbeckerle commented on a change in pull request #210: Add midBitsToEnd layer transform URL: https://github.com/apache/incubator-daffodil/pull/210#discussion_r277511326 ########## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/layers/GZipTransformer.scala ########## @@ -27,1...
mbeckerle commented on a change in pull request #210: Add midBitsToEnd layer transform URL: https://github.com/apache/incubator-daffodil/pull/210#discussion_r277514352 ########## File path: daffodil-test/src/test/resources/org/apache/daffodil/layers/midBitsToEnd.tdml ########## @@ -0,0 +1,8...
mbeckerle commented on a change in pull request #210: Add midBitsToEnd layer transform URL: https://github.com/apache/incubator-daffodil/pull/210#discussion_r277512516 ########## File path: daffodil-test/src/test/resources/org/apache/daffodil/layers/midBitsToEnd.tdml ########## @@ -0,0 +1,8...
mbeckerle commented on a change in pull request #210: Add midBitsToEnd layer transform URL: https://github.com/apache/incubator-daffodil/pull/210#discussion_r277511435 ########## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/layers/midBitsToEndTransformer.scala ########## ...
mbeckerle commented on a change in pull request #210: Add midBitsToEnd layer transform URL: https://github.com/apache/incubator-daffodil/pull/210#discussion_r277513113 ########## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/layers/midBitsToEndTransformer.scala ########## ...
mbeckerle commented on a change in pull request #210: Add midBitsToEnd layer transform URL: https://github.com/apache/incubator-daffodil/pull/210#discussion_r277511710 ########## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/layers/midBitsToEndTransformer.scala ########## ...
mbeckerle commented on a change in pull request #210: Add midBitsToEnd layer transform URL: https://github.com/apache/incubator-daffodil/pull/210#discussion_r277512873 ########## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/layers/midBitsToEndTransformer.scala ########## ...
bsloane1650 commented on a change in pull request #210: Add midBitsToEnd layer transform URL: https://github.com/apache/incubator-daffodil/pull/210#discussion_r277715267 ########## File path: daffodil-test/src/test/resources/org/apache/daffodil/layers/midBitsToEnd.tdml ########## @@ -0,0 +1...
bsloane1650 commented on a change in pull request #210: Add midBitsToEnd layer transform URL: https://github.com/apache/incubator-daffodil/pull/210#discussion_r277730375 ########## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/layers/midBitsToEndTransformer.scala ##########...
mbeckerle commented on a change in pull request #210: Add midBitsToEnd layer transform URL: https://github.com/apache/incubator-daffodil/pull/210#discussion_r277758371 ########## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/layers/midBitsToEndTransformer.scala ########## ...
stevedlawrence commented on a change in pull request #204: Provide more detail for failed assertions URL: https://github.com/apache/incubator-daffodil/pull/204#discussion_r278089339 ########## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/parsers/AssertPatternPars...
jadams-tresys commented on a change in pull request #204: Provide more detail for failed assertions URL: https://github.com/apache/incubator-daffodil/pull/204#discussion_r278118038 ########## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/parsers/AssertPatternParse...
jadams-tresys closed pull request #204: Provide more detail for failed assertions URL: https://github.com/apache/incubator-daffodil/pull/204 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, ...
jadams-tresys merged pull request #208: Output empty elements with self closing tags URL: https://github.com/apache/incubator-daffodil/pull/208 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the messag...
jadams-tresys merged pull request #209: Enable facet range checking for xs:decimal URL: https://github.com/apache/incubator-daffodil/pull/209 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message,...
jadams-tresys merged pull request #211: Escape all delimiters when unparsing URL: https://github.com/apache/incubator-daffodil/pull/211 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, pleas...
stevedlawrence commented on a change in pull request #210: Add midBitsToEnd layer transform URL: https://github.com/apache/incubator-daffodil/pull/210#discussion_r278097653 ########## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/RuntimePropertyMixins.scala ########## @@ ...
stevedlawrence commented on a change in pull request #210: Add midBitsToEnd layer transform URL: https://github.com/apache/incubator-daffodil/pull/210#discussion_r278106411 ########## File path: daffodil-propgen/src/main/resources/org/apache/daffodil/xsd/DFDL_part1_simpletypes.xsd ##########...
stevedlawrence commented on a change in pull request #210: Add midBitsToEnd layer transform URL: https://github.com/apache/incubator-daffodil/pull/210#discussion_r278152411 ########## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/layers/midBitsToEndTransformer.scala #######...
stevedlawrence commented on a change in pull request #210: Add midBitsToEnd layer transform URL: https://github.com/apache/incubator-daffodil/pull/210#discussion_r278140976 ########## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/layers/midBitsToEndTransformer.scala #######...
stevedlawrence commented on a change in pull request #210: Add midBitsToEnd layer transform URL: https://github.com/apache/incubator-daffodil/pull/210#discussion_r278107620 ########## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/layers/midBitsToEndTransformer.scala #######...
stevedlawrence commented on a change in pull request #210: Add midBitsToEnd layer transform URL: https://github.com/apache/incubator-daffodil/pull/210#discussion_r278108630 ########## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/layers/midBitsToEndTransformer.scala #######...
stevedlawrence commented on a change in pull request #210: Add midBitsToEnd layer transform URL: https://github.com/apache/incubator-daffodil/pull/210#discussion_r278116364 ########## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/layers/midBitsToEndTransformer.scala #######...
stevedlawrence commented on a change in pull request #210: Add midBitsToEnd layer transform URL: https://github.com/apache/incubator-daffodil/pull/210#discussion_r278111158 ########## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/layers/midBitsToEndTransformer.scala #######...
stevedlawrence commented on a change in pull request #210: Add midBitsToEnd layer transform URL: https://github.com/apache/incubator-daffodil/pull/210#discussion_r278141069 ########## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/layers/midBitsToEndTransformer.scala #######...
stevedlawrence commented on a change in pull request #210: Add midBitsToEnd layer transform URL: https://github.com/apache/incubator-daffodil/pull/210#discussion_r278117620 ########## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/layers/midBitsToEndTransformer.scala #######...
stevedlawrence commented on a change in pull request #210: Add midBitsToEnd layer transform URL: https://github.com/apache/incubator-daffodil/pull/210#discussion_r278120663 ########## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/layers/midBitsToEndTransformer.scala #######...
stevedlawrence commented on a change in pull request #210: Add midBitsToEnd layer transform URL: https://github.com/apache/incubator-daffodil/pull/210#discussion_r278114832 ########## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/layers/midBitsToEndTransformer.scala #######...
bsloane1650 commented on a change in pull request #210: Add midBitsToEnd layer transform URL: https://github.com/apache/incubator-daffodil/pull/210#discussion_r278153570 ########## File path: daffodil-test/src/test/resources/org/apache/daffodil/layers/midBitsToEnd.tdml ########## @@ -0,0 +1...
mbeckerle commented on a change in pull request #210: Add midBitsToEnd layer transform URL: https://github.com/apache/incubator-daffodil/pull/210#discussion_r278288840 ########## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/RuntimePropertyMixins.scala ########## @@ -655,...
stevedlawrence commented on a change in pull request #207: Added support for enumerations and TypeValueCalc URL: https://github.com/apache/incubator-daffodil/pull/207#discussion_r278202422 ########## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/dpath/DFDLXTypeCalcFunctions....
stevedlawrence commented on a change in pull request #207: Added support for enumerations and TypeValueCalc URL: https://github.com/apache/incubator-daffodil/pull/207#discussion_r278177311 ########## File path: daffodil-core/src/main/scala/org/apache/daffodil/dpath/Expression.scala #########...
stevedlawrence commented on a change in pull request #207: Added support for enumerations and TypeValueCalc URL: https://github.com/apache/incubator-daffodil/pull/207#discussion_r278165386 ########## File path: daffodil-core/src/main/scala/org/apache/daffodil/dpath/Expression.scala #########...
stevedlawrence commented on a change in pull request #207: Added support for enumerations and TypeValueCalc URL: https://github.com/apache/incubator-daffodil/pull/207#discussion_r278238335 ########## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/ReptypeMixins.scala #######...
stevedlawrence commented on a change in pull request #207: Added support for enumerations and TypeValueCalc URL: https://github.com/apache/incubator-daffodil/pull/207#discussion_r278234251 ########## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/ElementBase.scala #########...
stevedlawrence commented on a change in pull request #207: Added support for enumerations and TypeValueCalc URL: https://github.com/apache/incubator-daffodil/pull/207#discussion_r278235925 ########## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/QuasiElementDecl.scala ####...
stevedlawrence commented on a change in pull request #207: Added support for enumerations and TypeValueCalc URL: https://github.com/apache/incubator-daffodil/pull/207#discussion_r278211636 ########## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/ChoiceGroup.scala #########...
stevedlawrence commented on a change in pull request #207: Added support for enumerations and TypeValueCalc URL: https://github.com/apache/incubator-daffodil/pull/207#discussion_r278209692 ########## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/ChoiceGroup.scala #########...
stevedlawrence commented on a change in pull request #207: Added support for enumerations and TypeValueCalc URL: https://github.com/apache/incubator-daffodil/pull/207#discussion_r278230182 ########## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/ChoiceGroup.scala #########...
stevedlawrence commented on a change in pull request #207: Added support for enumerations and TypeValueCalc URL: https://github.com/apache/incubator-daffodil/pull/207#discussion_r278235316 ########## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/QuasiElementDecl.scala ####...
stevedlawrence commented on a change in pull request #207: Added support for enumerations and TypeValueCalc URL: https://github.com/apache/incubator-daffodil/pull/207#discussion_r278204295 ########## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/AnnotatedSchemaComponent.sca...
stevedlawrence commented on a change in pull request #207: Added support for enumerations and TypeValueCalc URL: https://github.com/apache/incubator-daffodil/pull/207#discussion_r278238026 ########## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/QuasiElementDecl.scala ####...
stevedlawrence commented on a change in pull request #207: Added support for enumerations and TypeValueCalc URL: https://github.com/apache/incubator-daffodil/pull/207#discussion_r278217790 ########## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/CompiledExpression.scala ##...
stevedlawrence commented on a change in pull request #207: Added support for enumerations and TypeValueCalc URL: https://github.com/apache/incubator-daffodil/pull/207#discussion_r278233899 ########## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/ElementBase.scala #########...
stevedlawrence commented on a change in pull request #207: Added support for enumerations and TypeValueCalc URL: https://github.com/apache/incubator-daffodil/pull/207#discussion_r278230603 ########## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/ChoiceGroup.scala #########...
stevedlawrence commented on a change in pull request #207: Added support for enumerations and TypeValueCalc URL: https://github.com/apache/incubator-daffodil/pull/207#discussion_r278231261 ########## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/ChoiceGroup.scala #########...
bsloane1650 commented on a change in pull request #207: Added support for enumerations and TypeValueCalc URL: https://github.com/apache/incubator-daffodil/pull/207#discussion_r278371495 ########## File path: daffodil-core/src/main/scala/org/apache/daffodil/dpath/Expression.scala ########## ...
bsloane1650 commented on a change in pull request #207: Added support for enumerations and TypeValueCalc URL: https://github.com/apache/incubator-daffodil/pull/207#discussion_r278372611 ########## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/dpath/DFDLXTypeCalcFunctions.sca...
mbeckerle commented on a change in pull request #207: Added support for enumerations and TypeValueCalc URL: https://github.com/apache/incubator-daffodil/pull/207#discussion_r278376148 ########## File path: daffodil-core/src/main/scala/org/apache/daffodil/dpath/Expression.scala ########## @@...
stevedlawrence commented on a change in pull request #207: Added support for enumerations and TypeValueCalc URL: https://github.com/apache/incubator-daffodil/pull/207#discussion_r278585968 ########## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/dpath/DFDLXTypeCalcFunctions....
jadams-tresys opened a new pull request #212: Catch error when delimiter expression fails URL: https://github.com/apache/incubator-daffodil/pull/212 We weren't handling a potential failure when an expression representing a delimiter failed and it was resulting in a very unhelpful Assert ...
jadams-tresys commented on issue #212: Catch error when delimiter expression fails URL: https://github.com/apache/incubator-daffodil/pull/212#issuecomment-486767935 Just pushed up a small fix to the test and rebased off of the most recent approved commits, which fixed the issue preventing the...
bsloane1650 commented on a change in pull request #210: Add midBitsToEnd layer transform URL: https://github.com/apache/incubator-daffodil/pull/210#discussion_r278696660 ########## File path: daffodil-propgen/src/main/resources/org/apache/daffodil/xsd/DFDL_part1_simpletypes.xsd ########## @...
bsloane1650 commented on a change in pull request #210: Add midBitsToEnd layer transform URL: https://github.com/apache/incubator-daffodil/pull/210#discussion_r278708400 ########## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/layers/midBitsToEndTransformer.scala ##########...
bsloane1650 commented on a change in pull request #210: Add midBitsToEnd layer transform URL: https://github.com/apache/incubator-daffodil/pull/210#discussion_r278713895 ########## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/layers/midBitsToEndTransformer.scala ##########...
stevedlawrence commented on a change in pull request #212: Catch error when delimiter expression fails URL: https://github.com/apache/incubator-daffodil/pull/212#discussion_r278657940 ########## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/Evaluatable.scala ####...
stevedlawrence commented on a change in pull request #212: Catch error when delimiter expression fails URL: https://github.com/apache/incubator-daffodil/pull/212#discussion_r278963668 ########## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/parsers/ElementKindPars...
jadams-tresys commented on a change in pull request #212: Catch error when delimiter expression fails URL: https://github.com/apache/incubator-daffodil/pull/212#discussion_r278985917 ########## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/parsers/ElementKindParse...
jadams-tresys commented on a change in pull request #212: Catch error when delimiter expression fails URL: https://github.com/apache/incubator-daffodil/pull/212#discussion_r278987367 ########## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/parsers/ElementKindParse...
bsloane1650 commented on a change in pull request #207: Added support for enumerations and TypeValueCalc URL: https://github.com/apache/incubator-daffodil/pull/207#discussion_r278998197 ########## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/QuasiElementDecl.scala #######...
bsloane1650 commented on a change in pull request #207: Added support for enumerations and TypeValueCalc URL: https://github.com/apache/incubator-daffodil/pull/207#discussion_r278999549 ########## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/QuasiElementDecl.scala #######...
mbeckerle opened a new pull request #213: fix eclipse classpaths for no more scala-debug directories. URL: https://github.com/apache/incubator-daffodil/pull/213 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To resp...
stevedlawrence commented on a change in pull request #213: fix eclipse classpaths for no more scala-debug directories. URL: https://github.com/apache/incubator-daffodil/pull/213#discussion_r279339143 ########## File path: eclipse-projects/core-test/.classpath ########## @@ -1,92 +1,117 @@ +...
stevedlawrence commented on issue #213: fix eclipse classpaths for no more scala-debug directories. URL: https://github.com/apache/incubator-daffodil/pull/213#issuecomment-487558463 Also, commit message is missing a bug number. ----------------------------------------------------------------...
stevedlawrence commented on a change in pull request #212: Catch error when delimiter expression fails URL: https://github.com/apache/incubator-daffodil/pull/212#discussion_r279340521 ########## File path: daffodil-test/src/test/resources/org/apache/daffodil/usertests/nameDOB_test.tdml #####...
stevedlawrence commented on a change in pull request #210: Add midBitsToEnd layer transform URL: https://github.com/apache/incubator-daffodil/pull/210#discussion_r279359204 ########## File path: daffodil-propgen/src/main/resources/org/apache/daffodil/xsd/DFDL_part1_simpletypes.xsd ##########...
stevedlawrence commented on a change in pull request #210: Add midBitsToEnd layer transform URL: https://github.com/apache/incubator-daffodil/pull/210#discussion_r279361571 ########## File path: daffodil-test/src/test/scala/org/apache/daffodil/layers/TestLayers.scala ########## @@ -44,4 +45...
jadams-tresys commented on a change in pull request #212: Catch error when delimiter expression fails URL: https://github.com/apache/incubator-daffodil/pull/212#discussion_r279389364 ########## File path: daffodil-test/src/test/resources/org/apache/daffodil/usertests/nameDOB_test.tdml ######...
bsloane1650 commented on issue #201: Fix bug in handling parse errors URL: https://github.com/apache/incubator-daffodil/pull/201#issuecomment-487603543 Commit message updated ---------------------------------------------------------------- This is an automated message from the Apache Git Ser...
bsloane1650 commented on a change in pull request #210: Add midBitsToEnd layer transform URL: https://github.com/apache/incubator-daffodil/pull/210#discussion_r279391196 ########## File path: daffodil-propgen/src/main/resources/org/apache/daffodil/xsd/DFDL_part1_simpletypes.xsd ########## @...
jadams-tresys commented on a change in pull request #212: Catch error when delimiter expression fails URL: https://github.com/apache/incubator-daffodil/pull/212#discussion_r279393635 ########## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/parsers/ElementKindParse...
stevedlawrence merged pull request #201: Fix bug in handling parse errors URL: https://github.com/apache/incubator-daffodil/pull/201 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please l...
stevedlawrence commented on issue #212: Catch error when delimiter expression fails URL: https://github.com/apache/incubator-daffodil/pull/212#issuecomment-487703862 +1 :+1: ---------------------------------------------------------------- This is an automated message from the Apache Git Ser...
stevedlawrence commented on a change in pull request #207: Added support for enumerations and TypeValueCalc URL: https://github.com/apache/incubator-daffodil/pull/207#discussion_r278586408 ########## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/dpath/DFDLXTypeCalcFunctions....
stevedlawrence commented on a change in pull request #207: Added support for enumerations and TypeValueCalc URL: https://github.com/apache/incubator-daffodil/pull/207#discussion_r278592463 ########## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/RestrictionUnion.scala ####...
stevedlawrence commented on a change in pull request #207: Added support for enumerations and TypeValueCalc URL: https://github.com/apache/incubator-daffodil/pull/207#discussion_r278607505 ########## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/SimpleTypes.scala #########...
stevedlawrence commented on a change in pull request #207: Added support for enumerations and TypeValueCalc URL: https://github.com/apache/incubator-daffodil/pull/207#discussion_r278603539 ########## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/SimpleTypes.scala #########...
stevedlawrence commented on a change in pull request #207: Added support for enumerations and TypeValueCalc URL: https://github.com/apache/incubator-daffodil/pull/207#discussion_r278594927 ########## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/RestrictionUnion.scala ####...
stevedlawrence commented on a change in pull request #207: Added support for enumerations and TypeValueCalc URL: https://github.com/apache/incubator-daffodil/pull/207#discussion_r279780900 ########## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/parsers/Expression...
stevedlawrence commented on a change in pull request #207: Added support for enumerations and TypeValueCalc URL: https://github.com/apache/incubator-daffodil/pull/207#discussion_r279777466 ########## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/parsers/ElementKin...
stevedlawrence commented on a change in pull request #207: Added support for enumerations and TypeValueCalc URL: https://github.com/apache/incubator-daffodil/pull/207#discussion_r278597400 ########## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/SchemaSet.scala ########## ...
stevedlawrence commented on a change in pull request #207: Added support for enumerations and TypeValueCalc URL: https://github.com/apache/incubator-daffodil/pull/207#discussion_r278610311 ########## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/SimpleTypes.scala #########...
stevedlawrence commented on a change in pull request #207: Added support for enumerations and TypeValueCalc URL: https://github.com/apache/incubator-daffodil/pull/207#discussion_r278611774 ########## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/SimpleTypes.scala #########...
stevedlawrence commented on a change in pull request #207: Added support for enumerations and TypeValueCalc URL: https://github.com/apache/incubator-daffodil/pull/207#discussion_r278613692 ########## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/SimpleTypes.scala #########...
stevedlawrence commented on a change in pull request #207: Added support for enumerations and TypeValueCalc URL: https://github.com/apache/incubator-daffodil/pull/207#discussion_r279766883 ########## File path: daffodil-runtime1-unparser/src/main/scala/org/apache/daffodil/processors/unparsers...
stevedlawrence commented on a change in pull request #207: Added support for enumerations and TypeValueCalc URL: https://github.com/apache/incubator-daffodil/pull/207#discussion_r279761380 ########## File path: daffodil-lib/src/main/scala/org/apache/daffodil/schema/annotation/props/PropertySc...
stevedlawrence commented on a change in pull request #207: Added support for enumerations and TypeValueCalc URL: https://github.com/apache/incubator-daffodil/pull/207#discussion_r279773322 ########## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/TypeCalculator.sca...
stevedlawrence commented on a change in pull request #207: Added support for enumerations and TypeValueCalc URL: https://github.com/apache/incubator-daffodil/pull/207#discussion_r279782198 ########## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/parsers/Expression...
stevedlawrence commented on a change in pull request #207: Added support for enumerations and TypeValueCalc URL: https://github.com/apache/incubator-daffodil/pull/207#discussion_r279782296 ########## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/parsers/Expression...
stevedlawrence commented on a change in pull request #207: Added support for enumerations and TypeValueCalc URL: https://github.com/apache/incubator-daffodil/pull/207#discussion_r279782605 ########## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/parsers/Expression...
stevedlawrence commented on a change in pull request #207: Added support for enumerations and TypeValueCalc URL: https://github.com/apache/incubator-daffodil/pull/207#discussion_r279784355 ########## File path: eclipse-projects/lib-test/.classpath ########## @@ -1,92 +1,111 @@ +<?xml versio...
stevedlawrence commented on a change in pull request #207: Added support for enumerations and TypeValueCalc URL: https://github.com/apache/incubator-daffodil/pull/207#discussion_r279770749 ########## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/TypeCalculator.sca...
stevedlawrence commented on a change in pull request #207: Added support for enumerations and TypeValueCalc URL: https://github.com/apache/incubator-daffodil/pull/207#discussion_r278599777 ########## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/SchemaSet.scala ########## ...
stevedlawrence commented on a change in pull request #207: Added support for enumerations and TypeValueCalc URL: https://github.com/apache/incubator-daffodil/pull/207#discussion_r279759921 ########## File path: daffodil-lib/src/main/scala/org/apache/daffodil/api/DaffodilTunables.scala ######...
stevedlawrence commented on a change in pull request #207: Added support for enumerations and TypeValueCalc URL: https://github.com/apache/incubator-daffodil/pull/207#discussion_r279772948 ########## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/TypeCalculator.sca...
stevedlawrence commented on a change in pull request #207: Added support for enumerations and TypeValueCalc URL: https://github.com/apache/incubator-daffodil/pull/207#discussion_r279754764 ########## File path: daffodil-core/src/main/scala/org/apache/daffodil/grammar/ElementBaseGrammarMixin.s...
mbeckerle commented on a change in pull request #207: Added support for enumerations and TypeValueCalc URL: https://github.com/apache/incubator-daffodil/pull/207#discussion_r279822070 ########## File path: daffodil-lib/src/main/scala/org/apache/daffodil/schema/annotation/props/PropertyScoping...
mbeckerle commented on a change in pull request #207: Added support for enumerations and TypeValueCalc URL: https://github.com/apache/incubator-daffodil/pull/207#discussion_r279825054 ########## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/CompiledExpression.scala #######...
stevedlawrence commented on a change in pull request #207: Added support for enumerations and TypeValueCalc URL: https://github.com/apache/incubator-daffodil/pull/207#discussion_r279825517 ########## File path: daffodil-lib/src/main/scala/org/apache/daffodil/schema/annotation/props/PropertySc...
stevedlawrence commented on a change in pull request #207: Added support for enumerations and TypeValueCalc URL: https://github.com/apache/incubator-daffodil/pull/207#discussion_r279826798 ########## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/CompiledExpression.scala ##...
In working on DAFFODIL-2083 with empty string in delimiters, I made some changes that also effect choiceDispatchKey. For delimiters it is a Schema Definition Error if an expression evaluates to an empty string. We had originally been creating a Parse Error (although it was getting masked by an Ass...
bsloane1650 commented on a change in pull request #207: Added support for enumerations and TypeValueCalc URL: https://github.com/apache/incubator-daffodil/pull/207#discussion_r279915094 ########## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/RestrictionUnion.scala #######...
bsloane1650 commented on a change in pull request #207: Added support for enumerations and TypeValueCalc URL: https://github.com/apache/incubator-daffodil/pull/207#discussion_r279917337 ########## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/parsers/ExpressionEva...
stevedlawrence commented on a change in pull request #207: Added support for enumerations and TypeValueCalc URL: https://github.com/apache/incubator-daffodil/pull/207#discussion_r280052820 ########## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/parsers/Expression...
bsloane1650 commented on a change in pull request #207: Added support for enumerations and TypeValueCalc URL: https://github.com/apache/incubator-daffodil/pull/207#discussion_r280098684 ########## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/ChoiceGroup.scala ########## ...
mbeckerle commented on a change in pull request #213: fix eclipse classpaths for no more scala-debug directories. URL: https://github.com/apache/incubator-daffodil/pull/213#discussion_r280168017 ########## File path: eclipse-projects/core-test/.classpath ########## @@ -1,92 +1,117 @@ +<?xml...
mbeckerle closed pull request #213: fix eclipse classpaths for no more scala-debug directories. URL: https://github.com/apache/incubator-daffodil/pull/213 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to...
mbeckerle commented on issue #213: fix eclipse classpaths for no more scala-debug directories. URL: https://github.com/apache/incubator-daffodil/pull/213#issuecomment-488371131 Closed. Will address the tool for maintaining these classpaths, and probably once that is fixed we need to just remo...
mbeckerle commented on issue #210: Add midBitsToEnd layer transform URL: https://github.com/apache/incubator-daffodil/pull/210#issuecomment-488391052 I believe we determined this interesting layering transform isn't actually required for the data format we thought needed it. So do we w...
stevedlawrence commented on issue #210: Add midBitsToEnd layer transform URL: https://github.com/apache/incubator-daffodil/pull/210#issuecomment-488637552 I'd vote to just close this pull request rather than incorporating it. If we incorporate, it's just one more thing we need to support and ...
mbeckerle commented on issue #210: Add midBitsToEnd layer transform URL: https://github.com/apache/incubator-daffodil/pull/210#issuecomment-488662304 I can go with that. ---------------------------------------------------------------- This is an automated message from the Apache Git Service....
bsloane1650 commented on issue #210: Add midBitsToEnd layer transform URL: https://github.com/apache/incubator-daffodil/pull/210#issuecomment-488679443 Closing sounds good to me as well. ---------------------------------------------------------------- This is an automated message from the Ap...
mbeckerle closed pull request #210: Add midBitsToEnd layer transform URL: https://github.com/apache/incubator-daffodil/pull/210 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on...
This email is FYI only. You can skip it unless you care about this specific development topic. I have made quite a lot of progress this past week so I thought it worth reporting about given that fixing these issues so that EDIFACT and TLOG can work has been delayed for so long. There are numerous ...
mbeckerle opened a new pull request #214: Daffodil 1080 sep URL: https://github.com/apache/incubator-daffodil/pull/214 Not for review yet. Just letting me look at the deltas. ---------------------------------------------------------------- This is an automated message from the Apache Git...
mbeckerle commented on a change in pull request #214: Daffodil 1080 sep URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r280999321 ########## File path: daffodil-runtime1-unparser/src/main/scala/org/apache/daffodil/processors/unparsers/SuppressableSeparatorUnparser.scala...
Wanted to make sure I am understanding the spec for choiceLengthKind correctly: - 'explicit' means that the branches of the choice are always filled to the fixed length specified by dfdl:choiceLength, so the ChoiceContent region is fixed length regardless of which branch appears. And under choice...
Hi and sorry for opening all these topics 😉 But at least that means we’re working hard on utilizing Daffodil 😉 Sort of all Protocols use some discriminator fields to define what’s coming up and how to interpret the data. When hand-coding drivers, we usually created Java enums with a...
Steve, I was able to more or less isolate the unparsing issue I mentioned this morning. I have submitted a bug report here: https://issues.apache.org/jira/browse/DAFFODIL-2125 It seems to be related to changing bit orders and suspensions. Let me know if you get a chance to look at it. Thanks, ...
stevedlawrence opened a new pull request #215: Ensure fragment bytes are delivered correctly when dfdl:outputValueCalc is followed by a different bitOrder URL: https://github.com/apache/incubator-daffodil/pull/215 When an OVC element is followed by an element with a different bitOrder, the...
stevedlawrence opened a new pull request #216: Do not abort when an import/includes fails URL: https://github.com/apache/incubator-daffodil/pull/216 When using XML Catalogs, it's very easy for import/includes to resolve to URI's that do not exist. This results in an IOException when trying...
mbeckerle commented on a change in pull request #216: Do not abort when an import/includes fails URL: https://github.com/apache/incubator-daffodil/pull/216#discussion_r282920645 ########## File path: daffodil-lib/src/main/scala/org/apache/daffodil/xml/DaffodilXMLLoader.scala ########## @@ -...
stevedlawrence commented on a change in pull request #216: Do not abort when an import/includes fails URL: https://github.com/apache/incubator-daffodil/pull/216#discussion_r282934428 ########## File path: daffodil-lib/src/main/scala/org/apache/daffodil/xml/DaffodilXMLLoader.scala ########## ...
stevedlawrence commented on a change in pull request #216: Do not abort when an import/includes fails URL: https://github.com/apache/incubator-daffodil/pull/216#discussion_r282944084 ########## File path: daffodil-cli/src/it/scala/org/apache/daffodil/parsing/TestCLIParsing.scala ########## ...
jadams-tresys commented on a change in pull request #215: Ensure fragment bytes are delivered correctly when dfdl:outputValueCalc is followed by a different bitOrder URL: https://github.com/apache/incubator-daffodil/pull/215#discussion_r283031022 ########## File path: daffodil-io/src/main/sca...
jadams-tresys merged pull request #212: Catch error when delimiter expression fails URL: https://github.com/apache/incubator-daffodil/pull/212 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message...
stevedlawrence merged pull request #216: Do not abort when an import/includes fails URL: https://github.com/apache/incubator-daffodil/pull/216 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message...
stevedlawrence merged pull request #215: Ensure fragment bytes are delivered correctly when dfdl:outputValueCalc is followed by a different bitOrder URL: https://github.com/apache/incubator-daffodil/pull/215 ---------------------------------------------------------------- This is an automat...
stevedlawrence opened a new pull request #217: Switch XML/JSON infoset inputters/outputters to use streams URL: https://github.com/apache/incubator-daffodil/pull/217 The API for XML and JSON Infoset Inputters/Outputters requires that users pass in a Reader or a Writer. The problem is that ...
jadams-tresys opened a new pull request #218: Implement dfdl:choiceLength='explicit' URL: https://github.com/apache/incubator-daffodil/pull/218 DAFFODIL-640 May have made this more complicated than it needed to be. For some reason I thought that choiceLength accepts an expression, but...
mbeckerle commented on a change in pull request #214: Sequences and Separators Refactoring and Rewrite URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r284791040 ########## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/ChoiceGroup.scala ########## @@...
mbeckerle commented on a change in pull request #214: Sequences and Separators Refactoring and Rewrite URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r284791830 ########## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/ElementBase.scala ########## @@...
mbeckerle commented on a change in pull request #214: Sequences and Separators Refactoring and Rewrite URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r284792604 ########## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/LocalElementMixin.scala ########...
mbeckerle commented on a change in pull request #214: Sequences and Separators Refactoring and Rewrite URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r284793307 ########## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/RuntimePropertyMixins.scala ####...
mbeckerle commented on a change in pull request #214: Sequences and Separators Refactoring and Rewrite URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r284793623 ########## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/SchemaComponent.scala ##########...
mbeckerle commented on a change in pull request #214: Sequences and Separators Refactoring and Rewrite URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r284794136 ########## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/SequenceGroup.scala ########## ...
mbeckerle commented on a change in pull request #214: Sequences and Separators Refactoring and Rewrite URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r284795231 ########## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/Term.scala ########## @@ -297,3...
mbeckerle commented on a change in pull request #214: Sequences and Separators Refactoring and Rewrite URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r284796903 ########## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/Term.scala ########## @@ -803,4...
mbeckerle commented on a change in pull request #214: Sequences and Separators Refactoring and Rewrite URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r284798142 ########## File path: daffodil-core/src/main/scala/org/apache/daffodil/grammar/primitives/SequenceChild.scala...
mbeckerle commented on a change in pull request #214: Sequences and Separators Refactoring and Rewrite URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r284798259 ########## File path: daffodil-core/src/main/scala/org/apache/daffodil/grammar/primitives/SequenceChild.scala...
mbeckerle commented on a change in pull request #214: Sequences and Separators Refactoring and Rewrite URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r284798142 ########## File path: daffodil-core/src/main/scala/org/apache/daffodil/grammar/primitives/SequenceChild.scala...
mbeckerle commented on a change in pull request #214: Sequences and Separators Refactoring and Rewrite URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r284799419 ########## File path: daffodil-core/src/main/scala/org/apache/daffodil/grammar/primitives/SequenceChild.scala...
mbeckerle commented on a change in pull request #214: Sequences and Separators Refactoring and Rewrite URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r284800167 ########## File path: daffodil-lib/src/main/scala/org/apache/daffodil/api/DaffodilTunables.scala ########## ...
mbeckerle commented on issue #214: Sequences and Separators Refactoring and Rewrite URL: https://github.com/apache/incubator-daffodil/pull/214#issuecomment-493146241 I also wanted to comment on backward compatibility. This new functionality is NOT 100% backward compatible. Several pre-...
mbeckerle commented on a change in pull request #214: Sequences and Separators Refactoring and Rewrite URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r284803213 ########## File path: daffodil-runtime1-unparser/src/main/scala/org/apache/daffodil/processors/unparsers/Sepa...
mbeckerle commented on a change in pull request #214: Sequences and Separators Refactoring and Rewrite URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r284804870 ########## File path: daffodil-runtime1-unparser/src/main/scala/org/apache/daffodil/processors/unparsers/Supp...
mbeckerle commented on a change in pull request #214: Sequences and Separators Refactoring and Rewrite URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r284805571 ########## File path: daffodil-runtime1-unparser/src/main/scala/org/apache/daffodil/processors/unparsers/Supp...
mbeckerle commented on a change in pull request #214: Sequences and Separators Refactoring and Rewrite URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r284806574 ########## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/infoset/InfosetImpl.scala #######...
mbeckerle commented on a change in pull request #214: Sequences and Separators Refactoring and Rewrite URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r284806758 ########## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/Suspension.scala #####...
mbeckerle commented on a change in pull request #214: Sequences and Separators Refactoring and Rewrite URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r284807157 ########## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/parsers/BinaryNumberTra...
mbeckerle commented on a change in pull request #214: Sequences and Separators Refactoring and Rewrite URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r284810024 ########## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/parsers/UnseparatedSequ...
mbeckerle commented on a change in pull request #214: Sequences and Separators Refactoring and Rewrite URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r284810164 ########## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/parsers/UnseparatedSequ...
mbeckerle commented on a change in pull request #214: Sequences and Separators Refactoring and Rewrite URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r284811333 ########## File path: daffodil-test-ibm1/src/test/resources/test-suite/ibm-contributed/dpaext1.tdml ########...
mbeckerle commented on a change in pull request #214: Sequences and Separators Refactoring and Rewrite URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r284812157 ########## File path: daffodil-test-ibm1/src/test/resources/test-suite/ibm-contributed/dpaextdeltxt101-err.df...
mbeckerle commented on a change in pull request #214: Sequences and Separators Refactoring and Rewrite URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r284812498 ########## File path: daffodil-test-ibm1/src/test/resources/test-suite/tresys-contributed/AF.dfdl.xsd ######...
mbeckerle commented on a change in pull request #214: Sequences and Separators Refactoring and Rewrite URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r284814732 ########## File path: daffodil-test/src/test/scala/org/apache/daffodil/section23/dfdl_expressions/TestDFDLExp...
stevedlawrence opened a new pull request #219: Ensure InputStreams created by includes/imports are closed URL: https://github.com/apache/incubator-daffodil/pull/219 - When we open a stream from a DaffodilInputSource, make sure we close the streams when we are done with them - In our c...
stevedlawrence merged pull request #217: Switch XML/JSON infoset inputters/outputters to use streams URL: https://github.com/apache/incubator-daffodil/pull/217 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respo...
mbeckerle commented on a change in pull request #218: Implement dfdl:choiceLength='explicit' URL: https://github.com/apache/incubator-daffodil/pull/218#discussion_r284820768 ########## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/RuntimePropertyMixins.scala ########## @@...
mbeckerle commented on a change in pull request #218: Implement dfdl:choiceLength='explicit' URL: https://github.com/apache/incubator-daffodil/pull/218#discussion_r284821498 ########## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/parsers/SpecifiedLengthParsers.sc...
mbeckerle commented on a change in pull request #218: Implement dfdl:choiceLength='explicit' URL: https://github.com/apache/incubator-daffodil/pull/218#discussion_r284819999 ########## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/parsers/SpecifiedLengthParsers.sc...
mbeckerle commented on a change in pull request #218: Implement dfdl:choiceLength='explicit' URL: https://github.com/apache/incubator-daffodil/pull/218#discussion_r284821271 ########## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/EvElement.scala ########## @@ -...
bsloane1650 commented on a change in pull request #219: Ensure InputStreams created by includes/imports are closed URL: https://github.com/apache/incubator-daffodil/pull/219#discussion_r284823093 ########## File path: daffodil-lib/src/main/scala/org/apache/daffodil/xml/DaffodilXMLLoader.scala...
mbeckerle commented on a change in pull request #219: Ensure InputStreams created by includes/imports are closed URL: https://github.com/apache/incubator-daffodil/pull/219#discussion_r284822950 ########## File path: daffodil-lib/src/main/scala/org/apache/daffodil/xml/DaffodilXMLLoader.scala ...
This PR has been sitting for a while with comments saying "not done reviewing". I approved it, though one such comment is mine. It has one approval, one not done by SL. Brandon, can you comment on whether you are ok with this being merged or have pending changes? This is an important change s...
stevedlawrence commented on a change in pull request #219: Ensure InputStreams created by includes/imports are closed URL: https://github.com/apache/incubator-daffodil/pull/219#discussion_r284830717 ########## File path: daffodil-lib/src/main/scala/org/apache/daffodil/xml/DaffodilXMLLoader.sc...
stevedlawrence commented on a change in pull request #219: Ensure InputStreams created by includes/imports are closed URL: https://github.com/apache/incubator-daffodil/pull/219#discussion_r284830771 ########## File path: daffodil-lib/src/main/scala/org/apache/daffodil/xml/DaffodilXMLLoader.sc...
mbeckerle commented on a change in pull request #219: Ensure InputStreams created by includes/imports are closed URL: https://github.com/apache/incubator-daffodil/pull/219#discussion_r284833226 ########## File path: daffodil-lib/src/main/scala/org/apache/daffodil/xml/DaffodilXMLLoader.scala ...
In case people didn't see it, the PR for the big (freakin' huge) change set for the sequences-and-separators change is now current and pending reviews. It's 100+ files touched, though I think well motivated. I had previously put out this PR, but was "not for merging". This one is now "the real t...
stevedlawrence commented on a change in pull request #214: Sequences and Separators Refactoring and Rewrite URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r285114984 ########## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/ChoiceGroup.scala #########...
stevedlawrence commented on a change in pull request #214: Sequences and Separators Refactoring and Rewrite URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r285119232 ########## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/ElementBase.scala #########...
stevedlawrence commented on a change in pull request #214: Sequences and Separators Refactoring and Rewrite URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r285115751 ########## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/ChoiceGroup.scala #########...
stevedlawrence commented on a change in pull request #214: Sequences and Separators Refactoring and Rewrite URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r285118171 ########## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/ElementBase.scala #########...
stevedlawrence commented on a change in pull request #214: Sequences and Separators Refactoring and Rewrite URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r285124957 ########## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/LocalElementMixin.scala ###...
stevedlawrence commented on a change in pull request #214: Sequences and Separators Refactoring and Rewrite URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r285127236 ########## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/ModelGroup.scala ##########...
stevedlawrence commented on a change in pull request #214: Sequences and Separators Refactoring and Rewrite URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r285124058 ########## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/ElementBase.scala #########...
stevedlawrence commented on a change in pull request #214: Sequences and Separators Refactoring and Rewrite URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r285125748 ########## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/LocalElementMixin.scala ###...
stevedlawrence commented on a change in pull request #214: Sequences and Separators Refactoring and Rewrite URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r285135563 ########## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/SequenceGroup.scala #######...
stevedlawrence commented on a change in pull request #214: Sequences and Separators Refactoring and Rewrite URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r285129128 ########## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/RuntimePropertyMixins.scala ...
stevedlawrence commented on a change in pull request #214: Sequences and Separators Refactoring and Rewrite URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r285133842 ########## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/SequenceGroup.scala #######...
stevedlawrence commented on a change in pull request #214: Sequences and Separators Refactoring and Rewrite URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r285166558 ########## File path: daffodil-core/src/main/scala/org/apache/daffodil/grammar/primitives/SequenceChild....
stevedlawrence commented on a change in pull request #214: Sequences and Separators Refactoring and Rewrite URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r285159370 ########## File path: daffodil-core/src/main/scala/org/apache/daffodil/grammar/SequenceGrammarMixin.scal...
stevedlawrence commented on a change in pull request #214: Sequences and Separators Refactoring and Rewrite URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r285142128 ########## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/Term.scala ########## @@ -...
stevedlawrence commented on a change in pull request #214: Sequences and Separators Refactoring and Rewrite URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r285144868 ########## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/Term.scala ########## @@ -...
stevedlawrence commented on a change in pull request #214: Sequences and Separators Refactoring and Rewrite URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r285139621 ########## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/Term.scala ########## @@ -...
stevedlawrence commented on a change in pull request #214: Sequences and Separators Refactoring and Rewrite URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r285163079 ########## File path: daffodil-core/src/main/scala/org/apache/daffodil/grammar/primitives/SequenceChild....
stevedlawrence commented on a change in pull request #214: Sequences and Separators Refactoring and Rewrite URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r285133525 ########## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/SequenceGroup.scala #######...
stevedlawrence commented on a change in pull request #214: Sequences and Separators Refactoring and Rewrite URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r285135479 ########## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/SequenceGroup.scala #######...
stevedlawrence commented on a change in pull request #214: Sequences and Separators Refactoring and Rewrite URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r285195114 ########## File path: daffodil-runtime1-unparser/src/main/scala/org/apache/daffodil/processors/unparsers...
stevedlawrence commented on a change in pull request #214: Sequences and Separators Refactoring and Rewrite URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r285229129 ########## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/parsers/SequenceCh...
stevedlawrence commented on a change in pull request #214: Sequences and Separators Refactoring and Rewrite URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r285193344 ########## File path: daffodil-runtime1-unparser/src/main/scala/org/apache/daffodil/processors/unparsers...
stevedlawrence commented on a change in pull request #214: Sequences and Separators Refactoring and Rewrite URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r285167295 ########## File path: daffodil-core/src/main/scala/org/apache/daffodil/grammar/primitives/SequenceChild....
stevedlawrence commented on a change in pull request #214: Sequences and Separators Refactoring and Rewrite URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r285202168 ########## File path: daffodil-runtime1-unparser/src/main/scala/org/apache/daffodil/processors/unparsers...
stevedlawrence commented on a change in pull request #214: Sequences and Separators Refactoring and Rewrite URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r285190885 ########## File path: daffodil-lib/src/main/scala/org/apache/daffodil/schema/annotation/props/ByHandMixi...
stevedlawrence commented on a change in pull request #214: Sequences and Separators Refactoring and Rewrite URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r285211325 ########## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/infoset/InfosetImpl.scala ##...
stevedlawrence commented on a change in pull request #214: Sequences and Separators Refactoring and Rewrite URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r285185418 ########## File path: daffodil-lib/src/main/scala/org/apache/daffodil/api/DaffodilTunables.scala ######...
stevedlawrence commented on a change in pull request #214: Sequences and Separators Refactoring and Rewrite URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r285188813 ########## File path: daffodil-lib/src/main/scala/org/apache/daffodil/schema/annotation/props/ByHandMixi...
stevedlawrence commented on a change in pull request #214: Sequences and Separators Refactoring and Rewrite URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r285191317 ########## File path: daffodil-propgen/src/main/scala/org/apache/daffodil/propGen/PropertyGenerator.scal...
stevedlawrence commented on a change in pull request #214: Sequences and Separators Refactoring and Rewrite URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r285194335 ########## File path: daffodil-runtime1-unparser/src/main/scala/org/apache/daffodil/processors/unparsers...
stevedlawrence commented on a change in pull request #214: Sequences and Separators Refactoring and Rewrite URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r285212033 ########## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/ProcessorResult.sc...
stevedlawrence commented on a change in pull request #214: Sequences and Separators Refactoring and Rewrite URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r285232419 ########## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/parsers/SequenceCh...
stevedlawrence commented on a change in pull request #214: Sequences and Separators Refactoring and Rewrite URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r285223159 ########## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/parsers/SeparatedP...
stevedlawrence commented on a change in pull request #214: Sequences and Separators Refactoring and Rewrite URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r285232032 ########## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/parsers/SequenceCh...
stevedlawrence commented on a change in pull request #214: Sequences and Separators Refactoring and Rewrite URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r285190073 ########## File path: daffodil-lib/src/main/scala/org/apache/daffodil/schema/annotation/props/ByHandMixi...
stevedlawrence commented on a change in pull request #214: Sequences and Separators Refactoring and Rewrite URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r285187963 ########## File path: daffodil-lib/src/main/scala/org/apache/daffodil/api/WarnID.scala ########## @@ -...
stevedlawrence commented on a change in pull request #214: Sequences and Separators Refactoring and Rewrite URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r285218441 ########## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/parsers/BinaryNumb...
stevedlawrence commented on a change in pull request #214: Sequences and Separators Refactoring and Rewrite URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r285222442 ########## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/parsers/SeparatedP...
mbeckerle commented on a change in pull request #214: Sequences and Separators Refactoring and Rewrite URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r285240206 ########## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/parsers/SequenceChildPa...
mbeckerle commented on a change in pull request #214: Sequences and Separators Refactoring and Rewrite URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r285234477 ########## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/Term.scala ########## @@ -803,4...
mbeckerle commented on a change in pull request #214: Sequences and Separators Refactoring and Rewrite URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r285236839 ########## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/parsers/SeparatedSequen...
mbeckerle commented on a change in pull request #214: Sequences and Separators Refactoring and Rewrite URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r285236000 ########## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/parsers/SequenceChildBa...
mbeckerle commented on a change in pull request #214: Sequences and Separators Refactoring and Rewrite URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r285247203 ########## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/ChoiceGroup.scala ########## @@...
stevedlawrence commented on a change in pull request #214: Sequences and Separators Refactoring and Rewrite URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r285257206 ########## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/ChoiceGroup.scala #########...
mbeckerle commented on a change in pull request #214: Sequences and Separators Refactoring and Rewrite URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r285259505 ########## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/ChoiceGroup.scala ########## @@...
Dear podling, This email was sent by an automated system on behalf of the Apache Incubator PMC. It is an initial reminder to give you plenty of time to prepare your quarterly board report. The board meeting is scheduled for Wed, 19 June 2019, 10:30 am PDT. The report for your podling will form a p...
I know that this PR has already been reviewed, but when I rebased it back onto the latest version of master, I discovered that it exposed a regression in master. There is now a second commit in the PR to fix this. Assuming no one objects, I can squash this into the main enumerations commit. Bran...
In working on schema for mil-std-6016, I have discovered a 6 bit character encoding that is distinct from the X-DFDL-US-ASCII-6-BIT-PACKED encoding we already support. What would the process for supporting this be? Brandon T. Sloane Associate, Services bsloane@tresys.com | tresys.com
mbeckerle commented on a change in pull request #214: Sequences and Separators Refactoring and Rewrite URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r285657866 ########## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/ChoiceGroup.scala ########## @@...
mbeckerle commented on a change in pull request #214: Sequences and Separators Refactoring and Rewrite URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r285689250 ########## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/LocalElementMixin.scala ########...
mbeckerle commented on a change in pull request #214: Sequences and Separators Refactoring and Rewrite URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r285697428 ########## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/RuntimePropertyMixins.scala ####...
mbeckerle commented on a change in pull request #214: Sequences and Separators Refactoring and Rewrite URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r285689883 ########## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/LocalElementMixin.scala ########...
mbeckerle commented on a change in pull request #214: Sequences and Separators Refactoring and Rewrite URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r285687889 ########## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/ElementBase.scala ########## @@...
mbeckerle commented on a change in pull request #214: Sequences and Separators Refactoring and Rewrite URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r285687800 ########## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/ElementBase.scala ########## @@...
mbeckerle commented on a change in pull request #214: Sequences and Separators Refactoring and Rewrite URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r285661559 ########## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/ElementBase.scala ########## @@...
mbeckerle commented on a change in pull request #214: Sequences and Separators Refactoring and Rewrite URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r285771432 ########## File path: daffodil-test-ibm1/src/test/resources/test-suite/ibm-contributed/dpaext1.tdml ########...
mbeckerle commented on a change in pull request #214: Sequences and Separators Refactoring and Rewrite URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r285736028 ########## File path: daffodil-runtime1-unparser/src/main/scala/org/apache/daffodil/processors/unparsers/Supp...
mbeckerle commented on a change in pull request #214: Sequences and Separators Refactoring and Rewrite URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r285725419 ########## File path: daffodil-lib/src/main/scala/org/apache/daffodil/schema/annotation/props/ByHandMixins.sc...
mbeckerle commented on a change in pull request #214: Sequences and Separators Refactoring and Rewrite URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r285725063 ########## File path: daffodil-lib/src/main/scala/org/apache/daffodil/api/WarnID.scala ########## @@ -83,15...
mbeckerle commented on a change in pull request #214: Sequences and Separators Refactoring and Rewrite URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r285722309 ########## File path: daffodil-lib/src/main/scala/org/apache/daffodil/api/DaffodilTunables.scala ########## ...
mbeckerle commented on a change in pull request #214: Sequences and Separators Refactoring and Rewrite URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r285728026 ########## File path: daffodil-lib/src/main/scala/org/apache/daffodil/schema/annotation/props/ByHandMixins.sc...
mbeckerle commented on a change in pull request #214: Sequences and Separators Refactoring and Rewrite URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r285710834 ########## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/Term.scala ########## @@ -434,5...
mbeckerle commented on a change in pull request #214: Sequences and Separators Refactoring and Rewrite URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r285732891 ########## File path: daffodil-runtime1-unparser/src/main/scala/org/apache/daffodil/processors/unparsers/Sepa...
mbeckerle commented on a change in pull request #214: Sequences and Separators Refactoring and Rewrite URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r285728285 ########## File path: daffodil-propgen/src/main/scala/org/apache/daffodil/propGen/PropertyGenerator.scala ##...
mbeckerle commented on a change in pull request #214: Sequences and Separators Refactoring and Rewrite URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r285764233 ########## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/parsers/SequenceChildPa...
mbeckerle commented on a change in pull request #214: Sequences and Separators Refactoring and Rewrite URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r285729326 ########## File path: daffodil-runtime1-unparser/src/main/scala/org/apache/daffodil/processors/unparsers/Sepa...
mbeckerle commented on a change in pull request #214: Sequences and Separators Refactoring and Rewrite URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r285767389 ########## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/parsers/SequenceChildPa...
mbeckerle commented on a change in pull request #214: Sequences and Separators Refactoring and Rewrite URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r285738792 ########## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/parsers/BinaryNumberTra...
mbeckerle commented on a change in pull request #214: Sequences and Separators Refactoring and Rewrite URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r285694312 ########## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/ModelGroup.scala ########## @@ ...
mbeckerle commented on a change in pull request #214: Sequences and Separators Refactoring and Rewrite URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r285734097 ########## File path: daffodil-runtime1-unparser/src/main/scala/org/apache/daffodil/processors/unparsers/Sepa...
mbeckerle commented on a change in pull request #214: Sequences and Separators Refactoring and Rewrite URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r285797819 ########## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/ChoiceGroup.scala ########## @@...