You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2020/07/03 18:33:41 UTC
[GitHub] [lucene-solr] chatman opened a new pull request #1647: General improvements to coreContainer shutdown
chatman opened a new pull request #1647:
URL: https://github.com/apache/lucene-solr/pull/1647
* Removing unnecessary "preClose()"
* Other changes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] chatman commented on pull request #1647: SOLR-14626: General improvements to coreContainer shutdown
Posted by GitBox <gi...@apache.org>.
chatman commented on pull request #1647:
URL: https://github.com/apache/lucene-solr/pull/1647#issuecomment-657855769
Closing this, all of these improvements are covered in SOLR-14636.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] chatman closed pull request #1647: SOLR-14626: General improvements to coreContainer shutdown
Posted by GitBox <gi...@apache.org>.
chatman closed pull request #1647:
URL: https://github.com/apache/lucene-solr/pull/1647
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] shalinmangar commented on pull request #1647: SOLR-14626: General improvements to coreContainer shutdown
Posted by GitBox <gi...@apache.org>.
shalinmangar commented on pull request #1647:
URL: https://github.com/apache/lucene-solr/pull/1647#issuecomment-653714746
Please be specific about the changes. Why do you think preClose is unnecessary? I see that invocation of `removeEphemeralLiveNode` method is removed entirely. Why do you think that is a safe change to make? With this PR, the live node is not removed until the zk client is closed which happens after pretty much everything is closed. This will cause other clients/replicas to keep sending requests to this node and erroring out.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org