[GitHub] dlg99 commented on a change in pull request #1410: Issue #1409: Added server side backpressure (@bug W-3651831@)

[GitBox <gi...@apache.org>]

dlg99 commented on a change in pull request #1410: Issue #1409: Added server side backpressure (@bug W-3651831@)
URL: https://github.com/apache/bookkeeper/pull/1410#discussion_r190748819
 
 

 ##########
 File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Journal.java
 ##########
 @@ -935,11 +940,27 @@ public void run() {
             while (true) {
                 // new journal file to write
                 if (null == logFile) {
+
                     logId = logId + 1;
+                    final JournalChannel.BufferedChannelBuilder bcBuilder;
+                    if (getDelay > 0 || addDelay > 0 || flushDelay > 0) {
 
 Review comment:
   will do.
   PowerMock in tests that extends BookKeeperClusterTestCase a bit problematic, likely due to  
   https://github.com/powermock/powermock/issues/822
   
   Figured a way how to use just mockito there, will update PR soon.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services