You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Andrew Onischuk <ao...@hortonworks.com> on 2017/03/30 12:30:37 UTC
Review Request 58070: Integrate stomp client library into agent code
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58070/
-----------------------------------------------------------
Review request for Ambari, Myroslav Papirkovskyy and Sid Wagle.
Bugs: AMBARI-20630
https://issues.apache.org/jira/browse/AMBARI-20630
Repository: ambari
Description
-------
It was decided to use stomp 4.1.17 (lastest version)
Some points about the library:
* It has apache license
* It supports basic functionality we need. Events subscription/unsubscription, acks/nacks, transactions, sending events to server and has a very simple neat API. Here are the docs on it <http://jasonrbriggs.github.io/stomp.py/api.html>
* It does not require any non-default python libraries
* I have already tested it with a simple stomp server I have setup.
* Supports both Python2.x and Python3.x
Diffs
-----
ambari-agent/conf/unix/install-helper.sh 0e32d0a
ambari-agent/pom.xml fb08ce2
ambari-agent/src/packages/tarball/all.xml 363941a
ambari-common/src/main/python/ambari_stomp/__init__.py PRE-CREATION
ambari-common/src/main/python/ambari_stomp/__main__.py PRE-CREATION
ambari-common/src/main/python/ambari_stomp/adapter/__init__.py PRE-CREATION
ambari-common/src/main/python/ambari_stomp/adapter/multicast.py PRE-CREATION
ambari-common/src/main/python/ambari_stomp/backward.py PRE-CREATION
ambari-common/src/main/python/ambari_stomp/backward2.py PRE-CREATION
ambari-common/src/main/python/ambari_stomp/backward3.py PRE-CREATION
ambari-common/src/main/python/ambari_stomp/backwardsock.py PRE-CREATION
ambari-common/src/main/python/ambari_stomp/backwardsock25.py PRE-CREATION
ambari-common/src/main/python/ambari_stomp/backwardsock26.py PRE-CREATION
ambari-common/src/main/python/ambari_stomp/colors.py PRE-CREATION
ambari-common/src/main/python/ambari_stomp/connect.py PRE-CREATION
ambari-common/src/main/python/ambari_stomp/constants.py PRE-CREATION
ambari-common/src/main/python/ambari_stomp/exception.py PRE-CREATION
ambari-common/src/main/python/ambari_stomp/listener.py PRE-CREATION
ambari-common/src/main/python/ambari_stomp/protocol.py PRE-CREATION
ambari-common/src/main/python/ambari_stomp/transport.py PRE-CREATION
ambari-common/src/main/python/ambari_stomp/utils.py PRE-CREATION
Diff: https://reviews.apache.org/r/58070/diff/1/
Testing
-------
mvn clean test
Thanks,
Andrew Onischuk
Re: Review Request 58070: Integrate stomp client library into agent
code
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58070/#review170647
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On March 30, 2017, 1:43 p.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58070/
> -----------------------------------------------------------
>
> (Updated March 30, 2017, 1:43 p.m.)
>
>
> Review request for Ambari, Myroslav Papirkovskyy and Sid Wagle.
>
>
> Bugs: AMBARI-20630
> https://issues.apache.org/jira/browse/AMBARI-20630
>
>
> Repository: ambari
>
>
> Description
> -------
>
> It was decided to use stomp 4.1.17 (lastest version)
>
> Some points about the library:
>
> * It has apache license
> * It supports basic functionality we need. Events subscription/unsubscription, acks/nacks, transactions, sending events to server and has a very simple neat API. Here are the docs on it <http://jasonrbriggs.github.io/stomp.py/api.html>
> * It does not require any non-default python libraries
> * I have already tested it with a simple stomp server I have setup.
> * Supports both Python2.x and Python3.x
>
>
> Diffs
> -----
>
> ambari-agent/conf/unix/install-helper.sh 0e32d0a
> ambari-agent/pom.xml fb08ce2
> ambari-agent/src/packages/tarball/all.xml 363941a
> ambari-common/src/main/python/ambari_stomp/__init__.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/__main__.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/adapter/__init__.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/adapter/multicast.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/backward.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/backward2.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/backward3.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/backwardsock.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/backwardsock25.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/backwardsock26.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/colors.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/connect.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/constants.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/exception.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/listener.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/protocol.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/transport.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/utils.py PRE-CREATION
> pom.xml 1cf13f4
>
>
> Diff: https://reviews.apache.org/r/58070/diff/2/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
Re: Review Request 58070: Integrate stomp client library into agent
code
Posted by Sid Wagle <sw...@hortonworks.com>.
> On March 30, 2017, 4:53 p.m., Sid Wagle wrote:
> > Is there apache hosted tarball option for STOMP? Including code is great but better option would be if the release tarball is hosted in Apache we could rev versions without additional work.
lso lets put branch-3.0-perf as branch for all the new work before we merge.
- Sid
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58070/#review170597
-----------------------------------------------------------
On March 30, 2017, 1:43 p.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58070/
> -----------------------------------------------------------
>
> (Updated March 30, 2017, 1:43 p.m.)
>
>
> Review request for Ambari, Myroslav Papirkovskyy and Sid Wagle.
>
>
> Bugs: AMBARI-20630
> https://issues.apache.org/jira/browse/AMBARI-20630
>
>
> Repository: ambari
>
>
> Description
> -------
>
> It was decided to use stomp 4.1.17 (lastest version)
>
> Some points about the library:
>
> * It has apache license
> * It supports basic functionality we need. Events subscription/unsubscription, acks/nacks, transactions, sending events to server and has a very simple neat API. Here are the docs on it <http://jasonrbriggs.github.io/stomp.py/api.html>
> * It does not require any non-default python libraries
> * I have already tested it with a simple stomp server I have setup.
> * Supports both Python2.x and Python3.x
>
>
> Diffs
> -----
>
> ambari-agent/conf/unix/install-helper.sh 0e32d0a
> ambari-agent/pom.xml fb08ce2
> ambari-agent/src/packages/tarball/all.xml 363941a
> ambari-common/src/main/python/ambari_stomp/__init__.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/__main__.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/adapter/__init__.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/adapter/multicast.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/backward.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/backward2.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/backward3.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/backwardsock.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/backwardsock25.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/backwardsock26.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/colors.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/connect.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/constants.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/exception.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/listener.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/protocol.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/transport.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/utils.py PRE-CREATION
> pom.xml 1cf13f4
>
>
> Diff: https://reviews.apache.org/r/58070/diff/2/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
Re: Review Request 58070: Integrate stomp client library into agent
code
Posted by Andrew Onischuk <ao...@hortonworks.com>.
> On March 30, 2017, 4:53 p.m., Sid Wagle wrote:
> > Is there apache hosted tarball option for STOMP? Including code is great but better option would be if the release tarball is hosted in Apache we could rev versions without additional work.
>
> Sid Wagle wrote:
> lso lets put branch-3.0-perf as branch for all the new work before we merge.
The problem with this approach is that we don't want stomp to interfere with stomp of customer (possibly of different version). Rewrite their stomp or get wrong stomp imported for them or for us. We had this problem with jinja and some other libs- resulting in EARs. That's why I renamed it to ambari_stomp and changed imports inside the code.
Which means it is not plain stomp which they have.
- Andrew
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58070/#review170597
-----------------------------------------------------------
On March 30, 2017, 1:43 p.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58070/
> -----------------------------------------------------------
>
> (Updated March 30, 2017, 1:43 p.m.)
>
>
> Review request for Ambari, Myroslav Papirkovskyy and Sid Wagle.
>
>
> Bugs: AMBARI-20630
> https://issues.apache.org/jira/browse/AMBARI-20630
>
>
> Repository: ambari
>
>
> Description
> -------
>
> It was decided to use stomp 4.1.17 (lastest version)
>
> Some points about the library:
>
> * It has apache license
> * It supports basic functionality we need. Events subscription/unsubscription, acks/nacks, transactions, sending events to server and has a very simple neat API. Here are the docs on it <http://jasonrbriggs.github.io/stomp.py/api.html>
> * It does not require any non-default python libraries
> * I have already tested it with a simple stomp server I have setup.
> * Supports both Python2.x and Python3.x
>
>
> Diffs
> -----
>
> ambari-agent/conf/unix/install-helper.sh 0e32d0a
> ambari-agent/pom.xml fb08ce2
> ambari-agent/src/packages/tarball/all.xml 363941a
> ambari-common/src/main/python/ambari_stomp/__init__.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/__main__.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/adapter/__init__.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/adapter/multicast.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/backward.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/backward2.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/backward3.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/backwardsock.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/backwardsock25.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/backwardsock26.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/colors.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/connect.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/constants.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/exception.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/listener.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/protocol.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/transport.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/utils.py PRE-CREATION
> pom.xml 1cf13f4
>
>
> Diff: https://reviews.apache.org/r/58070/diff/2/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
Re: Review Request 58070: Integrate stomp client library into agent
code
Posted by Sid Wagle <sw...@hortonworks.com>.
> On March 30, 2017, 4:53 p.m., Sid Wagle wrote:
> > Is there apache hosted tarball option for STOMP? Including code is great but better option would be if the release tarball is hosted in Apache we could rev versions without additional work.
>
> Sid Wagle wrote:
> lso lets put branch-3.0-perf as branch for all the new work before we merge.
>
> Andrew Onischuk wrote:
> The problem with this approach is that we don't want stomp to interfere with stomp of customer (possibly of different version). Rewrite their stomp or get wrong stomp imported for them or for us. We had this problem with jinja and some other libs- resulting in EARs. That's why I renamed it to ambari_stomp and changed imports inside the code.
>
> Which means it is not plain stomp which they have.
So what I meant was we can download the tarball using pom and include the source / binaries inside agent code but I am ok with the explanation. +1
- Sid
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58070/#review170597
-----------------------------------------------------------
On March 30, 2017, 1:43 p.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58070/
> -----------------------------------------------------------
>
> (Updated March 30, 2017, 1:43 p.m.)
>
>
> Review request for Ambari, Myroslav Papirkovskyy and Sid Wagle.
>
>
> Bugs: AMBARI-20630
> https://issues.apache.org/jira/browse/AMBARI-20630
>
>
> Repository: ambari
>
>
> Description
> -------
>
> It was decided to use stomp 4.1.17 (lastest version)
>
> Some points about the library:
>
> * It has apache license
> * It supports basic functionality we need. Events subscription/unsubscription, acks/nacks, transactions, sending events to server and has a very simple neat API. Here are the docs on it <http://jasonrbriggs.github.io/stomp.py/api.html>
> * It does not require any non-default python libraries
> * I have already tested it with a simple stomp server I have setup.
> * Supports both Python2.x and Python3.x
>
>
> Diffs
> -----
>
> ambari-agent/conf/unix/install-helper.sh 0e32d0a
> ambari-agent/pom.xml fb08ce2
> ambari-agent/src/packages/tarball/all.xml 363941a
> ambari-common/src/main/python/ambari_stomp/__init__.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/__main__.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/adapter/__init__.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/adapter/multicast.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/backward.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/backward2.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/backward3.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/backwardsock.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/backwardsock25.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/backwardsock26.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/colors.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/connect.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/constants.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/exception.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/listener.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/protocol.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/transport.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/utils.py PRE-CREATION
> pom.xml 1cf13f4
>
>
> Diff: https://reviews.apache.org/r/58070/diff/2/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
Re: Review Request 58070: Integrate stomp client library into agent
code
Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58070/#review170597
-----------------------------------------------------------
Is there apache hosted tarball option for STOMP? Including code is great but better option would be if the release tarball is hosted in Apache we could rev versions without additional work.
- Sid Wagle
On March 30, 2017, 1:43 p.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58070/
> -----------------------------------------------------------
>
> (Updated March 30, 2017, 1:43 p.m.)
>
>
> Review request for Ambari, Myroslav Papirkovskyy and Sid Wagle.
>
>
> Bugs: AMBARI-20630
> https://issues.apache.org/jira/browse/AMBARI-20630
>
>
> Repository: ambari
>
>
> Description
> -------
>
> It was decided to use stomp 4.1.17 (lastest version)
>
> Some points about the library:
>
> * It has apache license
> * It supports basic functionality we need. Events subscription/unsubscription, acks/nacks, transactions, sending events to server and has a very simple neat API. Here are the docs on it <http://jasonrbriggs.github.io/stomp.py/api.html>
> * It does not require any non-default python libraries
> * I have already tested it with a simple stomp server I have setup.
> * Supports both Python2.x and Python3.x
>
>
> Diffs
> -----
>
> ambari-agent/conf/unix/install-helper.sh 0e32d0a
> ambari-agent/pom.xml fb08ce2
> ambari-agent/src/packages/tarball/all.xml 363941a
> ambari-common/src/main/python/ambari_stomp/__init__.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/__main__.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/adapter/__init__.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/adapter/multicast.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/backward.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/backward2.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/backward3.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/backwardsock.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/backwardsock25.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/backwardsock26.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/colors.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/connect.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/constants.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/exception.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/listener.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/protocol.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/transport.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/utils.py PRE-CREATION
> pom.xml 1cf13f4
>
>
> Diff: https://reviews.apache.org/r/58070/diff/2/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
Re: Review Request 58070: Integrate stomp client library into agent
code
Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58070/#review170613
-----------------------------------------------------------
Ship it!
Ship It!
- Sid Wagle
On March 30, 2017, 1:43 p.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58070/
> -----------------------------------------------------------
>
> (Updated March 30, 2017, 1:43 p.m.)
>
>
> Review request for Ambari, Myroslav Papirkovskyy and Sid Wagle.
>
>
> Bugs: AMBARI-20630
> https://issues.apache.org/jira/browse/AMBARI-20630
>
>
> Repository: ambari
>
>
> Description
> -------
>
> It was decided to use stomp 4.1.17 (lastest version)
>
> Some points about the library:
>
> * It has apache license
> * It supports basic functionality we need. Events subscription/unsubscription, acks/nacks, transactions, sending events to server and has a very simple neat API. Here are the docs on it <http://jasonrbriggs.github.io/stomp.py/api.html>
> * It does not require any non-default python libraries
> * I have already tested it with a simple stomp server I have setup.
> * Supports both Python2.x and Python3.x
>
>
> Diffs
> -----
>
> ambari-agent/conf/unix/install-helper.sh 0e32d0a
> ambari-agent/pom.xml fb08ce2
> ambari-agent/src/packages/tarball/all.xml 363941a
> ambari-common/src/main/python/ambari_stomp/__init__.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/__main__.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/adapter/__init__.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/adapter/multicast.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/backward.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/backward2.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/backward3.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/backwardsock.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/backwardsock25.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/backwardsock26.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/colors.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/connect.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/constants.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/exception.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/listener.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/protocol.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/transport.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/utils.py PRE-CREATION
> pom.xml 1cf13f4
>
>
> Diff: https://reviews.apache.org/r/58070/diff/2/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
Re: Review Request 58070: Integrate stomp client library into agent
code
Posted by Andrew Onischuk <ao...@hortonworks.com>.
> On March 30, 2017, 6:23 p.m., Alejandro Fernandez wrote:
> > ambari-common/src/main/python/ambari_stomp/__init__.py
> > Lines 1 (patched)
> > <https://reviews.apache.org/r/58070/diff/2/?file=1680958#file1680958line1>
> >
> > Is this the header that the author expects for this file?
> > Will this pass the rat check?
All the custom libs we have. Are added to ignore in rat. I don't think we are allowed to put our header there.
- Andrew
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58070/#review170614
-----------------------------------------------------------
On March 30, 2017, 1:43 p.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58070/
> -----------------------------------------------------------
>
> (Updated March 30, 2017, 1:43 p.m.)
>
>
> Review request for Ambari, Myroslav Papirkovskyy and Sid Wagle.
>
>
> Bugs: AMBARI-20630
> https://issues.apache.org/jira/browse/AMBARI-20630
>
>
> Repository: ambari
>
>
> Description
> -------
>
> It was decided to use stomp 4.1.17 (lastest version)
>
> Some points about the library:
>
> * It has apache license
> * It supports basic functionality we need. Events subscription/unsubscription, acks/nacks, transactions, sending events to server and has a very simple neat API. Here are the docs on it <http://jasonrbriggs.github.io/stomp.py/api.html>
> * It does not require any non-default python libraries
> * I have already tested it with a simple stomp server I have setup.
> * Supports both Python2.x and Python3.x
>
>
> Diffs
> -----
>
> ambari-agent/conf/unix/install-helper.sh 0e32d0a
> ambari-agent/pom.xml fb08ce2
> ambari-agent/src/packages/tarball/all.xml 363941a
> ambari-common/src/main/python/ambari_stomp/__init__.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/__main__.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/adapter/__init__.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/adapter/multicast.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/backward.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/backward2.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/backward3.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/backwardsock.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/backwardsock25.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/backwardsock26.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/colors.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/connect.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/constants.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/exception.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/listener.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/protocol.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/transport.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/utils.py PRE-CREATION
> pom.xml 1cf13f4
>
>
> Diff: https://reviews.apache.org/r/58070/diff/2/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
Re: Review Request 58070: Integrate stomp client library into agent
code
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58070/#review170614
-----------------------------------------------------------
Fix it, then Ship it!
ambari-common/src/main/python/ambari_stomp/__init__.py
Lines 1 (patched)
<https://reviews.apache.org/r/58070/#comment243483>
Is this the header that the author expects for this file?
Will this pass the rat check?
- Alejandro Fernandez
On March 30, 2017, 1:43 p.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58070/
> -----------------------------------------------------------
>
> (Updated March 30, 2017, 1:43 p.m.)
>
>
> Review request for Ambari, Myroslav Papirkovskyy and Sid Wagle.
>
>
> Bugs: AMBARI-20630
> https://issues.apache.org/jira/browse/AMBARI-20630
>
>
> Repository: ambari
>
>
> Description
> -------
>
> It was decided to use stomp 4.1.17 (lastest version)
>
> Some points about the library:
>
> * It has apache license
> * It supports basic functionality we need. Events subscription/unsubscription, acks/nacks, transactions, sending events to server and has a very simple neat API. Here are the docs on it <http://jasonrbriggs.github.io/stomp.py/api.html>
> * It does not require any non-default python libraries
> * I have already tested it with a simple stomp server I have setup.
> * Supports both Python2.x and Python3.x
>
>
> Diffs
> -----
>
> ambari-agent/conf/unix/install-helper.sh 0e32d0a
> ambari-agent/pom.xml fb08ce2
> ambari-agent/src/packages/tarball/all.xml 363941a
> ambari-common/src/main/python/ambari_stomp/__init__.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/__main__.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/adapter/__init__.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/adapter/multicast.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/backward.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/backward2.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/backward3.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/backwardsock.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/backwardsock25.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/backwardsock26.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/colors.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/connect.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/constants.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/exception.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/listener.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/protocol.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/transport.py PRE-CREATION
> ambari-common/src/main/python/ambari_stomp/utils.py PRE-CREATION
> pom.xml 1cf13f4
>
>
> Diff: https://reviews.apache.org/r/58070/diff/2/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
Re: Review Request 58070: Integrate stomp client library into agent
code
Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58070/
-----------------------------------------------------------
(Updated March 30, 2017, 1:43 p.m.)
Review request for Ambari, Myroslav Papirkovskyy and Sid Wagle.
Bugs: AMBARI-20630
https://issues.apache.org/jira/browse/AMBARI-20630
Repository: ambari
Description
-------
It was decided to use stomp 4.1.17 (lastest version)
Some points about the library:
* It has apache license
* It supports basic functionality we need. Events subscription/unsubscription, acks/nacks, transactions, sending events to server and has a very simple neat API. Here are the docs on it <http://jasonrbriggs.github.io/stomp.py/api.html>
* It does not require any non-default python libraries
* I have already tested it with a simple stomp server I have setup.
* Supports both Python2.x and Python3.x
Diffs (updated)
-----
ambari-agent/conf/unix/install-helper.sh 0e32d0a
ambari-agent/pom.xml fb08ce2
ambari-agent/src/packages/tarball/all.xml 363941a
ambari-common/src/main/python/ambari_stomp/__init__.py PRE-CREATION
ambari-common/src/main/python/ambari_stomp/__main__.py PRE-CREATION
ambari-common/src/main/python/ambari_stomp/adapter/__init__.py PRE-CREATION
ambari-common/src/main/python/ambari_stomp/adapter/multicast.py PRE-CREATION
ambari-common/src/main/python/ambari_stomp/backward.py PRE-CREATION
ambari-common/src/main/python/ambari_stomp/backward2.py PRE-CREATION
ambari-common/src/main/python/ambari_stomp/backward3.py PRE-CREATION
ambari-common/src/main/python/ambari_stomp/backwardsock.py PRE-CREATION
ambari-common/src/main/python/ambari_stomp/backwardsock25.py PRE-CREATION
ambari-common/src/main/python/ambari_stomp/backwardsock26.py PRE-CREATION
ambari-common/src/main/python/ambari_stomp/colors.py PRE-CREATION
ambari-common/src/main/python/ambari_stomp/connect.py PRE-CREATION
ambari-common/src/main/python/ambari_stomp/constants.py PRE-CREATION
ambari-common/src/main/python/ambari_stomp/exception.py PRE-CREATION
ambari-common/src/main/python/ambari_stomp/listener.py PRE-CREATION
ambari-common/src/main/python/ambari_stomp/protocol.py PRE-CREATION
ambari-common/src/main/python/ambari_stomp/transport.py PRE-CREATION
ambari-common/src/main/python/ambari_stomp/utils.py PRE-CREATION
pom.xml 1cf13f4
Diff: https://reviews.apache.org/r/58070/diff/2/
Changes: https://reviews.apache.org/r/58070/diff/1-2/
Testing
-------
mvn clean test
Thanks,
Andrew Onischuk