You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/07/20 21:37:36 UTC
[GitHub] [arrow-rs] alamb opened a new pull request #578: Validate output of MIRI
alamb opened a new pull request #578:
URL: https://github.com/apache/arrow-rs/pull/578
# Rationale for this change
We started running MIRI again in https://github.com/apache/arrow-rs/pull/421, but while discussing with @jorgecarleitao
on https://github.com/jorgecarleitao/arrow2/pull/209, it turned out that we were still `||true` ing the output (aka not validating that MIRA was running cleanly)
# What changes are included in this PR?
Check output of MIRI return
# Are there any user-facing changes?
No
<!---
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] codecov-commenter edited a comment on pull request #578: Validate output of MIRI is successful on CI
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #578:
URL: https://github.com/apache/arrow-rs/pull/578#issuecomment-883730943
# [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/578?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#578](https://codecov.io/gh/apache/arrow-rs/pull/578?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2049c28) into [master](https://codecov.io/gh/apache/arrow-rs/commit/68a4b5baa0593f7ac43ae394b5b8d27fdb97be58?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (68a4b5b) will **not change** coverage.
> The diff coverage is `n/a`.
> :exclamation: Current head 2049c28 differs from pull request most recent head adc189d. Consider uploading reports for the commit adc189d to get more accurate results
[](https://codecov.io/gh/apache/arrow-rs/pull/578?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #578 +/- ##
=======================================
Coverage 82.46% 82.46%
=======================================
Files 167 167
Lines 46205 46205
=======================================
Hits 38101 38101
Misses 8104 8104
```
| [Impacted Files](https://codecov.io/gh/apache/arrow-rs/pull/578?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [arrow/src/array/ffi.rs](https://codecov.io/gh/apache/arrow-rs/pull/578/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2FycmF5L2ZmaS5ycw==) | `100.00% <ø> (ø)` | |
| [arrow/src/compute/kernels/sort.rs](https://codecov.io/gh/apache/arrow-rs/pull/578/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2NvbXB1dGUva2VybmVscy9zb3J0LnJz) | `94.15% <ø> (ø)` | |
| [arrow/src/datatypes/ffi.rs](https://codecov.io/gh/apache/arrow-rs/pull/578/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2RhdGF0eXBlcy9mZmkucnM=) | `72.86% <ø> (ø)` | |
| [arrow/src/ffi.rs](https://codecov.io/gh/apache/arrow-rs/pull/578/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2ZmaS5ycw==) | `87.07% <ø> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-rs/pull/578?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/578?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [68a4b5b...adc189d](https://codecov.io/gh/apache/arrow-rs/pull/578?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on a change in pull request #578: Validate output of MIRI is successful on CI
Posted by GitBox <gi...@apache.org>.
alamb commented on a change in pull request #578:
URL: https://github.com/apache/arrow-rs/pull/578#discussion_r673967746
##########
File path: arrow/src/array/ffi.rs
##########
@@ -96,6 +96,7 @@ mod tests {
}
#[test]
+ #[cfg_attr(miri, ignore)] // https://github.com/apache/arrow-rs/issues/580
Review comment:
@roee88 fixed in https://github.com/apache/arrow-rs/pull/582 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on a change in pull request #578: Validate output of MIRI is successful on CI
Posted by GitBox <gi...@apache.org>.
alamb commented on a change in pull request #578:
URL: https://github.com/apache/arrow-rs/pull/578#discussion_r673881389
##########
File path: arrow/src/array/ffi.rs
##########
@@ -96,6 +96,7 @@ mod tests {
}
#[test]
+ #[cfg_attr(miri, ignore)] // https://github.com/apache/arrow-rs/issues/580
Review comment:
new bug has been introduced since we had MIRI clean -- CI didn't catch it because we were ignoring CI output 😢
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] codecov-commenter commented on pull request #578: Validate output of MIRI is successful on CI
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #578:
URL: https://github.com/apache/arrow-rs/pull/578#issuecomment-883730943
# [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/578?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#578](https://codecov.io/gh/apache/arrow-rs/pull/578?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6d01cba) into [master](https://codecov.io/gh/apache/arrow-rs/commit/68a4b5baa0593f7ac43ae394b5b8d27fdb97be58?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (68a4b5b) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/arrow-rs/pull/578?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #578 +/- ##
=======================================
Coverage 82.46% 82.46%
=======================================
Files 167 167
Lines 46205 46205
=======================================
Hits 38101 38101
Misses 8104 8104
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-rs/pull/578?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/578?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [68a4b5b...6d01cba](https://codecov.io/gh/apache/arrow-rs/pull/578?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on pull request #578: Validate output of MIRI is successful on CI
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #578:
URL: https://github.com/apache/arrow-rs/pull/578#issuecomment-884212816
FYI @jorgecarleitao @nevi-me and @roee88 -- I am merging this PR in so that we do not allow MIRI failures in again on CI 🎉
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb merged pull request #578: Validate output of MIRI is successful on CI
Posted by GitBox <gi...@apache.org>.
alamb merged pull request #578:
URL: https://github.com/apache/arrow-rs/pull/578
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org